From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD5D5E7717F for ; Thu, 12 Dec 2024 15:15:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 513616B0089; Thu, 12 Dec 2024 10:15:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 49C826B008A; Thu, 12 Dec 2024 10:15:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 33DBA6B008C; Thu, 12 Dec 2024 10:15:36 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 05AB46B0089 for ; Thu, 12 Dec 2024 10:15:35 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 671B1AE832 for ; Thu, 12 Dec 2024 15:15:35 +0000 (UTC) X-FDA: 82886654466.17.90F2762 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by imf18.hostedemail.com (Postfix) with ESMTP id 59FD21C0021 for ; Thu, 12 Dec 2024 15:15:22 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=l2DbvhJK; dkim=pass header.d=linutronix.de header.s=2020e header.b=pamKl+3Q; spf=pass (imf18.hostedemail.com: domain of bigeasy@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=bigeasy@linutronix.de; dmarc=pass (policy=none) header.from=linutronix.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734016515; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4emVGX5GKepZ/jaWhhYiVTv1Ym5mrZk/KN4PTzN7QiA=; b=2dqfEokcporiqIGxJRYnaSLiJ4SSSvaNAfr5xf1fPptax9XwC4mGiXwjGmb9OtVJp6PSvs 0qhsYcXIW5M1dI5d+clrrbmcK1t3YYn1bgMlBOi8JksSQ+6SD5RRBP73iXRlUKQ4OH6WdP VGWxCfmfHYgNsqM9UGiijt1Rig2WZRk= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=l2DbvhJK; dkim=pass header.d=linutronix.de header.s=2020e header.b=pamKl+3Q; spf=pass (imf18.hostedemail.com: domain of bigeasy@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=bigeasy@linutronix.de; dmarc=pass (policy=none) header.from=linutronix.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734016515; a=rsa-sha256; cv=none; b=URJde7Tp2LFHRK6hnE/qMg+mrI9jVr/r22zmgQOiDJbi3B/UCDX0PZiczshueqVUdUh/il aZMDqqrvqa6csqqCv+EZDbgv4cipWc/656SxBA1VwBQzzaJz6h5ArSwXFIF8A/8YpO+GsJ 7r7wukX+Eb45PtahVHxsckeiOIwbr1Q= Date: Thu, 12 Dec 2024 16:15:29 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1734016531; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4emVGX5GKepZ/jaWhhYiVTv1Ym5mrZk/KN4PTzN7QiA=; b=l2DbvhJK9YYMV1DKIxM5b0/6AtJVAOtdqeQQUHzFPzos2HJTwiXcvrNzbE5bAlomrwyvli H+bZHxsMpS/32BvSRsojazKgDAWQ5i+hpgAxIFWikj9CBxiLMKq4AMrfdWtqNH1c/ip+fI Se2xWbFCt3WA+R65kgsaNDv804+jaqQ8qnOED4WfXsSEQnbp3nyhFtsZ5VlA5ir06CaxA4 P7S41PbX6EyY9QghnxVqvr9NF0TPAuaFa0a9KS+JykyMzouG0D4HzYg7+WXDXPHrxNlgbF gS+pGCFWSK7PBK3di2oPAINuR3n7CwWO5QIOe2eXm27QkO9D7ssvkBW30EHjzQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1734016531; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4emVGX5GKepZ/jaWhhYiVTv1Ym5mrZk/KN4PTzN7QiA=; b=pamKl+3Qf1+QZyveYyqL6dfqNAtGdvGhknNoGidk+HGu3eI3KbDvtL/xUBICQV66iUA1EQ HDmhzAgNbYJ8GFDQ== From: Sebastian Andrzej Siewior To: Alexei Starovoitov Cc: bpf@vger.kernel.org, andrii@kernel.org, memxor@gmail.com, akpm@linux-foundation.org, peterz@infradead.org, vbabka@suse.cz, rostedt@goodmis.org, houtao1@huawei.com, hannes@cmpxchg.org, shakeel.butt@linux.dev, mhocko@suse.com, willy@infradead.org, tglx@linutronix.de, tj@kernel.org, linux-mm@kvack.org, kernel-team@fb.com Subject: Re: [PATCH bpf-next v2 3/6] locking/local_lock: Introduce local_trylock_irqsave() Message-ID: <20241212151529.oPNxM6JC@linutronix.de> References: <20241210023936.46871-1-alexei.starovoitov@gmail.com> <20241210023936.46871-4-alexei.starovoitov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20241210023936.46871-4-alexei.starovoitov@gmail.com> X-Rspamd-Queue-Id: 59FD21C0021 X-Rspamd-Server: rspam12 X-Stat-Signature: y6jpgckay9949q6x4ce7pgtps5s6wehm X-Rspam-User: X-HE-Tag: 1734016522-868707 X-HE-Meta: U2FsdGVkX18DfaMuzkhE37wwvQsOqaP83J53lF/gCF4IaPcqNX/FbokGQnqTQ/O7WfikGFhAZO5L79GdgWJW6oty6a0c93RAONL0deCqKVBTOEmGqCc4fpbugWf4s0NEjb+ZsduS0kzsp6yMCMfMEHq0IJRtYoePzAWXKIIbW13WkRY34sZb9e/xKPPJj0wPTtwc17vmkgTorCGNAFwxn1cEKMaKTxYsJzHzH+Q3tXuBc5SgvFeTkgF8d3c4Fp0tJh1HtQQG34M5VQt3Ov4nKuI9RIW6xlwrWL7L8/UqzlbK8ALLevFf6oqWSxByRPgnwZhPhKx1TmPLaBlJTb6DHIrjwgNt1ya9FnaAhh78lJwPlClju9CrJh09zxINyLTOCF+5picVw06JHQ0A+jeNbrb8KOffbQ367U5fV9oyV4r1JL2yzB+bzlcUOJbVuG37AcQAmNNrzl3GauZ7PIv6X0Y+TKsIFOrL5FuueI3qIgDOwd8AHs5kGJxtiTqdpzuDwL73Tg1LxYtvOeF28yNY7wPO876ichKZGqV5c9E4xnA4SnWUD2SSdgLcpd5gfCMqDHcRlS1EyINDGqDrxeGk+8zSAwSUdCmMj7aQzmaHlza+x5g2vUkKFu4dJ4NPxB0gSMsV23fcU+blOz2Z6M8HHqjKqx2AUHmZMiZb4y+NvAgYyxfYu8C7GPflho/H2XZBcSHhGAfc9mq8U6aFHqsNAkYddQ46aOcTD8YgmMry2OeUh/Rc9OD0+0BM1bx/tmaONsF2lVCOTfYxXTuZWDQdksvmXPDBwLOhFc79znsy22yiVxDW0Pi3hm2lH6KySPY+DvUh597PI/WdEqyFyi+Iz8uU5BDL8G5qexTZnQBxYdOcev6tGValDCQu5+/jTMUZSkG6oEz2FCf1caH8kC0jnGS6zHvysf1d+Raz+si5anP1mlOY7QT3nS23lIEEtk9xeZOtmXzwtNlYaTa5bdM nflZUgi4 hzrTpg02G1Eg9K+sLWGNM13LQXqeTYMy3VmxJAf7BzdaAUH3jy5Sqxq2ZXLOGgtojU27FEw9FmMlqyxyJyEYKQGwjVNh3xYOQGHWidwlPOZGcWuCQY+tO6Ah01q3pfwRTStMzsbLxG9P5MMiwWkGpNA2JdvGLkix5Iw1sewP4/Eea1lkgnhvtFVFdEqPRUrv4nZauNs6YfTAbcTafXh7rXiUMah7UQFV6FFJChu2Ci459UZjxiGx8Dwt5seD8avof5+t/8kSmendz3omyb+YxhVISnQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > diff --git a/include/linux/local_lock_internal.h b/include/linux/local_lock_internal.h > index 8dd71fbbb6d2..2c0f8a49c2d0 100644 > --- a/include/linux/local_lock_internal.h > +++ b/include/linux/local_lock_internal.h > @@ -148,6 +163,14 @@ typedef spinlock_t local_lock_t; > __local_lock(lock); \ > } while (0) > > +#define __local_trylock_irqsave(lock, flags) \ > + ({ \ > + typecheck(unsigned long, flags); \ > + flags = 0; \ > + migrate_disable(); \ > + spin_trylock(this_cpu_ptr((__lock))); \ You should probably do a migrate_enable() here if the trylock fails. > + }) > + > #define __local_unlock(__lock) \ > do { \ > spin_unlock(this_cpu_ptr((__lock))); \ Sebastian