From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6F87E7717F for ; Thu, 12 Dec 2024 08:47:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1D0976B0088; Thu, 12 Dec 2024 03:47:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 181BF6B0089; Thu, 12 Dec 2024 03:47:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 06FE56B008A; Thu, 12 Dec 2024 03:47:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id DD4446B0088 for ; Thu, 12 Dec 2024 03:47:29 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 63490140B3F for ; Thu, 12 Dec 2024 08:47:29 +0000 (UTC) X-FDA: 82885677462.23.2321BC4 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf10.hostedemail.com (Postfix) with ESMTP id 3E7F3C0008 for ; Thu, 12 Dec 2024 08:47:17 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=PJsH8iSL; spf=pass (imf10.hostedemail.com: domain of leon@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=leon@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733993231; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZMiM32Uoqs8dR+TTH8r32VBqLmE9MQQt5kZhZ8Gvs60=; b=1C6B1VDlcK27qPjC4JTnMyh4J7JH/Wcx+oKKPnHdc3fJEf/hXM4DCAk2FH3wIym6vdr9Ni Z7qVlp2IbpEcqJ5E31AGuMq9MsGRtts8nF1GmxNIO9dYlxhcsEHFadxFFg6vb/GMx693k+ 6M4d+kF4YgqzcMk2AklIOn+vavV2cE0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733993231; a=rsa-sha256; cv=none; b=Q2AAjWTLyNZ2C3Bd3QRYfIMnK/TEKd1tPvojgiF1Viyk8DzrdSYAqS9LN30lCxkxNgBR4T LLUGVv8c558Y3hSMJbT27nXtqnOk9eWKzz2sIjLU+BJnLT61cefNkeOzNqP2InNcD0vEga NMSMtvdDjyh4jBVQBwozZB8HX6x9bOk= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=PJsH8iSL; spf=pass (imf10.hostedemail.com: domain of leon@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=leon@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id A9562A42630; Thu, 12 Dec 2024 08:45:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AD098C4CECE; Thu, 12 Dec 2024 08:47:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1733993246; bh=ReOcuWziWEQFCCJQAUurQfV5neoF3l/FqcJT0j3aqF4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PJsH8iSLtYHP8paIZEP4nJ8nTDKr+RtFEDNTXjVNpPCq42ZMvoqqJvcpOfszhO4+2 5q+56DuWg4SGme3LxI0sBsdYw0j/x32/u0c/gWkJfPUk3sl4nRpHe1PXPf31cktN6C ycJ7bYP1Dw9zQAeddLZhw7WIZ2LfeuPVgl8LORlnkJaVEgJdPeDEnlle2whXBTTqRq ayDuf0vzWweUJC34kQDFaAIuOSnAN7cRVoxR7StJNTRNATxu9LxOExmd8ebhsHoM6O UISY6so5QpmKtPUDrtYL4yyt3DEQVTWhA3MIrNyFAdOxmdoEnPoky4HtSJHNdc0edv zEy13QGAmAO8w== Date: Thu, 12 Dec 2024 10:47:21 +0200 From: Leon Romanovsky To: Christoph Hellwig Cc: Jens Axboe , Jason Gunthorpe , Robin Murphy , Joerg Roedel , Will Deacon , Sagi Grimberg , Keith Busch , Bjorn Helgaas , Logan Gunthorpe , Yishai Hadas , Shameer Kolothum , Kevin Tian , Alex Williamson , Marek Szyprowski , =?iso-8859-1?B?Suly9G1l?= Glisse , Andrew Morton , Jonathan Corbet , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-rdma@vger.kernel.org, iommu@lists.linux.dev, linux-nvme@lists.infradead.org, linux-pci@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org, Randy Dunlap Subject: Re: [PATCH v4 06/18] dma: Provide an interface to allow allocate IOVA Message-ID: <20241212084721.GH1245331@unreal> References: <20241212084206.GC9376@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241212084206.GC9376@lst.de> X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 3E7F3C0008 X-Stat-Signature: snzbdxy9u1ieo5o1bua6uzh969mjpryr X-Rspam-User: X-HE-Tag: 1733993237-682155 X-HE-Meta: U2FsdGVkX1/HDcoRbYrVuXpXAZGczVbw2i5f1CUsoo802an7siYvXPVgA73MYAYrswdzYtLI0UKjZ1InFLjml7kAccTRyZJYIZPGHbbF/D2XTB9NvrIY7/a/wK+5HT5tIGN7irrafnj5gQdVKKluS/KXDqnly3+Fmw2amaPykcs01niT0GN4SaWIqm4yVA6hqloaatIke9i9We4AsP2fyPL/ROmo4gHFEegw2FWSvIsj4EBA/PJ2N6DYgB2E04PCtKO/VFanSpzPrCjnyNVcYSocYGiZB+KpN3X8YkdPtUeja81C7X60Vl4GW1bK7jzyiN068MbBJx9JlhN9kyH4sFqgVIe3SeDWPyEKoDwq3H/Irh1gRaMS75Ps7lCp6c8PgkK2kkY45sZ0g1Vy38nx3mYxFtOPlT9QBprtwV9l9vsBtwWW1p+Lyn8DuGcqPYT2rZD60BdXWlDcMdLimZbD437d6JG+DNAiVHuyQoaRvU2KfvcziszOkMupJT8BaYIKUyQ324ozMygcUrIH568UMpQNHkdFlsb2NEqjUs3NtYb3C9Ui/YMewBFzgpoRYXLGP1Y0qhulwUNFrnLJ7qRqWmj/BM7v3B602MXah/s3KjMUCD1taeWPD5qbseG1uRtw12DkTgjJ/x5vCJ+2fT39KuWF+ANsj7UofNHIGBBOBZcSTeKzK4Uy0dyhfLGyW6a5fXhkDmHkOA+SpAM9Y8yAMN79lx2Lwo5OFhh5vZ8g/z1EBJuGpmM2v5IZ+Iid1vzEDX0ydPjXcYrG7LvVGKUIEq93NTKaqJekMx0RsHxIdie5t8L+jPAXmqHs5KEycCYMcs8eql3+omFAvxqF3v4VJGgRbgPLsUj9ECj9pOcUad9sFyX18n6wFU//p8OEyPSrTgzmRrl94Frzx/55AXT4pHJG+bELCtb7J5gpTbJ7ZJdjLcqo3aVSFbz5u17IN169PNZtcUFkn4kjXOYI8sK IO7p8hT/ qd7w5vupMyydvz4BH+gmmzuffkefPIgdtvov6+KZEPFiywK0g5MmrgZu8wmoJCHVEkQccoRJYNehvSxUZ2uE1hsyExdVJUrBs8tGyZkPhCNlXdQW5i5Uo9+8OgiWLq/yZ+Ji4QDy//wfNLe1O6Icj3b3IYS/IAerw7aywks0Lot/47hiM7y+jCN93WsAG0TOSbMcint1HquYjPj36GONcl21Hzo/UmRpPb22ea1d7WWJ2xlrn7mLfZaUafF+eePUAoRBw X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Dec 12, 2024 at 09:42:06AM +0100, Christoph Hellwig wrote: > s/dma/dma-mapping/ in the subject. > > > function call per API call used in datapath as well as a lot of boilerplate > > Please trim commit messages to 73 characters so that they still look good > in git show output. > > > +bool dma_iova_try_alloc(struct device *dev, struct dma_iova_state *state, > > + phys_addr_t phys, size_t size) > > +{ > > + memset(state, 0, sizeof(*state)); > > + if (!use_dma_iommu(dev)) > > + return false; > > + if (static_branch_unlikely(&iommu_deferred_attach_enabled) && > > + iommu_deferred_attach(dev, iommu_get_domain_for_dev(dev))) > > + return false; > > + return iommu_dma_iova_alloc(dev, state, phys, size); > > +} > > Now that dma_iova_try_alloc is the only caller of iommu_dma_iova_alloc, > maybe merge the two? Sure, will do > > Otherwise looks good: > > Reviewed-by: Christoph Hellwig Thanks a lot.