From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D377EE7717F for ; Thu, 12 Dec 2024 08:45:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1A8E06B007B; Thu, 12 Dec 2024 03:45:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 158F96B0082; Thu, 12 Dec 2024 03:45:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 020386B0083; Thu, 12 Dec 2024 03:45:41 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id D8A486B007B for ; Thu, 12 Dec 2024 03:45:41 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 5DA081616F3 for ; Thu, 12 Dec 2024 08:45:41 +0000 (UTC) X-FDA: 82885672254.09.E3607EB Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf09.hostedemail.com (Postfix) with ESMTP id 4913F140013 for ; Thu, 12 Dec 2024 08:45:23 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="jM/fC3SV"; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf09.hostedemail.com: domain of leon@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=leon@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733993128; a=rsa-sha256; cv=none; b=4RcrCqpUzHPyLBJx9gbYJrmyASSBoOHeOi1RVa/nLy3EyKErvz66jSZRrkQSV/URRuqbg1 3AK8lJ5TcqRmp6xCumXHfKxsnP5vGhBRImAa43lOp1S/ZV7J4VRVvMbrZFjX7vnaqdazx8 zMM+j1OLiNEBSB10MXJ2JWdun9K0TP4= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="jM/fC3SV"; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf09.hostedemail.com: domain of leon@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=leon@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733993128; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mSqvXnIvaard16c/eLd3u6yesms3ox0NrxpeL5ooiDg=; b=IL4Vli6tA6pLlO60fsu9wEOrghmpR75+/Boqfena9wphBC6PsLtyrTj1nT31vMRJCyzcBh sAYbh/bScx+o2RzAWeOqtrTgnppypSU7QCsqFt4egNUPmBQ80wn/sRmSwtkjq1Q08x417W Em3rPCFwg1/qONXieEPsKfem6APu3Tk= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 58A805C04FF; Thu, 12 Dec 2024 08:44:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8DD34C4CECE; Thu, 12 Dec 2024 08:45:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1733993138; bh=SnaoS3XbMfIwMqA358S7ljqTiZShb2tbxNANsv2qtHA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jM/fC3SV71OtekQMes8cU//Y2sVccBO5M1Rp1oSOeTfUHhdh/h8Kp0Wvkl5o9Y05t XZUgwUE2R2RdWaGKe67gws/VOMS7zdgNWvMX8LE9oP3EVbdz9mXouuy/FRi5oTmj1h HBkXA4kz2nWgmHfTNOBM+/FQGz9UW4jC5QE+0HuooFXn+AUPVn1GJd7D8dNvWcBu2h 38m7i4D9C3LMpjXAIPmM3N0DXbZhPQMfgP30p/Rbp0BTcWwMNAuanAHMhsbK+tTlgp VtDSO8fkHojv+71VgMMV/oewnpYMbcTPln7F9wB0QO2TpBTFnvhRf0FJehQQTrsban tm5f/HMiAk5mQ== Date: Thu, 12 Dec 2024 10:45:33 +0200 From: Leon Romanovsky To: Christoph Hellwig Cc: Jens Axboe , Jason Gunthorpe , Robin Murphy , Joerg Roedel , Will Deacon , Sagi Grimberg , Keith Busch , Bjorn Helgaas , Logan Gunthorpe , Yishai Hadas , Shameer Kolothum , Kevin Tian , Alex Williamson , Marek Szyprowski , =?iso-8859-1?B?Suly9G1l?= Glisse , Andrew Morton , Jonathan Corbet , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-rdma@vger.kernel.org, iommu@lists.linux.dev, linux-nvme@lists.infradead.org, linux-pci@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org, Randy Dunlap Subject: Re: [PATCH v4 05/18] dma-mapping: Add check if IOVA can be used Message-ID: <20241212084533.GG1245331@unreal> References: <20241212083459.GB9376@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241212083459.GB9376@lst.de> X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 4913F140013 X-Stat-Signature: zzgkfob9i3xj5d3h9trzz7whbumoz6z9 X-HE-Tag: 1733993123-713896 X-HE-Meta: U2FsdGVkX18sWjGBLr5DcHSzXGaYRk0eSTNM7CcWcWmy/rhIvmz9nzFmSTjNAXrOgF/4OQoy1jIDaj2OQOPeQv3oByEvUOJ+xnLkhr2wfrqLV+Ig9eKXFj++prOTvn44gxhk233oPTaMCEkgRmRA5I+oY5bg3IQaS4l0yj1Btg2j2sv+uY+6YFXtWYGKqO+L+Qlrj5W86Fy/HRZsucyhTRg9J4bucWT72YvAm7lXey6lxLbDIp3ZJg57wT6W3QjWBwSXhkpWyVLudGN1uQIsR4kIieZGBHBb779JoLEnbFsl73kW9KZ//agRvQr22Kks9YHxlEEZgOdoRomtX8sbVDdtdL6GEEnf7cZU2p45xjalXdWu4RAJfzeuVsegVEo7ZghJFimRdKANvJ0/F5QGdhUga4H3VRzYqJJMQ4fiQCQ0cEuknMs6SYx1zEesjh//AgTISEBAsoiQN7UWoh0rXajWLmc3YTFmfd4roSiledaiJ7LArLbFM78tNjvyPSGi6jNKxsCTEfJ3K1GjtzygK8xm9AUIRm2gw0+a/6brkeNmM5RXQs0eF+uJIIjy2aM1qiYEOWphegL3hzM+3j+ZIbgbcduzdILjUnnan9UDQUWi7swyXEl9kqxDspqXBMRcqc+N1dhB3JY+bU8Xo/5GS/RqAKPklsiboP61JMkxKKrdTUwiPKoXzjhUyU8nG/zjasiqbuixPCWZgDjPhSVBHSakkHBo528een2Xpmk20rhurPcx3ttcIyOC5Mci5mw+DobUZhDAAbFXv5+PGXU65gHdUWV3B9jQFM5rB0gInNr5aZ0psUZDvFbl68MPeDBkBXRj7HS70mPxhWt9xuPuORsM/pS2KLugWtZYz+dPeUgigdfSWPR3M1U4YFHNDjVmASmcQ5IdXhGdhl/mWB/fGQZ5On+yY7+ZQQAcsnxFHPHG0FBbp2zr+7Ri/0aFPGRoaD6lWQIDtYAT2a9L6VX 1jOxP8E6 yks986md2z0eIhMB0y2rdiIPwfQ5ssT1mZkd32+U5j/+C0rM1hDBvM2Puuxf9d5LVyOGMm6LsEBS72I+0pj2fWaTmfeL1hYcwJc2zXpSjeojf9S7LKeW9Uwgk2P5+2cjgTkcfZinMH7sA+v+FBEw4cSI4knmskTMBMoo1dCsdX0mv7BUhm+mUEQnb0TsRLQeBwcCSlPEz5l68GPezBGCy5WAbJvoHRLNdUE+QqCfYjVKJdfCrw4nR/mHO8LmPBF8IpK3jIwXqQr/GGv7hUk2+7eoiswxLbkY3YxNJydq6mvES3M0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Dec 12, 2024 at 09:34:59AM +0100, Christoph Hellwig wrote: > On Thu, Dec 05, 2024 at 03:21:04PM +0200, Leon Romanovsky wrote: > > From: Leon Romanovsky > > > > This patch adds a check if IOVA can be used for the specific > > transaction. > > > > In the new API a DMA mapping transaction is identified by a > > struct dma_iova_state, which holds some recomputed information > > for the transaction which does not change for each page being > > mapped. > > While the content of the patch here looks fine, the super fine > grained patch split look really odd and makes sensible review > hard. Was this a request on one of the earlier versions? I don't think so. It is combination of two factors: 1. Review cycles, which caused to shrink this patch. For example, see the amount of content in RFC version of same patch https://lore.kernel.org/all/cac154df7131984929a1cf73948bc5986af5ef85.1726138681.git.leon@kernel.org/ 2. Attempt to localize changes in dma-mapping.h file. The following patch touches dma-iommu.c, while this doesn't need to do so. I can squash them. Thanks