linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Leon Romanovsky <leon@kernel.org>
Cc: "Jens Axboe" <axboe@kernel.dk>, "Jason Gunthorpe" <jgg@ziepe.ca>,
	"Robin Murphy" <robin.murphy@arm.com>,
	"Joerg Roedel" <joro@8bytes.org>, "Will Deacon" <will@kernel.org>,
	"Christoph Hellwig" <hch@lst.de>,
	"Sagi Grimberg" <sagi@grimberg.me>,
	"Leon Romanovsky" <leonro@nvidia.com>,
	"Keith Busch" <kbusch@kernel.org>,
	"Bjorn Helgaas" <bhelgaas@google.com>,
	"Logan Gunthorpe" <logang@deltatee.com>,
	"Yishai Hadas" <yishaih@nvidia.com>,
	"Shameer Kolothum" <shameerali.kolothum.thodi@huawei.com>,
	"Kevin Tian" <kevin.tian@intel.com>,
	"Alex Williamson" <alex.williamson@redhat.com>,
	"Marek Szyprowski" <m.szyprowski@samsung.com>,
	"Jérôme Glisse" <jglisse@redhat.com>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	"Jonathan Corbet" <corbet@lwn.net>,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-block@vger.kernel.org, linux-rdma@vger.kernel.org,
	iommu@lists.linux.dev, linux-nvme@lists.infradead.org,
	linux-pci@vger.kernel.org, kvm@vger.kernel.org,
	linux-mm@kvack.org, "Randy Dunlap" <rdunlap@infradead.org>
Subject: Re: [PATCH v4 08/18] dma-mapping: Implement link/unlink ranges API
Date: Thu, 12 Dec 2024 09:43:32 +0100	[thread overview]
Message-ID: <20241212084332.GD9376@lst.de> (raw)
In-Reply-To: <50de680233f2947594471d30976565c209bf7864.1733398913.git.leon@kernel.org>

> +static inline int dma_iova_sync(struct device *dev, struct dma_iova_state *state,

Please avoid the overly long line here.

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>


  reply	other threads:[~2024-12-17  0:47 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-05 13:20 [PATCH v4 00/18] Provide a new two step DMA mapping API Leon Romanovsky
2024-12-05 13:21 ` [PATCH v4 01/18] PCI/P2PDMA: Refactor the p2pdma mapping helpers Leon Romanovsky
2024-12-05 13:21 ` [PATCH v4 02/18] dma-mapping: move the PCI P2PDMA mapping helpers to pci-p2pdma.h Leon Romanovsky
2024-12-05 13:21 ` [PATCH v4 03/18] iommu: generalize the batched sync after map interface Leon Romanovsky
2024-12-05 13:21 ` [PATCH v4 04/18] iommu: add kernel-doc for iommu_unmap and iommu_unmap_fast Leon Romanovsky
2024-12-11 22:20   ` Will Deacon
2024-12-12  8:33   ` Christoph Hellwig
2024-12-05 13:21 ` [PATCH v4 05/18] dma-mapping: Add check if IOVA can be used Leon Romanovsky
2024-12-12  8:34   ` Christoph Hellwig
2024-12-12  8:45     ` Leon Romanovsky
2024-12-05 13:21 ` [PATCH v4 06/18] dma: Provide an interface to allow allocate IOVA Leon Romanovsky
2024-12-12  8:42   ` Christoph Hellwig
2024-12-12  8:47     ` Leon Romanovsky
2024-12-05 13:21 ` [PATCH v4 07/18] iommu/dma: Factor out a iommu_dma_map_swiotlb helper Leon Romanovsky
2024-12-05 13:21 ` [PATCH v4 08/18] dma-mapping: Implement link/unlink ranges API Leon Romanovsky
2024-12-12  8:43   ` Christoph Hellwig [this message]
2024-12-05 13:21 ` [PATCH v4 09/18] dma-mapping: add a dma_need_unmap helper Leon Romanovsky
2024-12-05 13:21 ` [PATCH v4 10/18] docs: core-api: document the IOVA-based API Leon Romanovsky
2024-12-05 13:21 ` [PATCH v4 11/18] mm/hmm: let users to tag specific PFN with DMA mapped bit Leon Romanovsky
2024-12-12  8:48   ` Christoph Hellwig
2024-12-12  8:54     ` Leon Romanovsky
2024-12-05 13:21 ` [PATCH v4 12/18] mm/hmm: provide generic DMA managing logic Leon Romanovsky
2024-12-12  8:51   ` Christoph Hellwig
2024-12-05 13:21 ` [PATCH v4 13/18] RDMA/umem: Store ODP access mask information in PFN Leon Romanovsky
2024-12-05 13:21 ` [PATCH v4 14/18] RDMA/core: Convert UMEM ODP DMA mapping to caching IOVA and page linkage Leon Romanovsky
2024-12-05 13:21 ` [PATCH v4 15/18] RDMA/umem: Separate implicit ODP initialization from explicit ODP Leon Romanovsky
2024-12-05 13:21 ` [PATCH v4 16/18] vfio/mlx5: Explicitly use number of pages instead of allocated length Leon Romanovsky
2024-12-05 13:21 ` [PATCH v4 17/18] vfio/mlx5: Rewrite create mkey flow to allow better code reuse Leon Romanovsky
2024-12-05 13:21 ` [PATCH v4 18/18] vfio/mlx5: Enable the DMA link API Leon Romanovsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241212084332.GD9376@lst.de \
    --to=hch@lst.de \
    --cc=akpm@linux-foundation.org \
    --cc=alex.williamson@redhat.com \
    --cc=axboe@kernel.dk \
    --cc=bhelgaas@google.com \
    --cc=corbet@lwn.net \
    --cc=iommu@lists.linux.dev \
    --cc=jgg@ziepe.ca \
    --cc=jglisse@redhat.com \
    --cc=joro@8bytes.org \
    --cc=kbusch@kernel.org \
    --cc=kevin.tian@intel.com \
    --cc=kvm@vger.kernel.org \
    --cc=leon@kernel.org \
    --cc=leonro@nvidia.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=logang@deltatee.com \
    --cc=m.szyprowski@samsung.com \
    --cc=rdunlap@infradead.org \
    --cc=robin.murphy@arm.com \
    --cc=sagi@grimberg.me \
    --cc=shameerali.kolothum.thodi@huawei.com \
    --cc=will@kernel.org \
    --cc=yishaih@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox