From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7FC52E77183 for ; Tue, 17 Dec 2024 00:47:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6EA996B00A5; Mon, 16 Dec 2024 19:47:49 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 44C376B00A9; Mon, 16 Dec 2024 19:47:49 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 278D56B00A7; Mon, 16 Dec 2024 19:47:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 9AE1E6B00A7 for ; Mon, 16 Dec 2024 19:47:48 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 2893E1601E6 for ; Tue, 17 Dec 2024 00:47:48 +0000 (UTC) X-FDA: 82902612240.25.5325F3E Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf11.hostedemail.com (Postfix) with ESMTP id E5A8840008 for ; Tue, 17 Dec 2024 00:47:18 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=none; spf=pass (imf11.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734396446; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+V4ulW501CFBe21acqtUchKrgLK8usvF5c/zK5VBIhc=; b=eSBzmpvQbWqvxEBKKUxt8/e+uXsfOOPvRh5qtGaWKx/K408EjUnig52Zj5tvJMkxEhk2z0 A5jgTUaHhKOGkIqSP1f47Mh/SRVH7nu1z3CgcYZwNbZ5KYQCS4f1QzdS7IDPYh56EzAoUs pcUt8bvXGSYYqDaHARyD3JFgHAPe8Ng= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734396446; a=rsa-sha256; cv=none; b=xeut9nKso/IaLc+jcgXqwH69lq4T2wsRmsMSyviBOeaV2IyR0wOZNRzp95gdiGiBvY8JXI ghemOIkSl5B5A+v9Mx0y4nqqCdRLwH7mdUeIkekpRSKoo9cLpICdYj1SDrqAFS6fbQHqZ/ kvYNOQ+goOPIqsKjM0qKEu4/zOPjz/Q= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=none; spf=pass (imf11.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de; dmarc=none Received: by verein.lst.de (Postfix, from userid 2407) id B516068D1C; Thu, 12 Dec 2024 09:42:07 +0100 (CET) Date: Thu, 12 Dec 2024 09:42:06 +0100 From: Christoph Hellwig To: Leon Romanovsky Cc: Jens Axboe , Jason Gunthorpe , Robin Murphy , Joerg Roedel , Will Deacon , Christoph Hellwig , Sagi Grimberg , Leon Romanovsky , Keith Busch , Bjorn Helgaas , Logan Gunthorpe , Yishai Hadas , Shameer Kolothum , Kevin Tian , Alex Williamson , Marek Szyprowski , =?iso-8859-1?B?Suly9G1l?= Glisse , Andrew Morton , Jonathan Corbet , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-rdma@vger.kernel.org, iommu@lists.linux.dev, linux-nvme@lists.infradead.org, linux-pci@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org, Randy Dunlap Subject: Re: [PATCH v4 06/18] dma: Provide an interface to allow allocate IOVA Message-ID: <20241212084206.GC9376@lst.de> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: E5A8840008 X-Stat-Signature: 5c58i7io3kkp8csyz3f4etj1drmkz1y6 X-Rspam-User: X-HE-Tag: 1734396438-581717 X-HE-Meta: U2FsdGVkX19f6pnBlMflS2w4xjWc3TD3GWxh323UvItbtTsU36aYTUsn4SR0UESpPUGd9czTrTrqm+fDWSyB+aHoaUtz8EgbUjtRs/UOTaEM6AUEpkQqap+cPuQsiBorYPKXr87KjWtJ+jW8nFyZTa9bwCC72BHY7dwBwwNFcTfC9VrjH8SwuIEpPL2qE21yPSP66jcBmlmUL56Hx/wJRN11Bm2ov1G0tzX2uaDLK40vIL9bSH6uK71BDdAxQ1fBICfG2dcep3R4jBQHSqjtuNSeEgBFw8qgKhqHNW7HKQ8OaGnM3+KX8s+79rWCMTHXr1p8qnPtlxyZOh9W2aXLwXLwsEHLl01jKTVzGeT0bbaoag0uVb1Zn/qc/gd6QqUl26HhLqEz6reppWFn4WvLUDVnhZspwEJzdCIsm9Xq03uNt42bRzn5ABxmrT6C6no5wAzSfIiKhHeckO+/zOuYYB6VVy29//tUDSYSTux8HFz2T5iTocJnFovGW6Z4NfzzrJ5gbkPUQ6ISKRRhFyXP+LPCGnjmiOCuxJLfu66OzQmXywMJxtdsv2wtdVrHTFI2hFsY9RvLlESPz4g4puSVUkrplhQTK2meBicwIPK/OafTyGbEfvyg/Pi1KZQPZ06CIVZovIFuhmSJujvlOZT5721LBIu8rMmbGx3KvBL/0Li3UWWMtPaV6Ynk+oSsJdh3iTIyDM77960XTmWYpnsu7quAADmOqGJxtGj9uPXyk9EivfAp/DbcXx0KXwBRZlAaTj+GcZvDkYwKT5CcuscFZsMFkaC4V44Y0gr72aUBwLWq7ic2MKTuDcDpVnAptcfU2U4tsQYbEQxCdGv/e4Fyo20Ae5tAib+FhO/WF1p6Qa0Sxu2JuSSPgWm9wl5X0UH/zL30QcilU1uu8w7H2q0W9ELsT0x5fAxUxAXVfpMCd777wGOniOpK1zQ33JHAk5Jjj7PYCk5iBpXz7FzRwrL d4wlaNs+ 9CtSoQ1ww42V8Dl+r65bDznA6HGK7ys2ff/20PPiDYqM9QuGu23aXvc/qW9FGCv4vCDMGPp53G8ScfEgAaB7d12b3v9qhNbbX856MFYvtbKhSUg7mQHkyWlKH/VD3nldeVLRskQqQonlDZLwCPed53GZDjpmP5Tn5H0XmO1+eTdMVg5lqNHZ7VbbXhk3hnrefNEFxRjzqn2iNowo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: s/dma/dma-mapping/ in the subject. > function call per API call used in datapath as well as a lot of boilerplate Please trim commit messages to 73 characters so that they still look good in git show output. > +bool dma_iova_try_alloc(struct device *dev, struct dma_iova_state *state, > + phys_addr_t phys, size_t size) > +{ > + memset(state, 0, sizeof(*state)); > + if (!use_dma_iommu(dev)) > + return false; > + if (static_branch_unlikely(&iommu_deferred_attach_enabled) && > + iommu_deferred_attach(dev, iommu_get_domain_for_dev(dev))) > + return false; > + return iommu_dma_iova_alloc(dev, state, phys, size); > +} Now that dma_iova_try_alloc is the only caller of iommu_dma_iova_alloc, maybe merge the two? Otherwise looks good: Reviewed-by: Christoph Hellwig