From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9AFC8E7717D for ; Wed, 11 Dec 2024 17:18:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 18C5C6B0099; Wed, 11 Dec 2024 12:18:59 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 13D1F6B009E; Wed, 11 Dec 2024 12:18:59 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 004536B009F; Wed, 11 Dec 2024 12:18:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id D1C726B0099 for ; Wed, 11 Dec 2024 12:18:58 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 87A381A0F51 for ; Wed, 11 Dec 2024 17:18:58 +0000 (UTC) X-FDA: 82883337852.05.CAF76A7 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.19]) by imf24.hostedemail.com (Postfix) with ESMTP id CE27A18001A for ; Wed, 11 Dec 2024 17:18:52 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=M7LCWTXd; spf=pass (imf24.hostedemail.com: domain of lkp@intel.com designates 198.175.65.19 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733937526; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FFWVafWcuzCdiOhf2dqzsCoXW05fP9brs0xgGUCuFHo=; b=YY6U7vlBMKHEy3x0O4JvCBYO62Ja8pzQkNq78reFYhE1sAKSIOC6Ueb84iVkvTt+QpTnuA 2zOmcgZbwQh+XpTsu71iMGv/lb6E8+X8OdbaBV1nLFvMnNFMLGdBxrFUa0ZXgYAcN+Ri1q buBcVFvEtgF3xvwMg4IXcW/ebuL9sWw= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=M7LCWTXd; spf=pass (imf24.hostedemail.com: domain of lkp@intel.com designates 198.175.65.19 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733937526; a=rsa-sha256; cv=none; b=Q2HNzToqGFb9MFebA1bHbmtfqzg79/gNdPBadnveioQgndfs2zPUUJjS/5dS363JMkHw5S NkEOKTWcoRh18Xgdth7TAOYC3RhoNjhqzF/ffu3X59QSvs6Fa9nMKo+qAARQbIqxrIsBZM PJlA1RsXwtc9Aoox1gcn/NrY1Dx8Xj0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1733937535; x=1765473535; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=Ck+PVhr4fHniz5Eg+zhhB78UyZZdlCm0HtuiQWn6AFk=; b=M7LCWTXdz//c7Ef3CjUFAaH9qOzEdPC0rUDSWiP7iRbBRjbwPP1IHBzq 9Q+6uYSgD3THmU1waxSM9Zdn2zjvnV2U9Ao8Was4rqLl602vYQl5K6H8g iTEA0DwdrTVJF7fmUTpc8bQWHYc8q17o9IItTDgoCjs5WeFY5Myi3sRqW OD3QHw4ehkRKiJmt5LegUY4Cc/Go+s0bVSozF3QHYj/+w0Z+4PleBwFFQ 7QzQsqoudfbCoa9sYzgMPEOcozg3HyOKxuqhPAEWPT8Cf8o6Y7mCvo3sF f4rmlLbhaTLo6VaZHNA3EujN/YCGHDGpacgH+Lggnv8naMLC1fR+hu4Eu g==; X-CSE-ConnectionGUID: Cndkuov6QuWLCnGaOIREAw== X-CSE-MsgGUID: tb8VS0gcQmW96F5iJaB1cA== X-IronPort-AV: E=McAfee;i="6700,10204,11283"; a="34203262" X-IronPort-AV: E=Sophos;i="6.12,226,1728975600"; d="scan'208";a="34203262" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by orvoesa111.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Dec 2024 09:18:54 -0800 X-CSE-ConnectionGUID: CBUOilqoRsm+7CIBPNeM7Q== X-CSE-MsgGUID: DwmC44QBSTyW/BFN3cRSbw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,226,1728975600"; d="scan'208";a="95714130" Received: from lkp-server01.sh.intel.com (HELO 82a3f569d0cb) ([10.239.97.150]) by fmviesa007.fm.intel.com with ESMTP; 11 Dec 2024 09:18:52 -0800 Received: from kbuild by 82a3f569d0cb with local (Exim 4.96) (envelope-from ) id 1tLQML-0006vf-1b; Wed, 11 Dec 2024 17:18:49 +0000 Date: Thu, 12 Dec 2024 01:18:16 +0800 From: kernel test robot To: Hao Ge , surenb@google.com, kent.overstreet@linux.dev, akpm@linux-foundation.org Cc: oe-kbuild-all@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, hao.ge@linux.dev, Hao Ge , Ben Greear Subject: Re: [PATCH v3] mm/alloc_tag: Fix panic when CONFIG_KASAN enabled and CONFIG_KASAN_VMALLOC not enabled Message-ID: <202412120143.l3g6vx8b-lkp@intel.com> References: <20241211025755.56173-1-hao.ge@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241211025755.56173-1-hao.ge@linux.dev> X-Rspamd-Queue-Id: CE27A18001A X-Stat-Signature: 1xahw49ei8fzn9gu36t1i8bq5mudo735 X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1733937532-250520 X-HE-Meta: U2FsdGVkX19yCutoEd6cx7UL7XXjl0Yf35fPng5UPvx3GyT541Xr20URiFJktzsuw+5rDlrxL+Map0v7Frp5PQTx20wedJiEDvUNqA+toVnylZh/etw9id3WmMwUfzhcODZqNp2tQIA33mUj+LFAgYCd0KdAZzw8xX+uzqZTaNwXOcT4zQlwTwpNxwVyB9g+9hx4sJVH8enmFcy7lqI8LXlouxRRGqLvJGCkj4xDrB4ccN/pJeM7thnG1fSHGclXxsiFiuROR/0b9AqK553zHHLkc+o5fp2DE5IyWIFGYcw/oVkRm+qL0YSZj0zwnIUwAAPJy/STOyRGhSJqJYnMoHGpEbog3dHwtXTOo3ZyvWiO1ClaRSRIbuhi11labnfj9fMIrvHhAopkCGzaPfVypmq4D1YUscR/BcwVIWRebIkWlq9+ZidXD5LN9+4ImUp05o77AOrX7pyF5mq0X5f0mkd/0ZzfhX0JhbP7Om506dfwJZxxwna+SZDmKFtbM1c3ActlnqnNM8Myglt/vTz+so3nvpIO3RPzgmoBHIk8sPsnqVduuJn3YR2Q8TmPBk6715ykTRCOOOeaj0oOAXCkdRIrwexl79gyLGYxlyXXAQDIGr8KS88AkLX6U2MTwEi6gZz2tVK6l21nR0vuGXVEYRxGQoNj6BsXsnpi7qCk+vjNqANHe+aWtMWvlhjhH0VrmQ+u2oWQeHnz3qBZqYO2d0/hj+jHbcmkZnWu1iL5tnKjM45a9x3sEcSnAhZZJ1MSrz8bXdOsbdCbGCaGkjWstHvdl6BruGeVd4+2h+uTTUYV8Hrljo6R8wlAWFKuo1Nk9DLo62GZyO8ZoMsi56GsDejokf0GO/7JwVwiH6jrUmtBB5DROeQlUNSy7cUnYnh0xcLrjYlnSVDSlK+/ll9dSmuHklw2/xxWl7L9y26+0Z2rjRtBaBYkM6osa3hxbuyl6VuBYHoUrFek+iUOBGj rzDb7EY9 1/0O+hPk9dN6mL5DMgB5CssTRwEop3g2/oN/560SwG3U0B4VzuU2K5YkJS+GBbD+tZnVQCwqrkPaR2FJRILaB/DtiahqNA2tb+Ck/TOX/PHEL+fmrHR45IjbQLn2Elnjnsx/uYIx3bAtz+bipL+s6V+I2CsiOf5SUNoEeg/wsS7q8My96FaQMgvnWXg/udT1tW4fkI0NDvgNudnxiBL8XSveH+yClEKrhbMQWPy1sjN1vP8RWTMaJfFu4YeC737GEARUM1ddSYLQ7ro2NZ4AF9fp8ATDMJG1ezDacwSTHz8l9cUUsR8rY+JU6HPpIPQu8cce9dX8THHVYysrhVoGfnA80hivOxBttrhnUfMi39z+OczrhCNrOY43MYQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Hao, kernel test robot noticed the following build errors: [auto build test ERROR on akpm-mm/mm-everything] url: https://github.com/intel-lab-lkp/linux/commits/Hao-Ge/mm-alloc_tag-Fix-panic-when-CONFIG_KASAN-enabled-and-CONFIG_KASAN_VMALLOC-not-enabled/20241211-110206 base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything patch link: https://lore.kernel.org/r/20241211025755.56173-1-hao.ge%40linux.dev patch subject: [PATCH v3] mm/alloc_tag: Fix panic when CONFIG_KASAN enabled and CONFIG_KASAN_VMALLOC not enabled config: i386-buildonly-randconfig-005-20241211 (https://download.01.org/0day-ci/archive/20241212/202412120143.l3g6vx8b-lkp@intel.com/config) compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241212/202412120143.l3g6vx8b-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202412120143.l3g6vx8b-lkp@intel.com/ All errors (new ones prefixed by >>): lib/alloc_tag.c: In function 'vm_module_tags_populate': >> lib/alloc_tag.c:409:40: error: 'KASAN_SHADOW_SCALE_SHIFT' undeclared (first use in this function) 409 | (2 << KASAN_SHADOW_SCALE_SHIFT) - 1) >> KASAN_SHADOW_SCALE_SHIFT; | ^~~~~~~~~~~~~~~~~~~~~~~~ lib/alloc_tag.c:409:40: note: each undeclared identifier is reported only once for each function it appears in vim +/KASAN_SHADOW_SCALE_SHIFT +409 lib/alloc_tag.c 402 403 static int vm_module_tags_populate(void) 404 { 405 unsigned long phys_end = ALIGN_DOWN(module_tags.start_addr, PAGE_SIZE) + 406 (vm_module_tags->nr_pages << PAGE_SHIFT); 407 unsigned long new_end = module_tags.start_addr + module_tags.size; 408 unsigned long phys_idx = (vm_module_tags->nr_pages + > 409 (2 << KASAN_SHADOW_SCALE_SHIFT) - 1) >> KASAN_SHADOW_SCALE_SHIFT; 410 unsigned long new_idx = 0; 411 412 if (phys_end < new_end) { 413 struct page **next_page = vm_module_tags->pages + vm_module_tags->nr_pages; 414 unsigned long more_pages; 415 unsigned long nr; 416 417 more_pages = ALIGN(new_end - phys_end, PAGE_SIZE) >> PAGE_SHIFT; 418 nr = alloc_pages_bulk_array_node(GFP_KERNEL | __GFP_NOWARN, 419 NUMA_NO_NODE, more_pages, next_page); 420 if (nr < more_pages || 421 vmap_pages_range(phys_end, phys_end + (nr << PAGE_SHIFT), PAGE_KERNEL, 422 next_page, PAGE_SHIFT) < 0) { 423 /* Clean up and error out */ 424 for (int i = 0; i < nr; i++) 425 __free_page(next_page[i]); 426 return -ENOMEM; 427 } 428 429 vm_module_tags->nr_pages += nr; 430 431 new_idx = (vm_module_tags->nr_pages + 432 (2 << KASAN_SHADOW_SCALE_SHIFT) - 1) >> KASAN_SHADOW_SCALE_SHIFT; 433 434 /* 435 * Kasan allocates 1 byte of shadow for every 8 bytes of data. 436 * When kasan_alloc_module_shadow allocates shadow memory, 437 * its unit of allocation is a page. 438 * Therefore, here we need to align to MODULE_ALIGN. 439 * 440 * For every KASAN_SHADOW_SCALE_SHIFT, a shadow page is allocated. 441 * So, we determine whether to allocate based on whether the 442 * number of pages falls within the scope of the same KASAN_SHADOW_SCALE_SHIFT. 443 */ 444 if (phys_idx != new_idx) 445 kasan_alloc_module_shadow((void *)round_up(phys_end, MODULE_ALIGN), 446 (new_idx - phys_idx) * MODULE_ALIGN, 447 GFP_KERNEL); 448 } 449 450 /* 451 * Mark the pages as accessible, now that they are mapped. 452 * With hardware tag-based KASAN, marking is skipped for 453 * non-VM_ALLOC mappings, see __kasan_unpoison_vmalloc(). 454 */ 455 kasan_unpoison_vmalloc((void *)module_tags.start_addr, 456 new_end - module_tags.start_addr, 457 KASAN_VMALLOC_PROT_NORMAL); 458 459 return 0; 460 } 461 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki