From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E331E7717D for ; Thu, 12 Dec 2024 01:17:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7FE076B009A; Wed, 11 Dec 2024 20:17:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7AE126B009B; Wed, 11 Dec 2024 20:17:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6286F6B009D; Wed, 11 Dec 2024 20:17:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 3F59F6B009A for ; Wed, 11 Dec 2024 20:17:26 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 9F59E1A1361 for ; Thu, 12 Dec 2024 01:17:25 +0000 (UTC) X-FDA: 82884543294.23.5431FD6 Received: from mail-qt1-f174.google.com (mail-qt1-f174.google.com [209.85.160.174]) by imf09.hostedemail.com (Postfix) with ESMTP id 1B08B140004 for ; Thu, 12 Dec 2024 01:17:06 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=iu9GDr9Q; spf=pass (imf09.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.160.174 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733966232; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=djWQoJOklaLH0BLuJ8p0AL7/ItgSiiuZQ01XKXXCzcE=; b=e5uEPjOeUOUoAyzs9Lxj7eBl0GUprFDPJg5BGhkZ4RMryO9W7JfeWUs43J+68VI122Twbo DQBNkw9Ff1ShcGMXlsyySgsdHMP+NAPnpNySuR451tdzoD52BEhmfJ+Y5fw3OEvu4ydWQb TM9M+WSXo+Z3EZ/GmGGFwr9S1ZN73bE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733966232; a=rsa-sha256; cv=none; b=l/UY9hr+EkbPaYa3UyFmtOzF1c9NYLLJe5UBD4uG9/O/eg6qJZvdSSg7ocS3MuNJ8WgUpO jQS1LPVS73QzIdOTljInq+qUtxvxulQukxJn1rCa2ssjO5uJARWsSZ8K+IAANeLsaS5NhQ l87O7En7tbsq62Njo5dAGiNXAsR5xEc= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=iu9GDr9Q; spf=pass (imf09.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.160.174 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org Received: by mail-qt1-f174.google.com with SMTP id d75a77b69052e-46753242ef1so1055691cf.1 for ; Wed, 11 Dec 2024 17:17:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20230601.gappssmtp.com; s=20230601; t=1733966242; x=1734571042; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=djWQoJOklaLH0BLuJ8p0AL7/ItgSiiuZQ01XKXXCzcE=; b=iu9GDr9Q+LfzhSe1KJ7Ic0ed7rUqoYhRmweshZs4X8JU4/n/zAJtCot0FLF/TTHgp5 Kd2r/qYyNmJO60pykgpeP/kPNp2y9RFXxKMxnqXoEgDQFX5g8qO3+0mATirsVT1tyz/z Oy7zRBYMFQil0yYk48Th9tBuwCHv2qljdByEUniVuJZRoChvnRZj42bKHAI8LWWy1uuc BmB0GWCAdCDvAVXXVfo2cQ+rxjbwBHPJGKte4Aaj1kGRbM024roRg3M+h1a0TPNGD+fa XCiaM3fadsg4cH3bjp/UOtewwJDqIz5s+11CQzjxZoYqigJEB3ZCwUEzvKJMCXco9zbt etHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733966242; x=1734571042; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=djWQoJOklaLH0BLuJ8p0AL7/ItgSiiuZQ01XKXXCzcE=; b=iDdryKu1FblSG1Dao/zQbdo81/lvRSjjX53K8N4ZKuV7D6j+O8O1Or9lcK1Gz9ZKkf KpD41HyX8NGfn49V7+CTubWV5Ac4s1ApWewbg349Oplk/RPcZCiqsXPVNk9LVG69qhtB Hs8NS6l0Hed7HssSI9O90lPA2YNuZBv2n/LnC1HFcT8YAELi2g4XTPASAbzwWomcwvJm eQrmLvdJUWd41hATUbk7IKrOacpKWP+1Rz1/F+PgKp1GBg+yEHze5dUJE1G1y6fO6Kgn gVvS7eGz7WaLujUAGMvUz/2NXEeFl7W+d1uky80GZzWRN9HKd7D45QcHIouo+BdQixqq YdWQ== X-Forwarded-Encrypted: i=1; AJvYcCWqGElVa5N4Xqzn9rS3L65VsaokCxsBiLnxyrcxYXYE1CyEpOjQsyXwvNYC7oY6hwx53z23GBsCrA==@kvack.org X-Gm-Message-State: AOJu0YyGcfXCoNPV7S03jbQqq5Bup1wjru+c15pyCO6MrxiGpZiaqnrT c323xJZb+le222nnFlT/AF3bbQKL/xIIe/xDAGJqqhfWuohTHlm57vrOdkqJyjw= X-Gm-Gg: ASbGncv6tUBjVorzE8cd9LfrSIXxucDm71U8fFT66yZU1HoO/K6cacvkVSiRu4ufs2e UrONsplN15Ki6ckPHvrkqDcECzOeIecnOO+dTdWpTbQB6ufZ8YC7o8byQD5AMEik5hs+iaBlH91 wOBbLEcTYzFl0s33RNndEJeti9GQaRjDqrwELa5S9j8bmqUmbMb3bW764hRCYk8hUs1jhvWy3Ev PYJkTvjyDFnpSGLsikxU3Cx1lwDerspFr6dMWYQqxHwIH6VqYRg6NA= X-Google-Smtp-Source: AGHT+IEnJPekbYQNH9UrAAv3zHb1sBsf3vy+46DjthV6gdW4FwtIgcVe9aICG/pyjcXAlON52ZvNYQ== X-Received: by 2002:a05:622a:1243:b0:467:6226:bfc1 with SMTP id d75a77b69052e-467961afa32mr29536261cf.29.1733966242116; Wed, 11 Dec 2024 17:17:22 -0800 (PST) Received: from localhost ([2603:7000:c01:2716:da5e:d3ff:fee7:26e7]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-46780a93029sm21262041cf.84.2024.12.11.17.17.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Dec 2024 17:17:20 -0800 (PST) Date: Wed, 11 Dec 2024 20:17:19 -0500 From: Johannes Weiner To: "Matthew Wilcox (Oracle)" Cc: Andrew Morton , Christoph Hellwig , linux-mm@kvack.org, Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , cgroups@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v3] vmalloc: Fix accounting with i915 Message-ID: <20241212011719.GA1026@cmpxchg.org> References: <20241211202538.168311-1-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241211202538.168311-1-willy@infradead.org> X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 1B08B140004 X-Stat-Signature: eajaqgorotczbe6ytcnthr41g3zfqjzj X-Rspam-User: X-HE-Tag: 1733966226-931416 X-HE-Meta: U2FsdGVkX1+U6EeTUrhdNX8aKwm1KlI3b/eU6C2IfEac55U7K4qHtiN+4i1uFlYo//syn3bFzPXH7QZipdCwyUB7uQQNU7SmchzYAcTOs+Bz3c4/KxvtrHsTrd2NfR3KkhOjAU94ct0iAA0V8ltjL2okkNARC5a88jA3elDoXWFxFB1tVNIeyjmNirdQq0SD+ESkmz2k86rF513aqTVh7XFQcwE4n7f8EZP6yA75BMQzQQUMoxbIhvUlEjjSpCTtNtwn6zlBXEtOqdLkN4ocgxOETj8JFacfz8saGeWI0HVfBCEKxU++c1yZeeb3iKi1f75QZGPKoHMpdgYnlFqa1Q5FVsNpb3t/JnoX5pBZZEH+E27Po3nO6WdSW9mz1P3PY641jMb8c+4fRjnH6rgKrUARcZ/raVzywdhMzUuNuRy2V6CPbjTf7hJGwvvjc7LOjxtiaOl03i1+a2lk1HQhwzhhNHPFgXRHYKQns+IdPL5ZEdA2KdEoMiWufQMurM7IvOT/VXRKPl/pPfbWS1L6i6woIjbVtc7HexhgyVF3jgnhMn7dOj0TVMJulyHg2Ryux8qv9HcL9LVJq2GUiamgwk5dIdIsUv/UkpYhUKXnVjAm2OmrqU/NtXtlH5gEOVWjaBthwpyz+ygT2rj75YWbDWecqRmgWgx1+56c9cFwY6Ul0ctnV8akILz5myT5RCjIVH3AGpk1CdEMMS55RsKpEsW1HLxDmTUmRWPjZgIyVU7Y8P7ezszctjiF4m46ylYmypfCY/VTiOShcjNHaz8g7VYWpvDxBzFja18hkgEDdeaKbLi53PbfrCSwAJBoZLR2CVXDu3346+NyjU9029REJZMWE5XDfVnaN+3laHOSPNUMG77eLHtRSKMIxSB5vv9ENrwZGTaKpARGcrrRCiwJ9Q3YsBx+dLR5bbtRD/e4eMyATTgYSXmH5r/K/0aFSAJqteb4F79s2lCt7G44oqp gbXfbhpU 1Cm2a015BXloiG2E664ju0I9jZoUmdF/nuMhZSRSTTnC/pXf6DX2IxP4/4H8McbeD0L7gf4SwvTSACXSKcWKhL2lQYurNUehHz/aXAunUt3HUNjMVKmLjBBzrmrdlP6Itijk37Ge0XqMK6cUsp7brL0JGPe5zc4u19SZgaqnCCZn8dM36xzLVpVkq3QLdpT4CiPBsYKhFObC9JP4WkciyYc5viBzieoHdXS1n0KvTsTZUps48GqA+9sZdC87ZU7z6wdzvxLvGMASvjHSpXRl8+fZ5J3KHRD8DksDZqHVnavmIeIsiAA8WxFPJnrQ60p2WG3JmdkmVMckbPPJNNMRjUwnZMta9CFYwV/bCnOz8mqzHdP1oMOVo+gvwNZeC4ASFVHx/LlBOYbqFQJxqbdIioF2JDQF6cvMeidClCB9R1iRhNST0EqyQbwycTQS72+dualBeKdChJ+0JC91S0q9VliDGHrwobqx+dLF5sYcl2heigGWdkARorYH3olwm0WGf04ysrHc/mTUyLZqhp58bePC2mpztN8U894TqnrkYTrcKN3IRObVYVSct9g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.003376, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Dec 11, 2024 at 08:25:37PM +0000, Matthew Wilcox (Oracle) wrote: > If the caller of vmap() specifies VM_MAP_PUT_PAGES (currently only the > i915 driver), we will decrement nr_vmalloc_pages and MEMCG_VMALLOC in > vfree(). These counters are incremented by vmalloc() but not by vmap() > so this will cause an underflow. Check the VM_MAP_PUT_PAGES flag before > decrementing either counter. > > Fixes: b944afc9d64d (mm: add a VM_MAP_PUT_PAGES flag for vmap) > Cc: stable@vger.kernel.org > Signed-off-by: Matthew Wilcox (Oracle) > Acked-by: Johannes Weiner Nice, thanks, looks good to me.