From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2155E7717D for ; Wed, 11 Dec 2024 22:20:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2998C6B0085; Wed, 11 Dec 2024 17:20:13 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 249886B0088; Wed, 11 Dec 2024 17:20:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 110F06B0089; Wed, 11 Dec 2024 17:20:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id E75F46B0085 for ; Wed, 11 Dec 2024 17:20:12 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 93F1EAFFD9 for ; Wed, 11 Dec 2024 22:20:12 +0000 (UTC) X-FDA: 82884097212.28.1270FED Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf12.hostedemail.com (Postfix) with ESMTP id 7941E40009 for ; Wed, 11 Dec 2024 22:20:00 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=kBNirnu6; spf=pass (imf12.hostedemail.com: domain of will@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=will@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733955600; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NFm6TEc4bDsgccsGt1PrHoJ7kZc8ZvLb1gZZTByj/Vs=; b=EWmovicOIhGJciE7T4nWiDzmpXQ+GgC1TTC3vqlCJI7ArRf7eInFAkn9ORFlTSG//Bjqg9 zX4VqiTtIni+YqEH4cTCrWOJ2o6e5FhMh3kBKB8HUezg5In4ZIsRQYDXdNYL75xf6u34yi 9wuL/SGZ2xprrmTOvcrztWQS/4rySf8= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=kBNirnu6; spf=pass (imf12.hostedemail.com: domain of will@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=will@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733955600; a=rsa-sha256; cv=none; b=zIwrnxLG0RP2MKyiAh3faghFKnTi1N0DZrPBRxbqCgpuwwUFl+vBg8x9YJR7Q7+8fFHTlq JEfHjLByei7is35bWaLGixK/nvwDXkbfP2pDry9oX/Yxk1jxYvl741RXQaKvodcsyuDbWp gf1nbg3qLR34e9J10DpgJRzYDloE3pc= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 16B9E5C67B9; Wed, 11 Dec 2024 22:19:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4576FC4CED2; Wed, 11 Dec 2024 22:20:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1733955609; bh=VLhIlSr54TL2QmDP8JRM72GWULbrO+1dbQF3pJw1ea8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kBNirnu6kCr1d7gsDMgZrNuAXLYpD8uzILmzzbrNO1Mnk09f4n481Cndxfrau3+jJ FpLkwRUeISCmz/SpemPgohhlQ3XgJzMdmIoVZ+IhBa91qhgYo51NaglvZU5BDtIZwB //WGIgbYueq/MY8+Vmm6UVkGftTY+5cuZd/vROmxV6NP1K5rtWTWqMiA7gXfNGL2rJ x8QxUc2OB1rxoUChWT6mPdO+zhCO+RaRL8TgtaiQ2BKywx4s0f0kj5Ngw6pkMs+dfE zgxHiHxwQbMNfdTxhMs7Xm5RVvG80KHa9zyTwAQzCJbyWkRaNGRYrBbAH41l/rU6DO Lf0Zf/ATio7bQ== Date: Wed, 11 Dec 2024 22:20:00 +0000 From: Will Deacon To: Leon Romanovsky Cc: Jens Axboe , Jason Gunthorpe , Robin Murphy , Joerg Roedel , Christoph Hellwig , Sagi Grimberg , Leon Romanovsky , Keith Busch , Bjorn Helgaas , Logan Gunthorpe , Yishai Hadas , Shameer Kolothum , Kevin Tian , Alex Williamson , Marek Szyprowski , =?iso-8859-1?B?Suly9G1l?= Glisse , Andrew Morton , Jonathan Corbet , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-rdma@vger.kernel.org, iommu@lists.linux.dev, linux-nvme@lists.infradead.org, linux-pci@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org, Randy Dunlap , Jason Gunthorpe Subject: Re: [PATCH v4 04/18] iommu: add kernel-doc for iommu_unmap and iommu_unmap_fast Message-ID: <20241211222000.GH17486@willie-the-truck> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspamd-Queue-Id: 7941E40009 X-Stat-Signature: cuypigtbrbgo4d164q4g5qefkbhhse7o X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1733955600-329347 X-HE-Meta: U2FsdGVkX18exW1KdM4tqET3iCJOYVl3ukiJLxqvPA03MtYlkaiEHYw6iAhjLjCdQEUbmMS00a9v4mEBnkdOe9A29aYV5NALJes6VqVBOU4gz+syVNPAH7EqXWbYj42TbjV8DUTdrMoTlXvy6B9yj5pSqKU84b9bY/PKRgtvXP4oarmSprkol9+FDrGLKUI341S32eUSJEgyL2nVMnbOUQ7eij9QWGAWBaf85zbkP9/ZCbe2mlWIfGbxX7o12qM7JI3cfy5zHWM3rotdLExAsOnaYIphUNVfkqGvA05U3mGdcdxDi0j82ZlIo7CqwHNC+pTne4Silum7vuZm7MBBhxdzFQiuQBIRY/6GJwIJMKTO/4T7jwerbuzYQ+pb0bvMTvwf6JEtmEd7rR+fZw/Rbc45d5/I0TZWAdClUwLf6WrltwvKqAzMnrL4qpMeBO0xYq023RQYRhZT9REp4mTnf5DgwUvInOZ+v9attBtQjh2tYA+8rGtmGqyK0A9LbzLvZnXETujBWvdkkr8TuIHV36hU9qiHwdAiy42H7lRDzpo1lXbAZUJcJywOPUrTWVwE3QuvbaNXpdP0zn7xUqj8HVMkM2ejZfE4NJ0BUumXxWggal/qZyXcIbBEz481lE2mef/MDYkuE0lwZ9tqP+p/0GXaNWRv6PxCgRA1BHa27PBR7xSiFBsapudUmn9rjUBke0PR8TzjKQF2M4WJ0DvcjgAPZ/YaIP3rkhMc4Smkdk9wW4EYI3NAKtUEqAGAccFpnUwJuP7INwcGARAVlZLOMzlfGEjdddSIzHtmdNDaLgXZvTRJZftIrUMLEvRhm6E4f0NsgnLl9t+fNqzCJAA77GaxCHKFPfUozghzsN3LdUskztGuUvpu+6ZxBd7eBxxkdhJQA6+BjwfhkQYYy36iL5BVHAhSKZHJN/iZo1mIfLhSqUOr0J8Qj6HbcoU3knYCZKuuOPatJrGf7XF2i2k PcxYUXLZ Ob9OJHW5RCmZal6prAFrang91HWgsvrXIeCWSLmbE825FAyPbvwwKOs7B2B/A8//+pK+hCtP3NA1GKJWb2XTKQLzhB25ZAnji+hhBA8Ofl/UvUQuH3aAQFppjvoJMQNVa3JcLhRrHS1081ypb5HdJKn0YsUQOcsv4c2REbiqqEqHMnVuyZGEbRmbpXRmtm8X7HHBwlCAUKGtsPwjAxPhz3QH9uXmyz2Dz+QIGuUSlk+1bmq8nf4DpNnI1yTNyGafraj/wdsV6yu/HwwdnKTPn6DfqYVgxLlScYJzUzCIbVWscjc4CGCqWT4rO5A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Dec 05, 2024 at 03:21:03PM +0200, Leon Romanovsky wrote: > From: Leon Romanovsky > > Add kernel-doc section for iommu_unmap and iommu_unmap_fast to document > existing limitation of underlying functions which can't split individual > ranges. > > Suggested-by: Jason Gunthorpe > Signed-off-by: Leon Romanovsky > --- > drivers/iommu/iommu.c | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c > index ec75d14497bf..9eb7c7d7aa70 100644 > --- a/drivers/iommu/iommu.c > +++ b/drivers/iommu/iommu.c > @@ -2590,6 +2590,24 @@ size_t iommu_unmap(struct iommu_domain *domain, > } > EXPORT_SYMBOL_GPL(iommu_unmap); > > +/** > + * iommu_unmap_fast() - Remove mappings from a range of IOVA without IOTLB sync > + * @domain: Domain to manipulate > + * @iova: IO virtual address to start > + * @size: Length of the range starting from @iova > + * @iotlb_gather: range information for a pending IOTLB flush > + * > + * iommu_unmap_fast() will remove a translation created by iommu_map(). It cannot > + * subdivide a mapping created by iommu_map(), so it should be called with IOVA > + * ranges that match what was passed to iommu_map(). The range can aggregate > + * contiguous iommu_map() calls so long as no individual range is split. > + * > + * Basicly iommu_unmap_fast() as the same as iommu_unmap() but for callers Typo: s/Basicly/Basically/ Typo: s/as the same/is the same/ > + * which manage IOTLB flush range externaly to perform batched sync. Grammar: s/manage IOTLB flush range/manage the IOTLB flushing/ Typo: s/externaly/externally/ Grammar: s/to perform batched sync/to perform a batched sync/ With those: Acked-by: Will Deacon Thank you for doing this! Will