From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A5B6E7717D for ; Wed, 11 Dec 2024 16:30:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C918B6B0093; Wed, 11 Dec 2024 11:30:11 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C40FA6B0096; Wed, 11 Dec 2024 11:30:11 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B08F16B0098; Wed, 11 Dec 2024 11:30:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 902B26B0093 for ; Wed, 11 Dec 2024 11:30:11 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 4637A1A0BE7 for ; Wed, 11 Dec 2024 16:30:11 +0000 (UTC) X-FDA: 82883214960.04.B1C8FF2 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf17.hostedemail.com (Postfix) with ESMTP id 04DDE40017 for ; Wed, 11 Dec 2024 16:29:50 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=SfTs3FVh; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="E/WlTmkR"; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=SfTs3FVh; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="E/WlTmkR"; spf=pass (imf17.hostedemail.com: domain of jack@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733934593; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3twRuAkYpHgCNmk1tjJ/d+LtY2uXM1gPNvHwK+vKo5g=; b=C7AtG9brlkyqBqcSpyyJbg8T5wC+MxboYObPqNpyqpYtcUNmctYgRW+k0cFF8U8qKta+Tn TaBKfMLYNW91VKpS7qvkrfoRWM2zFa+iLL1jTplnRFdiiF4TC+pph51ZQhCJxSRze6U6fy bnTu0rYkpqofgfDueZjxQdTWQ+eXvPE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733934593; a=rsa-sha256; cv=none; b=k+IuPx1ncuy/GbGOLkijAMvzmkti+1god0xWTPmB/BsGHNoWhbvaaP4fJlr+QHtpc/LqlM PGb2NMXgkFxddAg8D/K7cWjKfuOYlnxNb90kCZJ4U2xoiZd5UqutuA5U4Ztd1p/aHx+eok sksoatgQIbP5mhdRMSfGYrGu5pkHsVI= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=SfTs3FVh; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="E/WlTmkR"; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=SfTs3FVh; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="E/WlTmkR"; spf=pass (imf17.hostedemail.com: domain of jack@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id C30FA1F74B; Wed, 11 Dec 2024 16:30:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1733934606; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3twRuAkYpHgCNmk1tjJ/d+LtY2uXM1gPNvHwK+vKo5g=; b=SfTs3FVh+l0sYUrKpZENXj63N+SojRDtvsiUbjl3KO1N9JmCEVfxE0YrbLrxyB8VT1/3FF wxFI3FBtTdkzF8qY6kqhVA7ve+LKUFqSaETTtVUd4aG1l0jGEdmkjVUqUdg3geI6eS82yy Yx9YEqI9WAiWqbPEw4Qndf1Om4l65ic= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1733934606; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3twRuAkYpHgCNmk1tjJ/d+LtY2uXM1gPNvHwK+vKo5g=; b=E/WlTmkRIUkUF9Qq1A+G3/+Pekx2KQvgk/b/FSP2OL2X80rDqU2jF+m27J6+LP9IcUZBoO WQokHPkDiqcsn6Dg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1733934606; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3twRuAkYpHgCNmk1tjJ/d+LtY2uXM1gPNvHwK+vKo5g=; b=SfTs3FVh+l0sYUrKpZENXj63N+SojRDtvsiUbjl3KO1N9JmCEVfxE0YrbLrxyB8VT1/3FF wxFI3FBtTdkzF8qY6kqhVA7ve+LKUFqSaETTtVUd4aG1l0jGEdmkjVUqUdg3geI6eS82yy Yx9YEqI9WAiWqbPEw4Qndf1Om4l65ic= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1733934606; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3twRuAkYpHgCNmk1tjJ/d+LtY2uXM1gPNvHwK+vKo5g=; b=E/WlTmkRIUkUF9Qq1A+G3/+Pekx2KQvgk/b/FSP2OL2X80rDqU2jF+m27J6+LP9IcUZBoO WQokHPkDiqcsn6Dg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id B41151344A; Wed, 11 Dec 2024 16:30:06 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id VQjwKw6+WWfKVwAAD6G6ig (envelope-from ); Wed, 11 Dec 2024 16:30:06 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id 60CDAA0894; Wed, 11 Dec 2024 17:30:06 +0100 (CET) Date: Wed, 11 Dec 2024 17:30:06 +0100 From: Jan Kara To: Randy Dunlap Cc: Klara Modin , Josef Bacik , kernel-team@fb.com, linux-fsdevel@vger.kernel.org, jack@suse.cz, amir73il@gmail.com, brauner@kernel.org, torvalds@linux-foundation.org, viro@zeniv.linux.org.uk, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-mm@kvack.org, linux-ext4@vger.kernel.org Subject: Re: [PATCH v8 16/19] fsnotify: generate pre-content permission event on page fault Message-ID: <20241211163006.2r2mxe7vddzgk7ka@quack3> References: <5d0cd660-251c-423a-8828-5b836a5130f9@gmail.com> <391b9d5f-ec3a-4c90-8345-5dab929917f7@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <391b9d5f-ec3a-4c90-8345-5dab929917f7@infradead.org> X-Rspamd-Action: no action X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 04DDE40017 X-Stat-Signature: cb6qoynbtwrswgdsjmj4913z8io54yyb X-Rspam-User: X-HE-Tag: 1733934590-857036 X-HE-Meta: U2FsdGVkX193Yo2JMTvNeY74x8jH0thZzWyN5xUmSE9g9tAZQMJQ9xQ+zNFToCRNByrm4/qBOlZdhxg9iT9u+aycG/tKIR85sLuBfjoQEELdiFuD7idLJ3wprby1qKBalpLG5MRkDO9GhRjdHdC5GvCmpODQ8wIomLGNVcnnYvJHOIVtrSJVjwSCYTxh4jxc3SeB30KWa9scc6oRvt+HriLpu6KvbDe8lbUxgaMlqegpFbImdlq3HKKV9BGB067yoG7IyA1CdRVbQaxbvT0VtwZh+ySFb84YqaVvGbegwcFEDcNFxUMk2TmNCCUzeHEkzio37BFLHNYUuN9Pq9Pcpd3dX4O7UeoJa/I52S3WNuUdm7H8ua4VIgj+0pYCTpTNx8Ie5XyX779v8sEMJ2PRbIrk1gyEsO18Yi2bjuHISZbKmgCiCM51NDhE9ZLzmMJQaKoFivKJASz5vx5GxJV2fFEtRdsQw83yJ5PPgcISoiX1zV2tDz3w5DpNeUz/Wr3eJ1VDihDN8KRpJmURmORT606gXOZm8vQ6BH0WhzUpfBKIsV6J4NenMQ7uHxXdb/srqVtRWr76c4d75/NwcirTIMXoOEdoXVrhcLjHKA4GpLsmtNCSCqA92LEli3AOQDazrShOWLgZMkdadbucB+v7l9Uy0OvnxVeApXfJW2XhC/N6yEdcE++sWainChqwGooefwqVu2s5H+mGIcHp9fXWUvMbQCC5K6FJRHUSq6OCeVw7X5VBAOCW5MZYAJXuckCJmYuH3ZQDeJkbzaeZHW/pgtsNfTAUhbhfYAKBMeDaqAcy8GV1IHElG1rL5ntbhoax4FF9osRM2j9EKRvCQ3AnHEzMv0BhdKGiBWKnGkNQF+p3A5iYpFDvJMyEzjFaZk6/DDQA8rlyZDtS1p92sDIWvfeGqfoP4VbrhemuOD53JIFvUt0k7N2Phi1HIPPaZu7OEo8AbWz9rmqR7ssQgii 7hD6PTJr gIxOvmv42UERhNSD6yAthHgVG6wwMSiDOKCyRFEhRd5dLV203FYslU7829YPyNfCf1GjMRk8e9FUBOCqG0kxsD1w0amfGVEJe0kakkyPsjVpPSD0HE2TWGs78Un/p7NrAvUmzUeOAVit4LYzslxyaT6yRPn4ziFE2o+E9EnWpkX2rNtf/q8QPvt1LHGtwvVA8cJllmf+84K6LcWe/IpPAGapnYjAqitAw4KOMryn+E2VDzhOBaHrEXVsmeYfJ6BjGbpJc2Nb8lVwnZ24aUQKCtFgERG9hQ8ZhkO0Q/fTGhwczBHTROfN/N8u5rZx2CETabRwP8HvQz50H38S8qeW0Ch3r+eiDJD48fNjpa1fiFn1svNQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue 10-12-24 13:12:01, Randy Dunlap wrote: > On 12/8/24 8:58 AM, Klara Modin wrote: > >> +/** > >> + * filemap_fsnotify_fault - maybe emit a pre-content event. > >> + * @vmf:    struct vm_fault containing details of the fault. > >> + * @folio:    the folio we're faulting in. > >> + * > >> + * If we have a pre-content watch on this file we will emit an event for this > >> + * range.  If we return anything the fault caller should return immediately, we > >> + * will return VM_FAULT_RETRY if we had to emit an event, which will trigger the > >> + * fault again and then the fault handler will run the second time through. > >> + * > >> + * This is meant to be called with the folio that we will be filling in to make > >> + * sure the event is emitted for the correct range. > >> + * > >> + * Return: a bitwise-OR of %VM_FAULT_ codes, 0 if nothing happened. > >> + */ > >> +vm_fault_t filemap_fsnotify_fault(struct vm_fault *vmf) > > > > The parameters mentioned above do not seem to match with the function. > > > which causes a warning: > > mm/filemap.c:3289: warning: Excess function parameter 'folio' description in 'filemap_fsnotify_fault' Thanks, fixed up! Honza -- Jan Kara SUSE Labs, CR