From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93DE7E77180 for ; Wed, 11 Dec 2024 15:32:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 057996B0099; Wed, 11 Dec 2024 10:32:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0086D6B009A; Wed, 11 Dec 2024 10:32:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E10FC6B009B; Wed, 11 Dec 2024 10:32:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id C2B786B0099 for ; Wed, 11 Dec 2024 10:32:22 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id F0D76AF308 for ; Wed, 11 Dec 2024 15:32:21 +0000 (UTC) X-FDA: 82883069010.26.4C851BF Received: from mail-qk1-f173.google.com (mail-qk1-f173.google.com [209.85.222.173]) by imf07.hostedemail.com (Postfix) with ESMTP id 3052A4000A for ; Wed, 11 Dec 2024 15:31:53 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=cMbJCW0F; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf07.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.222.173 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733931129; a=rsa-sha256; cv=none; b=HRuu3J3D+xFsNfSC1o6nhSayyVqkBBvg/xe0UVgSc+WReEUPPnTpjKHg/UdgxoYHBjR6q7 CvxjSlMpeeBmToFGf51lHq3a/7fEe/BxZhOjGn4qqBWwxWh3Pbx4rjt3K0V+ZaYeSQDK3w k7VBQRuLz0jqeclFyQi8hcPs6wdH4kc= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=cMbJCW0F; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf07.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.222.173 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733931129; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Awqg9NyNSHCYANmgf+Mn+5u0b6mI5gQklzYKZzm0vmc=; b=6DtARRTpug59xnpvcrrP3hkGySmZA1kj/v97tyudUqKocoITkq3VeB0qG9kPSWOeVzZz11 TezuvMJVCmVwtq5hq0wjRYpSFZyYCUs4f6XNhIGKAzF+RSouZT2N46p7ILxPDKZhoqFiAX hOfYxFwZR12SOs0TasMbGKfOjKti8Ak= Received: by mail-qk1-f173.google.com with SMTP id af79cd13be357-7b6e9586b82so102752485a.1 for ; Wed, 11 Dec 2024 07:32:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20230601.gappssmtp.com; s=20230601; t=1733931139; x=1734535939; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Awqg9NyNSHCYANmgf+Mn+5u0b6mI5gQklzYKZzm0vmc=; b=cMbJCW0Fe1nALzOImKxFB80EDA9JGIb7gPLL5W0RfuU0ZgcuuTtyNmv6bjIKB8scFx T64SQsH2+jrv3ROShYt8ZXOXviNqIbo6CDi4u7jq+Zu9pfltG/8imNoX52L/LrbqPzMH dzUKLwNcrB2QxF/+w211XmtVrkfYNoxpE9ayAepcxkxz4AyXve+CXEsEFdgvt71149Gn WYHbLXj34N1pLpl2/b2BR+bEmu4NRRu5caKEcM1T8XmKV3lAITBLyAcbYe8BqlEKuwH4 DZbJTRCPvxA9RbMzwnnKyYxeHLzyEQN+Au/bn8aS0mWgQXHc5lKYGpe4MVtSQMatqAOq f+GA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733931139; x=1734535939; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Awqg9NyNSHCYANmgf+Mn+5u0b6mI5gQklzYKZzm0vmc=; b=uPa6XERRVdlbQa4liRJiwg9+TaZhcsK1u3GpOPL8MiIge6Q5fCJIY91J1xuTusArfW m0HU78azqmFqAyent+V+NJHWR8mDPy3mHZQpsurcvpPFRieUdvt93QV05EbyksndNsrW v6MaTG2JfosLR29rdIU1J5Ejm2Ycg5CoJFitvFOkyD8AExN+R5QAWHXMpCclzaS0tGYK xuuq8o+wd6vcfGRsQOoVnuIA/ONphGgWMb2e1sEc53TdWZrO3l0fLr0KcDBBdtqErhkA MjpuL9/5Ca9fVKy7zluE70WEtrsWUTJ402mE1LyDeb3MJnFPpBCqPcM1fpEJU/HJkHba wYqw== X-Forwarded-Encrypted: i=1; AJvYcCWJzUWlCY2Ym7o3E8UkjbogPQQ9Ne7cB7/k5dJ+O2WUJs4DciV+YQK7pySF3jJ17nZtyp5bH3WhcA==@kvack.org X-Gm-Message-State: AOJu0Yyo3DBHLMAPPbxAjll0V1JRzqH8AVH/d+WppOsWHDdiV4IXCJGx U54hsuJoNCwcG55F/TGw+iEva5ZhTxckEK77ib+9+ztByxca2jbGBqJfO5umIQM= X-Gm-Gg: ASbGncvACzfAgQWDfEt1yaB3mRaaWCUJ/bJOWXZFMoVvl4TZQf7LZUCbq5w6t3aSt0d X3xwYeLltJXkHkwAMmrXqCby7jH470OUxdA3Mk9o1JnhImv6G6rGloX/yLZ90bxciZJbea+DJJJ wzeWkfh6mVUSK5a2/RnDZsJ9NfLRaP/78Un6PX7nQFirRX75r3Th2myU1x7fRvMyYmh3swXtLmD 10s+idUo6F+cQ0dLPk+Zf5sBVaS+Kwjc6gFnBcNRsbicOPzpJfj X-Google-Smtp-Source: AGHT+IFOj5lGUuf6afp3JD+tDypMseeTH5+Ku4Z+VnrYYRy/zTpgcZlsC0+8gorvfeDMXfHHS/mZ0g== X-Received: by 2002:a05:620a:4050:b0:7b6:6d5a:d51b with SMTP id af79cd13be357-7b6eb53b012mr449355685a.52.1733931138674; Wed, 11 Dec 2024 07:32:18 -0800 (PST) Received: from localhost ([2603:7000:c01:2716:da5e:d3ff:fee7:26e7]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7b6d020783esm360340185a.96.2024.12.11.07.32.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Dec 2024 07:32:17 -0800 (PST) Date: Wed, 11 Dec 2024 10:32:12 -0500 From: Johannes Weiner To: "Matthew Wilcox (Oracle)" Cc: Andrew Morton , Christoph Hellwig , linux-mm@kvack.org, Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , cgroups@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH 1/2] vmalloc: Fix accounting of VmallocUsed with i915 Message-ID: <20241211153212.GA3136251@cmpxchg.org> References: <20241211043252.3295947-1-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241211043252.3295947-1-willy@infradead.org> X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 3052A4000A X-Stat-Signature: xin8echbwujh5tyqnh3fir5nykqtkdgd X-HE-Tag: 1733931113-857723 X-HE-Meta: U2FsdGVkX180U5rKnaiyuw3t6C7cdX5EOF/At8WkYQw2s+2+03F/0Kig/7tnYVdkAE7p1l2e5eMnQOtrEov8zh9JhBB1mslSwzJRoMpT7CW5P8scC9W8/7qOVttJBN3LjMlcyb2uzNrvNwnerLgZtobq99MREcJEr2F06EmeWu48G/KVOs7woDij+AFVYzixJH3wBNYn1YOPtDK/VB6VRxNssJCqwKTh76GtsI/so+JBvRLpGLQb0AkY1+8WDVP9ky0gA8EE4l4i2lrqH2NmUcFZ3Wqk74sxKcqLS3sTBcOIhixi27oyZYAsIcaeo/Q+RLLJak3gG8qkeU9aMTEv6ZUmzODmAV/4Utj2/Uj93lZpAETTRPepJ0XSYt81T0fda5NPyNnZUk4jplfEZQEu82faQGdYdV2HtxlyWc/f64k5d/mFQ0obHYEZH5ivBI9WpBtk9C/DwVwFGMPxTb5n9Ocq1gDfle/luAuekgg0C4bI47deWAr9ci3PGcDZWOBZK3/CqqS3fCG5cBmXCU71GLw62SAnS6yQ8VIQuShxdwkhCawlz6gnN4sOqy4ApRgWJ5GcV1SkRkEEkh6LxspSqZw/3c3KB0yEmT/3S6rbE7Xyv5KIiW150fvkxdVKfOc+dIBMtQpzs4+AP5H4ZGjvAJkduBb+Vh5SkUxzEZLAG5YhDRr+YJ1Xdh/QmjsCdG/e4r0Tsst/PpODvzrYJXdlUof64fUhcNl2ZiOC77hVhpVoFV5kS/KJOsZQqZ7cu6UhmKKEdveuJ31pInY7/2twQUkwFDEgBvl2elYd52a6pwAkPE5kD+cefQxTpQlgmHZ8odxddQbpHd4KuPLaTiETfIZkdRVNJ2E5VelmeeU1G9jbbp57bjpmLA7uGTjHjDDkBue4y1Wu0tD0jm27guHwIbAmqahpm6P3RRoQPA7i30z0LNhQ0n050Zg1Nw7J26AxLQ0ufM7raBKeyruymeI t7LJUwfX n0Ylw/9AzrCOf1X7RpGtME6js3AbijsL8e5k3Fd5h43jDimKqC54f3hBP83jt31p0V8Y3filVepuXIgyLKm+gJzYrwvvRulHbK3dZOEPxrNX1ODQ70PeeO4QErlwU/aWT/Wu/72gltLeHJAu1AhuL30r/kSC5ocD+1driu16DcuYqmQgmORWuZEt69nFzVNtFSzoZRxVWic1hCm98LYjcJDq7oHFI5mH8I3ZkdvFj4ztJvFyASbvzyQrxhmOneHWr8d1r7+kw5FfCAc5KElRnoSEenK5L/olLsMElrH9OSvXDwLC54mMcWcIYMg62ajzxu9j+BkWvIuSUBhrfY2wrFwkptZ1MaYF8BXsdDnVigswcEKDYBzTDgP9/nvHntvRND3ZRJMMPsVlukaRe9PBJCs6X/fQEGYl3FysqmiBD5hzf27aJPwOjbovt7J1gRGlTKGAg5dQO2/jSNzIUEqmqsBQbEs/KXWPzkQRjzXAlztsYsHYidQho1Yo78dCHB1I9w0d4AkRblXlMS7qecosOFEUkF7bnmDSrIeogz9XANWUs7+FR2fx6u8MK3w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.008691, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Dec 11, 2024 at 04:32:49AM +0000, Matthew Wilcox (Oracle) wrote: > If the caller of vmap() specifies VM_MAP_PUT_PAGES (currently only the > i915 driver), we will decrement nr_vmalloc_pages in vfree() without ever > incrementing it. Check the flag before decrementing the counter. > > Fixes: b944afc9d64d (mm: add a VM_MAP_PUT_PAGES flag for vmap) > Cc: stable@vger.kernel.org > Signed-off-by: Matthew Wilcox (Oracle) Acked-by: Johannes Weiner