From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12F71E7717F for ; Tue, 10 Dec 2024 16:54:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 844996B026B; Tue, 10 Dec 2024 11:54:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7CD266B026C; Tue, 10 Dec 2024 11:54:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 647CC6B026D; Tue, 10 Dec 2024 11:54:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 457626B026B for ; Tue, 10 Dec 2024 11:54:16 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id F156D1607BE for ; Tue, 10 Dec 2024 16:54:15 +0000 (UTC) X-FDA: 82879646262.08.7FBC9E7 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf22.hostedemail.com (Postfix) with ESMTP id 91809C0015 for ; Tue, 10 Dec 2024 16:53:50 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=f3hvz97N; spf=pass (imf22.hostedemail.com: domain of oleg@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=oleg@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733849630; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=uYgy4fScGjSMekKKz7zapMxNc5WYY7jYizVCi92CPVg=; b=a+DBOH9Xbm8dO+SYVOi0qRV6HVFU9KivjV8w45GUIgVT5dooxjszV+HSVnfKkng17ZbZ8v /SRmKnws4HbMBlxnIpZVW42HFlplsx7ogQNwKg4wvR1UWzxZvrKX0LB5CqbtDcsiwcp9gE ukn3uZzj2zCcnw5EuMtCKdlGeLXCldo= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=f3hvz97N; spf=pass (imf22.hostedemail.com: domain of oleg@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=oleg@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733849630; a=rsa-sha256; cv=none; b=zNoO+odyimpo/7VmOWTGjbOCNys41PIDLw1jL+raxFMU8detJ8sXj5kpRRWB6wvPsing5b AXoDBjyGWY18BvJJoN+8D8+EkOU4vN5dzoLmQuZyiQiiqVwGFYWu/s0ubcSfcNVPiVo8r3 bgV0qlFlvxaXu8A3LTxtYKgElQS5eqo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1733849653; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=uYgy4fScGjSMekKKz7zapMxNc5WYY7jYizVCi92CPVg=; b=f3hvz97NNfVZeyVWUc8nLiXOctQqW4DpM6D+AWQ116r6Hz8gxUfqu0yKKZDOqUTUDCH/VR tskjsdhY0+gI00KVVeq1iocZK9sNvpwpAUL3gDLmSZeYeLXMznEV0EVdTJsit2PfpWz8Le pWlxqGIYj35TIuomFYf5g+u57t5nCSk= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-5-Pcjwg3CCMr-5zOAySgSt3g-1; Tue, 10 Dec 2024 11:54:10 -0500 X-MC-Unique: Pcjwg3CCMr-5zOAySgSt3g-1 X-Mimecast-MFC-AGG-ID: Pcjwg3CCMr-5zOAySgSt3g Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id A3AE11955BF9; Tue, 10 Dec 2024 16:54:06 +0000 (UTC) Received: from dhcp-27-174.brq.redhat.com (unknown [10.45.226.4]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with SMTP id F15341956089; Tue, 10 Dec 2024 16:53:58 +0000 (UTC) Received: by dhcp-27-174.brq.redhat.com (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Tue, 10 Dec 2024 17:53:43 +0100 (CET) Date: Tue, 10 Dec 2024 17:53:34 +0100 From: Oleg Nesterov To: Lorenzo Stoakes Cc: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Kan Liang , Masami Hiramatsu , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, Andrew Morton , "Liam R . Howlett" , Vlastimil Babka , Jann Horn , linux-mm@kvack.org, Peng Zhang Subject: Re: [PATCH] fork: avoid inappropriate uprobe access to invalid mm Message-ID: <20241210165334.GB31266@redhat.com> References: <20241210163104.55181-1-lorenzo.stoakes@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241210163104.55181-1-lorenzo.stoakes@oracle.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 91809C0015 X-Rspam-User: X-Stat-Signature: js1mmuztrxt6hqnx6chkmfm3wtjszcdr X-HE-Tag: 1733849630-322435 X-HE-Meta: U2FsdGVkX1/Nf4DofLFF8Ql1DrHZQZ+WKWsy937EVGQitIIamAe9t8/mXLC4yJLNiU/JXH+lqgf7g00nhlzxxMmN2S5lsEyqfQMzbgKAm/bW/92uNCnHQfKOPXHzSsY1Sr1NGdcuNyTode9J0MBPf5iy63gjhTgdIcu849Ncbv69t/z4WcyaoT/wqnECMyQQvVvg6Y63gry0BvdnetKTgVrnyfVyFXhal6EZBrrny/ixsTBwW559QZZUyhDBGsiRHsY+FA4dmEBCB1NacNrhLur2cS+AKLylSyHFVQ/+PfjTJJPv6mzOXLIoXQcHhBoeUCG26TNNjgarVk5u8zCkQCuT1MT1N7GCUoVJg9Z+0i5MIRI7bBciTar5OHsJiTY/qiVVhtfKmqwMHhD/k3gL5mOYvcDPmFQACELLJOUOrJ2OWXwXYpsRJWS+7tG06RB12JKC4Z9NV4Olyh/8/Zt6Be4tEnE2Q5MSmtcYIaieTPI/6IprIdWyGgvA/pQ3WWINo+a/oeeGvvZPTFl7rV9lZRK+p6Nee4aeniQITzmnTZt/w9Z5OXA0tB9DicfUWPg/mFEhP2TYNz/cNO1S155eamNZ6HGEdPwxLR5njeyHVcLXZDU7qI8nYbiEuopDyej9HfShfohtN+jWIhxmMVZ0Oot2kc/mgncI8b1rI77Y/SoBlzqig6cPy+brgbFB0rYt1kFfm/Z4GvMgscdZyyo/5s2Q3AcOa0WU9HI9uh1DN1bYb0O6sB9KggNnuMVg1WCvVE8/wa6jYTInpfQC6h6kUu4al19X/6bXG79iq4GKLiph1IDSGRq1ewTzOUzIGYK6q44ww9HY3PPYIRD3khenmGQEV12dZ0/xDMgYuzeh2K7oWToXFCE3NckC7cmiihuOoerBXGnL0FoRabosHTAthD49A7oiigcai/n7AwjXh0OxYRHXT/PfLMxUGSiOiMJGs7oYfbMUm8Mko1rbHn0 8x2g6062 lscQOzkaPYK03TfTicCPC1yl+28usZPNLyuM25mHkWguxnv2GyCQSnXOl06qClShCKDYTg2mEDuALqHQ5kpQvIjgryQNpMnje9DotWDKhrG8Ha4TbgugQXcdVQzu6a7fAd7/b2s/mD1JlK8kjAjzh2xueNrOWZvUuhYIg/BjZI4WVAWnngulG6eXCuncgNz18WK+xvViJ18oBUEyp3UUZpnSITVtXq0aqFMfmGIWYGXuCUjBLcpb+7br3LZRXMsb4UIBU4Fl36Ne6esVbN7sllc9XI6Lfxw2Cdg8GXOgkBL814mdJsgxPvh4xmQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.006370, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: I must have missed something, but... On 12/10, Lorenzo Stoakes wrote: > > @@ -1746,9 +1741,11 @@ static struct mm_struct *dup_mm(struct task_struct *tsk, > if (!mm_init(mm, tsk, mm->user_ns)) > goto fail_nomem; > > + uprobe_start_dup_mmap(); > err = dup_mmap(mm, oldmm); > if (err) > - goto free_pt; > + goto free_pt_end_uprobe; > + uprobe_end_dup_mmap(); > > mm->hiwater_rss = get_mm_rss(mm); > mm->hiwater_vm = mm->total_vm; > @@ -1758,6 +1755,8 @@ static struct mm_struct *dup_mm(struct task_struct *tsk, > > return mm; > > +free_pt_end_uprobe: > + uprobe_end_dup_mmap(); if dup_mmap() fails and "mm" is incomplete, then with this version dup_mmap_sem is dropped before __mmput/exit_mmap/etc. How can this help? Oleg.