From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41EFFE7717D for ; Mon, 9 Dec 2024 17:36:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CB68C8D0092; Mon, 9 Dec 2024 12:36:24 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C66D88D0058; Mon, 9 Dec 2024 12:36:24 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B07398D0092; Mon, 9 Dec 2024 12:36:24 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 834358D0058 for ; Mon, 9 Dec 2024 12:36:24 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 399A5A056A for ; Mon, 9 Dec 2024 17:36:24 +0000 (UTC) X-FDA: 82876124016.23.8DBCC8B Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf15.hostedemail.com (Postfix) with ESMTP id A5C6AA0004 for ; Mon, 9 Dec 2024 17:36:00 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=GTU+clBP; spf=pass (imf15.hostedemail.com: domain of imbrenda@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=imbrenda@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733765762; a=rsa-sha256; cv=none; b=p2Fz+9wGleyuzjr/9WE8mKxHefc3RhEYhK/g7YwmHTXlCNorlzSA+GJm005op8XFD9r0Vj +sJLyIo4AynQw/w5+5ptQ6XHVTzwzdMZocOmwnlXQwpBcubRMf/S2QeJig8PgFzQutbNMs 5TFTXXx8r7Cw4X2IaXWbiK2Ic4EVV10= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=GTU+clBP; spf=pass (imf15.hostedemail.com: domain of imbrenda@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=imbrenda@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733765762; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TvXjD5sYjVjwVQKUFAm5ajrLGlsD4EPwD6ySYHNV9y0=; b=VpRtqz3/d4VGpkjoHIig60bQhxghj+MLhXtoPvWdmKdR5QnVdcPXcFAIxy5T0DoX3NWyjg ru4Z20/cusxL71UWg3t043yNjmhAPJC+xMkzbf8zQj+PQyelLbYOUz1xJkT8qlwPoNismG 0IB3NezZXEdCrZDI1JoNbpbfIEuQCqI= Received: from pps.filterd (m0353725.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4B9CNZvm030669; Mon, 9 Dec 2024 17:36:16 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=TvXjD5 sYjVjwVQKUFAm5ajrLGlsD4EPwD6ySYHNV9y0=; b=GTU+clBPgWoKiThNubTyx9 6OsyBvbc0LvJtUJ94ybICM8GbhTAvKJlsAS6ST91rcozg9O+PAsHndvx10R5cH97 gD9HfBItn/hIsCOpKq7Nqt0mGP4JJb6gNMV2O8ygJwXWvmcBCWSMXT3tB1LksUNd 2FzVWgD0Ls0ByT5Ig5Kj526FYsBOIVqt6ZTvcFwhzt13IxoHh/O3PuoTQj3rMnHx bbLFClMX5wVnh5ZpnnVOp1PBvzHPAVEpzfAEv0o2v8yB4Tyxi5U3EfBYnoa1g9hD k5+DwbdsVdKMS8dyL4bj2ESP6GKyr0pBA7in4bHt3l8Tb9v/UvPvnljcIPL0oMMw == Received: from ppma13.dal12v.mail.ibm.com (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 43ccsj9w16-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 09 Dec 2024 17:36:15 +0000 (GMT) Received: from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1]) by ppma13.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 4B9FbdWI023018; Mon, 9 Dec 2024 17:36:15 GMT Received: from smtprelay06.fra02v.mail.ibm.com ([9.218.2.230]) by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 43d2wjqdrb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 09 Dec 2024 17:36:14 +0000 Received: from smtpav05.fra02v.mail.ibm.com (smtpav05.fra02v.mail.ibm.com [10.20.54.104]) by smtprelay06.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 4B9HaDfg22872490 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 9 Dec 2024 17:36:13 GMT Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 58F6D20043; Mon, 9 Dec 2024 17:36:13 +0000 (GMT) Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 1E31620040; Mon, 9 Dec 2024 17:36:13 +0000 (GMT) Received: from p-imbrenda (unknown [9.152.224.66]) by smtpav05.fra02v.mail.ibm.com (Postfix) with ESMTP; Mon, 9 Dec 2024 17:36:13 +0000 (GMT) Date: Mon, 9 Dec 2024 18:36:11 +0100 From: Claudio Imbrenda To: David Hildenbrand Cc: Matthew Wilcox , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-s390@vger.kernel.org Subject: Re: Removing page->index Message-ID: <20241209183611.1f15595f@p-imbrenda> In-Reply-To: References: Organization: IBM X-Mailer: Claws Mail 4.3.0 (GTK 3.24.43; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: HBnYQoZuWsDnCU7JE8hIozGZoBz_2fKN X-Proofpoint-ORIG-GUID: HBnYQoZuWsDnCU7JE8hIozGZoBz_2fKN X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1051,Hydra:6.0.680,FMLib:17.12.62.30 definitions=2024-10-15_01,2024-10-11_01,2024-09-30_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1011 adultscore=0 impostorscore=0 spamscore=0 lowpriorityscore=0 bulkscore=0 mlxlogscore=890 mlxscore=0 priorityscore=1501 suspectscore=0 malwarescore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2412090136 X-Rspamd-Queue-Id: A5C6AA0004 X-Stat-Signature: etymt7s8yuaf3qdh5hdgnknjy35fhykm X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1733765760-741976 X-HE-Meta: U2FsdGVkX193I5Bc+tAwmHAOatCSDLtIuWbYkrn96Mx2AoLzNIldPNFqFJCLOzSRKp/PEZddSc/mjUPoFtCBiHTAMCWDgBfngoUrlSzLIlf/xF5Zlp49EYhlFamfBrBivShcouyyi6A+RtqksQQY11GoXvGq+6S86PRA8bfFha+rdHWV2bP1h5p7AyRZ+yasnomaU/eoc9a1QPMYs9qQfgclATkLovrU73IrEBmOFfUOjEetLPTs5CoUdFbsMeVlZj9ZqOTbyH+qbkXTnGDa2WT2jTLiRr2sGpTH76kfTS7xRIuNiszMCDTkEJZAXfyeLvJFWkb/JXWnwebRpG8CS5YeocgsA3pau6yR4tnLAO39iw1kgrS8Cn0BXe/zAgAE+sufl489UICRtQoiKq3i1RtzVoK38GEmFakk2qXmOj1DmRLH22uLOySKfKFzPAbjpxxpvHR2Fa0jPp9U87p2gXej9MGvvSKqe7OQTAVzAqPNy0cwEQvu/IBCU0mK8NRdJ2T8n3tALLdDG9mbjLJE4KbEBWLJHI0WIPx0axCjEiFQviSgJbskUwUuiIzDYA3SPLzIm1IRC1Z8MvlgGYykDDx31auLp6geTZze4c8bSbYNPY3QKaN7pdrvmtLWk6zXUhwhxtcGxK1qnlYQA7ik1Keia9+JChipyHrsvfOvhM9RW4CNtdR2O9nvQ3DOUwBDpAQpuLXPD1Ggrt+Rqwm7MEHVEp3phscuTEu/ftcPl/vCFB3dzALlz8kDftwqBC5NbYcetdUFbBayLXGdaEMNbftJGCtrJgvzBibfl/1IAHP1cNHUT5mKlmTeo3sidAvSyH7BxWcvgTTTyHb02f0feeN+OCFOeJS455cLBbSw4BWHVspyQ+zfwxq1K6G01HhQdDuVO4YjRzc7wvmgd3vDVHzKsg2baUsdgTLSEejgxger1mEh6g724sInjgxyWCPZcohHYaLZwPtyNJjDROn QgegsFZ7 gS01hVoqrXUKaP2c4dzHTEoqRses6rMs7Hj6gM98PEIsakJBOEV15+Wd66Z6X+Xzzbj1Kh7VunVbZskepRJmtykeESiaOkQt6J0xiw4OWviGLGT7EIK6wut+cqDAV+6uBQibEXYqFlEms/klZLTkMv2oW+Vs++VhDgRPQSCHufzkmOE2TuZvu39gbUaRJYzrGhH75O08hFZYmEAwF8PgebVodnqevNfHXBk2LCn6Eor/w9osujfvUzl3AtDqa+aOLsD0vRnowkbOWCeITVNG/Y2QZvZvkds/34ebtlz5OUgE066/mSeNwcPipxRmHgs6kHof929jkJHItAtsYVIXREJQkEJbn7orVUfcpe//4ARF7VJGyYdPBAxpc5EP2n3sG8vGWCiGdIfWZEsA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 4 Dec 2024 16:58:52 +0100 David Hildenbrand wrote: > On 03.12.24 20:51, Matthew Wilcox wrote: > > I've pushed out a new tree to > > git://git.infradead.org/users/willy/pagecache.git shrunk-page > > aka > > http://git.infradead.org/?p=users/willy/pagecache.git;a=shortlog;h=refs/heads/shrunk-page > > > > The observant will notice that it doesn't actually shrink struct page > > yet. However, we're getting close. What it does do is rename > > page->index to page->__folio_index to prevent new users of page->index > > from showing up. > > BTW, I was wondering how often we convert a page to a folio to then > access folio->index / folio->mapping and not actually having a folio (in > the future). > > I suspect this will need quite some changes to get it right, and I would > count that as "less obvious". > > Calling PageAnon() on anything mapped into user space page tables might > be one such case, for example. > > > > > There are (I believe) three build failures in that tree: > > > > - fb_defio > > - fbtft > > - s390's gmap (and vsie? is that the same thing?) > > Not completely (vsie (nested VMs) uses shadow gmap, ordinary VMs use > ordinary gmap) , but they are very related (-> KVM implementation on s390x). > > I know that Claudio is working on some changes, but not sure how that > would affect gmap's usage of page->index. After I'm done, we won't use page->index anymore. The changes I'm working on are massive, it's very impractical to push everything at once, so I'm refactoring and splitting smaller and more manageable (and reviewable) series. This means that it will take some time before I'm done (I'm *hoping* to be done for 6.15) > > s390x gmap is 64bit only, so we have to store stuff in 8byte. gmap page > tables are > > Maybew e could simply switch from page->index to page->private? But I > lost track if that will also be gone in the near future :) > > > > > Other than that, allmodconfig builds on x86 and I'm convinced the build > > bots will tell me about anything else I missed. > > > > Lorenzo is working on fb_defio and fbtft will come along for the ride > > (it's a debug printk, so could just be deleted). > > > > s390 is complicated. I'd really appreciate some help. > > > > The next step is to feed most of the patches through the appropriate > > subsystems. Some have already gone into various maintainer trees > > (thanks!) > > > > > > There are still many more steps to go after this; eliminating memcg_data > > is closest to complete, and after that will come (in some order) > > eliminating ->lru, ->mapping, ->refcount and ->mapcount. > > Will continue working on the latter ;) >