From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11B8EE7717D for ; Mon, 9 Dec 2024 14:16:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9859F8D0068; Mon, 9 Dec 2024 09:16:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 933D08D0058; Mon, 9 Dec 2024 09:16:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7D48D8D0068; Mon, 9 Dec 2024 09:16:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 5D0C98D0058 for ; Mon, 9 Dec 2024 09:16:38 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 49C368060C for ; Mon, 9 Dec 2024 14:16:17 +0000 (UTC) X-FDA: 82875619470.01.2FF4716 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf23.hostedemail.com (Postfix) with ESMTP id 0A737140021 for ; Mon, 9 Dec 2024 14:16:00 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=dr0GGrD4; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="02tE/xNQ"; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=dr0GGrD4; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="02tE/xNQ"; spf=pass (imf23.hostedemail.com: domain of jack@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733753761; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=X21WmVeRotOreOUDuaW7CWWm46V9QKf04q+yG+mPlF4=; b=LbDni6VLdSyEYd0bfaFPZJlCY45vLbYBcBCPixPy0xOoyjPbw6731d667+qr7HPJqA24c3 koe7MOd4I1DJQniZwUc5vHQ4OXaueUFlpSygiUfZSnqOB8R7fiVsefn9UEXj+E3PcHD+S8 MPLeuaaHiR/aFzheXQ8T3YHXf7YYEBg= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=dr0GGrD4; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="02tE/xNQ"; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=dr0GGrD4; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="02tE/xNQ"; spf=pass (imf23.hostedemail.com: domain of jack@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733753761; a=rsa-sha256; cv=none; b=tEDnFrS2CS523HS+P3Ul2h069b6PzLA4GY5wBxCCyeWYRwgxKuubWmLAJAPiTb6d9uwf3O 2qiUiF++J2Ddu2+AFMvAOSGeJKHmLsQ1mNEAtydNfLVd+FgrCGXJibmXyu4KvH0UMC/h8a Na/eCJoLC21i6ZeCxsNm1166Q9My+Lw= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id BFD7C211D3; Mon, 9 Dec 2024 14:16:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1733753772; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=X21WmVeRotOreOUDuaW7CWWm46V9QKf04q+yG+mPlF4=; b=dr0GGrD45D25MNefPhUdHe7n8ICbL0JpYJqkYMSJeR3PC0XDVb2hdy9QJxkRUj2wNh9XIm dBWmce7tOw4u+uMeOTNQylOZWmlVWYqoZqc6LSUUiXiEGwVNFSc35hxC0CbyXo3qrcpcIN cBuy7YHWyuELtl1yBOfCo4Jurgbr96k= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1733753772; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=X21WmVeRotOreOUDuaW7CWWm46V9QKf04q+yG+mPlF4=; b=02tE/xNQzzKHBSiwiNBefAPFE05K38AoRmMzMOuz1tPcD1kuWTlHHx4KGZgdqLGDhwuUwB A9Rb3MWeiH5o7GBQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1733753772; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=X21WmVeRotOreOUDuaW7CWWm46V9QKf04q+yG+mPlF4=; b=dr0GGrD45D25MNefPhUdHe7n8ICbL0JpYJqkYMSJeR3PC0XDVb2hdy9QJxkRUj2wNh9XIm dBWmce7tOw4u+uMeOTNQylOZWmlVWYqoZqc6LSUUiXiEGwVNFSc35hxC0CbyXo3qrcpcIN cBuy7YHWyuELtl1yBOfCo4Jurgbr96k= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1733753772; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=X21WmVeRotOreOUDuaW7CWWm46V9QKf04q+yG+mPlF4=; b=02tE/xNQzzKHBSiwiNBefAPFE05K38AoRmMzMOuz1tPcD1kuWTlHHx4KGZgdqLGDhwuUwB A9Rb3MWeiH5o7GBQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id AEB6F13A41; Mon, 9 Dec 2024 14:16:12 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id oj+QKqz7VmfzegAAD6G6ig (envelope-from ); Mon, 09 Dec 2024 14:16:12 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id 63CDFA0B0C; Mon, 9 Dec 2024 15:16:12 +0100 (CET) Date: Mon, 9 Dec 2024 15:16:12 +0100 From: Jan Kara To: Klara Modin Cc: Jan Kara , Josef Bacik , kernel-team@fb.com, linux-fsdevel@vger.kernel.org, amir73il@gmail.com, brauner@kernel.org, torvalds@linux-foundation.org, viro@zeniv.linux.org.uk, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-mm@kvack.org, linux-ext4@vger.kernel.org, sraithal@amd.com Subject: Re: [PATCH v8 16/19] fsnotify: generate pre-content permission event on page fault Message-ID: <20241209141612.wtst3obur3xxbtiq@quack3> References: <5d0cd660-251c-423a-8828-5b836a5130f9@gmail.com> <20241209123137.o6bzwr35kumi2ksv@quack3> <604c3501-f134-4a6e-ad41-ace84c2fd902@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <604c3501-f134-4a6e-ad41-ace84c2fd902@gmail.com> X-Rspamd-Server: rspam05 X-Stat-Signature: 3eajydqff3m3m5h1ann8pxicnfafw8pg X-Rspamd-Queue-Id: 0A737140021 X-Rspam-User: X-HE-Tag: 1733753760-958352 X-HE-Meta: U2FsdGVkX1/B6DHeTOQXYJyqzg2zgaI8WbDBwJB/kmIEV2GHiy34IKWAeK41POp55zr6DqfyDxgpV4ECRM0/OrJHnesG0tN0pKr+F8EilRj0kzF3dGeoBxf10b0/dadpzHZ2ZGJcsVA4lp2r3Vj8kBpoifwz97I+5RCXZ/dfkKG3pPSLxb1rP4BnX1qj3KaQSo3Mqx4IJPbSFK+UaAHX/H/0Ju9LBBDIhETe3HElhOlLcpoxsbVa5/APtVj8LjyUXJoduASMjGyR5ghc50dAle6wBezR1sS68fhm98z2KMcpIsciisrO8+XBfrrfDMPTAwrWuhWDvuDzyNbNvNkt7Tzo0JCh+dga0MHEDqgiRkUTiTWiBW0AzPWcZXYwh7JJuicwUWGZh2fP+1QuimUhSzusRCpJZzvRw7+9B7D09CDU0+JVvZE+qX8cIQuefJmtONoR1SNDrxYMUM91m8eUErAthBkF6MGntUf5ftKgbDwxXSWnXm7YeUVlpazv82834pamWgi1H0eEtXsOII4iI5k//fEJCTh285SYFFsoAK+6M3+4hemyhSTzH480wmaJA4A8K8wwM69pddp7Z52yPrvBnPNkblUdUxvLyu9cdiOBiezZ+3En9Mgc5XVBg+OYbWHlzgozJjqbmNA9VKFPruk6W2lce2ktxi/QeeN7Y04gOzNDZAduJuxTSfdM19MmNwNlbpIpbTb2p1Ev4oMema5m5BUdqOH6rajdjOhcPc5yBn/T55nzR/WzPiaaZOmq2njaA1rrxxIFXvsZ/yeV+FY69Ot3tlV6X8IA9b7GRWcBh3F3gQ8QJOZV0q0kwHlLR2GFcAQJThwujz0niosG4SJa3vFOqcMkGhnrdvrXw4PZSc40VzkN6C2GK5tFpsi7A/ppg5Wo5bwQgBdjNVTtuxPK8PFjRR5uHzTtjloDDq0cxUWiFz9x2ekhCli7V4a6yAQoF1S+GjXITEHM8T/ SoSiJ0Tk e4Hj6Zl4ZhXzJT1xhjhQFbfP56ME7rsXG3ZWmzk56lTDdnThOw7Z/SKsA8y+12DsvCJzpiB1aKrKKPB0t8QTOqLXoLMrTfV06f36mB8ASr8YnHHiESN7WEO/SBlirvGzoybEo3xN7LfNHTHZvMFv6V5ApZMoM5loPt1vvfxQHBC2qh01z5qUWpJbjH1qY4DecvT+cjPk2seOPl6wtDVCClXlP0/e2TEopKkqMVpEn1DmSB4d9THKF4F2Vm+CmKVvQTM/3u6dOK05gEWFWWYoaiG63ZSyI+Umwn1WdLaIvbrht6RZHhejE7UBzTOEy/V8keNTd6btLl6aiHyaT8dq8KS2yJQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon 09-12-24 13:56:47, Klara Modin wrote: > Hi, > > On 2024-12-09 13:31, Jan Kara wrote: > > Hello! > > > > On Sun 08-12-24 17:58:42, Klara Modin wrote: > > > On 2024-11-15 16:30, Josef Bacik wrote: > > > > FS_PRE_ACCESS or FS_PRE_MODIFY will be generated on page fault depending > > > > on the faulting method. > > > > > > > > This pre-content event is meant to be used by hierarchical storage > > > > managers that want to fill in the file content on first read access. > > > > > > > > Export a simple helper that file systems that have their own ->fault() > > > > will use, and have a more complicated helper to be do fancy things with > > > > in filemap_fault. > > > > > > > > > > This patch (0790303ec869d0fd658a548551972b51ced7390c in next-20241206) > > > interacts poorly with some programs which hang and are stuck at 100 % sys > > > cpu usage (examples of programs are logrotate and atop with root > > > privileges). > > > > > > I also retested the new version on Jan Kara's for_next branch and it behaves > > > the same way. > > > > Thanks for report! What is your kernel config please? I've just fixed a > > bug reported by [1] which manifested in the same way with > > CONFIG_FANOTIFY_ACCESS_PERMISSIONS=n. > > > > Can you perhaps test with my for_next branch I've just pushed out? Thanks! > > > > Honza > > My config was attached, but yes, I have Ah, sorry, somehow I've missed that. > CONFIG_FANOTIFY_ACCESS_PERMISSIONS=n. I tried the tip by Srikanth Aithal to > enable it and that resolved the issue. > > Your new for_next branch resolved the CONFIG_FANOTIFY_ACCESS_PERMISSIONS=n > case for me. Thanks for testing! Glad to hear the problem is solved. Honza -- Jan Kara SUSE Labs, CR