From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A681E7717D for ; Mon, 9 Dec 2024 12:31:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E943D6B042B; Mon, 9 Dec 2024 07:31:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E44FE6B042C; Mon, 9 Dec 2024 07:31:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CE5A56B042D; Mon, 9 Dec 2024 07:31:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id B0F6F6B042B for ; Mon, 9 Dec 2024 07:31:43 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 4CE0314036F for ; Mon, 9 Dec 2024 12:31:43 +0000 (UTC) X-FDA: 82875356676.29.13BF8C4 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf02.hostedemail.com (Postfix) with ESMTP id BAF3E80018 for ; Mon, 9 Dec 2024 12:31:01 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=a8alBplm; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=aVkAywdg; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=s7b6X5lY; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="NZm6wN/j"; spf=pass (imf02.hostedemail.com: domain of jack@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733747487; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eWEHuKiBS+G2Q7jP9q4X0yWXbPoQTpw0Vark8slFW3s=; b=gNhpo8ISA52CuMNsLImikY9RCdzyvHuiyrvxcxN4bBX8AGA/t5s4SrZGovxzXgnXPuDKif LH0rAEdMpdHKAAACTiRph+0qf9omLyKkIpgwDo3C9AZGrJGEkNl0b86Zlp2HevYSoYJch0 5YN3W2P/TEATz9SfJw5IDBonTA19wt4= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=a8alBplm; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=aVkAywdg; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=s7b6X5lY; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="NZm6wN/j"; spf=pass (imf02.hostedemail.com: domain of jack@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733747487; a=rsa-sha256; cv=none; b=IwW3ozrTczBsAPkNhhpEvr3yNX9FdJ5b/3vjPeizSNHfVh/tLGlM51Yq1lm1Ciz1kzMcb9 rEjPH3Pogw+Hv1y0jPnGeHG4fWbQf04+PmKT1hnN7cFR43H/xw7ZTcqsPCc//zdz24y84e 8R2srWpsgdTAic4eUM/8nCkMtXT9Has= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 74C9721187; Mon, 9 Dec 2024 12:31:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1733747499; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=eWEHuKiBS+G2Q7jP9q4X0yWXbPoQTpw0Vark8slFW3s=; b=a8alBplmbSs3zbTzX8eZZNimO8rdDKocg8U/ZftHrhulaQJVyGokgXqScAOUXO+cMtMRgQ 055DhSkux+RfeDOtF5KSHlzfwln95/DTLuR0z0pgTUcSJNsH5/MdvTZoNdbs2pvjCWTsZC H5C/EytcKhuG3BxN+2uN1VbFa05nIHs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1733747499; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=eWEHuKiBS+G2Q7jP9q4X0yWXbPoQTpw0Vark8slFW3s=; b=aVkAywdgczZXpN8VrWfC5Y068pRahTvITxTFm+mdW0pIv4jsu1vMmgxzPQ9dFVcBo8X1oE E7Afeeb8vTzWfGCw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1733747498; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=eWEHuKiBS+G2Q7jP9q4X0yWXbPoQTpw0Vark8slFW3s=; b=s7b6X5lYdWJBir4zFbcEFhbjweSj8Hii8ii09WJ+iDy4oOq6Zda1PtqtWWVyylnLsSynC5 fO/KFZVitPaIW1J30cNch96iySR8wmJw5mv8ZlUBf+HK8lRjq/Q0+r8h4+uZdRqE+QrtF8 tvaxW2OcvVij8pUF6SXzvjp3wC1+eVs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1733747498; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=eWEHuKiBS+G2Q7jP9q4X0yWXbPoQTpw0Vark8slFW3s=; b=NZm6wN/j7V9DiBem0D+yRqMnHKdoei5QTRGKQmokOFa/RPCjRqpWlHzEQv/oBUc7gpte44 tLoNk8XF0tKvqfCQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 5F66E138D2; Mon, 9 Dec 2024 12:31:38 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 9TVCFyrjVmcoWgAAD6G6ig (envelope-from ); Mon, 09 Dec 2024 12:31:38 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id 0597DA0B0C; Mon, 9 Dec 2024 13:31:38 +0100 (CET) Date: Mon, 9 Dec 2024 13:31:37 +0100 From: Jan Kara To: Klara Modin Cc: Josef Bacik , kernel-team@fb.com, linux-fsdevel@vger.kernel.org, jack@suse.cz, amir73il@gmail.com, brauner@kernel.org, torvalds@linux-foundation.org, viro@zeniv.linux.org.uk, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-mm@kvack.org, linux-ext4@vger.kernel.org Subject: Re: [PATCH v8 16/19] fsnotify: generate pre-content permission event on page fault Message-ID: <20241209123137.o6bzwr35kumi2ksv@quack3> References: <5d0cd660-251c-423a-8828-5b836a5130f9@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5d0cd660-251c-423a-8828-5b836a5130f9@gmail.com> X-Rspamd-Server: rspam05 X-Stat-Signature: hrazygf66xh5eh65bi6dukhhjxejqh9q X-Rspamd-Queue-Id: BAF3E80018 X-Rspam-User: X-HE-Tag: 1733747461-532131 X-HE-Meta: U2FsdGVkX1/dW9u7WW5VPZlAp5Mt3KF/xCatNA9KMlL1dxoAzSihX/2HTiZTMDUo9MhJBUAy60jsCZnWhUCrbJXvScZ27lcxfqTEVERxpC8XPGTbev1rnmpbfoz5aF3wO3SqhfhdeGhW8iHa6grw5Pk8ctd05PnS5OGYdJ+PIVNS1YPlwIBmMVxFuqh5ROHDtYSsWJ4MwCw3kV9Dgy9e2ahL8gXmnHx4bDgbAhF/mNcHbJcBz0gQzIVvtjKJvU8Y1BHs3EIwoz/U+I9wJS+tNxaUrKeTXf3CXcnMu9z76rlgdRLitVQ+wSGk4rq7iB7Jwzfwamy9WD5i3WkQ28eEIQ8CG39xFY0qxIGL6ZIhy1TBs7LCSXDRyM6DbHwEd2DaSeRm9Xyvo1wEQbbRebsBDQQvXjfk1v9zBx+R5FyDuFbLbY5nJnDKguRK9frmf3OLPZShU6hQhiEsyQXp1N8zVdc1RNV6h3Whkr9KbICAWyiKGwzh+A2ZdvY7wjGZxa8JgVtq7t6qkCafQlRBWVrABA1RZVbWbXW3GO/TKhd2Dkl+oljmVMvN7LMQJ6eW2nMTMyStKTX/+0zCm1XPMuwXh/YAI2wQxCUfOFHlX5NCKnUrTVA1ePOUkqXWWRExo71fPWb0evWXlbExm9IOHEEg1t2bVxlQWxL9bsLScuzsGMF9ElJ6DH0MmiBCzVOhttySFS+jVSEl2kNh8IweMrjdugozxB6wg8zxPqkhSCz6rPD39DzwtjaZpfC5dfpLCwYl6IWey/VfwpLMcgW4jKb+LW85Hx0lZOArjX+leOyuhuE9oSiKZ7L2ANywTfhIrcUQFwnAnDxRpOjITwi1+MQvXqMyJMcYGuNtTrgxvVLFqo8hR4GYxrvCS/RbsATldRYxffn8HrKZ0J/TX7B5giGQcpZAO1zxubjI7cvhaH1hA2dOwqWneoLSRdkZMMeu0MPz0A1oLJmvQluwoMa7NBI ia5f4sK+ CSjbWgdiVMS/em85+CpaNdEqM16SjeOYerUFT2u5BJ+DoNjVj0l+dPJfu46/p0ipL+FFxfiQ/J2HmpuDjCHq6KxfOdr5CNuFNQe0Kg7VBFTCZP77zGM+nPzzeN+tFs9OZPN/43rV6oNQYakGCeGwe7BHi03KHYXweW+lPTgJp5jcYX/fOGcmGE1aZEO0gFA0azgc1ZyddQNF/+uR413MvjrE/EDb4HZ8O9AlTrS92aoV1CudUFxY3HZHDIIjo6TvLqV1Levxr0qgBGYSM+iq4TVJsunRSVWmEofPMq9YIX5kBeuYnj7czQ1LWObMUHimVS3XeZuMTUPyZZ/1GZpL1wotIcg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hello! On Sun 08-12-24 17:58:42, Klara Modin wrote: > On 2024-11-15 16:30, Josef Bacik wrote: > > FS_PRE_ACCESS or FS_PRE_MODIFY will be generated on page fault depending > > on the faulting method. > > > > This pre-content event is meant to be used by hierarchical storage > > managers that want to fill in the file content on first read access. > > > > Export a simple helper that file systems that have their own ->fault() > > will use, and have a more complicated helper to be do fancy things with > > in filemap_fault. > > > > This patch (0790303ec869d0fd658a548551972b51ced7390c in next-20241206) > interacts poorly with some programs which hang and are stuck at 100 % sys > cpu usage (examples of programs are logrotate and atop with root > privileges). > > I also retested the new version on Jan Kara's for_next branch and it behaves > the same way. Thanks for report! What is your kernel config please? I've just fixed a bug reported by [1] which manifested in the same way with CONFIG_FANOTIFY_ACCESS_PERMISSIONS=n. Can you perhaps test with my for_next branch I've just pushed out? Thanks! Honza -- Jan Kara SUSE Labs, CR