From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66FD2E7717D for ; Mon, 9 Dec 2024 12:26:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D80458D0052; Mon, 9 Dec 2024 07:26:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D300E8D004C; Mon, 9 Dec 2024 07:26:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BD05A8D0052; Mon, 9 Dec 2024 07:26:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id A055D8D004C for ; Mon, 9 Dec 2024 07:26:57 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 53D72A0512 for ; Mon, 9 Dec 2024 12:26:57 +0000 (UTC) X-FDA: 82875343362.17.3BAD400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf23.hostedemail.com (Postfix) with ESMTP id 54EDE140004 for ; Mon, 9 Dec 2024 12:26:41 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=hDV+qciK; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=DC+e+KmZ; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=hDV+qciK; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=DC+e+KmZ; spf=pass (imf23.hostedemail.com: domain of jack@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733747206; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=39v1UJM0wPzy1yOKPoun+15gHceKb1wHaTEtw27KJCc=; b=5KWoiBIf5DHIRcRfZOkyQ+mGLQ6ptGoSSNAJ0FPmFfff/CxrbnfLuznudCAAIGA5LY1jo3 1Q/Bq8ToUf67vNGCqFfIuTHf4FVcM2kbiazCODO1GEaslW38pVT2febCokGNd8WRxfmukv 0yAsoZr6mm10lF/PdHdZRNV30fP8pF8= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=hDV+qciK; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=DC+e+KmZ; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=hDV+qciK; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=DC+e+KmZ; spf=pass (imf23.hostedemail.com: domain of jack@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733747206; a=rsa-sha256; cv=none; b=zXY6myePeP40BSBhGIBi6b3mQEA9MC5efgp6oUKOXA+GrTLlEJBeQsld49y5R6frz5+hqc 9FgBxjJzcTSD8+PWBYfnmu9ARJ2LqBQ6d4Fapm/GcrsbtZwg/3xxiQA6tg/jqW3mMxTEeH VLBXV8EoaQwWHJ21dMI6PNPoshBtBtM= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 5561821170; Mon, 9 Dec 2024 12:26:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1733747213; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=39v1UJM0wPzy1yOKPoun+15gHceKb1wHaTEtw27KJCc=; b=hDV+qciKDx6oL68xDXqrcCyLSYXGtcrbJz1IvjJt1bTUtS1M9m6tle3UhEWz7CXfNDOfEF jqTyg25TrY0zcuBP68b3+6amX27gggg4Pvub3o65w0d+JflnpGHUTRDNHmBTp5nZ//D/Ae AIJXtnr5nQwq3RcG7FyQ9f5aE9W1mQ4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1733747213; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=39v1UJM0wPzy1yOKPoun+15gHceKb1wHaTEtw27KJCc=; b=DC+e+KmZ/WnfcmV7DU9t2KQKF2XIGc+Y/e98jEpDPB+lg7Vz+gmerLwJqeKP6a9Qi+Jf0Q wOpN7xYQKwnNmIAQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1733747213; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=39v1UJM0wPzy1yOKPoun+15gHceKb1wHaTEtw27KJCc=; b=hDV+qciKDx6oL68xDXqrcCyLSYXGtcrbJz1IvjJt1bTUtS1M9m6tle3UhEWz7CXfNDOfEF jqTyg25TrY0zcuBP68b3+6amX27gggg4Pvub3o65w0d+JflnpGHUTRDNHmBTp5nZ//D/Ae AIJXtnr5nQwq3RcG7FyQ9f5aE9W1mQ4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1733747213; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=39v1UJM0wPzy1yOKPoun+15gHceKb1wHaTEtw27KJCc=; b=DC+e+KmZ/WnfcmV7DU9t2KQKF2XIGc+Y/e98jEpDPB+lg7Vz+gmerLwJqeKP6a9Qi+Jf0Q wOpN7xYQKwnNmIAQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 4466B138D2; Mon, 9 Dec 2024 12:26:53 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id VVxtEA3iVmdxWAAAD6G6ig (envelope-from ); Mon, 09 Dec 2024 12:26:53 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id E84FAA0B0C; Mon, 9 Dec 2024 13:26:48 +0100 (CET) Date: Mon, 9 Dec 2024 13:26:48 +0100 From: Jan Kara To: Bert Karwatzki Cc: Josef Bacik , linux-kernel@vger.kernel.org, Jan Kara , kernel-team@fb.com, linux-fsdevel@vger.kernel.org, amir73il@gmail.com, brauner@kernel.org, torvalds@linux-foundation.org, viro@zeniv.linux.org.uk, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-mm@kvack.org, linux-ext4@vger.kernel.org Subject: Re: commit 0790303ec869 leads to cpu stall without CONFIG_FANOTIFY_ACCESS_PERMISSIONS=y Message-ID: <20241209122648.dpptugrol4p6ikmm@quack3> References: <20241208152520.3559-1-spasswolf@web.de> <20241209121104.j6zttbqod3sh3qhr@quack3> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241209121104.j6zttbqod3sh3qhr@quack3> X-Rspamd-Queue-Id: 54EDE140004 X-Stat-Signature: xprcxw9bhzatn8i7411qmryw1hwd31ir X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1733747201-607971 X-HE-Meta: U2FsdGVkX1/POeLaaWe/yL4L92SHsWq9dhmzqqK07bAFdQOP1TFo+nxr/zBnY4aSDMqwu/tdGU1S21FCb6u34nACG/MgqlvFkw0q1svQZ9SolHTbKPVqXtdCHIDNGldRrnfCakQwNrsQaGiA63T1ZQfxdwQMtSJnZ7uD6SdDyx4Na9KqUa3+fibZyFXW9IHatja4Jhaoh6Kb7r6vvEEp4xiXD+OMCYVal2MR1tsjR4odEKxmxOGIBdPNqa1+Z10dTve/h2hDuGASl4EXbgk+53OZGsgyZzVG6OsGG1ctL5bAKfv6ihi2CCcmtvOOUYzGeA5BUr9bAcWJ7crhuH5XvcGDxfvT4BWnfwpgJRAr5HPyDRmiQ9Mu1DBSmptUXngp055GPdJ46EArdA3ELkM03l31xVgg77EF1rjCMAeiMBHMTHU28JZHQ8i5aGL2Ci1IFSOWMQS9Hwb65mkwV+7hP+0lutx8qz9uIS6XlfYDJxWbJsChOu4KtIsBDwRQGy545GiQpYlzmg6sJCqDgRsmZh/mGPlQ2xUmrmlV0zCEZPWt9MKyn83jRmenKQ+dkeN+QWBeZA3PjbkjFHmOVmNZBoFF9CxKw5c3UMaLUx4cv2gkZx9w+TcKJ2rHqysmTvGMe1in0jePwJzHCL/VP9WUJfjsefC87TR9G/hgrNsTelkCHivlg8H9+foSAFmEv4anHxWvNzV8ZlKLzO17u9D8gqEAvPRTLaJC3TPpA5dpJG2/DeHsCGFihSI0XxSTu470HAQqH8lgfR5moN1ip0YntlTRM+CdRTus+UbtMAYuMANmJdwjTqXk4aDFFELTYGipCQDomAVUdifzJ5H5yqnOtIutNVErJ1vtoXIFoVpy2388uOWuYSVqUvOzuu3LPybXKz/s0dGBLDHMA+HoG8tuZEiOapsb5wuM7q7A1EJA/oXq7+VnmsEUMCAtybYeXbp2m7CoXEquXFoUwjjvf3L 2HfzBp/R rDaCKXlqONk1AvcsmVdam5vUzQWsCDdIpwTa8siKhImCP7Sj5YaK88vjuZY8N200vfO6HxkrC8th0MgwQuNMEeKMWJAZlvHVSqIWgPOGQ/JJrVGRW6C5IGmKHBTmIhll2mO8aQTp1TU+/bDTR7J4b+83uiEwX5fcKlC59hpm2bJU9caD7DD3znQ9SyedMS9oOr/ix2y3YlrbKplucPNmd+ADbrKGZbjdw4SjTQ1DkMAiuPLghQqcaAiNhHGpLuz6EAs/V+kyETEpE2UXIWXqTweC2rvjmBHVlLLq5LIDSGcMxB3+rJ6/7UjzfmP6hibGqv5Bkv0sgUwaOg+1L2NSN3530jM6TDqdT1Y8reC4n7ir0ZmiF7dk3xuMtVSW3X4Q6QZPS/y6ZnTf35G4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.001315, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon 09-12-24 13:11:04, Jan Kara wrote: > > Then I took a closer look at the function called in the problematic code > > and noticed that fsnotify_file_area_perm(), is a NOOP when > > CONFIG_FANOTIFY_ACCESS_PERMISSIONS is not set (which was the case in my > > .config). This also explains why this was not found before, as > > distributional .config file have this option enabled. Setting the option > > to y solves the issue, too > > Well, I agree with you on all the points but the real question is, how come > the test FMODE_FSNOTIFY_HSM(file->f_mode) was true on our kernel when you > clearly don't run HSM software, even more so with > CONFIG_FANOTIFY_ACCESS_PERMISSIONS disabled. That's the real cause of this > problem. Something fishy is going on here... checking... > > Ah, because I've botched out file_set_fsnotify_mode() in case > CONFIG_FANOTIFY_ACCESS_PERMISSIONS is disabled. This should fix the > problem: > > index 1a9ef8f6784d..778a88fcfddc 100644 > --- a/include/linux/fsnotify.h > +++ b/include/linux/fsnotify.h > @@ -215,6 +215,7 @@ static inline int fsnotify_open_perm(struct file *file) > #else > static inline void file_set_fsnotify_mode(struct file *file) > { > + file->f_mode |= FMODE_NONOTIFY_PERM; > } > > I'm going to test this with CONFIG_FANOTIFY_ACCESS_PERMISSIONS disabled and > push out a fixed version. Thanks again for the report and analysis! So this was not enough, What we need is: index 1a9ef8f6784d..778a88fcfddc 100644 --- a/include/linux/fsnotify.h +++ b/include/linux/fsnotify.h @@ -215,6 +215,10 @@ static inline int fsnotify_open_perm(struct file *file) #else static inline void file_set_fsnotify_mode(struct file *file) { + /* Is it a file opened by fanotify? */ + if (FMODE_FSNOTIFY_NONE(file->f_mode)) + return; + file->f_mode |= FMODE_NONOTIFY_PERM; } This passes testing for me so I've pushed it out and the next linux-next build should have this fix. Honza -- Jan Kara SUSE Labs, CR