From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44106E7716E for ; Sat, 7 Dec 2024 06:00:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 306D98D0016; Sat, 7 Dec 2024 01:00:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 28FCB8D0015; Sat, 7 Dec 2024 01:00:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 130D28D0016; Sat, 7 Dec 2024 01:00:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id E8D1B8D0015 for ; Sat, 7 Dec 2024 01:00:41 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 8EA9FAF1EE for ; Sat, 7 Dec 2024 06:00:41 +0000 (UTC) X-FDA: 82867113084.01.5EABFEA Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf01.hostedemail.com (Postfix) with ESMTP id 4B8094001B for ; Sat, 7 Dec 2024 06:00:26 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=z95DUuXf; dmarc=none; spf=pass (imf01.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733551223; a=rsa-sha256; cv=none; b=O/aiVXCC6w4Z1lTJUpKqlK0kMigYCr1lS5Mi+6u+Fh3K3smn8nAgtE8eeyjnynh5oICcOE ZXOx34/GImMzqY7gUL5gAPkwcos+IZ0sd7YrUKjrwMdU/KiRqRP+/4D3wpLYKDqbK1KAgE Nqu3m0+iI4Ji8mQI+Rx38Lf2OHLp7E0= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=z95DUuXf; dmarc=none; spf=pass (imf01.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733551223; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1ZjksLUqMnalB1JDoCuhf68Vic/DDcW26SieefK0e2A=; b=BhxqoxgR7Cy7gTYUuHK/kiktiIfxfvCbxMVy4M4Nksd3cI70OZ8DBuQq/kq4ue8zKZxUlq AYP0dXp5kIgGtF/9Mp3WoR93YxazR6M704O6xEvInJdvzvTjbp4xbk37s4yOqZqJyI41W5 jDNlojMTx8Nfv6izRG10ZI1wHUd7YiE= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 02B0EA4020B; Sat, 7 Dec 2024 05:58:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 547E5C4CECD; Sat, 7 Dec 2024 06:00:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1733551238; bh=dxb0Zy9wKWNA7XqTg0/T1rddBsXo4s7NLdfNncQkqz4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=z95DUuXfwVbMM1mrsFfe3WoC/fhTpjLd0At8oG7fapXuuqv88Xrcwr1fHm+1yWoqt AeoPncQ2vy4saVAqL/J7AlPO27kTOBTy3RKuof5IhlDOnp0aM8ZsEmOCEqkXt2tuns ck5X03VIz+1AH3EHqqLAIqdyz5RWNzi3xBB6xCOI= Date: Fri, 6 Dec 2024 22:00:37 -0800 From: Andrew Morton To: Junjie Fu Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, willy@infradead.org, mhocko@suse.com, gourry@gourry.net Subject: Re: [PATCH] mempolicy.h: Remove unnecessary header file inclusions Message-Id: <20241206220037.5c0cd212d3269dd8a6f36e4d@linux-foundation.org> In-Reply-To: References: X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Stat-Signature: szxabc97jw8f8ux8jqdg5sed4fk4fzzq X-Rspam-User: X-Rspamd-Queue-Id: 4B8094001B X-Rspamd-Server: rspam08 X-HE-Tag: 1733551226-187001 X-HE-Meta: U2FsdGVkX1/qgDrlD23URSYQinbM/BRGJ5zK0FqjLz6KS1OW7qDGoOgBjtY5WfVRINkop0pN7c1ciU5jqBUP5m10+V/3kQl7GXcgaje9JbAvzWXjqDaIMSYnXLHcCiyLLDInlepSeyETjKbXLztll8mAg/CQ+7EfDmG2uBp+VZyx86CKB2gj6cII+6koGHpTd+Qpp47N1Sl5W3lr1IytcIb1kMx4q1OYTw2DWKcB+MJzEXK4HJeki1bkCpqwnUN4q9Qf8l56GZ2X7+HT4s4OidBTb4lB0VA5HlpnXqXByw92bZ1ssAOHcpQsSP0hqDkx1aNkyqPyi033YbxMJle42axNypZp+oAE8aLduzJu62UcxmnJMVuyl2rvnZbwvnUDK1dSgYLa6KBtDkCZKntXW0cNK142pgwm9HVU2yt81zmh/vm4/BhHd0uf3H7ApWeF+yF9tDDh5EaaZzziKTaygst7qIBfPZ3Sxb+nyfSNLTweE6KLkWO5vfn58EPnL5Kg4dpbpHndhHgUhRGGmTfVDP9kvgJyB3NdHIOdbjhkKYUM14OVDwgzPuIbTBWv//OOC2q494FMvKvfl1Sb1bFbCKDKsJtOkrJ7TOnsRzOP3+w5rwi7gyNSkqvBlCBSiiDswyd88tg+DMD2EMOaZcklZDSaRitEMgxIDccwWZqjrBFX08YxWWVk7PCIVlFvIM03ksghGv8Li2kF1077pgyJYQR3JtX6EacLKz4q3hUWNIwPBPO9dtMFahT7LpV1cxiNRZkSFY5qNt/sSLX/dgONca3RXmck5V18irq7mMW2+KEOOR7u+ciRKM214jJruXMY760KUHuGr6xRvOwEMOyD2jaSJkkGh517zeJcq9zE5IPtGBPjesgtW2QOk4lriVzpMZz0i8VxmECNnye6NWISIoqwT1tQ/07YqxzyX0d2Av4Q9ofsDIxhHgq8InmvXm/ZdRtWTQ9YBiTWGdkxmCX CSH8a095 frSTY8KbKzTC4GKxkvnGnVFQPWG5XVIO1eWp9NvM/3oTg5BtLiaIpd3qvRt/ccCqKaTEK9XMElymBT6KzKMJIee/z0rtf5lA3a3w3hAVWrCLPyDoBMX/dSJdc5Ry+qrsJs4nUv+Xbg96uSkIEVrP9Yfx92V+q7qsD7py6cwtqKVJQ60YKkLPAR+arxsZseC8e759uKzs9DrVyrrYcuTGwO2t06SqeYJ38MbtPJ5fspHGc7O7lX2+70VJBqnNmsLO8Dw9QRS3/CEfdiEI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 6 Dec 2024 23:53:49 +0800 Junjie Fu wrote: > Originally, linux/mempolicy.h included linux/pagemap.h because vma_migratable() > was implemented inline within the header, requiring mapping_gfp_mask() > function to implement vma_migratable(). Now that vma_migratable() is only > declared in linux/mempolicy.h and its implementation has been moved to mempolicy.c, > the inclusion of linux/pagemap.h in the header is no longer necessary. > > Additionally, since mempolicy.c includes internal.h, and internal.h already > includes linux/pagemap.h, so there is no need to modify mempolicy.c after > removing the direct inclusion of linux/pagemap.h from linux/mempolicy.h If mempolicy.c uses things whcih are defined in pagemap.h then mempolicy.c should include pagemap.h directly, and not rely upon such nested includes. It's simpler, directer, expresses what's actually happening and avoids build breakage due to ongoing header untanglings.