From: Andrew Morton <akpm@linux-foundation.org>
To: Junjie Fu <fujunjie1@qq.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
willy@infradead.org, mhocko@suse.com, gourry@gourry.net
Subject: Re: [PATCH] mempolicy.h: Remove unnecessary header file inclusions
Date: Fri, 6 Dec 2024 22:00:37 -0800 [thread overview]
Message-ID: <20241206220037.5c0cd212d3269dd8a6f36e4d@linux-foundation.org> (raw)
In-Reply-To: <tencent_08B979048FE091821B290B18AE97E70DC507@qq.com>
On Fri, 6 Dec 2024 23:53:49 +0800 Junjie Fu <fujunjie1@qq.com> wrote:
> Originally, linux/mempolicy.h included linux/pagemap.h because vma_migratable()
> was implemented inline within the header, requiring mapping_gfp_mask()
> function to implement vma_migratable(). Now that vma_migratable() is only
> declared in linux/mempolicy.h and its implementation has been moved to mempolicy.c,
> the inclusion of linux/pagemap.h in the header is no longer necessary.
>
> Additionally, since mempolicy.c includes internal.h, and internal.h already
> includes linux/pagemap.h, so there is no need to modify mempolicy.c after
> removing the direct inclusion of linux/pagemap.h from linux/mempolicy.h
If mempolicy.c uses things whcih are defined in pagemap.h then
mempolicy.c should include pagemap.h directly, and not rely upon such
nested includes. It's simpler, directer, expresses what's actually
happening and avoids build breakage due to ongoing header untanglings.
next prev parent reply other threads:[~2024-12-07 6:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-06 15:53 Junjie Fu
2024-12-07 6:00 ` Andrew Morton [this message]
2024-12-07 8:14 ` [PATCH] mm/mempolicy.c: include pagemap.h directly Junjie Fu
2024-12-07 17:14 ` Matthew Wilcox
2024-12-07 18:22 ` [PATCH] mm/mempolicy.c: include pagemap.h directly in right place Junjie Fu
2024-12-07 19:53 ` [PATCH] mempolicy.h: Remove unnecessary header file inclusions SeongJae Park
2024-12-07 21:55 ` Matthew Wilcox
2024-12-08 13:50 ` Junjie Fu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241206220037.5c0cd212d3269dd8a6f36e4d@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=fujunjie1@qq.com \
--cc=gourry@gourry.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox