From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE0E3E7716E for ; Sat, 7 Dec 2024 04:29:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2E9E48D0014; Fri, 6 Dec 2024 23:29:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 272C38D0011; Fri, 6 Dec 2024 23:29:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 114058D0014; Fri, 6 Dec 2024 23:29:10 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id E6ADA8D0011 for ; Fri, 6 Dec 2024 23:29:09 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 90A0E809B1 for ; Sat, 7 Dec 2024 04:29:09 +0000 (UTC) X-FDA: 82866883050.29.EE40F42 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf29.hostedemail.com (Postfix) with ESMTP id CF2B0120005 for ; Sat, 7 Dec 2024 04:28:42 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=MDn6GOgv; spf=pass (imf29.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733545740; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oERH5MeCBBFl4TRrlXho2q/CRm6Bwzc8/P4KBTJXXIk=; b=e0CaIlkkpfE55i5T3CLkFTwPxVot25GXWY9OiuNaYYeqOtPMaP7a5L8YCYtfvinvT45/8U M+72xNOg3VtQ+JHNXwJ6Uw3Mxk3WN34psEpHC+4P3D9zdOin0hIGk/ALx81uyDRCowfSn7 /Sl4hAhnl4OqnyyspPIg3y76CaIz4k4= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=MDn6GOgv; spf=pass (imf29.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733545740; a=rsa-sha256; cv=none; b=7XtpQGmI9dPXI8vMHC5qOn/88yyvBMx0nAPo54crlSKB4oiEluHTuZuD3oSsxxHmx7VqrN 2UJtHCLwOVEeBGgQ89M6Ea+2Rl/OEhRKfsZ1DQ+dvnGUZVDmcG9lJNk5jzjUGcZoYimX2H Buymw623/TYG0UtRGmNsWnE4nugGHxQ= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id D8A6E5C2A17; Sat, 7 Dec 2024 04:28:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4D27AC4CECD; Sat, 7 Dec 2024 04:29:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1733545746; bh=7ujOXHiY2JcriC2wOuNhv6HLkcewVN8yC452wdStT/0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=MDn6GOgvQqCGCYf9EL+Jkrm9535UtanJ5AFtgX+yVnNqXgg5bh3UX+F8mbDrJ12b8 eMs4cq0vn59NaF+iEAhMI8eqU/qK3WMN8jeyH8HQWn/8vxOXK4jqr90oI45CloWmbO VMms735LHpGCHKGEnWh7E1iLptdRTW2a++ta6cg0= Date: Fri, 6 Dec 2024 20:29:04 -0800 From: Andrew Morton To: Suren Baghdasaryan Cc: willy@infradead.org, liam.howlett@oracle.com, lorenzo.stoakes@oracle.com, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, mjguzik@gmail.com, oliver.sang@intel.com, mgorman@techsingularity.net, david@redhat.com, peterx@redhat.com, oleg@redhat.com, dave@stgolabs.net, paulmck@kernel.org, brauner@kernel.org, dhowells@redhat.com, hdanton@sina.com, hughd@google.com, minchan@google.com, jannh@google.com, shakeel.butt@linux.dev, souravpanda@google.com, pasha.tatashin@soleen.com, corbet@lwn.net, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@android.com, Peter Zijlstra Subject: Re: [PATCH v5 0/6] move per-vma lock into vm_area_struct Message-Id: <20241206202904.e685764837504d97cbc3cf62@linux-foundation.org> In-Reply-To: <20241206225204.4008261-1-surenb@google.com> References: <20241206225204.4008261-1-surenb@google.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: CF2B0120005 X-Stat-Signature: pnzpqsnws8tgczqzaqekkn3d4hqi5jij X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1733545722-702368 X-HE-Meta: U2FsdGVkX1/KP1ujwPhLjmjScdy0fHNxSDevQkOFy0BAv5kyhGazoYmX3YJAVYyBgaUnDcWVTcBqVMAacgWQrkScU924ghnMHqEtdRpDwIvH0IDt5D3dr/XFlyfEkijiARlXSurJwBmdlr48WxGa9oQOIdIpz4iVkJHjGqujWVeDdbKamA9um9RueSMtcI/wp4OpGYSOUJ9Ic3kdFXjfcWJe3jUj7pw02cLFrEmiiaVdb1q8b8rIOSwbAnJniUOwnZ761io6TVd0wewTg/6FlLDG5b8qjEqBAF3goXuxLliH7AGXNEKu65FzGhPFxGhaPe4bZnLxSXvdop/Li4Q7ctKhERIgr20MCx0qufvUNUO1E8+x5dL5BGeiDKWOUMwxBLRe0mteAg68MIG8fyaCyGLuEM5AkQr0TEFIs2wqPyxIvFv875UmpQ4N3VcY+1ecGMo6KPFSWT8dzn/4CVWFLwi22toaFlph+l4fDXpJ0n3GUIZWnc9tICwb6aqqhOsbbHdCJk/z9HNNjIvYwGEnD4vDWPiTgaAyQlfHi3YrF449n5qFgQ+xaMrqS1tq3LVPNkd3CvEBY60Iy+JOFKpP9im4kBbSCCQr2mml71aD0O4GCwOoR6E4tKQQ4Q6dqvk7AJYl6yoZMUhbIpQyN2k45DKfrrVvRduRlxCOQI2L9fVFM4C6AgV59ayDSk8hYESHvX7ddcT8XWOLSKxYP4V/+dE52Gs+EP1Ut1a7omkyL+2g3XQYAOA/xHQ6Ti4LCb3LfP+HQAo65BL/VE5kCxJHbWPxBHhnISc4EAIVFPONj16Jp2LLw2HyxeSV2ffNaFedd6EHyuAHLh59iBPDOBi59ym4jkaCfZjIv8xVkB3jZA+ObVr59tkOLB5u6t49L0nkJdjF25tTbrZ9CiSClKlF1LxVvAHOmWfWyQ00Vc2P84yaHwwUAmCM1cWFgHTCIyexdBXOvzxDxlSb28NhFgS i24vf1v+ ZYD3+1pcInj3TKfcphcR0m7/ciotkfcrEAZj3morHUSdnPluSmjSdb6G6XO5UGuD5qEiMNhnHDrf10Yvds+LjLSh/RLb/ZHMRW7AgH1A3qWoCSbKdY0UnKSXTOMftK+DnlgTLIMyOFn0ofl8tdoRkNB5b+0HKqbVVqX4MWa3HehqbI1/rHzBBejVjUnyX2d+9DGUDSjIc3RVMhXXCAIioIzb+etKIrd6Wq+gjsQpfd5+HYTT6ezbc3oUHO9XGbvFX78+9wBa7CIKBOtMIWIJnNocyeiG0LMCmD+hLbz18aDXFgO+pvAfnTjVRJ97W351GLgLZ+QEOdWwG0y7k4opoJWWNDA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 6 Dec 2024 14:51:57 -0800 Suren Baghdasaryan wrote: > Back when per-vma locks were introduces, vm_lock was moved out of > vm_area_struct in [1] because of the performance regression caused by > false cacheline sharing. Recent investigation [2] revealed that the > regressions is limited to a rather old Broadwell microarchitecture and > even there it can be mitigated by disabling adjacent cacheline > prefetching, see [3]. > > ... > > Patch applies over linux-next (due to vm_lock change [5] not in mm tree). > > ... > > [5] https://lore.kernel.org/all/20241122174416.1367052-2-surenb@google.com/ Well that's awkward. I added the "seqlock: add raw_seqcount_try_begin" series to mm.git. Peter, please drop your copy from linux-next?