From: Brian Geffon <bgeffon@google.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Brian Geffon <bgeffon@google.com>
Subject: [PATCH 2/2] selftests: mm: Add a new MREMAP_DONTUNMAP self test
Date: Fri, 6 Dec 2024 10:20:32 -0500 [thread overview]
Message-ID: <20241206152032.1222067-3-bgeffon@google.com> (raw)
In-Reply-To: <20241206152032.1222067-1-bgeffon@google.com>
Add a new selftest which validates that a new_addr as a hint behaves
in the same way as mmap.
Signed-off-by: Brian Geffon <bgeffon@google.com>
---
tools/testing/selftests/mm/mremap_dontunmap.c | 41 ++++++++++++++++++-
1 file changed, 40 insertions(+), 1 deletion(-)
diff --git a/tools/testing/selftests/mm/mremap_dontunmap.c b/tools/testing/selftests/mm/mremap_dontunmap.c
index 1d75084b9ca5..ccce97c68019 100644
--- a/tools/testing/selftests/mm/mremap_dontunmap.c
+++ b/tools/testing/selftests/mm/mremap_dontunmap.c
@@ -224,6 +224,44 @@ static void mremap_dontunmap_simple_fixed()
ksft_test_result_pass("%s\n", __func__);
}
+// This test validates MREMAP_DONTUNMAP using a newaddr hint without
+// MREMAP_FIXED.
+static void mremap_dontunmap_simple_newaddr_hint()
+{
+ unsigned long num_pages = 5;
+
+ // This dest hint is intentionally not aligned.
+ void *new_addr_hint = (void*)0x999900010;
+
+ void *source_mapping =
+ mmap(NULL, num_pages * page_size, PROT_READ | PROT_WRITE,
+ MAP_PRIVATE | MAP_ANONYMOUS, -1, 0);
+ BUG_ON(source_mapping == MAP_FAILED, "mmap");
+ memset(source_mapping, 'a', num_pages * page_size);
+
+ void *remapped_mapping =
+ mremap(source_mapping, num_pages * page_size, num_pages * page_size,
+ MREMAP_DONTUNMAP | MREMAP_MAYMOVE,
+ new_addr_hint);
+ BUG_ON(remapped_mapping == MAP_FAILED, "mremap");
+
+ // And the source mapping will have had its ptes dropped.
+ BUG_ON(check_region_contains_byte
+ (source_mapping, num_pages * page_size, 0) != 0,
+ "source should have no ptes");
+
+ // And the remapped area will be filled with 'a's.
+ BUG_ON(check_region_contains_byte
+ (remapped_mapping, num_pages * page_size, 'a') != 0,
+ "dest should have remapped content");
+
+ BUG_ON(munmap(source_mapping, num_pages * page_size) == -1,
+ "unable to unmap source mapping");
+ BUG_ON(munmap(remapped_mapping, num_pages * page_size) == -1,
+ "unable to unmap source mapping");
+ ksft_test_result_pass("%s\n", __func__);
+}
+
// This test validates that we can MREMAP_DONTUNMAP for a portion of an
// existing mapping.
static void mremap_dontunmap_partial_mapping()
@@ -348,7 +386,7 @@ int main(void)
ksft_finished();
}
- ksft_set_plan(5);
+ ksft_set_plan(6);
// Keep a page sized buffer around for when we need it.
page_buffer =
@@ -359,6 +397,7 @@ int main(void)
mremap_dontunmap_simple();
mremap_dontunmap_simple_shmem();
mremap_dontunmap_simple_fixed();
+ mremap_dontunmap_simple_newaddr_hint();
mremap_dontunmap_partial_mapping();
mremap_dontunmap_partial_mapping_overwrite();
--
2.47.0.338.g60cca15819-goog
next prev parent reply other threads:[~2024-12-06 15:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-06 15:20 [PATCH 0/2] mremap: Fix newaddr hint with MREMAP_DONTUNMAP Brian Geffon
2024-12-06 15:20 ` [PATCH 1/2] mremap: Fix new_addr being used as a " Brian Geffon
2024-12-06 15:34 ` Marco Vanotti
2024-12-06 15:39 ` Brian Geffon
2024-12-06 15:20 ` Brian Geffon [this message]
2024-12-06 18:42 ` [PATCH 0/2] mremap: Fix newaddr " Jann Horn
2024-12-06 18:52 ` Lorenzo Stoakes
2024-12-09 2:28 ` Brian Geffon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241206152032.1222067-3-bgeffon@google.com \
--to=bgeffon@google.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox