From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37E72E7716E for ; Fri, 6 Dec 2024 00:31:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 14C076B011A; Thu, 5 Dec 2024 19:31:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0FC426B011E; Thu, 5 Dec 2024 19:31:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EDEBD6B0120; Thu, 5 Dec 2024 19:31:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id CE3FE6B011A for ; Thu, 5 Dec 2024 19:31:01 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 5D671AEE74 for ; Fri, 6 Dec 2024 00:31:01 +0000 (UTC) X-FDA: 82862654154.29.62B9237 Received: from mail-ej1-f51.google.com (mail-ej1-f51.google.com [209.85.218.51]) by imf26.hostedemail.com (Postfix) with ESMTP id ED9B814000C for ; Fri, 6 Dec 2024 00:30:46 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=AKaPKZ5c; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf26.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.51 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733445051; a=rsa-sha256; cv=none; b=qgB6SqWo6BByLeBzvRskN0A5B7qkNe/8WgqIa3tt5IkCGCRMpPGYE/gJGI4Ni6umQtM0R0 VYeSgyACco97n6YKNAcGAZSWlFM4xYug23lzsNV4NnegD6D4BZ+4q4tJY7GhNl2TnayESE YAPe8Dc04QyTxq7F/ag2/rGVhTrDfZk= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=AKaPKZ5c; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf26.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.51 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733445051; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CuJ7vWjq9N4bf180yHzi7XHCXBBIt3hkByBmhQQJFDA=; b=ZhAH77XwtrFDN/3UkJNF4Kum4pqau3bhk0ql93untqBUxMXRX7xJAZHfajY3hJzO1l9O1Y Owt41DCYjRWHaQLUUaUnLqkFQZ2kdnOsQ+9b8PFP0dTONXNRrUD0Kxgzv3BXF3+S3TltDO aXG+VMdH7ufaYizDeTQFhudYsbMkBbg= Received: by mail-ej1-f51.google.com with SMTP id a640c23a62f3a-a9e8522445dso279671166b.1 for ; Thu, 05 Dec 2024 16:30:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1733445058; x=1734049858; darn=kvack.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=CuJ7vWjq9N4bf180yHzi7XHCXBBIt3hkByBmhQQJFDA=; b=AKaPKZ5cU/KHtHrtacxqubKpUfGVSO6c93jtHfpIU4p3++hfNYtuy5M7lj1l693ACx XFiODI73ZqwI7FBMtORtCbJ/blipda1qTgBtJ5IdmeAGhigvQsX/r2ZVcaLoTQMrR0i5 7oA0Xr3CiPplDHh0Ad2WVCTsREl6ZnaHQiuBNTALCS1RQ2caUAADhmdUSXCbZ6u9wsJQ ZY0Qow1MgpUY86lQYoBXlMxGSDqK0/H0Tl2JSOl2cQz/CwRVQKrQl1ssRadcdseavXSP ilJ2dyKKR0n2Z9ofUQE5d1Ky2rhJQKpB+onOmmIHLLyS2LFsKtsjzPBLD/I/bcf0IAjE 7UBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733445058; x=1734049858; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=CuJ7vWjq9N4bf180yHzi7XHCXBBIt3hkByBmhQQJFDA=; b=phQ1lJkOUTs86gNlkpB3SuWBm+4VNRKpAWTzZJJ2E/l/0kkylGdnZw4vX7x9DwWLkO s15LiBo/JFLxX3RSAS/u8R8V/xRfRm8LzOdyp0o6LiI/pQhNxZju7BFLkJCfrJRjcxO3 BOBPoYw4CPoGv6tOAtAx9Oz2kiARUoUH6U4vr1M6EpP4iKtSCBMUu6Qvl+5+QYk825hK 2LBF5pwORLlxfEsCqIHYr1iEVVI0pLi/Ff6kveqYxkC1utNO7HOPr+EM4x4oIS5TWKXY wVqp2fO0MsO95kJB/mLORsnot0K2TlLUc8/5BJATA4HgDeSsFW1iMzsw+Q1X/M4FROdB 94Mw== X-Forwarded-Encrypted: i=1; AJvYcCW8fnPxxHQTr4aAfiNwPpYs30F4diNuqvaJWd/SokQRnWVY7C5QrBQfqxLPx9OexF901Ane6mjNGg==@kvack.org X-Gm-Message-State: AOJu0YzBf0gfLp7L9qIf7uSFnq7nU6EPSdqMImiVjQPV0JaAONWCDDxH pkQYklBBOq7nguWisK4arHoZBcvg0JVRw9OcPLtLdxffQBCCxb/L X-Gm-Gg: ASbGnctBoxBqPoP7ElGILUQetZqak2S87hnXWhiNjO9Uh9m2FRDg5TMsoA3qbZla8wL wdW3NDX6ZDp0cbt2Tx6B6mA9jx3NIY4O+orV7PUKZRdhJx/VPXKLKDNpkX5Ozj6ZecOc8LjBp4x jiskYevY2AcLfUg/q9Dxo/LUd+JY20458e/QWD/RUcFwTP2HTJH4eVLs2ubA4kp6YnM4e1jSs9I hbYejKMGuVNAqL4xOYJgS7nWYSH0WmEjihTUNwkG5hgWY5bhOEkpw== X-Google-Smtp-Source: AGHT+IGdYCzXiyn+212FHw2lMBug+v2LYRIEy3va52yhzA+1vwvzueHuUr0mlkyKkF4A+lap/DWwIw== X-Received: by 2002:a17:906:3155:b0:a99:6791:5449 with SMTP id a640c23a62f3a-aa63a264d25mr68373866b.52.1733445057370; Thu, 05 Dec 2024 16:30:57 -0800 (PST) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aa62601b5f3sm160564766b.120.2024.12.05.16.30.55 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 05 Dec 2024 16:30:56 -0800 (PST) Date: Fri, 6 Dec 2024 00:30:54 +0000 From: Wei Yang To: Lorenzo Stoakes Cc: Wei Yang , Andrew Morton , "Liam R . Howlett" , Vlastimil Babka , Jann Horn , Eric Biederman , Kees Cook , Alexander Viro , Christian Brauner , Jan Kara , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/5] mm/vma: make more mmap logic userland testable Message-ID: <20241206003054.cj767w67kydv3rms@master> Reply-To: Wei Yang References: <20241204235632.e44hokoy7izmrdtx@master> <68dd91e4-b9c3-413c-b284-f43636e7ffba@lucifer.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <68dd91e4-b9c3-413c-b284-f43636e7ffba@lucifer.local> User-Agent: NeoMutt/20170113 (1.7.2) X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: ED9B814000C X-Stat-Signature: n37yj4tc9w5trxa9w4tpu4itkewiaie9 X-HE-Tag: 1733445046-690322 X-HE-Meta: U2FsdGVkX1+CBfHO0t6vJnnHqwMB8Ar1ggfvc+yCBPukGGL4CDuiyXevappWfB8QMQNoAKjb96jRwHdAhRxBKAg69HnP/1mpUD18jQOemZe4rWW7FWmOVwZSXuiyIN9J50FfCI9skKz63Z960YaTb5SSPSx7+NgWG2hQkwF8H7zWkFTBkq8OuLvl00tPyjly/f/gvoOyunyKRY8JEr+3krEgl0haa0hhyNV1Rle85ANUV4LaKjfA2IszGbAOP+AvXspzTGgIbCTmzWFGYwNS+8xzTcUgVBMTw8VYZr+eyRLMzhepUimmNw1xfx+x1a1Es0nWjfxCYvrOr26X8CdBHg1BdIqJO+caw7Je5ELlKAHOhKIzKx4k6rzbCIg4k97uXpCEsVZ7zniriQw7AHd4Xlz+aQY9ZZA4kgNy/UwgVdodo6HgB6cshWgbSnEQPkWJZC7Pyyjy/2Bl+A6G2m1KiormM6kr/HhOORx6jW1W11EV06SkRlDZl80r/hfUq8QEozNxukDuAFlAwFYC1WCLE6mucWQmjfJh5J3gzBbkTRxlfsEEW7ed1DQi/8fw6pTQ7qPJmcsCCIRXo8LAWU72bBCLcpOVvxhImdQT0osJ9XDTAVBQCdHMQrhIqbMA28CKzt0ynCHzladlcMtVkog/twXzG0n2GvdtAz57dVauYWlU3kmDlT+oD+mUfFw5stDBX2oDZP1X/r6ty1r7NvaJeqdry4dV840RtRE+GKmHVIoL5qPq2vbz5qQtwm9g2KVlhfrT03JyeWoIPARhY+qeAYMDrmnvf1+fSqFlvbf3mU9QdlZTszYJ1tDF5auTTOprxlheI9q///CILIEJIwj4hiFdC5IwqXnXsSbJeTF6IZESmnqC4wWpen2DbbxZ69YsSfLVgPTNmWtgHBENPM6PrqqvH9AEqccrke7PxI56I+i2ucXbRGFK7T+OULQEvD0FBkBu4JoCTnrqmkMc7M2 5zcPSZb2 jY2YGgXBF6Gr9XIVwPQA5G4Am7Z9ZJUQ/1ZrgUh4+bdP/TCg/c2lYcEpxsGRWLWKcKsLfQXkRTwyEt1o/xDGj4vJKRHl4+Jw3ieTNytnhLRQW8GGu65m15DMq6cH+l0PeLkUNfbRDodPs7orM3RSvmzymeUg9F22+acKH2tB8/txS2a0tqmlEZgmYIn4C7b+wtEC/jlEmPJWidj6MFUPu/aTg+58XjGbcA9zpufXweUf1slOEfFq22JTSDphBjiwNLWH1ui3uNq3TDV+OrIqw4hqG0UtS8fd6d/7cDjz2smxK60dTUdpmkw5nTZLUYX0aoQXzND0XixoJnfjmtTDS6zrtw0AcgwlDg+4dmQRLfrkbxL0UeAa/e9kll8uG4MrG+a6jOXn/ZqpJmTkzzhOwPu2HGQv/GttSY27Tx98cN8ZFTuWWu124poX4YrFZNSahxkY8ukMoTm+OZZnPkP3Qszj8+viNSzT94K4zRo4IEIewzSo1Y1/IWG3grwm/zjjKdS8mIAApIuUJPykY2HYdDBOUJTSibBNnIMhluaQcLmbuv7XQIgOA7ugvuskaZTGd7JTJ2l5YMCzfLtThaQRTm3FxaiW6glZC+lJWq2qY06K9zor2mGgWXomKWRug81BmRj/YF+j6cT4FTiiMK1HAMHTkQg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Dec 05, 2024 at 07:03:08AM +0000, Lorenzo Stoakes wrote: >On Wed, Dec 04, 2024 at 11:56:32PM +0000, Wei Yang wrote: >> On Tue, Dec 03, 2024 at 06:05:07PM +0000, Lorenzo Stoakes wrote: >> >This series carries on the work the work started in previous series and >> ^^^ ^^^ >> >> Duplicated? > >Thanks yes, but trivial enough that I'm not sure it's worth a >correction. Will fix if need to respin. > >> >> >continued in commit 52956b0d7fb9 ("mm: isolate mmap internal logic to >> >mm/vma.c"), moving the remainder of memory mapping implementation details >> >logic into mm/vma.c allowing the bulk of the mapping logic to be unit >> >tested. >> > >> >It is highly useful to do so, as this means we can both fundamentally test >> >this core logic, and introduce regression tests to ensure any issues >> >previously resolved do not recur. >> > >> >Vitally, this includes the do_brk_flags() function, meaning we have both >> >core means of userland mapping memory now testable. >> > >> >Performance testing was performed after this change given the brk() system >> >call's sensitivity to change, and no performance regression was observed. >> >> May I ask what performance test is done? > >mmtests brk1, brk2 (will-it-scale) The one from here ? https://github.com/gormanm/mmtests > >You'd not really expect an impact based on relocation of this code, but >with brk it's always worth checking... > Yes, I am trying to know usually what perform test we would use. >> >> >> -- >> Wei Yang >> Help you, Help me -- Wei Yang Help you, Help me