linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: "Matthew Wilcox (Oracle)" <willy@infradead.org>
To: Minchan Kim <minchan@kernel.org>,
	Sergey Senozhatsky <senozhatsky@chromium.org>
Cc: Hyeonggon Yoo <42.hyeyoo@gmail.com>,
	linux-mm@kvack.org, Alex Shi <alexs@kernel.org>
Subject: [PATCH v8 05/21] mm/zsmalloc: convert obj_malloc() to use zpdesc
Date: Thu,  5 Dec 2024 17:49:42 +0000	[thread overview]
Message-ID: <20241205175000.3187069-6-willy@infradead.org> (raw)
In-Reply-To: <20241205175000.3187069-1-willy@infradead.org>

From: Hyeonggon Yoo <42.hyeyoo@gmail.com>

Use get_first_zpdesc/get_next_zpdesc to replace
get_first_page/get_next_page. no functional change.

Signed-off-by: Hyeonggon Yoo <42.hyeyoo@gmail.com>
Signed-off-by: Alex Shi <alexs@kernel.org>
---
 mm/zsmalloc.c | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c
index 03b77690c616..af8a6cd6b814 100644
--- a/mm/zsmalloc.c
+++ b/mm/zsmalloc.c
@@ -1313,12 +1313,12 @@ EXPORT_SYMBOL_GPL(zs_huge_class_size);
 static unsigned long obj_malloc(struct zs_pool *pool,
 				struct zspage *zspage, unsigned long handle)
 {
-	int i, nr_page, offset;
+	int i, nr_zpdesc, offset;
 	unsigned long obj;
 	struct link_free *link;
 	struct size_class *class;
 
-	struct page *m_page;
+	struct zpdesc *m_zpdesc;
 	unsigned long m_offset;
 	void *vaddr;
 
@@ -1326,14 +1326,14 @@ static unsigned long obj_malloc(struct zs_pool *pool,
 	obj = get_freeobj(zspage);
 
 	offset = obj * class->size;
-	nr_page = offset >> PAGE_SHIFT;
+	nr_zpdesc = offset >> PAGE_SHIFT;
 	m_offset = offset_in_page(offset);
-	m_page = get_first_page(zspage);
+	m_zpdesc = get_first_zpdesc(zspage);
 
-	for (i = 0; i < nr_page; i++)
-		m_page = get_next_page(m_page);
+	for (i = 0; i < nr_zpdesc; i++)
+		m_zpdesc = get_next_zpdesc(m_zpdesc);
 
-	vaddr = kmap_local_page(m_page);
+	vaddr = kmap_local_zpdesc(m_zpdesc);
 	link = (struct link_free *)vaddr + m_offset / sizeof(*link);
 	set_freeobj(zspage, link->next >> OBJ_TAG_BITS);
 	if (likely(!ZsHugePage(zspage)))
@@ -1346,7 +1346,7 @@ static unsigned long obj_malloc(struct zs_pool *pool,
 	kunmap_local(vaddr);
 	mod_zspage_inuse(zspage, 1);
 
-	obj = location_to_obj(m_page, obj);
+	obj = location_to_obj(zpdesc_page(m_zpdesc), obj);
 	record_obj(handle, obj);
 
 	return obj;
-- 
2.45.2



  parent reply	other threads:[~2024-12-05 17:50 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-05 17:49 [PATCH v8 00/21] Add zpdesc memory descriptor for zswap.zpool Matthew Wilcox (Oracle)
2024-12-05 17:49 ` [PATCH v8 01/21] mm/zsmalloc: add " Matthew Wilcox (Oracle)
2024-12-10 13:44   ` Hyeonggon Yoo
2024-12-05 17:49 ` [PATCH v8 02/21] mm/zsmalloc: use zpdesc in trylock_zspage()/lock_zspage() Matthew Wilcox (Oracle)
2024-12-05 17:49 ` [PATCH v8 03/21] mm/zsmalloc: convert __zs_map_object/__zs_unmap_object to use zpdesc Matthew Wilcox (Oracle)
2024-12-05 17:49 ` [PATCH v8 04/21] mm/zsmalloc: add and use pfn/zpdesc seeking funcs Matthew Wilcox (Oracle)
2024-12-05 17:49 ` Matthew Wilcox (Oracle) [this message]
2024-12-05 17:49 ` [PATCH v8 06/21] mm/zsmalloc: convert create_page_chain() and its users to use zpdesc Matthew Wilcox (Oracle)
2024-12-10 13:53   ` Hyeonggon Yoo
2024-12-05 17:49 ` [PATCH v8 07/21] mm/zsmalloc: convert obj_allocated() and related helpers " Matthew Wilcox (Oracle)
2024-12-05 17:49 ` [PATCH v8 08/21] mm/zsmalloc: convert init_zspage() " Matthew Wilcox (Oracle)
2024-12-05 17:49 ` [PATCH v8 09/21] mm/zsmalloc: convert obj_to_page() and zs_free() " Matthew Wilcox (Oracle)
2024-12-05 17:49 ` [PATCH v8 10/21] mm/zsmalloc: add zpdesc_is_isolated()/zpdesc_zone() helper for zs_page_migrate() Matthew Wilcox (Oracle)
2024-12-05 17:49 ` [PATCH v8 11/21] mm/zsmalloc: rename reset_page to reset_zpdesc and use zpdesc in it Matthew Wilcox (Oracle)
2024-12-10 14:00   ` Hyeonggon Yoo
2024-12-05 17:49 ` [PATCH v8 12/21] mm/zsmalloc: convert __free_zspage() to use zpdesc Matthew Wilcox (Oracle)
2024-12-05 17:49 ` [PATCH v8 13/21] mm/zsmalloc: convert location_to_obj() to take zpdesc Matthew Wilcox (Oracle)
2024-12-05 17:49 ` [PATCH v8 14/21] mm/zsmalloc: convert migrate_zspage() to use zpdesc Matthew Wilcox (Oracle)
2024-12-05 17:49 ` [PATCH v8 15/21] mm/zsmalloc: convert get_zspage() to take zpdesc Matthew Wilcox (Oracle)
2024-12-05 17:49 ` [PATCH v8 16/21] mm/zsmalloc: convert SetZsPageMovable and remove unused funcs Matthew Wilcox (Oracle)
2024-12-10 14:04   ` Hyeonggon Yoo
2024-12-05 17:49 ` [PATCH v8 17/21] mm/zsmalloc: convert get/set_first_obj_offset() to take zpdesc Matthew Wilcox (Oracle)
2024-12-10 14:10   ` Hyeonggon Yoo
2024-12-05 17:49 ` [PATCH v8 18/21] mm/zsmalloc: introduce __zpdesc_clear_movable Matthew Wilcox (Oracle)
2024-12-05 17:49 ` [PATCH v8 19/21] mm/zsmalloc: introduce __zpdesc_clear/set_zsmalloc() Matthew Wilcox (Oracle)
2024-12-05 17:49 ` [PATCH v8 20/21] mm/zsmalloc: introduce zpdesc_clear_first() helper Matthew Wilcox (Oracle)
2024-12-05 17:49 ` [PATCH v8 21/21] mm/zsmalloc: update comments for page->zpdesc changes Matthew Wilcox (Oracle)
2024-12-10 15:46   ` Hyeonggon Yoo
2024-12-11  4:37     ` Matthew Wilcox
2024-12-12  0:11       ` Hyeonggon Yoo
2024-12-13  2:25         ` Alex Shi
2024-12-09 11:59 ` [PATCH v8 0/21] Add zpdesc memory descriptor for zswap.zpool alexs
2024-12-10  5:54 ` [PATCH v8 00/21] " Sergey Senozhatsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241205175000.3187069-6-willy@infradead.org \
    --to=willy@infradead.org \
    --cc=42.hyeyoo@gmail.com \
    --cc=alexs@kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=minchan@kernel.org \
    --cc=senozhatsky@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox