From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2082E7716E for ; Fri, 6 Dec 2024 01:47:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7ECD86B015F; Thu, 5 Dec 2024 20:47:09 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 775BC6B015E; Thu, 5 Dec 2024 20:47:09 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5F0986B015F; Thu, 5 Dec 2024 20:47:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 3C5386B015C for ; Thu, 5 Dec 2024 20:47:09 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id DF75E81853 for ; Fri, 6 Dec 2024 01:47:08 +0000 (UTC) X-FDA: 82862846010.14.8F0C6A6 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf14.hostedemail.com (Postfix) with ESMTP id 2B101100008 for ; Fri, 6 Dec 2024 01:46:49 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=u6FLIIxt; dmarc=none; spf=pass (imf14.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733449612; a=rsa-sha256; cv=none; b=Li8sd2dCeh4bogBes8d8PpB1r2sXW9QWkcciyF5XliezItR8HVJggrcrg8fPIHFrT6PSb1 Q709zHG0/IaL+69FcT+gTTeQaJUEz7goqY0yp0YeRbN3nMStT++coh0da83q6YWev1yIBP Tp/lYlci2Xe1LC6rqPFsK7rLgEirVgw= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=u6FLIIxt; dmarc=none; spf=pass (imf14.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733449612; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=B4nb6p5pJEgr+ircCvvvQGexW5DEn2+uwDtzDCBuXkU=; b=4iOS3YUTXC6YFPEDgZuwMszGbh4Pgbw+ngGqtWv9J6AjbMtkRWBKUvVgdE55qvUhfQSk0h vIVdMEgz2rHJKOadNu7K5SR655MUsB1PLJ0l8rOqXqzuQTjlsaKTBt+CpDHT6Nytq0P65u jcr7/1lsGVDkm3CTqw7F4Gie9Nb+Mac= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 80E1DA4138A; Fri, 6 Dec 2024 01:45:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E0669C4CED1; Fri, 6 Dec 2024 01:47:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1733449626; bh=l+jopiwo262+5UsZDfF7mCnibov6B0ToInGv92Kte/I=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=u6FLIIxtSioQVLzeRm+xARbngLsCgb7AWmOxlni4qPCoq4AmHg1klR1T+BQlC+QCr FIBSDIyVtGyWc5CE8hhNGhT3Ez3NladBiM1nzJ5J+k1Uk5YrK6LOqg3eGyxuJMchMD u0bgSH16oejUP1mF8QnEW1j46Zc7DKEKo/VrdNLw= Date: Thu, 5 Dec 2024 17:47:05 -0800 From: Andrew Morton To: Kefeng Wang Cc: "Huang, Ying" , David Hildenbrand , Matthew Wilcox , Muchun Song , , Zi Yan Subject: Re: [PATCH v2 1/2] mm: use aligned address in clear_gigantic_page() Message-Id: <20241205174705.99acb4e658cf8f3f19c0fa77@linux-foundation.org> In-Reply-To: <95c61e7d-2572-46b8-89f7-abab8ea1b7c7@huawei.com> References: <20241026054307.3896926-1-wangkefeng.wang@huawei.com> <54f5f3ee-8442-4c49-ab4e-c46e8db73576@huawei.com> <4219a788-52ad-4d80-82e6-35a64c980d50@redhat.com> <127d4a00-29cc-4b45-aa96-eea4e0adaed2@huawei.com> <9b06805b-4f4f-4b37-861f-681e3ab9d470@huawei.com> <113d3cb9-0391-48ab-9389-f2fd1773ab73@redhat.com> <878qu6wgcm.fsf@yhuang6-desk2.ccr.corp.intel.com> <87sese9sy9.fsf@yhuang6-desk2.ccr.corp.intel.com> <64f1c69d-3706-41c5-a29f-929413e3dfa2@huawei.com> <87v7x88y3q.fsf@yhuang6-desk2.ccr.corp.intel.com> <20241130181546.0d4d95e2ad9c0be707f54a50@linux-foundation.org> <87ser8c6ai.fsf@DESKTOP-5N7EMDA> <95c61e7d-2572-46b8-89f7-abab8ea1b7c7@huawei.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Stat-Signature: 4cmsgruipq1hg6af6ia56wtk7pnb75dh X-Rspam-User: X-Rspamd-Queue-Id: 2B101100008 X-Rspamd-Server: rspam08 X-HE-Tag: 1733449609-684005 X-HE-Meta: U2FsdGVkX1+jEI8BWgUY7ccorFgzt6VKJuDvs0XGrYnjvEv2yT1YViMXYBhCd91Z+G+HmFx/2rlFMgQDfDlzq74yvvpQNCfaEBY9ghJRkUGGkfAsf88CGMmskMWbE+4jedvy8oJxBzDa5hdVBh+DNJFMbMgfxK5ZHcpMKA1QvZYQ689/nQiZ775b8yw8DPbNlJg+12evWzQifNOfGC+lBF0x7P3VDTogZy6RWpQzug5+tD7eDH2xVSB6cwhifJpCB0tPaXn95chp3ersvKm4exFPTTdnNLPL7N53cOCfHbPnblFor3GkgpnDB/GIECo3rhJsbvAThpRaywFIfVDKSzcyWNTVg1nLb8/CO/u9Wj+2+A3u0Rcb5GdcAV5pYVz5YjOflmc7G5btczPoDXSP9IjI3C6hrPiG4njrSbKldEROjUbKZwtug/g8QHMg+HWQFkCRQqRbwIQDraq1KHpWEFjqSbmdS5M7pH6pt3D5/uGpdx4Dd5WDKO77KLkkrHpWONNqw1DCG6oBU4MIZgnsX74pgUuBjMnvXEcHYylV0bjOSFEgv5dBo3iCpx3pVLjIEswVzFz6rtdXbA+TNDp6yyNnzkeLY864GW5iA2/Oqw6hQQvRmClIGuhNWNQtkQwTu/dfpC/sIXrbVGn+qt4FHlPpZGmfQOX5sTe87kgWGiyFRd/7C/pWdDJLu2RYLY817CyVsscJp7+fYq6eZwehy5Ga7gN4aWYXM+oIWhF3FTbQYWhPEuD8Mw+WPJjGst1+2VMDBA/y6Ui6sQBWUl8Ub0dJi5h61oMrqQVlvdCnuGeCXYsR8UlogWU6gb5waU/+N+yIKjCoyNaO247YZd+rq6MJQoXS5FE5dcA+L6Fc4jUvufjeXnXJ/jIvG0v9YRl41McBW02P4oQm9PGR1Tda6QqkJm28/ZVm3zDYuSWsQgjtLRzwUZ5ww8qZXVKNzy9KX4qg9Tj/4WaN9hURaWj 0FeUcAZ3 Ebab4DjogJALD3mLy+B/dIK8vl0wPeUBTdf1ZdDLAbaUnrEoE6zO7MixUzmd/GMBcKjGrI/54WTfDoWps/LYBaKMB16q8LDoVyWj+yIlljkq95yBLuLml4bjY7JEnebbbp3HOdfo3w+4zsc1dk3ZHlfhyyjEIKpXj59YkHHawVyYNQQlONP5D7/CZAA8sMTSUhAT18WCGuatVR3QW7WhHhoTw48CrGfr29khtWNIrMhs6nGoDba0dGyNLmApPybylI+DebXDvdgtCXPi53AKUZKNoJh0UARSIE5eFtFEL/qaliOCypA0VJARRi8JZJeHR8q9qhkeR9tD7Mnd10DysXaW/7g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 2 Dec 2024 09:03:45 +0800 Kefeng Wang wrote: > >>> WARNING: the patch is only build tested. > >> > >> I'm holding this patch in mm-unstable because it's unclear (to me) that > >> this regression has been adequately addressed? > > > > Yes. This patch isn't ready to be merged yet. More works are needed to > > root cause the problem and implement the proper fix. I guess that > > Kefeng will continue to work on this. > > Sorry for the late, I've been buried in other tasks. > > The two bugfix patches in the next should be merged firstly, which is > not related about the performance issue. > > 84ddd1450383 mm: use aligned address in copy_user_gigantic_page() > 9fbd869b19b8 mm: use aligned address in clear_gigantic_page() > > > and according to the suggestion of Ying, I am trying to fix the > performance issue on arm64(will in new series), but I need to check no > regression on other arm64's machine, will send the new patches once > the test is complete. > > So Andrew, please help to pick up the above two bugfix patches to > v6.13-rcX if no objection. I added cc:stable to both and moved them into mm-hotfixes-unstable, targeting an upstream merge next week. "mm: use aligned address in clear_gigantic_page()": https://lkml.kernel.org/r/20241028145656.932941-1-wangkefeng.wang@huawei.com "mm: use aligned address in copy_user_gigantic_page()": https://lkml.kernel.org/r/20241028145656.932941-2-wangkefeng.wang@huawei.com