From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D712E7716F for ; Thu, 5 Dec 2024 01:24:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4930E6B0088; Wed, 4 Dec 2024 20:24:13 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 441E76B008A; Wed, 4 Dec 2024 20:24:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 309D56B008C; Wed, 4 Dec 2024 20:24:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 11DB66B0088 for ; Wed, 4 Dec 2024 20:24:13 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 70C9A14131D for ; Thu, 5 Dec 2024 01:24:12 +0000 (UTC) X-FDA: 82859158830.08.F25DFCC Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.13]) by imf22.hostedemail.com (Postfix) with ESMTP id 6E995C0009 for ; Thu, 5 Dec 2024 01:23:53 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=fRatOr4N; spf=pass (imf22.hostedemail.com: domain of lkp@intel.com designates 198.175.65.13 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733361834; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EZaHgjAmVql9lcWh0Ck4FcoeGCs4wDYC2obnvpWH6qg=; b=ufQwvVEJ5bWCDrfxWtDJlaqDH4kuWBHcfu9PHh1/AUgfMixK/QxJqBYdj0pdgQPSkznxPD 66FQPDddkyWuVLpu53O+EfFmo/HnNCY5ud/L+MhxWvBJZv99ZcY8PzBSLe0w6MwVV1Cfkv jCN4tfU7PC3gx4+UeUJp4uFG1PX1sgI= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=fRatOr4N; spf=pass (imf22.hostedemail.com: domain of lkp@intel.com designates 198.175.65.13 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733361834; a=rsa-sha256; cv=none; b=G7dRuIor8oE7XMBokV6Gp0W31w6wxfa/UnJoM8B7Eh1ztDhhztYmjBYlN1PfAyuOUpFjOZ cXlnv+7YRMTwYfENig5E8Jr1BRO1wqY9mr2De+H4yAyX/WC+ZybVuHsKatIWcYpObPP8Q0 G5ZK91iYbaaFcOc2a4xKOCsTlLX5Agg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1733361850; x=1764897850; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=iw7fuXPYCUPZXzib8rOrienqpPhH7l+XsBbTP71d4Zo=; b=fRatOr4NI2CDdv4oBmyuv3OtW9kXkqLNOZxnP6tdv/C0wa1QUsh0THQR wce14paob23SbNqMpoCqFdCzhcLDTS29eTuaMYWGBbTGM+A/3uFG+eMdB y/ZW3/3vXxQudKGwO3pVTjnbbiV5qA+/Sfz8ZOfj2CMoFor7svzaJneqI HcITQDlsazbY2hwfiEFsxl8l+sqZdXRlQT9PF+Hjaq2yP6QpVk8RMFvDs ie/wm0zKGgWI5au9Td84pTcKgTc6zKfvrgdTAuwKQrA27I7CRdBTS9ZSd bzetKv5Wwc9If5Fb0DPaBhxlFIKi+H9wR0alN1GvFWVyCyYppl70EkGaG Q==; X-CSE-ConnectionGUID: VILCNhvwRw6wANX0HMX+FA== X-CSE-MsgGUID: ILF5W7lfT8WiPOZGg/2dLg== X-IronPort-AV: E=McAfee;i="6700,10204,11276"; a="44685147" X-IronPort-AV: E=Sophos;i="6.12,209,1728975600"; d="scan'208";a="44685147" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by orvoesa105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Dec 2024 17:24:08 -0800 X-CSE-ConnectionGUID: P03VVCmST22TMFZDz086Nw== X-CSE-MsgGUID: Jq6R7X5tTxOL8zTJ/81Amw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,209,1728975600"; d="scan'208";a="98003848" Received: from lkp-server02.sh.intel.com (HELO 1f5a171d57e2) ([10.239.97.151]) by fmviesa003.fm.intel.com with ESMTP; 04 Dec 2024 17:24:05 -0800 Received: from kbuild by 1f5a171d57e2 with local (Exim 4.96) (envelope-from ) id 1tJ0b5-0003eF-0O; Thu, 05 Dec 2024 01:24:03 +0000 Date: Thu, 5 Dec 2024 09:23:04 +0800 From: kernel test robot To: Guillaume Morin , linux-kernel@vger.kernel.org Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, linux-mm@kvack.org, guillaume@morinfr.org, Muchun Song , Andrew Morton , Peter Xu , David Hildenbrand , Eric Hagberg Subject: Re: [PATCH v1] hugetlb: support FOLL_FORCE|FOLL_WRITE Message-ID: <202412050954.m9cwNOJC-lkp@intel.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 6E995C0009 X-Rspam-User: X-Stat-Signature: fizq1r4gz8ciqex7ce7my4qf59rshm1y X-HE-Tag: 1733361833-721466 X-HE-Meta: U2FsdGVkX18Ww2tJGXTv2VsTU5X24tQ8NAlEKrsmbTM45wqlgfmG53Y+qfCNwv884Q+uPP0qqFPG2X47Y5jqlm2IU5Rh0subm4N1uP9sm+eB5okr4+Ht72B7KUrZrnKCjs6/rX3BORyV8bFGWCXmILwo9EvdlWAtAaEBPrk13fTrC3ZnyHmVLg/M56B63y+m542GH1baiJ1BkGUT+hX1ktQWf18sDi5SEi3QSts2sTkkOb9ruqS0nxtE/Umba7XtiQdgQejPbXAKOiyqBvDQNfsjXYkovqC3uIUEegZWq6HMBvL/gPTfGa3ce4uGayJH+y5zvkbFln/+CPjxqQfmqFBPDwlFrhuNQaqqCYWbUAT+cxXLE3Y5y9gF+tPmmGVXLcZ2CmFokfaPdFqSOWWHadto6rdsEhxj5Jy0PKkFAuBZ7BQZXByvsFWVg/zlWjTuEsMIVeQEY8h40cu7+SJHiqV/uN0J8KTXLUPEyNhnHTKCp6U/n2hgCPsbFmOwXjvK6ZPD7WjlZqcXI3Z/5sqjKT2FAypPgUeVCRms47PDjFYzQ2GHhGKH622fW5WG73kfIBJMW751qGRQQczCNC+6WwR6nvUbMw1qgx1PTyrQeSaXfA4W/VBD7ob4b1G6TLm+kbVVBwV89Wnlajd3lwbPqUEjmlhOQk7Q0PjTK+2tqAxMyEnFjhEA/c0gGPVf78VfTgfS3GOQ0cHDSsKAdAQywIEZMk6klLXiH2Dc/rvRokXu1hTDEM67+qWaSc50Os+ZGSpLvZCMdknuV7mUBQ/83S9U7LLKAsvpcH8Uw+lTemom+AaPAcowMgisJN8pcVzDdYQB9SmRPYk/R07vpA/NTb3T5Xr8xHc+GyAe/SZ2q0BlL4jDtK75kyQmwAoETQcO0MRpYjfBn0TvJyzBSB49Gse7J/bMzhmNFcznvfiLzv83lL2GeKmj+rKtGB2sxzh9awoVDssMyRaWoPZJl1H /4juXCbR +UZdVMOOPjPm5qDc3/DpirpboTiN2kmk8fR4hwFgz0+fEHQ5jtsEczaSeFgO6oPr19WBDtGpCvcd8xECRNiifkpcrvX65QJof8TZmhFpewvpgek99m9lIFPRdyQ76sEdObUMp5gD5roNB3BeqGD1zpK0g1A7DgkG8C8k4FEY79pnaiqcqxn6psvSapF+duNgiFnw92wz+mCBVbGNYwPCYclSG5DfYb3RmMyjW1RVDjT+m42S/XfaX/jJNqXVtEtmBpAD8eJJ52//b6IHPzfE1WkON8vo7A6Vkb+8ulggfV0XGXzIkEKH7TVXSOH8YO5fvAC7qJ82N7lUsGf9eawyphTQdT5NR3U8vvYTbw3wWDyHrBbj00dIIUBNz3aeuQJUc+Nd5Zokh4ki+8iomq8Mf1tVqhLc9d0eM9DihpRsblhsrLPPNfBdpYbYXBs1ByhUBWqN1lFW6meUSPjw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Guillaume, kernel test robot noticed the following build warnings: [auto build test WARNING on akpm-mm/mm-everything] [also build test WARNING on linus/master v6.13-rc1 next-20241204] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Guillaume-Morin/hugetlb-support-FOLL_FORCE-FOLL_WRITE/20241205-022843 base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything patch link: https://lore.kernel.org/r/Z1Ce6j5WiBE3kaGf%40bender.morinfr.org patch subject: [PATCH v1] hugetlb: support FOLL_FORCE|FOLL_WRITE config: x86_64-buildonly-randconfig-002-20241205 (https://download.01.org/0day-ci/archive/20241205/202412050954.m9cwNOJC-lkp@intel.com/config) compiler: clang version 19.1.3 (https://github.com/llvm/llvm-project ab51eccf88f5321e7c60591c5546b254b6afab99) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241205/202412050954.m9cwNOJC-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202412050954.m9cwNOJC-lkp@intel.com/ All warnings (new ones prefixed by >>): In file included from mm/gup.c:7: In file included from include/linux/mm.h:2223: include/linux/vmstat.h:504:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion] 504 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS + | ~~~~~~~~~~~~~~~~~~~~~ ^ 505 | item]; | ~~~~ include/linux/vmstat.h:511:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion] 511 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS + | ~~~~~~~~~~~~~~~~~~~~~ ^ 512 | NR_VM_NUMA_EVENT_ITEMS + | ~~~~~~~~~~~~~~~~~~~~~~ include/linux/vmstat.h:518:36: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion] 518 | return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_" | ~~~~~~~~~~~ ^ ~~~ include/linux/vmstat.h:524:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion] 524 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS + | ~~~~~~~~~~~~~~~~~~~~~ ^ 525 | NR_VM_NUMA_EVENT_ITEMS + | ~~~~~~~~~~~~~~~~~~~~~~ In file included from mm/gup.c:20: include/linux/mm_inline.h:47:41: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion] 47 | __mod_lruvec_state(lruvec, NR_LRU_BASE + lru, nr_pages); | ~~~~~~~~~~~ ^ ~~~ include/linux/mm_inline.h:49:22: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum lru_list') [-Wenum-enum-conversion] 49 | NR_ZONE_LRU_BASE + lru, nr_pages); | ~~~~~~~~~~~~~~~~ ^ ~~~ >> mm/gup.c:681:33: warning: variable 'page' is uninitialized when used here [-Wuninitialized] 681 | !can_follow_write_pud(pud, page, vma, flags)) | ^~~~ mm/gup.c:673:19: note: initialize the variable 'page' to silence this warning 673 | struct page *page; | ^ | = NULL 7 warnings generated. vim +/page +681 mm/gup.c 667 668 static struct page *follow_huge_pud(struct vm_area_struct *vma, 669 unsigned long addr, pud_t *pudp, 670 int flags, struct follow_page_context *ctx) 671 { 672 struct mm_struct *mm = vma->vm_mm; 673 struct page *page; 674 pud_t pud = *pudp; 675 unsigned long pfn = pud_pfn(pud); 676 int ret; 677 678 assert_spin_locked(pud_lockptr(mm, pudp)); 679 680 if ((flags & FOLL_WRITE) && > 681 !can_follow_write_pud(pud, page, vma, flags)) 682 return NULL; 683 684 if (!pud_present(pud)) 685 return NULL; 686 687 pfn += (addr & ~PUD_MASK) >> PAGE_SHIFT; 688 689 if (IS_ENABLED(CONFIG_HAVE_ARCH_TRANSPARENT_HUGEPAGE_PUD) && 690 pud_devmap(pud)) { 691 /* 692 * device mapped pages can only be returned if the caller 693 * will manage the page reference count. 694 * 695 * At least one of FOLL_GET | FOLL_PIN must be set, so 696 * assert that here: 697 */ 698 if (!(flags & (FOLL_GET | FOLL_PIN))) 699 return ERR_PTR(-EEXIST); 700 701 if (flags & FOLL_TOUCH) 702 touch_pud(vma, addr, pudp, flags & FOLL_WRITE); 703 704 ctx->pgmap = get_dev_pagemap(pfn, ctx->pgmap); 705 if (!ctx->pgmap) 706 return ERR_PTR(-EFAULT); 707 } 708 709 page = pfn_to_page(pfn); 710 711 if (!pud_devmap(pud) && !pud_write(pud) && 712 gup_must_unshare(vma, flags, page)) 713 return ERR_PTR(-EMLINK); 714 715 ret = try_grab_folio(page_folio(page), 1, flags); 716 if (ret) 717 page = ERR_PTR(ret); 718 else 719 ctx->page_mask = HPAGE_PUD_NR - 1; 720 721 return page; 722 } 723 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki