From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B24E6E7716D for ; Wed, 4 Dec 2024 21:01:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1CD3A6B0082; Wed, 4 Dec 2024 16:01:31 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 17E6A6B0083; Wed, 4 Dec 2024 16:01:31 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 045516B0085; Wed, 4 Dec 2024 16:01:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id D9A046B0082 for ; Wed, 4 Dec 2024 16:01:30 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 752CC1211E5 for ; Wed, 4 Dec 2024 21:01:30 +0000 (UTC) X-FDA: 82858496952.25.2F10507 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.20]) by imf23.hostedemail.com (Postfix) with ESMTP id 27C04140034 for ; Wed, 4 Dec 2024 21:01:16 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=TLC5gjIT; spf=pass (imf23.hostedemail.com: domain of lkp@intel.com designates 198.175.65.20 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733346080; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wH4J70FyZHUXXFGE+AMN9PziHEi+DKMcQ6eXEH6q9ck=; b=MJ7zD3d2vx3ZUaYUs5b4+t7fdxcEgI6cay/BcfFvhcJHtBaLs7SHqIux9RJPvXhoo0UoiZ FHkhP9pdya+IpGzXmFdVjoRYR94eGGlv942ishfyusJ2Gyxhd8w1oLLtl3255Nbc1WO5BY qMR3pwx8u2YFqU9ubgdOFp22SibsMOU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733346080; a=rsa-sha256; cv=none; b=nE92FXCfpX5hiRXi+EfqB8yeJVoBlzaZqZJlCZEvs5W4vV5uoat7Tpn4at5Wqw9jiQTwFn vCGyPGmo/sThyy8KH+zwwpnKiGc0b3F2JUFKJe6ECMcm2MERSQFwwFkkf4ABRCTwETTxRU CBr0aAP0yep1hXoMKWM6hHvxL14T7IY= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=TLC5gjIT; spf=pass (imf23.hostedemail.com: domain of lkp@intel.com designates 198.175.65.20 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1733346087; x=1764882087; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=+B1b48erQIeQixduuLKyl6Gzmhalqkxt2Aqtmj7j3GM=; b=TLC5gjITF5/nWmXCWgEBjkjdvsGE2TtCmsLHtPjMBjNYQlJq1n9I8qzy FHxHcgEJZaY2xQJ2E/aU0VzbsTG61u7eR7TEwQx1jXgM18wjtIVAO6Wlw F0RFKbwawm3cL88ltywisbLtvBw5Pn8WowmOsR3YfxDh/LtMa0NotcMZU 6focaZWrs77K+/tIsL2lCf1IFjd/q4EydF8DU9SlEvjmNRrnJwAhFucnS emRodfJSEPW7Gjxz1+Df04pDzxzIw7/izvFz1PO8P0cB/WYxXWFs+DYgy cX68FhkToFjovRfAoPun+40uyqxNh/DxUMWqvVo8ppYdmm36pwUb6BBPl w==; X-CSE-ConnectionGUID: 81KgGHGHTQ68hi68mq21+g== X-CSE-MsgGUID: nElPOuUaSG2vXPni0IZEnQ== X-IronPort-AV: E=McAfee;i="6700,10204,11276"; a="33376966" X-IronPort-AV: E=Sophos;i="6.12,208,1728975600"; d="scan'208";a="33376966" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by orvoesa112.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Dec 2024 13:01:25 -0800 X-CSE-ConnectionGUID: nWMhahjzT6unCm7yL0vWZw== X-CSE-MsgGUID: rdAyQyECS1GnVqSYeIN72A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,208,1728975600"; d="scan'208";a="97937244" Received: from lkp-server02.sh.intel.com (HELO 1f5a171d57e2) ([10.239.97.151]) by fmviesa003.fm.intel.com with ESMTP; 04 Dec 2024 13:01:21 -0800 Received: from kbuild by 1f5a171d57e2 with local (Exim 4.96) (envelope-from ) id 1tIwUo-0003UF-2o; Wed, 04 Dec 2024 21:01:18 +0000 Date: Thu, 5 Dec 2024 05:00:57 +0800 From: kernel test robot To: Maarten Lankhorst , linux-kernel@vger.kernel.org, intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Tejun Heo , Zefan Li , Johannes Weiner , Andrew Morton , Friedrich Vock , Maxime Ripard Cc: oe-kbuild-all@lists.linux.dev, Linux Memory Management List , cgroups@vger.kernel.org, Maarten Lankhorst Subject: Re: [PATCH v2.1 1/1] kernel/cgroup: Add "dmem" memory accounting cgroup Message-ID: <202412050415.jf4sa0gH-lkp@intel.com> References: <20241204143112.1250983-1-dev@lankhorst.se> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241204143112.1250983-1-dev@lankhorst.se> X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 27C04140034 X-Stat-Signature: xraax9cdu4qus6i99u19ybdo973ic97o X-Rspam-User: X-HE-Tag: 1733346076-721518 X-HE-Meta: U2FsdGVkX18oh5h2ZgAN8rDNdDZPLToUSCdlAN0Ep7Pd4EhWUB3fnxHEFW2U9QLeMigrETLkPNlSUUyPkPxkbvW/G7MreU9cfxL0eabYFCiHv42dIcBiuZffA0iWlKSff3gfoJlfb32QW+JIBsiSbTGdWoEg+L8xfbMio9/KQb0d6MvocQ/ydu+v5vVuPpLOvs/+k1uNxgZ6NfvR2GM3mFHQz18M8Z6APcG8soXvVh0oAmqQuPDYmPonQT1QIOktcfM+C2ofJoFaD9a2hw5sgDFER6WVXD2Lurir1EG5dJzhzWoe1t/Enq80UkGzDU/sGK8HHMVX0ma+jr9Suedv5irzt9AtFpdqYeS8Oh9SEqaU4VeNQ+Fl660pqa1nMZjywaDBOt6/T72yAVIpU4IH3JkjbSgOcdAKSbjeUwh7Ffp5S6GOXJFaqSyN1Q1ZSHO7dJpNjoe+KGSsKKfm1kwt2nuv8nTFZYeyrJ2dp0aTLGHIl3YbQ3t3q/HQd9EGbuAb4hMmiynBNOjAmcvh/WMT1zEhL7I9e2xQBBIMvyaUO343udEnlN/0tpYqwLO50YxopRRhWKV6yyMb2w9bLNzxAkX3P94psJGLqNtc74iei1McV2rUra6Yrnt5N4VKF9UpD6Hhk22cGZ6FkHrZvrk8LEtxueXggsb9sbjIh4WRHnt77QX9KaZ3oeWzE+zIeyIovVXXmzy/kzTXLCF4DVu5+qLEEsITUJfkrIAMyFQScfxKBD0VNKdUlkzClH4bIKhu25aGgisc4N1cheumFb5aB6lmsRaJYplYZaKmEtST70dFzOUpMxFadwoeo4FpVAUrhlxzcMs19uih3zswVy5GrByNa3YGvvigE6F7sFcQBQkxwlIjaDsEK+KRaxMjW+NWXrj9Azr9UDxx0wapZ7GjX385D+aTm9gd0am+Vc4MsGMtEZzXHoLEISuBcuKbNTSSsz+F3hUj8zQ2PTcA3c1 01EDFUSy Xd6yUZeFD5P4lmfzkGx3VBmWUu0B+fB5uzhhHYBNFUmC5b8/pZYmuCwqyeAk79yE6yG7VYTD6zbgqGV4I7TkbK7Jm9NRIjUtk8D2FOgBuP0duasGxD8US3qXm9FX+TBo2Rb73Dr5spDntDlI3x9fFHjUpYrufIuj0JQLUPc59HWnzEs1B3fRgZzUhVMXYtwebRWEHPbptcDjtHsRUWDsiNo4TOK8Do5HStP8GwFRq1Jt3SfqGmbeqnNh0li6fd2sH0AdJWF3kpN+uoAqYXNznjB5vM9sH8Xf60MJcPypz/rkq3b3BUrlu4nBnvTiSZCdtQziUoX3GoXGd2qxE3jApKhBrDYn/CltZlzn6 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Maarten, kernel test robot noticed the following build warnings: [auto build test WARNING on tj-cgroup/for-next] [also build test WARNING on akpm-mm/mm-everything linus/master v6.13-rc1 next-20241204] [cannot apply to drm-misc/drm-misc-next drm-tip/drm-tip] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Maarten-Lankhorst/kernel-cgroup-Add-dmem-memory-accounting-cgroup/20241204-233207 base: https://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup.git for-next patch link: https://lore.kernel.org/r/20241204143112.1250983-1-dev%40lankhorst.se patch subject: [PATCH v2.1 1/1] kernel/cgroup: Add "dmem" memory accounting cgroup config: sh-allmodconfig (https://download.01.org/0day-ci/archive/20241205/202412050415.jf4sa0gH-lkp@intel.com/config) compiler: sh4-linux-gcc (GCC) 14.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241205/202412050415.jf4sa0gH-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202412050415.jf4sa0gH-lkp@intel.com/ All warnings (new ones prefixed by >>): kernel/cgroup/dmem.c: In function 'dmem_cgroup_state_evict_valuable': >> kernel/cgroup/dmem.c:302:30: warning: variable 'climit' set but not used [-Wunused-but-set-variable] 302 | struct page_counter *climit, *ctest; | ^~~~~~ -- >> kernel/cgroup/dmem.c:300: warning: Excess function parameter 'dev' description in 'dmem_cgroup_state_evict_valuable' >> kernel/cgroup/dmem.c:300: warning: Excess function parameter 'index' description in 'dmem_cgroup_state_evict_valuable' >> kernel/cgroup/dmem.c:635: warning: Function parameter or struct member 'region' not described in 'dmem_cgroup_try_charge' >> kernel/cgroup/dmem.c:635: warning: Excess function parameter 'dev' description in 'dmem_cgroup_try_charge' vim +/climit +302 kernel/cgroup/dmem.c 280 281 /** 282 * dmem_cgroup_state_evict_valuable() - Check if we should evict from test_pool 283 * @dev: &dmem_cgroup_region 284 * @index: The index number of the region being tested. 285 * @limit_pool: The pool for which we hit limits 286 * @test_pool: The pool for which to test 287 * @ignore_low: Whether we have to respect low watermarks. 288 * @ret_hit_low: Pointer to whether it makes sense to consider low watermark. 289 * 290 * This function returns true if we can evict from @test_pool, false if not. 291 * When returning false and @ignore_low is false, @ret_hit_low may 292 * be set to true to indicate this function can be retried with @ignore_low 293 * set to true. 294 * 295 * Return: bool 296 */ 297 bool dmem_cgroup_state_evict_valuable(struct dmem_cgroup_pool_state *limit_pool, 298 struct dmem_cgroup_pool_state *test_pool, 299 bool ignore_low, bool *ret_hit_low) > 300 { 301 struct dmem_cgroup_pool_state *pool = test_pool; > 302 struct page_counter *climit, *ctest; 303 u64 used, min, low; 304 305 /* Can always evict from current pool, despite limits */ 306 if (limit_pool == test_pool) 307 return true; 308 309 if (limit_pool) { 310 if (!parent_dmemcs(limit_pool->cs)) 311 return true; 312 313 for (pool = test_pool; pool && limit_pool != pool; pool = pool_parent(pool)) 314 {} 315 316 if (!pool) 317 return false; 318 } else { 319 /* 320 * If there is no cgroup limiting memory usage, use the root 321 * cgroup instead for limit calculations. 322 */ 323 for (limit_pool = test_pool; pool_parent(limit_pool); limit_pool = pool_parent(limit_pool)) 324 {} 325 } 326 327 climit = &limit_pool->cnt; 328 ctest = &test_pool->cnt; 329 330 dmem_cgroup_calculate_protection(limit_pool, test_pool); 331 332 used = page_counter_read(ctest); 333 min = READ_ONCE(ctest->emin); 334 335 if (used <= min) 336 return false; 337 338 if (!ignore_low) { 339 low = READ_ONCE(ctest->elow); 340 if (used > low) 341 return true; 342 343 *ret_hit_low = true; 344 return false; 345 } 346 return true; 347 } 348 EXPORT_SYMBOL_GPL(dmem_cgroup_state_evict_valuable); 349 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki