From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30C67E7716D for ; Wed, 4 Dec 2024 23:56:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 782826B007B; Wed, 4 Dec 2024 18:56:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 732196B0083; Wed, 4 Dec 2024 18:56:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5F9786B0085; Wed, 4 Dec 2024 18:56:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 41DC56B007B for ; Wed, 4 Dec 2024 18:56:40 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id C98A21A128E for ; Wed, 4 Dec 2024 23:56:39 +0000 (UTC) X-FDA: 82858938246.08.AAD2733 Received: from mail-ed1-f43.google.com (mail-ed1-f43.google.com [209.85.208.43]) by imf02.hostedemail.com (Postfix) with ESMTP id 5C04E8000D for ; Wed, 4 Dec 2024 23:56:09 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=GOf5KNkz; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf02.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.43 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733356591; a=rsa-sha256; cv=none; b=o89qjprn59fCyPnn9Fg8JADxQw5yeKLyjf2q9UfTSiFndrPQrCQeFYus3KbqtK0g9FN/aR YRF0fvyPxOCqurdgszZGUMwIlqaEB5zvOioJi1po3rvbllzcm9ZKlpR6NlGy6hYQKbQn6E FkwNlekjCStiuLuhLpnIUtpf0Rfj5yM= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=GOf5KNkz; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf02.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.43 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733356591; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vJKz2wj2juop4/IeMZVrYzFBdQURnaygM5UccUrxv6w=; b=M3xRB0g04o4gkIEJpAI6Di43KpaeNpi6729ym3w286hPnulPMKKcKlhhWxaXEnOatsw6xJ cUO8X3av86URKUZ2TbQsxUAQcwMGmSSL5J3x5kYEt0Yco3AHCixz0ZzwGiQRHlgDArZ6Y4 pWAF6hv4K8SLH17x4gZb8rzHx49GM/A= Received: by mail-ed1-f43.google.com with SMTP id 4fb4d7f45d1cf-5d0bde80b4bso376923a12.2 for ; Wed, 04 Dec 2024 15:56:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1733356596; x=1733961396; darn=kvack.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=vJKz2wj2juop4/IeMZVrYzFBdQURnaygM5UccUrxv6w=; b=GOf5KNkz9jKnkEH31Ry2B9xjRTkeAs/v8s/jckl2P5svxJW9Eiv1XNrkD7POSkYLHE IJext0k+z7dgmQHLFhSA4twF2aMKXMC6dPHlgV1C0qTpJcWwjFAX7Hv7wN3CoyYOXh+Q fw2PQ3vIdjesFyKnHs+lqaaN/rUm6Rr8rEa5bfaKM+IUgTU5D94SesVRSBJ775pfq3XV ocIluxvuSrwAlDeiC5gRYi++0QwYtudxBH7n6d+qR+YbInQ0i0MoMTVL5o91onr9QsN8 xTj1g0vYroijw6POeT55nWYr1clSIWr5PWSewNUVcndETHYmrq4q+TxwlDHGalx6oCAt G/yA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733356596; x=1733961396; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=vJKz2wj2juop4/IeMZVrYzFBdQURnaygM5UccUrxv6w=; b=Ve6nt+OBJkFrTDCSXS9MakYluqx5zHl09v/j6GqVMr4tzmjsN2pjumMEqZ3E/kLvG9 MQiKbO0nyy9nzmwikbqV6CwoIrz/qNH/R9+br5FucIhc8RcqORjvvqGAfStfAmAz5MOe Ri3+LoTMAQTnykp6MCEVORmo2aAurrOWrz++G7dP3ZKV4uDn8TejYQjs/PFeCzh4WP6/ SQlZtKBXTKAtg2ojZHsJJgoK7C3fR4Ggz9KKG7u64oqWjMbidga9MgS0cEUg5+YMmuKS cDF3zoDAMKUMtbcUc1WEQMeWhC0JcLU2Ybww8h1g78GVx6DoWCOHr3m4KQ2uNAemXrt8 zZ6Q== X-Forwarded-Encrypted: i=1; AJvYcCVxUOI1B/ttotylVF2vBId/mHTF0lPRt5JL+CE2h4TRQ6nQZgAjkKgJbRjcaE0nnHV2MGKJqLihEQ==@kvack.org X-Gm-Message-State: AOJu0YzO7Gn2gB7Dq308y/kuD+55Cp9iW+HPlWrqe2TKqd9SYy5+h5Jb ue8VUUOYmdhoDpLnkaVbEguxIPoaKzMkPPWzrQcSOGZ0DJXwpj0N X-Gm-Gg: ASbGncvakEUj8Chh9dS/52eInH5YSy7V92dfYKQq1eZSo6BrlXM/HMy0vXrd9NZ7uDg aopWxlLtyZVk9QtRRS/vPeFq//pJnjAL8JKZBDVIhda2cAJCLrqU3qpJh+YMSHvAaUJXe+Epqa9 Vh2cDE7vwOvd8HAVNeKEiMZF8A1vZ46en/3/mQINW0kZ1v+iec6rP0wg+a55vlBt5fFl69tvdh6 EI0suXwRQ36CGDdrsIEGNRkhancf2D3DfnAhGIL/3RHM+MnLQ== X-Google-Smtp-Source: AGHT+IH8dzA/+2KKrO1cHwwQZR17w7HCC+oSR5sKhkw++P4LEAldEsyaN/rRyXoeSB1VU7N5URE/zQ== X-Received: by 2002:a05:6402:510a:b0:5d0:f9a0:7c1f with SMTP id 4fb4d7f45d1cf-5d10cb817d3mr7963616a12.23.1733356596024; Wed, 04 Dec 2024 15:56:36 -0800 (PST) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5d14c799224sm97394a12.69.2024.12.04.15.56.32 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 04 Dec 2024 15:56:34 -0800 (PST) Date: Wed, 4 Dec 2024 23:56:32 +0000 From: Wei Yang To: Lorenzo Stoakes Cc: Andrew Morton , "Liam R . Howlett" , Vlastimil Babka , Jann Horn , Eric Biederman , Kees Cook , Alexander Viro , Christian Brauner , Jan Kara , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/5] mm/vma: make more mmap logic userland testable Message-ID: <20241204235632.e44hokoy7izmrdtx@master> Reply-To: Wei Yang References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 5C04E8000D X-Stat-Signature: oetskpfnjbh5iz97g4p8y6at9qscqpz8 X-HE-Tag: 1733356569-48420 X-HE-Meta: U2FsdGVkX19zNtiTdAveCCyZwD6TVJ47zGPIzXzAb8jj1YQwA51ho9/R9kS7aYVktU2GmSUpeh/0ZczG73dSYdWMGrVCTVHtj6g+e8NDBYd2Zk+4JNDox/qihYRu+EEXxvsfvuiGKXtsfUS73fDodyD7Ue5yIrYntufdEnzP6j4kEyGFja3KVumsi8LhCrwN0Z/psWw81Kdp525ABQHznBsZVYSs03zZ3BPvjs7KGjfLRIGEUQtz5lw/OIMq+wekAibp31EleIrjGtSFPOhG9rOeMjGsHueXhPTjNbCKOAMfizmTaCUwgIyUHrk95ANCy32x3tUbrMY7Oosxy4+p4wNhZggHu7KH/MDJp805NndBNUk+H3gXkZeFXcju8d59ehnOo60xUIpmud+xuP2PhAOGOtljn/qbxlt+r/4ZRgsriwBUOFx3HrfPP9dSLeZhWC17Br0r2TXU89FcMGMk0+x/QGcgJByE9YArNLr0/6XN8l6PxhIX6tmiJX2ODF8G+SlCsQYUIgvHDpsUnRt488Cx2YBSXlPDeNxChVromM87yKwKxFf/QAjbDhv2N0yRojVHcdrRrJc0MCpHf+JXvGVF1lzVvjncH0lFa4yMGKGBjve12iLzgPHSSwWKkzZ7VqZwlu5Ta/uHsxaGPYguxwW9FPuIeztXCZBk6DNWLCUyY1gMXY/084IGNwlkYJMcxfgbe3HB+nC2aYw7xoORzWz7cNjl5El8YwOFB/4+ILcMaIRB33yMrGK+uC11uItsWM3ymYh85qJnLt2PxD2qAnEsWQE0tIJ2pIB5inJqh1J0sqB+o/wVPXvfPAszFo3UMjCA3lASKLEWrtzOO7ey/zTf8hFiLdCyJ2I0qwG7rvuApapR3RFIT3WKUxdSKa7n+siaktDz2v63Qwqfq9BMSZUlLwfXq5YDBSBVmKroT0HDr8Yas0bmiFBuOLzLFjaDKEUv+syiHNeiNbZ1/Vr 4th30L+S LghAEu1MS65qZ+cAJ1E059MS5Bt6VMLVjuXbP65aXWfiD0F/BaysGS0OHvyWKcL4Midot8jgKDMIGudNIKGk53iwES6Gfu91W6Aj5hcmE7LEeP76WHeN9lV1XIkz5rOsOnq+1HLoKzBFQvj83VC5VOH+/OoQ2BgCn7VJJMl9ZeMA1dVTgYnfNxx4DxMOgIIcjbHBkuK1Ge8GW1B5sYyM2e/tEQ/w2hkA8oFDCKRl7AGHq1jaUuYp+S1EU0NJlBhiiBL8tY00v08fUyvzPG0DaXEiwpNWJzij0+TQtZYhjqaMid3YdtXrzc0cEl1/xsscG3zks6folkG7+AAVMRZL1+0+lNwVmgtUSTwxIT3grMOC7PBdgtj0e6IxFuv3ETYmgqRE8kmRxL84W/pF0m8uBr/lLePr/osYWrlVZ6rI7bUPDVEadaYDDqQsWotVG/bEdnDsCxCNyOBTJzlPcQx8Xl5mSMGKsJ39sRttZlnznmFHOa1oxTeiIo1QXNo/abxCXdaXu/Rqa3svfWIG6dM+0vYnx80I0u41o9ba70TQRaYbWRz4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000062, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Dec 03, 2024 at 06:05:07PM +0000, Lorenzo Stoakes wrote: >This series carries on the work the work started in previous series and ^^^ ^^^ Duplicated? >continued in commit 52956b0d7fb9 ("mm: isolate mmap internal logic to >mm/vma.c"), moving the remainder of memory mapping implementation details >logic into mm/vma.c allowing the bulk of the mapping logic to be unit >tested. > >It is highly useful to do so, as this means we can both fundamentally test >this core logic, and introduce regression tests to ensure any issues >previously resolved do not recur. > >Vitally, this includes the do_brk_flags() function, meaning we have both >core means of userland mapping memory now testable. > >Performance testing was performed after this change given the brk() system >call's sensitivity to change, and no performance regression was observed. May I ask what performance test is done? -- Wei Yang Help you, Help me