From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B92CE7716E for ; Wed, 4 Dec 2024 12:55:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 458546B00A0; Wed, 4 Dec 2024 07:55:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 409CD6B00A2; Wed, 4 Dec 2024 07:55:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 25D7F6B00A4; Wed, 4 Dec 2024 07:55:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 009286B00A0 for ; Wed, 4 Dec 2024 07:55:19 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id D418AC0F97 for ; Wed, 4 Dec 2024 12:55:18 +0000 (UTC) X-FDA: 82857271770.25.AC8974C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf01.hostedemail.com (Postfix) with ESMTP id AD54040014 for ; Wed, 4 Dec 2024 12:55:05 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=TdOovVI1; spf=pass (imf01.hostedemail.com: domain of dhildenb@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhildenb@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733316906; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=na4vd6mThSkzeb6NVT06w3pd7mJ97fz8U44/x2n2hr0=; b=LghUOTET3iXVakWaFZg8dLxWNfnc7RQxR9klI1ZywHJoA/Jb+yTIyVrmaSzWjznNj1Mx8r WIWO/N3Z2SRz1RLKag3nmU/S7/L5KzYaAjHGZyIMC/qY4mNFLsLHpvfnw4R6JTJMLtylfA GiKnLxfdIC2XGgaVU2zgSTQHBtouEGs= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=TdOovVI1; spf=pass (imf01.hostedemail.com: domain of dhildenb@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhildenb@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733316906; a=rsa-sha256; cv=none; b=dL7ur/cey7QBafE3MtbFYJ0zUfPG+1FxHusThXdZpYaeISxKLABF93KaV6Ud1g+Uh5rTWw byHAuCYAxx6GP/d8O7qNjojGGORGM1dWuR50FHa8nlx5YpNCnAOKZTMf354q9E2u+9wmfD NQXAV1T4fPkKCBOoF7FUSfncEAP44rs= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1733316916; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=na4vd6mThSkzeb6NVT06w3pd7mJ97fz8U44/x2n2hr0=; b=TdOovVI1AYXmBregFcCv3CP3VqahGsCQqDKzUanVUGbIvU0xVoRSg4Q3u7DgIzz7syvJEy SkMbJWFDUKOvyTjBXMDAT5AaW8SynmbU2HSBijcuXN9k3wS1I6+oGjMENf4y+vMutPHNMZ u0HaGWhWtKod+MCkdF2oBKsnf0JPhkk= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-353-AS9J6RofMseZO47B0Umt8Q-1; Wed, 04 Dec 2024 07:55:14 -0500 X-MC-Unique: AS9J6RofMseZO47B0Umt8Q-1 X-Mimecast-MFC-AGG-ID: AS9J6RofMseZO47B0Umt8Q Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-434a9861222so55180595e9.2 for ; Wed, 04 Dec 2024 04:55:14 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733316914; x=1733921714; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=na4vd6mThSkzeb6NVT06w3pd7mJ97fz8U44/x2n2hr0=; b=t1EFGsywBt4k4VT8MlKGc1qzkdNaAW9+LnYMNnrUyYGnsvhavVUbFe+FKTKfBeffyJ 0kf4LAKINx0we3vreGZbGzd+bYS4/jBKDMaWoDRRHckf6JDU+LvHk6Huz9FacRNo/cjU izfxpnVOc8YimB7tw1G7QGSJUxVlIJvL9BnedqjDYvAd0FCkS9ZEEHiFm85hOwV+oF5F vH+WPja5nOrMq32IybKATuysTXHh/XZkB4FDyrtm2HjgSwiXaWtRRxiudnqLz5Iyc668 UiymjmRY5tuKMjNz+1dgOcXIxXekahhbGEbo5RMsOvpsCxQr9e6+rmHX/NV8fFqS9pPl FCJw== X-Gm-Message-State: AOJu0YyZYgcoPfeV/G+3Vtnh24q2qLZu8SGSCoaP6SH390oEOcKu76HP JFXGAmfMahYuDy1fl/h21pvNejD0h/t2XtHqBGUMcEOpKUVMAdBASEmONXIWwyaj9CaN94Sw6AI fiGP/a2Xa6RFNBr4TQIv+ddpJXybMAAVbe7NIYac/YJBec7y1 X-Gm-Gg: ASbGncvr1dwTyxshQ6jY3IPz/ZvyttG02AboIThFLlXB5o5BbHcdA8BsG8xYv1OQAq5 6EVsqGNwBS6Fye0kDv6OTeVXPb8IQLsh10GeR1t/qX4iUEb33UN67SuLre76+22dMcVOxRTVC7J MhZL0bTNG+GyplPXpMkeLwlsQIJnfP0KgBrgMw4pT8t7cdWWjPjdzzmLXhTLuna93Uv/KpKl5bI p6QWeGNiMwyawVmUxFtMf7JioVP+JdLo7Pv6mFnMCG2TNK7uBxErzFstGmybU+UdzH4EnONTSUH SPZdRXwqjSaH47/2B/2xykXbF8/mtFcTgIA= X-Received: by 2002:a05:600c:3550:b0:434:a781:f5d5 with SMTP id 5b1f17b1804b1-434d0a15047mr62644345e9.30.1733316913742; Wed, 04 Dec 2024 04:55:13 -0800 (PST) X-Google-Smtp-Source: AGHT+IHdVB6YFjtubaQuZKYqVl7K3swrZVKNM9mWRen9YVYSXicgBrRTJ3zdugRU4fK2CCWYQJl/Fg== X-Received: by 2002:a05:600c:3550:b0:434:a781:f5d5 with SMTP id 5b1f17b1804b1-434d0a15047mr62643915e9.30.1733316913375; Wed, 04 Dec 2024 04:55:13 -0800 (PST) Received: from localhost (p200300cbc70be10038d68aa111b0a20a.dip0.t-ipconnect.de. [2003:cb:c70b:e100:38d6:8aa1:11b0:a20a]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-385df488559sm15210226f8f.63.2024.12.04.04.55.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Dec 2024 04:55:12 -0800 (PST) From: David Hildenbrand To: linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, linux-s390@vger.kernel.org, virtualization@lists.linux.dev, kvm@vger.kernel.org, linux-fsdevel@vger.kernel.org, kexec@lists.infradead.org, David Hildenbrand , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , =?UTF-8?q?Eugenio=20P=C3=A9rez?= , Baoquan He , Vivek Goyal , Dave Young , Thomas Huth , Cornelia Huck , Janosch Frank , Claudio Imbrenda , Eric Farman , Andrew Morton Subject: [PATCH v2 09/12] virtio-mem: mark device ready before registering callbacks in kdump mode Date: Wed, 4 Dec 2024 13:54:40 +0100 Message-ID: <20241204125444.1734652-10-david@redhat.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20241204125444.1734652-1-david@redhat.com> References: <20241204125444.1734652-1-david@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 5-y_oGjDjl8YJU56cGddvkGtbVyR62DUZLGIRACCjvY_1733316914 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-Rspamd-Server: rspam05 X-Stat-Signature: gkmykh7az19rzjbqn1s7qgqaaq9xz5gw X-Rspamd-Queue-Id: AD54040014 X-Rspam-User: X-HE-Tag: 1733316905-431338 X-HE-Meta: U2FsdGVkX184vnDzfhGZTmLqPjZYLxy3NwmzerWjzU48KUSMeJrC4/aCJh9EswSFby44dsv2rR4JQ2yhlgTNzjYjJPNDfsAdvcLWwfscrjI+ZJ6mU+bJHNSRVQUQCvgrWIDU5mLJfzOejlGa2RZB0HNa4DbsK9iJblzXRe2/03Z9z1v8C36oVv+jb1/fBd1u4L16os/1ANcqw6zzsSFkYNTI2FHLMCJyMOrlb61AwwNkM3dq8R0JKCwbq0auQIu0DCS3GAYFKL4kgbR94pDEECPKu/d5ETlDmphNJ8fhEmKSg0gtoHJJm9PQ/q7oMwxFfGxq+6kXF7quxLfTE8+l+IDRmCM7tI7nPo4+IpnUCnzH2QhdAV/xP2fEg9IbtXSB/A0VX635jBTx1yBH9BZ9qvJMFUfMZGcp/96quUmhBai6m9toz9jty+VIvF4jurdpmhwKmiz/9xoK8npHNtDBx1WPRwvk94eC344rPszgH3cTnUDlBO6S6v0xCwSXJKmeGs+FWB91uw2pTr7XjyaJEzwjCve3gtzTNtGKm0lF3Cy0BDDX3H36MNsORR4+iy/vr0Qw2pp5R48MqFs+Qf+si9+4yh+Jju9JoNL84GFNesRDhadiQGGdYVPQHNbdyZUwQ9Z8IVfh7CCv3pdA3jwGYjJOCtCw3X7fYhm0a9poI6F6ordAZ6507ZM9fKXqRoj2mMNyCxdt9E1e1Cb8gRyKVhyTQHry9+z/2d4STOM1IasEZ8Y60ExxTKy0HfoIdHzmvXShPoOHxniQy8B+PMLQf8TfDbI9+S7pJbxIjNXzlroBYNgdIJcVR64UTGGqlc4TZhupHOi70unnJxSw598EJvYeVwiEQR/8vEFObF7WkCAv79f93CeZvb8+RQTUvgFsc5mxHkT8WzTU5jTY48cwDBuRB9fuEPPuqpE2boxowCJmQD1aKgYgoNZ9Q802PIjtyqc8hcVxbSIFNCpb4a3 9i+Q/llA V4N0TB0aI9DirE2MG73ccPcFaktMbtLxwhpC5ErA9ES4OfxgsK2JWNyHDhrKJp7HRqn7LfWF0Sn/Bh5yqpuoLQk5kNG3w+9RCAwBBEOR4qQpWTO7cF0lrPU6zdKTTkp2znVI0CZSWX4ez203aKR+jmBo4vNYGYoAgz0tngIicGLVNVSrC3qaDYZ5l+sYThizNmWPp0/GAQNyqLLy67jSqV78cmZ7xdNV9NV3EKYUI84v1V57yHPrFrHN6DdfRqfyhQnwthn1kF//dxZM4/edQCTjlHgy3zu1BaQzRhGF4lX9+udOLg0zFDSRNVLgTIwToHDzVMUZztPqKGDAJoLEurGdjnHkVOY7FrSIV3CW7r1uBkjwnxj1rq05vzrT2Tfkuvw7uy9KmaK8wEBxE3vU0uN82Hjzx6Jc2JW5/35dzgno8Nqiqsmk6cwltTQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: After the callbacks are registered we may immediately get a callback. So mark the device ready before registering the callbacks. Signed-off-by: David Hildenbrand --- drivers/virtio/virtio_mem.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/virtio/virtio_mem.c b/drivers/virtio/virtio_mem.c index b0b871441578..126f1d669bb0 100644 --- a/drivers/virtio/virtio_mem.c +++ b/drivers/virtio/virtio_mem.c @@ -2648,6 +2648,7 @@ static int virtio_mem_init_hotplug(struct virtio_mem *vm) if (rc) goto out_unreg_pm; + virtio_device_ready(vm->vdev); return 0; out_unreg_pm: unregister_pm_notifier(&vm->pm_notifier); @@ -2729,6 +2730,8 @@ static bool virtio_mem_vmcore_pfn_is_ram(struct vmcore_cb *cb, static int virtio_mem_init_kdump(struct virtio_mem *vm) { + /* We must be prepared to receive a callback immediately. */ + virtio_device_ready(vm->vdev); #ifdef CONFIG_PROC_VMCORE dev_info(&vm->vdev->dev, "memory hot(un)plug disabled in kdump kernel\n"); vm->vmcore_cb.pfn_is_ram = virtio_mem_vmcore_pfn_is_ram; @@ -2870,8 +2873,6 @@ static int virtio_mem_probe(struct virtio_device *vdev) if (rc) goto out_del_vq; - virtio_device_ready(vdev); - /* trigger a config update to start processing the requested_size */ if (!vm->in_kdump) { atomic_set(&vm->config_changed, 1); -- 2.47.1