From: <yang.yang29@zte.com.cn>
To: <jiang.kun2@zte.com.cn>
Cc: <bsingharora@gmail.com>, <david@redhat.com>,
<linux-kernel@vger.kernel.org>, <linux-mm@kvack.org>,
<linux-doc@vger.kernel.org>, <wang.yong12@zte.com.cn>,
<wang.yaxin@zte.com.cn>, <fan.yu9@zte.com.cn>,
<he.peilin@zte.com.cn>, <tu.qiang35@zte.com.cn>,
<qiu.yutan@zte.com.cn>, <zhang.yunkai@zte.com.cn>,
<ye.xingchen@zte.com.cn>, <xu.xin16@zte.com.cn>,
<akpm@linux-foundation.org>, <Liu.Jianjun3@zte.com.cn>,
<tan.hu@zte.com.cn>, <jiang.xuexin@zte.com.cn>
Subject: Re: [PATCH linux next] delayacct: add delay max to record delay peak
Date: Wed, 4 Dec 2024 09:43:21 +0800 (CST) [thread overview]
Message-ID: <20241204094321160yp9RJKElKXTlg-q1OzYU-@zte.com.cn> (raw)
In-Reply-To: <20241203170816.3fe81941fe1866ca1672eba8@linux-foundation.org>
On Tue, 3 Dec 2024 16:48:48 +0800 (CST) <jiang.kun2@zte.com.cn> wrote:
> From: Wang Yaxin <wang.yaxin@zte.com.cn>
> the 'delay max' can display delay peak since the system's startup
What about also add 'delay min' ? This could help us get to know how
large the difference is between min and max, provide clues for optimizing
potential. This is also some benchmark tools do, like stream which print:
precision of your system timer.
-------------------------------------------------------------
Function Best Rate MB/s Avg time Min time Max time
Copy: 234195.8 0.073357 0.073357 0.073357
Scale: 163856.6 0.104847 0.104847 0.104847
Add: 177791.5 0.144944 0.144944 0.144944
And please also update Documentation/accounting/delay-accounting.rst.
Other parts LGTM, thanks!
next prev parent reply other threads:[~2024-12-04 1:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-03 8:48 jiang.kun2
2024-12-04 1:08 ` Andrew Morton
2024-12-04 1:43 ` yang.yang29 [this message]
2024-12-05 11:10 yaxin_wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241204094321160yp9RJKElKXTlg-q1OzYU-@zte.com.cn \
--to=yang.yang29@zte.com.cn \
--cc=Liu.Jianjun3@zte.com.cn \
--cc=akpm@linux-foundation.org \
--cc=bsingharora@gmail.com \
--cc=david@redhat.com \
--cc=fan.yu9@zte.com.cn \
--cc=he.peilin@zte.com.cn \
--cc=jiang.kun2@zte.com.cn \
--cc=jiang.xuexin@zte.com.cn \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=qiu.yutan@zte.com.cn \
--cc=tan.hu@zte.com.cn \
--cc=tu.qiang35@zte.com.cn \
--cc=wang.yaxin@zte.com.cn \
--cc=wang.yong12@zte.com.cn \
--cc=xu.xin16@zte.com.cn \
--cc=ye.xingchen@zte.com.cn \
--cc=zhang.yunkai@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox