From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 173FAE6C5E5 for ; Tue, 3 Dec 2024 02:04:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4CD8D6B007B; Mon, 2 Dec 2024 21:04:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 47DC96B0083; Mon, 2 Dec 2024 21:04:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2F7C76B0085; Mon, 2 Dec 2024 21:04:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 11FCC6B007B for ; Mon, 2 Dec 2024 21:04:42 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 7323BADD18 for ; Tue, 3 Dec 2024 02:04:41 +0000 (UTC) X-FDA: 82852003836.29.E5AAE0B Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) by imf16.hostedemail.com (Postfix) with ESMTP id EA25D180006 for ; Tue, 3 Dec 2024 02:04:25 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=VNa0jKt5; spf=pass (imf16.hostedemail.com: domain of lkp@intel.com designates 192.198.163.12 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733191467; a=rsa-sha256; cv=none; b=vZQQe/xYZ1L585hBH1IXRDjreVgPWKKV63K6Qn72dELUDQXsf06ykk4m4H2uP1psGSkqd4 spJgTDZMzIFlIsjk2BiUsNsSJLPSUUvWXsyRSPEQqeiyKAh6kPyIgNusRWzUNHz1vYGipr skRVWIpiPPwlWwqbg87/HzUnALAxQ7E= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=VNa0jKt5; spf=pass (imf16.hostedemail.com: domain of lkp@intel.com designates 192.198.163.12 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733191467; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=73Od7IJ06PKunxrJA1W+tTtE0cK0LCmW0fZlA8h2MDA=; b=jOSJRBjWc5Jqo+zUhCdB2VdBn4uAOith4qtT+gn6+7nonLlqDi/cLcb2T50PdyJVzHjMRP lp003mDzh4vecki37anQSOgsrtsg7iu9wn+j6EOagIrBZW2UmUQLfXtJB83Jary0nWYWRD ASDDRKQRJkLXUk3bp/YM2kzFafcXbSI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1733191479; x=1764727479; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=xr/4Fwe3ocV4wZZiAFhod7Jm8urk9+EfI8yGAVuF37g=; b=VNa0jKt5yIgx5WAo0ISp6PECrPU0JZuLDTCGsWLtA/e2mHd6kaGb9aY5 fddsMMJnvBZFt++543ERL7Slks/AIsvUuDMIKDheogX+Xkm1imzB6H+s0 aM/ewf3CL14zO6a6p1UXYltVCUz1Q0XKuOML6XhK3AbXGwMBjKaSGZuv8 X718axghyZp06+PIl+XehJbx3G4fx9zsfIHv4ByWqyvWGKnTjboM6+zz3 HbUO4olQFNp78PsqFfn0SadXtdMh1eERHbX5yh6fk4PstkhOYG9oDOoPO 7O+LgNarK6OokWShMo524td0aZvw5cKtup/lCV4r/Yyr/6a3xbL8+FV8z g==; X-CSE-ConnectionGUID: aPVLt97QQO25iIo6NOVhsw== X-CSE-MsgGUID: E/DOhlCpQri7E3rJWlvRWA== X-IronPort-AV: E=McAfee;i="6700,10204,11274"; a="37322924" X-IronPort-AV: E=Sophos;i="6.12,204,1728975600"; d="scan'208";a="37322924" Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Dec 2024 18:04:36 -0800 X-CSE-ConnectionGUID: aScvZaJLTd+RglbCgCMfZQ== X-CSE-MsgGUID: hRGf8/VbQPCFJUIqz3AgLA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,204,1728975600"; d="scan'208";a="98057774" Received: from lkp-server02.sh.intel.com (HELO 36a1563c48ff) ([10.239.97.151]) by fmviesa004.fm.intel.com with ESMTP; 02 Dec 2024 18:04:33 -0800 Received: from kbuild by 36a1563c48ff with local (Exim 4.96) (envelope-from ) id 1tIIGw-00039h-1H; Tue, 03 Dec 2024 02:04:23 +0000 Date: Tue, 3 Dec 2024 10:03:57 +0800 From: kernel test robot To: Kairui Song , linux-mm@kvack.org Cc: oe-kbuild-all@lists.linux.dev, Andrew Morton , Linux Memory Management List , Chris Li , Hugh Dickins , "Huang, Ying" , Yosry Ahmed , Roman Gushchin , Shakeel Butt , Johannes Weiner , Barry Song , Michal Hocko , linux-kernel@vger.kernel.org, Kairui Song Subject: Re: [PATCH 1/4] mm, memcontrol: avoid duplicated memcg enable check Message-ID: <202412030915.jyKBIDck-lkp@intel.com> References: <20241202184154.19321-2-ryncsn@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241202184154.19321-2-ryncsn@gmail.com> X-Rspamd-Queue-Id: EA25D180006 X-Stat-Signature: sg1mkxgo7cj6hj1o1zmiokamfdczqwf6 X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1733191465-168871 X-HE-Meta: U2FsdGVkX1++49T3uE1i2prg+KJZSB3sDQ+e6S03s8Zj3F3zTF2ER2yMWY1CQfEAGt7SjwD3CTwKMAdOQuqFPXiGiMyxGGBhup4oSMKvauFa9ATBh0KnxxAxygbrYVsu1b5kofmJBYtYkg4u6TlSIUcMjUw3FTDPyAb+StADJd+XpQg9vmDw/Lv84+RQPxkZokqqKaEfssNAen9lUzqAbBOIjj69cu+Gd84b8q/W1vjowSnF2pWXXe7BsheeAHZxy2pFJF1JIigRPT/b41JLi6WuRlo5s9EPuekF/eziepOhcrhy0Bl1Gphu3ge8pGaY84y2Asb0i4eaGsTlijDBF0lRYoZGS/DT7su4W4p/Clt99m2b5jpHzAWXX+MFQwwehre4xgPhMq7vOX0hfQhDCC8gmBbP5QI09YpXGVfCy2F5VE44mIaNUy6gxzeI8oTl6NOboBPhuAqz5Ap159rYnNF+Y+6ZTX7cLkpNTYbPDcEAE112lGFyeFy5ZvAy0tAwPMXoI3x/bDiYf0xWM9sNmtZWeItCOKUWyBWqhhwbh3ypnoVB61gQTmmt/4bRvXODlCoLk83JZR6xun0Wa9iG0w2zdnCH8uMkqqhYnGpljj5ZX6iNBeD8MPeHcO3cL02808ySh9LF16l0tclcuOTVE8nhLKs3XEdHN1H4MR1GRbc6iR4rwvw7hyX4RJ/hBHlr+lL7+e0N2WL4tLKO3Id3n40wncARc3DB/Mp1E/7e1EWo0zhb21nrZ70RduOmG5rrjbdpXASIS5and0buKTNA1+F/LMWwAtU6UeouXmB+BqwcBpxQtQWCKdEeI2pkSoaA7L++D1OrEKe70vAfJN1ZqVDFvU5bKMXgMexy0shC7tPxyQeOHYL/eVNb+umBkecjqEV1gIwt/ty9CeunDeK09OpAe2fOjiAoFXjscFFA8bK1g+qNVAjSZFxDHOaNwriPaqJN+hQKGs0GjPCXzAt sToWuyq8 A16JdWggSR3G3N8TnVL0ZVU94d05BCARdhfPT4YFwvLYlyd5iPFSuBy3IuDiOG/R0OHHfTz6iBE5DXhqOkejuRsEI5rfHUWL3nX6WaOgZLYsUvAQ6q4r6YMluaGiSgWmBaFh+rgk/q1S1dbwHTsU1DswK5GWKiLNXCpRzDMTW4xoCuJo1Y1YqlblIGnurruSuAMPOnNy5D3I+ZRdpWsBI+TO+Qv2zCAGxr1hsKagF+aLoR/vErDaodazDBq+X4Thm9oe8rHN3+LC+/d5M2fCBgLUDsDH/PVj+DIagrs1/sTGjStxwrXFe4NQjdrLvNPwZSn/+qYmBDZG0Sd72gpmUeQtAl48i3Xd760bb X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Kairui, kernel test robot noticed the following build errors: [auto build test ERROR on akpm-mm/mm-everything] url: https://github.com/intel-lab-lkp/linux/commits/Kairui-Song/mm-memcontrol-avoid-duplicated-memcg-enable-check/20241203-024957 base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything patch link: https://lore.kernel.org/r/20241202184154.19321-2-ryncsn%40gmail.com patch subject: [PATCH 1/4] mm, memcontrol: avoid duplicated memcg enable check config: arm-randconfig-002-20241203 (https://download.01.org/0day-ci/archive/20241203/202412030915.jyKBIDck-lkp@intel.com/config) compiler: arm-linux-gnueabi-gcc (GCC) 14.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241203/202412030915.jyKBIDck-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202412030915.jyKBIDck-lkp@intel.com/ All errors (new ones prefixed by >>): mm/memcontrol.c: In function 'mem_cgroup_swapin_uncharge_swap': >> mm/memcontrol.c:4618:17: error: implicit declaration of function '__mem_cgroup_uncharge_swap'; did you mean 'mem_cgroup_uncharge_swap'? [-Wimplicit-function-declaration] 4618 | __mem_cgroup_uncharge_swap(entry, nr_pages); | ^~~~~~~~~~~~~~~~~~~~~~~~~~ | mem_cgroup_uncharge_swap vim +4618 mm/memcontrol.c 4587 4588 /* 4589 * mem_cgroup_swapin_uncharge_swap - uncharge swap slot 4590 * @entry: the first swap entry for which the pages are charged 4591 * @nr_pages: number of pages which will be uncharged 4592 * 4593 * Call this function after successfully adding the charged page to swapcache. 4594 * 4595 * Note: This function assumes the page for which swap slot is being uncharged 4596 * is order 0 page. 4597 */ 4598 void mem_cgroup_swapin_uncharge_swap(swp_entry_t entry, unsigned int nr_pages) 4599 { 4600 /* 4601 * Cgroup1's unified memory+swap counter has been charged with the 4602 * new swapcache page, finish the transfer by uncharging the swap 4603 * slot. The swap slot would also get uncharged when it dies, but 4604 * it can stick around indefinitely and we'd count the page twice 4605 * the entire time. 4606 * 4607 * Cgroup2 has separate resource counters for memory and swap, 4608 * so this is a non-issue here. Memory and swap charge lifetimes 4609 * correspond 1:1 to page and swap slot lifetimes: we charge the 4610 * page to memory here, and uncharge swap when the slot is freed. 4611 */ 4612 if (!mem_cgroup_disabled() && do_memsw_account()) { 4613 /* 4614 * The swap entry might not get freed for a long time, 4615 * let's not wait for it. The page already received a 4616 * memory+swap charge, drop the swap entry duplicate. 4617 */ > 4618 __mem_cgroup_uncharge_swap(entry, nr_pages); 4619 } 4620 } 4621 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki