* Re: [PATCH 5/6] pps: embed "dev" in the pps_device
[not found] <20241202163451.1442566-6-mschmidt@redhat.com>
@ 2024-12-03 1:02 ` kernel test robot
2024-12-03 2:04 ` kernel test robot
1 sibling, 0 replies; 2+ messages in thread
From: kernel test robot @ 2024-12-03 1:02 UTC (permalink / raw)
To: Michal Schmidt, Rodolfo Giometti
Cc: oe-kbuild-all, Uwe =?unknown-8bit?Q?Kleine-K=C3=B6nig?=,
Greg Kroah-Hartman, Christophe JAILLET, Dr. David Alan Gilbert,
Ma Ke, Andrew Morton, Linux Memory Management List,
George Spelvin, linux-kernel
Hi Michal,
kernel test robot noticed the following build errors:
[auto build test ERROR on 7af08b57bcb9ebf78675c50069c54125c0a8b795]
url: https://github.com/intel-lab-lkp/linux/commits/Michal-Schmidt/pps-fix-cdev-use-after-free/20241203-025037
base: 7af08b57bcb9ebf78675c50069c54125c0a8b795
patch link: https://lore.kernel.org/r/20241202163451.1442566-6-mschmidt%40redhat.com
patch subject: [PATCH 5/6] pps: embed "dev" in the pps_device
config: arm-randconfig-002-20241203 (https://download.01.org/0day-ci/archive/20241203/202412030824.tmsDhCFT-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241203/202412030824.tmsDhCFT-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202412030824.tmsDhCFT-lkp@intel.com/
All errors (new ones prefixed by >>):
In file included from include/linux/device.h:15,
from include/linux/cdev.h:8,
from include/linux/pps_kernel.h:12,
from drivers/pps/clients/pps-ktimer.c:15:
drivers/pps/clients/pps-ktimer.c: In function 'pps_ktimer_exit':
>> drivers/pps/clients/pps-ktimer.c:59:21: error: incompatible type for argument 1 of '_dev_info'
59 | dev_info(pps->dev, "ktimer PPS source unregistered\n");
| ~~~^~~~~
| |
| struct device
include/linux/dev_printk.h:110:25: note: in definition of macro 'dev_printk_index_wrap'
110 | _p_func(dev, fmt, ##__VA_ARGS__); \
| ^~~
drivers/pps/clients/pps-ktimer.c:59:9: note: in expansion of macro 'dev_info'
59 | dev_info(pps->dev, "ktimer PPS source unregistered\n");
| ^~~~~~~~
include/linux/dev_printk.h:95:37: note: expected 'const struct device *' but argument is of type 'struct device'
95 | void _dev_info(const struct device *dev, const char *fmt, ...)
| ~~~~~~~~~~~~~~~~~~~~~^~~
drivers/pps/clients/pps-ktimer.c: In function 'pps_ktimer_init':
drivers/pps/clients/pps-ktimer.c:77:21: error: incompatible type for argument 1 of '_dev_info'
77 | dev_info(pps->dev, "ktimer PPS source registered\n");
| ~~~^~~~~
| |
| struct device
include/linux/dev_printk.h:110:25: note: in definition of macro 'dev_printk_index_wrap'
110 | _p_func(dev, fmt, ##__VA_ARGS__); \
| ^~~
drivers/pps/clients/pps-ktimer.c:77:9: note: in expansion of macro 'dev_info'
77 | dev_info(pps->dev, "ktimer PPS source registered\n");
| ^~~~~~~~
include/linux/dev_printk.h:95:37: note: expected 'const struct device *' but argument is of type 'struct device'
95 | void _dev_info(const struct device *dev, const char *fmt, ...)
| ~~~~~~~~~~~~~~~~~~~~~^~~
vim +/_dev_info +59 drivers/pps/clients/pps-ktimer.c
697fb85fcf21b5 Rodolfo Giometti 2010-03-10 52
697fb85fcf21b5 Rodolfo Giometti 2010-03-10 53 /*
697fb85fcf21b5 Rodolfo Giometti 2010-03-10 54 * Module staff
697fb85fcf21b5 Rodolfo Giometti 2010-03-10 55 */
697fb85fcf21b5 Rodolfo Giometti 2010-03-10 56
697fb85fcf21b5 Rodolfo Giometti 2010-03-10 57 static void __exit pps_ktimer_exit(void)
697fb85fcf21b5 Rodolfo Giometti 2010-03-10 58 {
5e196d34a77642 Alexander Gordeev 2011-01-12 @59 dev_info(pps->dev, "ktimer PPS source unregistered\n");
697fb85fcf21b5 Rodolfo Giometti 2010-03-10 60
5e196d34a77642 Alexander Gordeev 2011-01-12 61 del_timer_sync(&ktimer);
5e196d34a77642 Alexander Gordeev 2011-01-12 62 pps_unregister_source(pps);
697fb85fcf21b5 Rodolfo Giometti 2010-03-10 63 }
697fb85fcf21b5 Rodolfo Giometti 2010-03-10 64
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH 5/6] pps: embed "dev" in the pps_device
[not found] <20241202163451.1442566-6-mschmidt@redhat.com>
2024-12-03 1:02 ` [PATCH 5/6] pps: embed "dev" in the pps_device kernel test robot
@ 2024-12-03 2:04 ` kernel test robot
1 sibling, 0 replies; 2+ messages in thread
From: kernel test robot @ 2024-12-03 2:04 UTC (permalink / raw)
To: Michal Schmidt, Rodolfo Giometti
Cc: llvm, oe-kbuild-all, Uwe =?unknown-8bit?Q?Kleine-K=C3=B6nig?=,
Greg Kroah-Hartman, Christophe JAILLET, Dr. David Alan Gilbert,
Ma Ke, Andrew Morton, Linux Memory Management List,
George Spelvin, linux-kernel
Hi Michal,
kernel test robot noticed the following build errors:
[auto build test ERROR on 7af08b57bcb9ebf78675c50069c54125c0a8b795]
url: https://github.com/intel-lab-lkp/linux/commits/Michal-Schmidt/pps-fix-cdev-use-after-free/20241203-025037
base: 7af08b57bcb9ebf78675c50069c54125c0a8b795
patch link: https://lore.kernel.org/r/20241202163451.1442566-6-mschmidt%40redhat.com
patch subject: [PATCH 5/6] pps: embed "dev" in the pps_device
config: i386-buildonly-randconfig-005-20241203 (https://download.01.org/0day-ci/archive/20241203/202412030942.aHisJx3i-lkp@intel.com/config)
compiler: clang version 19.1.3 (https://github.com/llvm/llvm-project ab51eccf88f5321e7c60591c5546b254b6afab99)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241203/202412030942.aHisJx3i-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202412030942.aHisJx3i-lkp@intel.com/
All errors (new ones prefixed by >>):
>> drivers/pps/clients/pps-ktimer.c:59:11: error: passing 'struct device' to parameter of incompatible type 'const struct device *'; take the address with &
59 | dev_info(pps->dev, "ktimer PPS source unregistered\n");
| ^~~~~~~~
| &
include/linux/dev_printk.h:160:46: note: expanded from macro 'dev_info'
160 | dev_printk_index_wrap(_dev_info, KERN_INFO, dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~
include/linux/dev_printk.h:110:11: note: expanded from macro 'dev_printk_index_wrap'
110 | _p_func(dev, fmt, ##__VA_ARGS__); \
| ^~~
include/linux/dev_printk.h:56:37: note: passing argument to parameter 'dev' here
56 | void _dev_info(const struct device *dev, const char *fmt, ...);
| ^
drivers/pps/clients/pps-ktimer.c:77:11: error: passing 'struct device' to parameter of incompatible type 'const struct device *'; take the address with &
77 | dev_info(pps->dev, "ktimer PPS source registered\n");
| ^~~~~~~~
| &
include/linux/dev_printk.h:160:46: note: expanded from macro 'dev_info'
160 | dev_printk_index_wrap(_dev_info, KERN_INFO, dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~
include/linux/dev_printk.h:110:11: note: expanded from macro 'dev_printk_index_wrap'
110 | _p_func(dev, fmt, ##__VA_ARGS__); \
| ^~~
include/linux/dev_printk.h:56:37: note: passing argument to parameter 'dev' here
56 | void _dev_info(const struct device *dev, const char *fmt, ...);
| ^
2 errors generated.
vim +59 drivers/pps/clients/pps-ktimer.c
697fb85fcf21b5 Rodolfo Giometti 2010-03-10 52
697fb85fcf21b5 Rodolfo Giometti 2010-03-10 53 /*
697fb85fcf21b5 Rodolfo Giometti 2010-03-10 54 * Module staff
697fb85fcf21b5 Rodolfo Giometti 2010-03-10 55 */
697fb85fcf21b5 Rodolfo Giometti 2010-03-10 56
697fb85fcf21b5 Rodolfo Giometti 2010-03-10 57 static void __exit pps_ktimer_exit(void)
697fb85fcf21b5 Rodolfo Giometti 2010-03-10 58 {
5e196d34a77642 Alexander Gordeev 2011-01-12 @59 dev_info(pps->dev, "ktimer PPS source unregistered\n");
697fb85fcf21b5 Rodolfo Giometti 2010-03-10 60
5e196d34a77642 Alexander Gordeev 2011-01-12 61 del_timer_sync(&ktimer);
5e196d34a77642 Alexander Gordeev 2011-01-12 62 pps_unregister_source(pps);
697fb85fcf21b5 Rodolfo Giometti 2010-03-10 63 }
697fb85fcf21b5 Rodolfo Giometti 2010-03-10 64
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 2+ messages in thread