From: Dafna Hirschfeld <dafna.hirschfeld@intel.com>
To: linux-mm@kvack.org
Cc: muchun.song@linux.dev, akpm@linux-foundation.org,
Dafna Hirschfeld <dafna.hirschfeld@intel.com>
Subject: [PATCH] mm/hugetlb: change ENOSPC to ENOMEM in alloc_hugetlb_folio
Date: Sun, 1 Dec 2024 03:03:41 +0200 [thread overview]
Message-ID: <20241201010341.1382431-1-dafna.hirschfeld@intel.com> (raw)
The error ENOSPC is translated in vmf_error to VM_FAULT_SIGBUS which is
further translated in EFAULT in i.e. pin/get_user_pages.
But when running out of pages/hugepages we expect to see ENOMEM and
not EFAULT.
Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@intel.com>
---
mm/hugetlb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/hugetlb.c b/mm/hugetlb.c
index cec4b121193f..5c8de0f5c760 100644
--- a/mm/hugetlb.c
+++ b/mm/hugetlb.c
@@ -3113,7 +3113,7 @@ struct folio *alloc_hugetlb_folio(struct vm_area_struct *vma,
if (!memcg_charge_ret)
mem_cgroup_cancel_charge(memcg, nr_pages);
mem_cgroup_put(memcg);
- return ERR_PTR(-ENOSPC);
+ return ERR_PTR(-ENOMEM);
}
int alloc_bootmem_huge_page(struct hstate *h, int nid)
--
2.34.1
next reply other threads:[~2024-12-01 1:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-01 1:03 Dafna Hirschfeld [this message]
2024-12-01 2:51 ` Andrew Morton
2024-12-14 9:18 ` Alexander Gordeev
2024-12-01 11:49 ` Matthew Wilcox
2024-12-02 3:49 ` Muchun Song
2024-12-02 6:02 ` Dafna Hirschfeld
2024-12-02 6:06 ` Dafna Hirschfeld
2024-12-08 5:20 ` Dafna Hirschfeld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241201010341.1382431-1-dafna.hirschfeld@intel.com \
--to=dafna.hirschfeld@intel.com \
--cc=akpm@linux-foundation.org \
--cc=linux-mm@kvack.org \
--cc=muchun.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox