From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FCDBD70E0E for ; Sun, 1 Dec 2024 06:59:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BBB246B0082; Sun, 1 Dec 2024 01:59:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B6B246B0083; Sun, 1 Dec 2024 01:59:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A32FC6B0085; Sun, 1 Dec 2024 01:59:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 786AE6B0082 for ; Sun, 1 Dec 2024 01:59:57 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id E8E04AE012 for ; Sun, 1 Dec 2024 06:59:56 +0000 (UTC) X-FDA: 82845489930.01.5204ECC Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf17.hostedemail.com (Postfix) with ESMTP id 6221F40011 for ; Sun, 1 Dec 2024 06:59:47 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=nca0ZPjl; spf=pass (imf17.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733036384; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=COhLuRydHQlYs5y9STNUkB305slOTETnQnEhklTaeEI=; b=KoyLfISXG+3rI7f0hQO7a0kiDo07rtChLPdj4+kM5kxqRjIXIBdcVd2JAv6y7Skhhjsa/Z R0b9v2tPrMfnr//SbWK761vSRG/ZKVthrrBJ3QV4TusoOarfIqahxPpeK4iNTp5FlkcenY a4afKscwS1ysmAZgani9eroS2lnq6Vs= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733036384; a=rsa-sha256; cv=none; b=nYe1HRwN/cv1B3xbQOXx/hL86rIM0EH9YgFXMArrwap+4aFk/Y+/QSzCv2KCF081Sb+2Qe 1tUY8qX2+VxyBlKMtqD1O0QUjjwSNBlJiGM/cRcMeEHJHUYLweMyStbbDwpeS3GEvVKtA+ 744dBacG+sqFBZAheJPZxbi6OvtfO9g= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=nca0ZPjl; spf=pass (imf17.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 548D55C5D46; Sun, 1 Dec 2024 06:59:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D31BBC4CECF; Sun, 1 Dec 2024 06:59:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1733036394; bh=gYLJdRFK4oBa/CZ9J3uxe9m9yhUdD2Er/DAuyttmBGk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=nca0ZPjl9wwSpanyfQgFWWkyXkWFnXDJFtEpy4gwA45jLjRcbrdnkfr3vsTexIrpi B8+YbZnbXRk30JjnB3RtEyvSd7WSwzvPvJ8JxmBfK9gWRLM0tx88nohS/SxlK2/r57 EQU8v6CMeha6U2jC+xZYQST/eQadpg1bwp52fdD8= Date: Sat, 30 Nov 2024 22:59:53 -0800 From: Andrew Morton To: Miaohe Lin Cc: David Hildenbrand , , , Subject: Re: [PATCH] mm/memory-failure: fix VM_BUG_ON_PAGE(PagePoisoned(page)) when unpoison memory Message-Id: <20241130225953.dbb95dbf5f6c785e931f45f7@linux-foundation.org> In-Reply-To: <0519bf4b-49aa-6b81-a041-362a171b2a5e@huawei.com> References: <20240712064249.3882707-1-linmiaohe@huawei.com> <20240712140921.9aa90b18d22e67417d59dfc1@linux-foundation.org> <8fe349f9-d3d3-65ab-6045-da0bd19249ea@huawei.com> <00e18339-d911-4332-8732-e31bcecbf823@redhat.com> <5f8107e2-2b37-d899-f7f2-5a6093d8b089@huawei.com> <0519bf4b-49aa-6b81-a041-362a171b2a5e@huawei.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 6221F40011 X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: w1u8wk7q5fqoh1wist363k4gghk55pq8 X-HE-Tag: 1733036387-214649 X-HE-Meta: U2FsdGVkX18dyY0ds0nUlVulsHjRrXj2k8123upiobSct0CIIi+kBCV0N4/vWV0BLwVvQn9q7arsrirhBi+DlbvcG/BSzSUWUx3LXtEhzvkTE26DYOBIEu7GoRRsva4rDoVKNhgSBgVe+BAJ/4km5X4YFFXm8x8KUQ6qZ3/ssex36OTAECzyOLCtNFDqdxCpCiYDnzfLNFw4LLN6eYWY1/x+Rs9bpxnMcWPOQBKoj31bFMcJ6qGpBGOrY+ai0lfhwhQcrYdPB6K4hMIOpe2UTxJX/QH66DrZ+WZ6A+TfKFN+yN0z2kzaZPsZz0+pr/l9pg7JNEPk44TA4AWdosRxnOVt79wTRl/U5QwwSCLEw2+W5gnxePmSFZTOth8fDcOdO9+FOl87hsv3q5TZL+8ZO5zqVrNi0L/QF6vFlKSwiRK8oaLD3xFQx5AnXzIod21r3rlCqSYyqDqwX0zDWfOXOcdhFD9RZincTB746Od0OmChtI1L+Qkk3DJL67Bu5GcMMiQiGOQ7eg7DE98iAd/aUWOVOWDF4dMXAnwxoqMgNA/cPelMQ2WxoV/QKxtiAi0ZLnge2G31QLTXak+ozSk46UXci63UcdGPQ9N/NHBD3OYOPPZv39fkjZYJ/EFLcCSouyl+OdnSt59XGjl5AgTNbQ50p5W+Gm/oB//mOsPSGyjD1R27q67Jf+ErJOghX/rdkI2jnTyjq1+mL8EmXoFRj8eejiXOHCOtQ3SP6sSWdJB1HK2C0f0OW1X4pW1RX3juEkgCU6fq1EfhlsrV30UDtRx3buA3/Oz4bpYl2MrO9g3NN5w7KTf8qVy2MQ9fAmtQReV7lrgExHGhsAZvBXV+b1+yGGXxhTRmdebPFZGBy8Y0WXeXGB6SuHZT3L896QUCI9+k5RUktn3S+N5rgqD5Ty8Hx+RKE27ELVDJqTgrFzp4IPphEE12fmG0lTATzmnRQjqAnckPIkfiYLPTL1V 19hCDWIz u4b7oMYsf2HVjp9H/N78MyR7tD5zFQPR8fQmSu+H8cRmQirgCzn/pVX4azoTL8uYxicqxrIb3b0msDa1KlSGxy+QgufUqal+TJpr+5M8r8dkLOEOCfW/cU3r6stZqpS6GfuNrJHS/s8c8NotI0s+2TrQ0hLK91bZbvN0hsHiVq77417+rdi6u6p2roL1t4V4Omv+A34ivbCmF1Bmq8T+q/ouEpRCWZRaTt/DHamDKdahd8bOxrPUNnEdJgTXxy+U5E+UY2AwkTIRkATeAdUPm8rDSRuutoqYA6YN+gOfu0L0ezshPIbeFpPmdJRmkTCS9ZMrAbLiBeALZRJ7tP6NGADOusU4MKCycxFU2NQPsZxhOXiKWn8az/nmMdnowvV+d32r4dq7Dz8UGtL0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 5 Aug 2024 14:25:14 +0800 Miaohe Lin wrote: > >>>> Yup, this will be a good alternative. But will it be better to simply check PagePoisoned() instead? > >>> > >>> The memmap of offline memory sections shall not be touched, so .... don't touch it ;) > >>> > >>> Especially because that PagePoisoned() check is non-sensical without poisoining-during-memmap-init. You would still work with memory in offline sections. > >>> > >>> I think the code is even wrong in that regard: we allow for memory offlining to work with HWPoisoned pages, see __offline_isolated_pages(). Staring at unpoison_memory(), we might be putting these pages back to the buddy? Which is completely wrong. > >> > >> I agree with you. Thanks for detailed explanation. :) > >> Thanks David. > > > > So ... I assume there will be a new patch? :) > > I was just back from my two-weeks holidays. ;) I will try to send a new version when possible. Maybe I missed the v2. I'll drop this v1 patch.