From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00B43D729FB for ; Sun, 1 Dec 2024 06:44:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AC5306B0082; Sun, 1 Dec 2024 01:44:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A4DA36B0083; Sun, 1 Dec 2024 01:44:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8EE066B0085; Sun, 1 Dec 2024 01:44:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 6ED856B0082 for ; Sun, 1 Dec 2024 01:44:25 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id B81C3120BA1 for ; Sun, 1 Dec 2024 06:44:24 +0000 (UTC) X-FDA: 82845450954.22.AE4BB2C Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf24.hostedemail.com (Postfix) with ESMTP id DE7DF180005 for ; Sun, 1 Dec 2024 06:44:21 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b="ExKz/JwC"; dmarc=none; spf=pass (imf24.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733035458; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vn21W/Ys5i+hOkBCo2Okoqrz1iSmGOZAw76rBEq3CNA=; b=lVxZ3UhOEBOUJC9MjuG0L2pb1+rtKyC4K+V7gJMgH3JGKGuFZAhCaxcrWXGEkMcDbxjno1 RMH20x9C5OCHKZD/Wk5x4gfErle7vWTOGvP2DOQS0w80nD7xCBfhCXeCm+X2bELNLD1yxD nCcxntYz/YsEuh1eg62Th1Jk8MuCgE8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733035458; a=rsa-sha256; cv=none; b=ZFuvkg1J5sJxVKJB1c7wgjq3AKRjDaWLML922KFNn+CcX8QvrrbEeL3v8vg43FD5NYIbyn wVx3oKO1vdzMlUIBOzdZBxJiSYvy++e/6Jpdi/cHUD/KXhEK00y8cZhLOn0gAu+S4jttA7 /CGUeeGgCxcM66RbSgNXjOTh2dtsU2M= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b="ExKz/JwC"; dmarc=none; spf=pass (imf24.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 77E3CA40342; Sun, 1 Dec 2024 06:42:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8A0C3C4CECF; Sun, 1 Dec 2024 06:44:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1733035461; bh=gsnpeJtjLe4QariqBC9pm0OX3G9e3PnVJM/Uc6pmVrE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ExKz/JwCpE+Xrzq2DA+WFew2zJaxqm0cZF7AI5zJwwTd5dkgFM/RXyykUx8Iymymq UrTVq+rtFgnzNdtZBC/LHc8BmiOnDdzeH4JtQw95zpeozzdimitIsboB3Hq2KJwCXh NdA3C7tunDSR1d8GEAJy1PzJSnrSiFOBg33kFCXs= Date: Sat, 30 Nov 2024 22:44:19 -0800 From: Andrew Morton To: Peter Zijlstra Cc: Suren Baghdasaryan , Wei Yang , andrii@kernel.org, jannh@google.com, Liam.Howlett@oracle.com, lorenzo.stoakes@oracle.com, vbabka@suse.cz, mhocko@kernel.org, shakeel.butt@linux.dev, hannes@cmpxchg.org, david@redhat.com, willy@infradead.org, brauner@kernel.org, oleg@redhat.com, arnd@arndb.de, zhangpeng.00@bytedance.com, linmiaohe@huawei.com, viro@zeniv.linux.org.uk, hca@linux.ibm.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 3/3] mm: introduce mmap_lock_speculate_{try_begin|retry} Message-Id: <20241130224419.80c06e9458defceb2a4949ec@linux-foundation.org> In-Reply-To: <20241125165357.GA16789@noisy.programming.kicks-ass.net> References: <20241122174416.1367052-1-surenb@google.com> <20241122174416.1367052-3-surenb@google.com> <20241125005804.libwzfcz6d5zeyi4@master> <20241125165357.GA16789@noisy.programming.kicks-ass.net> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Stat-Signature: c3so56y7peu8az547q7ceoqs9gpy3oo1 X-Rspamd-Queue-Id: DE7DF180005 X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1733035461-754569 X-HE-Meta: U2FsdGVkX19OxqUcrZk5A7RIwAlrlwt3sAJNhaqmPSU5dkm/k9SOflxXV9gdtUcXdaxlmkn6Wf3cBKuABxCq9i0OfJJuaKmjUMyghrwNyncyL8k/jPD3WH/h2qDYhtJf937XeGzPk8kSXcnd5S0u45q1MP4lmOizXaXqYtv+pf8i350qy8TfJT5jRSEdGkiW2sQLCDWvw0qbt9LBHOIo/0xtwffpO6txmf198GNHuS9TcPGN/ZCskgtuK6+s817Ju5f0KjzDw3P6Aka3YOGwzmm+HKDoCnMk+GrULBghlMKK+rdr5+h2gp0adHBRJscfKBRrVseO3SuYtsZ2qFIUPkwPq01A0wBNTdzVTsekrHX95ZV90LBTadDiU1RFYiUQY76ZCd9JR2qaWJzuIu1AwbH3Ofn8vykokxIfOrbMlpY2dU5IID1lrhk0o4ovS2k9HE58QRJA9l3WytUNRV9xpvJrNj6C9pb8IfzKtOzFZXBrlkOSaoxOo32HMKncbI7srsUKcDaY7xD7mbl8hbYGL38bnmMp6NMXBLDCdbyQKfP1YzsUUzNOWxklirZ5kvJCdMwgX2H5YCJutX88XT9ER7IcFUkOBaK691WwmVoMZIvVIaZf9k2kWrMPexahNBPRjXcaWeyuvqUElHbuewdSNv9uStOUo7Trv6JxwPkX0aw18cooI8+Xzz6lWhhrdQNMJw1varLbG3IvOylSpt9PBInFlI/C0gypW2C1oJJUdZW4yzDxjs35IYTTFuX2m4LTLm0oR2fUZCWMF9RV+tc1LicDwY5LQvfai0wO+0SVZrW0MPOcMeBGmtrneOpYACZ2rJ7TWABU09SMq9YECvFI02wa5xajWHexkMaFngl0/5krfW/ug/+eaMfhiMlzywtkEp96+3R/aewFQEIXkTvd3lHepZ8VcPZW4DRBDnvwNXA3++aqaxceQB8SP6g3HAyM5McSJgX20X/MTwM63tF H12A6Oxc Fe7MX375uyMK7oibPNVtzY2zzqyRsRZ+c8lCXU6G+lsQUdG/a7mR/QSS/BBG531pQlfelASzrS+HlOAfIj/9ICxUVUeG494AyrYkej1AqyBVYd/quTEDtiOQRIywSxzaV0d7wRm7sX0nykHS4+eleRaG4XAAhz4wzDHDa3GMixdH4UqSs+DrZpNiQaszpLsiRQ6KcrK+/N4b/C8vg5kwuHYaNSCEOikUsAT61PXbZYPx189IFZvuO45HrkDU38b5lUwT7lHWbT6vKvKaZkL+ApJ5AVvPxBrBua53YPNVMuyiKwcrCjlclEAUMILBS1dK5AtPiBLeD27oXvvIm4yzhuZFhaSW8k7RJgfMt0Bx/p38ADv1zE+d1r/bb7hH9lX4ghgVYzYzVRjcYzDlV3wyJrj6T6AdMofWJZj13U/C0kCfnr4I= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 25 Nov 2024 17:53:57 +0100 Peter Zijlstra wrote: > On Mon, Nov 25, 2024 at 08:18:38AM -0800, Suren Baghdasaryan wrote: > > > > >+static inline bool mmap_lock_speculate_retry(struct mm_struct *mm, unsigned int seq) > > > >+{ > > > >+ return do_read_seqcount_retry(&mm->mm_lock_seq, seq); > > > > > > Just curious why we don't use read_seqcount_retry(). > > > > > > Looks this is the only user outside seqlock.h. > > > > Ah, good eye! read_seqcount_retry() would be better. > > > > Peter, do you want me to post a new patchset or you can patch it when > > picking it up? > > Fixed up my local copy, thanks! I take this to mean that you'll be merging these. I don't see this series in -next and I'm sitting on the v1 series, which I shall now drop.