From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53766D7361D for ; Sun, 1 Dec 2024 02:51:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D21076B0082; Sat, 30 Nov 2024 21:51:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CD0FB6B0083; Sat, 30 Nov 2024 21:51:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BBFB66B0085; Sat, 30 Nov 2024 21:51:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 9E2276B0082 for ; Sat, 30 Nov 2024 21:51:25 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 319F0C0C98 for ; Sun, 1 Dec 2024 02:51:25 +0000 (UTC) X-FDA: 82844863878.18.C6B9CCA Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf03.hostedemail.com (Postfix) with ESMTP id DC11520010 for ; Sun, 1 Dec 2024 02:51:18 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=GRSRBQRm; spf=pass (imf03.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733021474; a=rsa-sha256; cv=none; b=yjZUL7YrMdp5qbKpA7JN5sPcLROGne4Vy7zYN43lWacJTduwp0R/rlO7oG2JEIcxq2zH2a yo89dA67K/HTYN7AD+proebVWHt4YOg1jNWF5kgIKfmHPDvm5UWF0nzHA2E4oukrK5fUeI ae6Ch1+xBSvnbnVqnhebJUe2BEKg32s= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=GRSRBQRm; spf=pass (imf03.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733021474; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=E/XaCn+jOAG7g5vVrVxRospMojGdtUbYG/i+yVHQvIE=; b=zg3zPfkQPkYHpELM3spgQ8FGQDimaxnXpnrzkjdlPQhTyfZ5lHz85Tjs3oEiGP6tQgKv8n YX+4iiN7BrnDxK2I96wxHjH0KpUYCu5w5Vj6/7PvCJbwqDG0KQ9L+ZgcexzKmtX5r6mq8J grmuI4D7Et0ucE53rIAEBR35Y/sPjYw= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 0709DA402AF; Sun, 1 Dec 2024 02:49:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1D712C4CECC; Sun, 1 Dec 2024 02:51:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1733021482; bh=15QmBWfC+pZXNHLL6gm+kiq7th9FLilk6eWP2VS8T+k=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=GRSRBQRmjGfq/Ptg0nxqu2ipO/DwZTLN22SA4fvm+VTjzhCGsZ6ictWzxYw4q/RV4 VKvKH4mHeaW/g3T+rjaK6iQ1eHtXZf4Al3PgHKEzy6GQTgjbMNQb44lhAEnro/UzZ8 EfiV0TtQsCNpqkPo27TzXmD5N1Vqx39CYefiCPvM= Date: Sat, 30 Nov 2024 18:51:21 -0800 From: Andrew Morton To: Dafna Hirschfeld Cc: linux-mm@kvack.org, muchun.song@linux.dev Subject: Re: [PATCH] mm/hugetlb: change ENOSPC to ENOMEM in alloc_hugetlb_folio Message-Id: <20241130185121.02da011be898052454116c4b@linux-foundation.org> In-Reply-To: <20241201010341.1382431-1-dafna.hirschfeld@intel.com> References: <20241201010341.1382431-1-dafna.hirschfeld@intel.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: DC11520010 X-Stat-Signature: dbhndcztuy1w55qr5szzfffqbw13n691 X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1733021478-128141 X-HE-Meta: U2FsdGVkX1+r4WJD/gDsD1jcBdYmTHaPbBnzLT9yWdNDUDrvWIu/c+gtOThT5uFP/ksO4DsMfu8nX9Jjc6Tlv3DT9iwRWk2NuXyNaVfKsg7d6akxCeMQO9JT23Nfy4sTFr20Ca5yrqs+KmuKAVdn1nvBzWOiomvxM95RYl/u5JDPWv3DR/hAPm1HIFk2ue9w7Dhg172I7/qBmzfMQmrbgfjIFZJt7HiSkRndhdu96xV3xFEW26dFpdSYOAnl1iIw1z0cux31PCXFKh5qU3lo5nZUjS0wmXT+ZoV3rcs4yKQOulW4dPkXHKU6CQW5Mjs2hc/yzs3HFEq8yAnTMPYtw3DgwzDej3nWMCyGx3L00EU4ejaQ30/9APst99KeV5v3pg23GQiHjdjtWwqNyDHBiXKoljnx7qib5/WI5g9gZPV1wNgw1cYA4rVhsEHa1k87/a/DehcdU1cq0z2N5zKguVzH0ICH770ZRgYdKbYlmcSJvo+PGvGaaTN9stuf3yfyzClZ1z0GhjobnPpSZsyfJwmIs82eVjXF+jHB8xsut9gPBCxodd54hT06xwG9VFD2J5A4zh6Vfn1vSUGtNCp/qhhOm4H7yyFKtbTXk6s4xzORDAdnKO9ZdrePdVNmU6yiiagqXkTEKvqTih9bJXMmGhllnhemO0hszohQnjZjSMkgKi75BxfGcGZgg6d9g4VI8RvXAumnGkrwPvtBJ3YSmeZuONBGGwh8eAg+7ugsV8L8NoT4Z6mSBuhP4un9c2rCkJnHR8i3t1z8P2Jkg4mHTSHUchS4hqNkjUUyt3qSyxvSIGVi/Vk8jNIJyi9IAQYgnClnDdUzMNYKDHBNflHq+Bl5HeoM5ejNGPYMbT9Vndfotz7jMtDW1oQI/lntHzgudI9ARk9+FyU16sYvjYN1sYS0lwVWZ+lLhLB2KNbILMCnT6nC3nX5H4kx0qUUYJ2Omc1VISkcFWUXfMnZCyb iIW944eZ F34mjO4aPi001T+ErU6lpZRNlZFUUyZCH1IZyJPHHS1+9SY/41D6Z2F/5cu1g1tv/1orPisUUfd58PD2DrG2pnB4pWDN+fAnTRmGyLUU8TIbIpq1fRbxi51z7jbeOyMI3R8kGTYq9brYerkVlwLFuUR2Z5nKmZWT88bIWT9R0Gzv+g2R6sC9Zy6mIm9wurxTfYARBxxyz8ojh/AgOdWXKxAvXAPesTYDSJmj1pusKXdd7IL0rOk9GPHiCuIsnCPyG+UVw5SovZ+0vL4BU/n8Rq+fmulHrr+Pi+3Nv1F4ZwaM9cAFkN3mA3S9HOhn9/ZF+j2JY X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, 1 Dec 2024 03:03:41 +0200 Dafna Hirschfeld wrote: > The error ENOSPC is translated in vmf_error to VM_FAULT_SIGBUS which is > further translated in EFAULT in i.e. pin/get_user_pages. > But when running out of pages/hugepages we expect to see ENOMEM and > not EFAULT. > > ... > > --- a/mm/hugetlb.c > +++ b/mm/hugetlb.c > @@ -3113,7 +3113,7 @@ struct folio *alloc_hugetlb_folio(struct vm_area_struct *vma, > if (!memcg_charge_ret) > mem_cgroup_cancel_charge(memcg, nr_pages); > mem_cgroup_put(memcg); > - return ERR_PTR(-ENOSPC); > + return ERR_PTR(-ENOMEM); > } > > int alloc_bootmem_huge_page(struct hstate *h, int nid) err, yes. ENOSPC is for disk drives! I'll slap a cc:stable on this fix for a decade old bug.