From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21359D73619 for ; Sun, 1 Dec 2024 02:15:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 69B876B0082; Sat, 30 Nov 2024 21:15:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 649E76B0083; Sat, 30 Nov 2024 21:15:51 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 538BC6B0085; Sat, 30 Nov 2024 21:15:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 36E266B0082 for ; Sat, 30 Nov 2024 21:15:51 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 9A35E1A1818 for ; Sun, 1 Dec 2024 02:15:50 +0000 (UTC) X-FDA: 82844774040.13.07D943C Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf18.hostedemail.com (Postfix) with ESMTP id 53C141C0004 for ; Sun, 1 Dec 2024 02:15:44 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=xwNwWjxX; spf=pass (imf18.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733019337; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8dKRmuvH4yEEUd7bPJ5fQYW+TfOENFBlsiRIQd7lMvQ=; b=GOHD9lR5GmGlFJO/jyK9i28umNmg7/dn5S7b1oVGuoGvT9g031mK8/2+BrTh9Qaoqk0u7k F7r55f/VEc/gNSDkZBf2xgxfpyUp/+3fcrjvqlKhRzKP5HTlB3g7QLclFWlamKtc4r6IeO UgGh2g2LX+l42djMaA53iNqPu5kXurY= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=xwNwWjxX; spf=pass (imf18.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733019337; a=rsa-sha256; cv=none; b=h1AGYn3mowvO++5/DMo87qkmVbY9fxZr1Hok6KIib2U0FosaLH2fJTsrhZqfJLYznuESFx mFbG5UelN+1sIwGSwQa+sOkgkn3ZMxt8+ZU1GLirGySPPMWgtvElUJ3vF092NpSRvKfCyB G2wcP4X+G6dKdxiLninzsJSHGFIqoZk= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 99FF65C5B26; Sun, 1 Dec 2024 02:15:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E6964C4CECC; Sun, 1 Dec 2024 02:15:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1733019347; bh=tDVuaccHOfQ5uROSHeHn8HdJkWFS+laGOC7TufoGz8U=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=xwNwWjxXSQYkEEWZtIQtU4hrF6Hbd9Gm+xU6Yo3yea+fCTGRwrO6jaF95dbNiqx+V lwEs1KgVuUHw0+O4AnNwlZO47dC1d7Fecr4q5aT6wrK0O+AVtQfMSNslNP5l7wyg40 DH8j9myCJLzhVZ/m/I4Sl0+OrBVeZaQ+eJidjNrA= Date: Sat, 30 Nov 2024 18:15:46 -0800 From: Andrew Morton To: "Huang, Ying" Cc: Kefeng Wang , David Hildenbrand , Matthew Wilcox , "Muchun Song" , , Zi Yan Subject: Re: [PATCH v2 1/2] mm: use aligned address in clear_gigantic_page() Message-Id: <20241130181546.0d4d95e2ad9c0be707f54a50@linux-foundation.org> In-Reply-To: <87v7x88y3q.fsf@yhuang6-desk2.ccr.corp.intel.com> References: <20241026054307.3896926-1-wangkefeng.wang@huawei.com> <54f5f3ee-8442-4c49-ab4e-c46e8db73576@huawei.com> <4219a788-52ad-4d80-82e6-35a64c980d50@redhat.com> <127d4a00-29cc-4b45-aa96-eea4e0adaed2@huawei.com> <9b06805b-4f4f-4b37-861f-681e3ab9d470@huawei.com> <113d3cb9-0391-48ab-9389-f2fd1773ab73@redhat.com> <878qu6wgcm.fsf@yhuang6-desk2.ccr.corp.intel.com> <87sese9sy9.fsf@yhuang6-desk2.ccr.corp.intel.com> <64f1c69d-3706-41c5-a29f-929413e3dfa2@huawei.com> <87v7x88y3q.fsf@yhuang6-desk2.ccr.corp.intel.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 53C141C0004 X-Rspam-User: X-Stat-Signature: mhznw6gf9xjtow4x3eb5rujx1ptjdg4d X-HE-Tag: 1733019344-571639 X-HE-Meta: U2FsdGVkX195j4OpMpDERNNWDryuG1cupbq0kU7o8HPXTC3kzB4TVmdnhKQhqbAKzQrJBxZWG2S0MpEzuXp9fZ8LOUA2kM8msmfBI+64EuB3a5LycZGTsyC4nAm4l4MI7GkdVDM/jBxL8AoGo3jHNQ2dJ02uRiEfbj2wsp6X4pyavDYi/Y8ybzrtKOPlTzvA15p/xufb51sYFk1mAwmhQpVOBTBHvK86XD8Jdi1KSQgOI3fImd3X0qga/im8NeH6lc6gXkMKg7u+8JFo3Aezi/kP55Xezm/hmOW2QovRYhvSKDEn9yX4dhDRyi0BeFXnQyP46fI/D12f/tYZFid14xgb4twYHnMrZ8iP8K5Leoecdezu4w2TMZL09lB2Vb9iBuP47/mOcHBotsuKO9Ch4cu+/h4ECB/S+O0uT3bl7StNZ+AsYCqCcpegfCqCrXBhUGBl3bt7OF/E4d6cS2UOsqhRgkxQacR31OszWc4U4n4V3IsD9akpBIbv9DPxsnzDGJdyam/Ao7HnFl+n1b1O/80X/Zj7j9Ur3HkzdjmEvn+u1a5VwmbMbFAz22Ikqo5yIgN1fIUz6rRt/H/dXLJE4kXiZqLRsBD8TIDfskwfM+cu92VWJNSiOgkS8iE/kE4G7P+WlXyH97QHQhLiHW5BUZXGfz8Y9Sbd8GApfBtKchV5SmSwEwMh5N1dEyZwZQk5OmtEktOFK8HcTsutxfjcEt8yiQL54GniACRTcmQvxaru9EXjA1+9H+ZIYWvJPMVMzB6OloPedxlyxl+rmzx3xUlGxlmclTxcg86mf+fo56q8ke+Hx52Y1OMtNbLCR8dw+R5QOcSjL7/tgv6aOGYmTm2d12wGBuOq/nxo1ZT3M+Vds3x6Qy8IyhjCsi6PW9Uqu3zzWfRLwqOVdP3Q0zZ7ONhiydsqIT3nlhCT3+ANEYWw4yix0ncdCBOJRIaRtp1J6XP2Ze+lUYR+U+8jHpN nAFu+J0I ZnWylw8i/0wjuaV4hNOR7j17MO7cXyOiUbQNw1qWoHWfzJQ5KzBN/tzYRME+7EkXZRA4+sD3iLpGoHlJ6spV97/UgpZTcMY2ZirSzp74km3PRjjN4ZeWLR561sQWbVZGzLOov+yXytDQKsIvDPkUGCYTVd7HULY79K17OfvLgljsLcqjkkYREQYmwwHwPIsUxXM6/jk2m7EvZIPQberfyCL+/2Cdk9Qp07hjcz1B6uVRY8+0XK3MC9t4cvOMq1YTTe9GzYDSZfzCEWRIyYVtnM9+hauvN6GIScZbiRbo96385q1SIOZ5C+6xvFLABuoYstYDt X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 31 Oct 2024 16:39:53 +0800 "Huang, Ying" wrote: > However, on ARM64, it does introduce some regression for clearing pages > from end to start. That needs to be addressed. I guess that the > regression can be resolved via using more clearing from start to end > (but not all). For example, can you take a look at the patch below? > Which uses the similar framework as before, but clear each small trunk > (mpage) from start to end. You can adjust MPAGE_NRPAGES to check when > the regression can be restored. > > WARNING: the patch is only build tested. I'm holding this patch in mm-unstable because it's unclear (to me) that this regression has been adequately addressed?