From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11B46D735F6 for ; Sat, 30 Nov 2024 04:31:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6240D6B0082; Fri, 29 Nov 2024 23:31:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5D39C6B0085; Fri, 29 Nov 2024 23:31:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4C2646B0088; Fri, 29 Nov 2024 23:31:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 2D7BC6B0082 for ; Fri, 29 Nov 2024 23:31:45 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 97D40805BD for ; Sat, 30 Nov 2024 04:31:44 +0000 (UTC) X-FDA: 82841487918.18.0158A0B Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf08.hostedemail.com (Postfix) with ESMTP id DEC52160007 for ; Sat, 30 Nov 2024 04:31:36 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b="MUklcsa/"; spf=pass (imf08.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1732941094; a=rsa-sha256; cv=none; b=v9acPgCzACxct/C1/bURTVlHkpzXt03rJIxVoSzDftnvAErwgNLhHxp0e5ZWpVHJOPJQ7F tdtbB1EuTir4NMqu10sBB+taf5oa1jSIIfeib/Y/QCvcLrHvIOjTO4D+DTKkPrfTXBTsD+ TPDWsFrJim03ohsP5KbuZF7oo0Tmu4U= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b="MUklcsa/"; spf=pass (imf08.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1732941094; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7KGuJRBFRrasrnDzJxlBPCbY8zd4Rrmb5VHlr08wswM=; b=sIDHGxMIeSbbF6f0olDoxpQfqReVX7WPkgjeVXoN7Zj5Lg8EGZerj5+pmSjVg81oxSAbbH KQlM1D1yWUm5X44lrwR8f85xnWux8GGztfAt78LJPPQbzJEbl1E8zpVAB6XWSoAMCFIxgx 7RVAcpikTeYeds4BvT78RDRp5EFcc78= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 129AB5C0498; Sat, 30 Nov 2024 04:30:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A7AB6C4CECC; Sat, 30 Nov 2024 04:31:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1732941099; bh=SStyP3fEZzrsViwsPw8nnitcOmFNktyfgaiEdGnT72s=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=MUklcsa/FhzhQkxzL5RFJconuGnmkbpq0MqLdmoUa12XD7gLmTIvFHRu331ZubnQP pOSCwPWlXST2JfCohchJkeEyBP2nVU78Hvxu0tRfkD3WlTs65AdcOqvdB9XagLK0M/ bpw3CMuP6AGHFYaDoMaQnUjszo+unmtrdIOmVDNY= Date: Fri, 29 Nov 2024 20:31:39 -0800 From: Andrew Morton To: Wei Yang Cc: Liam.Howlett@oracle.com, maple-tree@lists.infradead.org, linux-mm@kvack.org Subject: Re: [PATCH v3 0/3] simplify split calculation Message-Id: <20241129203139.d01376d8beab1f6ef485aa12@linux-foundation.org> In-Reply-To: <20241113031616.10530-1-richard.weiyang@gmail.com> References: <20241113031616.10530-1-richard.weiyang@gmail.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: DEC52160007 X-Stat-Signature: keh4oj56f81n3uoyuenea9gkdyzqh55a X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1732941096-443106 X-HE-Meta: U2FsdGVkX19/tFdne+s84aHLxUFyF0j/76EjZjkQqX1cAKYywAaEc3QtqDO6uagpgQ08eLCIqq2d4G/IHbo1QBdzf7cYaUoLO5xcbsb3eaxRrJEAhWS9+ppcxOg3nS/ENonTZX9lDsDOvdgpPlLOiInAe3ZZ43PGNlJUPacFlUOPkDbKeQ0GAaY2WLuBPpncBwbCd0O+raXuFBoPX8B055rjQvCeEszedBqBfppEAkIrD/hw2IyPpxgvHX+tLsKAsVPdnlkP++24O13VnhRyMN4Zf/M1GUfLPf72qwXVoBFU772q/pBKp7kFLZZpddEjs9oLUoy1TkshZPS8t5mOSadPYfDEw1CR/dQWlI+6ehzPKdq8wbkcPuO3vrKycpB68+CfyT26shTnn3FXRkK7ClnF/OOTDkIUYBMZA2crgIEI1KVx9/Z1CKY+OqHNpv8xokYNUH5j+NBp6V1SR6BjNIqoUV/vEIMWRJIs7Yk3/pb3tQjZSh9DNTiSoflKKv/0tHVNsR7XM72VSeY2raC46o3BXoWQhVeitQJS1qmmw3H5Mzyuh0Hwk/ihxV/Fi9oIzPu8tkB8eTmj21SldyjG81AZ8qi5Q+PczUtyxn4dOXJ56m3SNNp3oMh9CJxhkPVjowjQJomq73XXhta5iGBS5GO1X9XMEBJ2Of6el+wyYNm5OhudXEZ5123d8dmTZpzBeg15Yu62meDaCdjjMwKj9lHz54qphYqbAPs/a4EqACN+lP7IP8bQ0fleTiah5jzDd5JubiPuTxMcwwTbm+MKkexRO6d7toLwSn3BkOr9b1sMbSCEZqfF7wxPkWIGJlPBF28/9pDcqk8OgJ0fLiw3qkiuHQV2vsi5T2YUzgriOyqfTaxl79L0UVCDnmzynozJhi7+itKqwItec95W2QDtS1xCFPTDxxvnLZ0g9OOOOquAjCto6DS6PljTbqRfufScCoAxaURoZdHJUHprMxm FVrx7Hzc FvTENkJG/DAo4WTLSUAB9T6J9+RxJK6s6PGMHZ1w0LBQK5O7YcG0cSO1wl8oorunh+JATL5oxZFHn4qMz9SLb75/LX6WRml5nVKzfJn+HmRUNTIQTSHmO0+aDXEjgn0B5feA5iPiAF5UdcAY/d368pqQaMeEaSmX5m9lT7oFlwV8qxtn0k+qgO2ldYQkqEmNfPWDR7W3g/3DCGxqLvKh93KTSgwMeBj2K63KV12iCMvQ0G3OSg35GKfYJ65P8RENW15qwhZbX28fr/d+f4toHoX2beKdHdRsTKDPZPjb+fKmj8ocGO+S66stJWf1tF/1t8MsQyv8Icq+jCiZD+RSfWDQLetq2QAp5KofQT262+mvLQuI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 13 Nov 2024 03:16:13 +0000 Wei Yang wrote: > In version 1 [1], we found current split would result into deficient node. > > By discussion, current implementation would lead to jitter problem. Since this > is a rare case in real world, we decide to simplify the split calculation. > > Patch 1: simplify split calculation > Patch 2: add a test case to check deficient node > Patch 3: validate deficient node except for root node > > [1]: https://lkml.kernel.org/r/20241020024628.22469-1-richard.weiyang@gmail.com There's nothing here which is really useful as a [0/n] overview. Why is [1/3] being proposed for -stable? The changelog doesn't describe what benefit such a backport would provide to -stable users.