From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 412B8D6EBE5 for ; Fri, 29 Nov 2024 07:49:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 62A506B0083; Fri, 29 Nov 2024 02:49:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5DA476B0085; Fri, 29 Nov 2024 02:49:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4A19A6B0088; Fri, 29 Nov 2024 02:49:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 2BF206B0083 for ; Fri, 29 Nov 2024 02:49:52 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id BF0561A0E71 for ; Fri, 29 Nov 2024 07:49:51 +0000 (UTC) X-FDA: 82838358330.21.A449284 Received: from invmail4.hynix.com (exvmail4.hynix.com [166.125.252.92]) by imf09.hostedemail.com (Postfix) with ESMTP id ACAD614000C for ; Fri, 29 Nov 2024 07:49:43 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=none; spf=pass (imf09.hostedemail.com: domain of honggyu.kim@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=honggyu.kim@sk.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1732866581; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SoqOjftFKu1sn0mbVYPHUo5N0omAA7zr06thaOyybKo=; b=W4B9pefw61aLX6OUoIbZE8y5jW6o5/kLotrMryH2qyZss5A1bg1aHj+H/h1DWPL1h9GXx5 inSVHdTWETvFXz9Quk+kSPZJaKZ1sg5ZEPChL8gXIjIQGwrt2Cl7YaT6gUIka/UBxxfqqt pFAdpM753uf/ThPgXOTNjyOw0LG3yWA= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=none; spf=pass (imf09.hostedemail.com: domain of honggyu.kim@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=honggyu.kim@sk.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1732866581; a=rsa-sha256; cv=none; b=tqP+hKWYaUaipBebAOygD7RaQTuaug1JQrmNyrGcJaOJ7NgW9xxbiR4nxtOuNuBJjw/l0a MKi8Erqsel3MbDKFAfG4JAnMJ0Gj5PmER4RFDdLKbFWGa1fyrjB2106xFh73bhonAzq6Mq HzZOcLWgykTDeCidgjlpRIEtDSNC/08= X-AuditID: a67dfc5b-3e1ff7000001d7ae-1d-67497218d5e9 From: Honggyu Kim To: SeongJae Park Cc: damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Yunjeong Mun , kernel_team@skhynix.com, Honggyu Kim Subject: Re: [RFC PATCH] mm/damon: explain "effective quota" on kernel-doc comment Date: Fri, 29 Nov 2024 16:49:40 +0900 Message-ID: <20241129074942.1554-1-honggyu.kim@sk.com> X-Mailer: git-send-email 2.43.0.windows.1 In-Reply-To: <20241128175046.87869-1-sj@kernel.org> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrLLMWRmVeSWpSXmKPExsXC9ZZnoa5EkWe6wfOXRhZP/v9mtbi8aw6b xb01/1ktDn99w+TA4rFpVSebx6ZPk9g9XmyeyejxeZNcAEsUl01Kak5mWWqRvl0CV8bxLZ1s Bc3yFV8+HmNrYHwv3sXIySEhYCLxpW8zI4x9d+s0VhCbTUBN4srLSUwgtoiAosS5xxeB4lwc zAJbGCW6l2wCSwgLBEmcuHGEBcRmEVCVuHxjDTOIzStgJnH281YWiKGaEo+3/2QHsTkFjCWO v14I1iskwCPxasN+Roh6QYmTM5+A1TMLyEs0b53NDLJMQmAKm8SrXbtYIQZJShxccYNlAiP/ LCQ9s5D0LGBkWsUolJlXlpuYmWOil1GZl1mhl5yfu4kRGIjLav9E72D8dCH4EKMAB6MSD6+A kGe6EGtiWXFl7iFGCQ5mJRHeK4s90oV4UxIrq1KL8uOLSnNSiw8xSnOwKInzGn0rTxESSE8s Sc1OTS1ILYLJMnFwSjUwak0quBvKNyd6f82Mv2lFl2u3W7fdvcrxTsJybYGdMp/BxUObfaZy 27idO3ov3VLh/NQXP1cwXd/PrjmX8WEHv5Llw9/cb3NnlPBOddjMEhtSW8fkEN/Z5nLZe6bF mSpTUReDgOUd/eFBjTcE/fbzdbJeObTSrD501f8tK58frNm3d4/Xw/MmSizFGYmGWsxFxYkA Nxwl5UACAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrELMWRmVeSWpSXmKPExsXCNUNLT1eiyDPd4M9pLYsn/3+zWnx+9prZ 4vDck6wWl3fNYbO4t+Y/q8Xhr2+YLH5vW8HmwO6xaVUnm8emT5PYPV5snsno8e22h8fiFx+Y PD5vkgtgi+KySUnNySxLLdK3S+DKOL6lk62gWb7iy8djbA2M78W7GDk5JARMJO5uncYKYrMJ qElceTmJCcQWEVCUOPf4IlCci4NZYAujRPeSTWAJYYEgiRM3jrCA2CwCqhKXb6xhBrF5Bcwk zn7eygIxVFPi8faf7CA2p4CxxPHXC8F6hQR4JF5t2M8IUS8ocXLmE7B6ZgF5ieats5knMPLM QpKahSS1gJFpFaNIZl5ZbmJmjqlecXZGZV5mhV5yfu4mRmDILav9M3EH45fL7ocYBTgYlXh4 BYQ804VYE8uKK3MPMUpwMCuJ8F5Z7JEuxJuSWFmVWpQfX1Sak1p8iFGag0VJnNcrPDVBSCA9 sSQ1OzW1ILUIJsvEwSnVwFiT+I9j3tuun5M7+Dvvupef3ui6IWe7v0LEF6Fr02f/PPaoebM5 8/99sgHtffm3pqvv2X35jsUux+O5f5eHPc/pe5R4fMHdvonNKVv5Xl5gvPrl/fX4csGvvRUF xvyP7uyYv3XxHbNjxa2tfjMm9M7ZOqlyTfQdzuXqH2y7296VbmeeVpzDv+e8EktxRqKhFnNR cSIAlN3IITUCAAA= X-CFilter-Loop: Reflected X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: ACAD614000C X-Rspam-User: X-Stat-Signature: 8335bucrscztsz399ndd355f3a98way9 X-HE-Tag: 1732866583-354052 X-HE-Meta: U2FsdGVkX1+YjYKywyvGQhA0x9S3h7ECjPJ72J7C7QQO8n34I4Eq1dbuedRgThv3yawcAD1Ac4BxENC9Vi8C4ny/Yo07mIxd/7Gp329rCH+ot8JE7zjBdTy+TmUWDOSqwTuYA+eWGYLyeaLeSSU4vhlCSU2mQWmc4N6OmM+phqTbCl66dbcf31x1qxbd/ky4fBmVEW5rbRsYnItMEoKMDfFkFdS37h5xzlH/R4p+ZEyndKa3j5f/Cud8YNTig7ApDvlEW5sIMCokFYTRQS3UL9vbnhNvgiPPHUtQStHzUkC5owZtP4NkZav0F4iFr3M8p720qBys8A8rIXEOCJ4CLZsM7chCFPfpwW9ArmErTi+rqhWnKONJowmngoH8rqVQSaVAgVLBbeJmmzHHrqkSMwssempe+tbg43Gxzhls+1QcNSTHnjEqwTzvh52hWTTyFpI1uMyfNNHyx2ejsC85owIhBAO+5JytxN7cXGlW0GznBDTImlyKZDYdVhiC4S9dkg0IvxoBqozfh9mVzbStE7Wv2bA1YbUVI8wl3zRvtc4yxr2M/9sqUYJ/1hvs66NVfVZUs5pPkhk6JDhTWfY/ohWpeo4Iwbm+gvilvBKC03NwM+AYJNSrBV8tpIZY9nIZb2xUBn9M0zTjOvF/2CBaSZbwgQUZXnHc2czI2c2s5QV6W7JhYHtJ+F7n0FWdzM+ZMzQwWjawjdV6vOq/6UocJGFzbTXnWOChAEMzKM6T7mqqloMceOzlujVxqhamCkWJp6GKk8qSO5Nhb4+7746EL9PmfNEsvjiIEckarFvlBuF4F1CmgcU/Ffu7YRg+JjJ/5sFQ70c09cFpidV5qfIFq0LsZEsFMDDmrKeiOp+Xh9scRLilkoPiUiJZRbrlWAud4WXz73/A9TSz/xTbLBGa0FnicWnLZVXbsRExINJ9txUxG2+990lqFC72BtXSgfOnOXgJ49XBtXXpuv7AUL2 +pvdAieB myZmL/uTqV38y9g5Vakdjg2DdSma+AwGoAhP3XpbWPa8SeuUh3KidVzP5J7bwbxS8G2Hl+B7RSkoEypg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 28 Nov 2024 09:50:46 -0800 SeongJae Park wrote: > On Thu, 28 Nov 2024 18:53:55 +0900 Honggyu Kim wrote: > > > On Tue, 26 Nov 2024 11:43:47 -0800 SeongJae Park wrote: > > > On Tue, 26 Nov 2024 17:24:33 +0900 Honggyu Kim wrote: > > > > > > > Hi SeongJae, > > > > > > > > Thanks very much for the quick response. > > > > > > No problem, all owing to your kind report! > > > > > > > I think it looks great but I > > > > have some minor comments so please see my inline comments below. > > > > > > > > Thanks, > > > > Honggyu > > > > > > > > On Mon, 25 Nov 2024 16:29:21 -0800 SeongJae Park wrote: > > > > > The kernel-doc comment for 'struct damos_quota' describes how "effective > > > > > quota" is calculated, but does not explain what it is. Actually there > > > > > was an input[1] about it. Add the explanation on the comment. > > > > > > > > > > [1] https://github.com/damonitor/damo/issues/17#issuecomment-2497525043 > > > > > > > > > > Cc: Yunjeong Mun > > > > > Cc: Honggyu Kim > > > > > Signed-off-by: SeongJae Park > > > > > --- > > > > > include/linux/damon.h | 10 +++++++--- > > > > > 1 file changed, 7 insertions(+), 3 deletions(-) > > > > > > > > > > diff --git a/include/linux/damon.h b/include/linux/damon.h > > > > > index a67f2c4940e9..a01bfe2ff616 100644 > > > > > --- a/include/linux/damon.h > > > > > +++ b/include/linux/damon.h > > > > > @@ -193,9 +193,13 @@ struct damos_quota_goal { > > > > > * size quota is set, DAMON tries to apply the action only up to &sz bytes > > > > > * within &reset_interval. > > > > > * > > > > > - * Internally, the time quota is transformed to a size quota using estimated > > > > > - * throughput of the scheme's action. DAMON then compares it against &sz and > > > > > - * uses smaller one as the effective quota. > > > > > + * To convince the different types of quotas and goals, DAMON internally > > > > > + * converts those into one single size quota called "effective quota". DAMON > > > > > > > > Could we use "effective size quota" instead of "effective quota"? > > > > IMHO, it will better give an idea this is related to "esz" in the code, > > > > which means effective size. > > > > > > The above sentence is saying it as one single "size" quota, so calling it > > > "effective size quota" here feels like unnecessary duplicates of the word > > > ("size") to me. I'd like to keep this sentence as is if you don't really mind. > > > > Since the time or other goals are eventually transformed into a size > > quota, I thought the "effective size quota" makes sense but I won't > > stick to my term here. > > I understand your concern. But I want to make it not very strictly fixed and > well-defined term, but just somewhat understandable with common sense and given > context, for flexibility and conciseness. So unless this is really makes it > difficult to understand what it means even with common senses and the context > I'd like to keep current form. > > I believe your answer to the above question is "no" since you mentioned you > won't stick to your term. Please let me know if I'm misreading you. OK. I'm fine with the changes with this patch. I won't ask more changes. > > > > We originally asked this question about the term "effective" itself as > > we didn't find an explanation what "effective" means actually in the > > doc. It'd be better to have more explicit explanation as well. > > I think this patch makes the point pretty explicit, so my humble brain is bit > confused what "more explicit" really means. Could you please clarify what > changes you want to be added? Nevermind, your changes here with some grammar and typo fixes are enough for this patch. Thanks, Honggyu > > Thanks, > SJ > > [...]