From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2224BD6D251 for ; Thu, 28 Nov 2024 01:11:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9A7316B0088; Wed, 27 Nov 2024 20:11:37 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 957B26B0089; Wed, 27 Nov 2024 20:11:37 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 81F226B008C; Wed, 27 Nov 2024 20:11:37 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 6506E6B0088 for ; Wed, 27 Nov 2024 20:11:37 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id DB2F7815C0 for ; Thu, 28 Nov 2024 01:11:36 +0000 (UTC) X-FDA: 82833726066.04.FDEB3E7 Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com [209.85.208.46]) by imf03.hostedemail.com (Postfix) with ESMTP id 100432000F for ; Thu, 28 Nov 2024 01:11:31 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=B3LTiqCO; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf03.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.46 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1732756292; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FsdeMrGED1LRUn9Rt5INOP6e7rH6Q9XXVUvbeGhU/2Y=; b=eOllZUdlxwKulhb3UYz9E6veOBAAtiO/PNoz4FUy7SCHOSy0QYfItLsgpwNi28I9J9Q6RY Xfb4CJudTx3O/dWW2Ec3dVh9Y3kMqtvgboizPbGrrSV77M+XhGPLbE0ayHN1pBBp9n1yoh Kx1V4a3wUn1k7EGr5hL2wmh5BqGlEkU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1732756292; a=rsa-sha256; cv=none; b=Wz0ptcsDwlNFTXZPajoEeyb6t+Uh5Fv0rX47z6UuWZ4DPPJIPKh2OkPn8gYsoP1UoAFKkL i1eG4/z6l2LFDB/mI1GygTYgXVHpVr4pnWhNI1zZeeU4+DwYilXBCpK+Sm8hrxT6x5zyG/ Zh7+631ZpJLmoVdmoiPhQoq/c6Dq6JE= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=B3LTiqCO; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf03.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.46 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com Received: by mail-ed1-f46.google.com with SMTP id 4fb4d7f45d1cf-5cecbddb574so368623a12.1 for ; Wed, 27 Nov 2024 17:11:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1732756293; x=1733361093; darn=kvack.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=FsdeMrGED1LRUn9Rt5INOP6e7rH6Q9XXVUvbeGhU/2Y=; b=B3LTiqCOvnNNs/hYDULBh8vCr4YYtkEYtM88W62JNzw/KW4KBpppb7E/YpXC8ecAva dU4w8khALujMiWwyX4BJ3CnmkX8PFpzKqQ0JmdXVH3GNzte12hZ53Yabih57GproPx02 s/GZCYVIksdMMrUIDBfHsuOjzbD6gAfG4NwHOzSQNEap6fqsnnmlkfGtH9QM+fxaMQFU TUPQmMr/D0rl5s5g8BTQhxw3cfcukjry1uT84VQiB4ufRF/bkEoXn/YUVlbxCmfEne4g vVcKhRdSLadGj42nTe1Zt7ocdxwqO0Sh8oRQ3q0mbCz9e3W0UkBJjYkajXw6LzDhtmjJ NeEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732756293; x=1733361093; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:to:from:date:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=FsdeMrGED1LRUn9Rt5INOP6e7rH6Q9XXVUvbeGhU/2Y=; b=Jji988cK4rePcS73MvVgD60kIOANN2JX/XnPowC+SQF7ZClVfT4iWxWMMrOtiQaeom LsKsVBOQi6fGB79dne910FY7aHSGW799Sj5D7xbm1QtmbyFPC9pmROPNEw2MwzrsNALI t0Vsj7iPJ9D2bj3Qyo5hbe4DmKTt02UNLHIFf0mnjJPAG7R2EX23zUeRCJJWwCJ3nsqg JsvAkKMLHMjWOrVf1jSwe+LD8A8cn3baXWzgVA1K8xVgOaTmL8Uloe4Py27saHZlzqTL zVFcQNnhiW5b9rFDw1/svttd6mBvuwR+VHh7ajkD2IkeKk9M0C6kSgbH5WuE8V2/mJfN Xwhw== X-Forwarded-Encrypted: i=1; AJvYcCWe73vJ/4T1bQCAwLPq5fcyE0PgDUj34sgvlRrea7ub96Ce6k0U5YptcHDGV9JFzffxFkjxNmGvFA==@kvack.org X-Gm-Message-State: AOJu0YzI59G7qvC9znk8EC+Z1OnVpWUlceKOwKJEzhjdvG2KaF8JGV+m TyhVBu0s2wCFk8+vDz/3zGRJkY3PF+DXGsvrVE3jqa63nE72bx1x X-Gm-Gg: ASbGnctyzmAtY8J7k7wufLeOTpV5/iUDmu58Wf1Yh7Yy9G3o4L4qXcP4S4BR/Lrk6/7 mQrMOO0viadLtftK37VCxQ9k1mb2QVr7PlkLgsuAWfG6HFCz0ZF3EEx12ivo6nFwTDUgc2sAl1E 4Na5SVg98hk9Da51eMsg0+hiM8i6TmGNWWkWdAhEM7fBNy0ImYeAozvnrtwajz+ggocn2PDF5DE HT560xoVaezQ+/GgleVxw/IdCrxiAlEYGQwxk9HDz142StopQ== X-Google-Smtp-Source: AGHT+IFdev3Krnr+XivxF7+lfkiOOIWNl7+tIOdq21So6tu1oHYdvLTqUMiUj/Rct2CkRFr0dlwPYA== X-Received: by 2002:a05:6402:388a:b0:5d0:68b1:6478 with SMTP id 4fb4d7f45d1cf-5d080c44626mr5033941a12.27.1732756293068; Wed, 27 Nov 2024 17:11:33 -0800 (PST) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5d097eb224esm177737a12.72.2024.11.27.17.11.30 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 27 Nov 2024 17:11:31 -0800 (PST) Date: Thu, 28 Nov 2024 01:11:29 +0000 From: Wei Yang To: "Liam R. Howlett" , Wei Yang , akpm@linux-foundation.org, maple-tree@lists.infradead.org, linux-mm@kvack.org Subject: Re: [PATCH 0/7] spanning write related cleanup Message-ID: <20241128011129.c4i3gkp4rbetndy6@master> Reply-To: Wei Yang References: <20241127012753.3393-1-richard.weiyang@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-Stat-Signature: b55atwc189fk5txups6np5aytdopm7rr X-Rspamd-Queue-Id: 100432000F X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1732756291-677288 X-HE-Meta: U2FsdGVkX1+AxVXhN3mrZ9KvA+LLMAAt6nIBi5qvARC1jF11o+8VYLtVTkS3OemVU6e3NOjY/f9k/OTku/y6wMHCMzLfplv7vDao0YHk7G4M+bGoRrWscxmFGE2rTddex0EHwYWN7qAgkM9GmzZl21p2xNNtYjuIntrFFNZ9rawHoixagPFDfwr3+ZtGLTyxYAEgMgCxJ+DeJHh4/dPyS9WDb9Tvw3STiwXBkhaGKR4kbM0GRsSLB4fa2Ihj3NK5MvpErhNr8ZNFawFPlAJbG5Ju9S4B70EYRHMxX6i0Ol4gsXbXd9hxFdQY7gqwnHAXNwQ6SkobTWizvkWiiLIgyi06O6KszStmI69VCGy5hCJ2FBphT1yF9lgxOS89lckqPna/DPvM9Tv7mKAwjaf/0ZWUTxjsgL3OId9m6Fi43bMdbnOxHi+C9JjsJLYHesOR3JDxJ1BtA9Cr8M3q61B06JpMJgZZ1B0mDyY0b24B3sjTLioCpuyDG3xpHusbALM/bhtzEUvb5tMpTERZLfAMJkStjkdv8FnBPrCERoP5Fk0ZyAw1r0AO5MF/d5vdHsivxgvpdtOJAWE+mhYOER2U/Kp/urcCb4LwSoYgB02Qb6KiF93vQV36wZn/E25L+IlJZke6ToisXlg3ghEQaY/9z6elkXxXWV5I3Nng/6re4Q+pHVRxNKfw1Cg/yQZdy0oT0Gte0YJMxpC2EImU9NwxV51eGK8oLetmYYjAXtWZRr+LryOSw42lVsQUX4ssXXU22IEwEbgIfv5JgQDgE0fvgHvnMXB+W4dLtz0UsNIqW9BNffW/YpQ4Kp4iDyiuvwhWswlPkMR93DW98QoDq30GFOd+RcTz5AXi5AyGefjtn7gqqCxhmRDPJiN/7cgd5K96Hs98fchUPhd6C4grOjMBGpKxd2qRJShOwByluVr1x2ARYCieZzcurBujh2543W5EuYeSnCagjJRgKvQuCdk FPsku/ik worxccdVKSr+sKIxMe6ybD3LBhSHx0/zLEsKrGmbrvxto6y8+kg229JTjC0jhIKRnnTK9L5olRmP8KRZ7RO8lVU9k1ijnqN6Hcby18KkDI1l8WgihVRgFWLE/NKc6kG+FbVulOCxmblDJAbd8U3/42EvOYmV95wlj+h+2qetUovpiKzkfq6y3q1eyKbspI4o5Cc7GOZGpsrIt4SyYG1nW8pGOHZMQvD4gUbE+tsJ7PguGfhqlLUasTFvoC2j2pDvqmorgG38jnHR1/zRpuLlZpKv/6OJoDAzLzdbGR67Y+8HsQxEJd/f/Iwa6y/hhK+e4JVs76iWCdPLQm4IcTfZ/hkObijcLzAjp55SiZfWW/l8Ur98NWGtVnayLkAzwVBGJcPoBqWXb1ieYnnhiXr02Zc7Prj+cIKTJhTXMRw1BbAQWiNnV4xOO/40A8N6jBFYzmKq21Hb0THI/DLAm5aMb3Zl/ytYUcWTM5CdoZlg6McqIcHiTxGdaBfBDR8Z+A0hqB6mXs4fBuQ3i3uF1v/4C1kxWomIQxTNQyKnMaWt5/R8mh3dV1N3Ug/k7RDcFZQZSgBe9SvoqSxV6NkUOOOjCjWAZI4oof4jX5bNuvuBtOZaHumjq+7nCKNPlWWkQJfx5Ru9ESo357pN3YF0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Nov 27, 2024 at 08:31:13AM -0500, Liam R. Howlett wrote: >* Wei Yang [241126 20:28]: >> Here is some cleanup related to spanning write. > >None of these fix anything, but do fiddle with code that's pretty >critical to the kernel. Most of the changes will be immeasurable in >change but carry risk to causing subtle changes. > >Some are simple removal of returns that aren't used while others change >things because you think they are probably the equivalent. This seems >like unnecessary chrun at this point. I'm all for efficient code but >this is getting a bit much, some of these are just preference of what to >use that will already exist in the cpu cache. > >I'll get back to you when I dig through them, as some need a deeper look >for sure. Thanks > >Liam > >> >> Wei Yang (7): >> maple_tree: not necessary to check ahead if !content >> maple_tree: validate we won't split on NULL >> maple_tree: check mid_split only may have >> maple_tree: the return value of mast_spanning_rebalance() is not used >> maple_tree: the type of left subtree is already saved in bnode->type >> maple_tree: always need to update max of new left node >> maple_tree: only ascend left subtree to get the old node for >> replacement >> >> lib/maple_tree.c | 56 +++++++++++++++++++++++++----------------------- >> 1 file changed, 29 insertions(+), 27 deletions(-) >> >> -- >> 2.34.1 >> -- Wei Yang Help you, Help me