linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] selftests/damon: Add _damon_sysfs.py to TEST_FILES
@ 2024-11-27 12:08 Maximilian Heyne
  2024-11-27 17:04 ` SeongJae Park
  0 siblings, 1 reply; 2+ messages in thread
From: Maximilian Heyne @ 2024-11-27 12:08 UTC (permalink / raw)
  Cc: Maximilian Heyne, SeongJae Park, Shuah Khan, Andrew Morton,
	damon, linux-mm, linux-kselftest, linux-kernel

When running selftests I encountered the following error message with
some damon tests:

 # Traceback (most recent call last):
 #   File "[...]/damon/./damos_quota.py", line 7, in <module>
 #     import _damon_sysfs
 # ModuleNotFoundError: No module named '_damon_sysfs'

Fix this by adding the _damon_sysfs.py file to TEST_FILES so that it
will be available when running the respective damon selftests.

Fixes: 306abb63a8ca ("selftests/damon: implement a python module for test-purpose DAMON sysfs controls")
Signed-off-by: Maximilian Heyne <mheyne@amazon.de>
---
 tools/testing/selftests/damon/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/damon/Makefile b/tools/testing/selftests/damon/Makefile
index 5b2a6a5dd1af7..812f656260fba 100644
--- a/tools/testing/selftests/damon/Makefile
+++ b/tools/testing/selftests/damon/Makefile
@@ -6,7 +6,7 @@ TEST_GEN_FILES += debugfs_target_ids_read_before_terminate_race
 TEST_GEN_FILES += debugfs_target_ids_pid_leak
 TEST_GEN_FILES += access_memory access_memory_even
 
-TEST_FILES = _chk_dependency.sh _debugfs_common.sh
+TEST_FILES = _chk_dependency.sh _debugfs_common.sh _damon_sysfs.py
 
 # functionality tests
 TEST_PROGS = debugfs_attrs.sh debugfs_schemes.sh debugfs_target_ids.sh
-- 
2.40.1




Amazon Web Services Development Center Germany GmbH
Krausenstr. 38
10117 Berlin
Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss
Eingetragen am Amtsgericht Charlottenburg unter HRB 257764 B
Sitz: Berlin
Ust-ID: DE 365 538 597



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] selftests/damon: Add _damon_sysfs.py to TEST_FILES
  2024-11-27 12:08 [PATCH] selftests/damon: Add _damon_sysfs.py to TEST_FILES Maximilian Heyne
@ 2024-11-27 17:04 ` SeongJae Park
  0 siblings, 0 replies; 2+ messages in thread
From: SeongJae Park @ 2024-11-27 17:04 UTC (permalink / raw)
  To: Maximilian Heyne
  Cc: SeongJae Park, Shuah Khan, Andrew Morton, damon, linux-mm,
	linux-kselftest, linux-kernel

On Wed, 27 Nov 2024 12:08:53 +0000 Maximilian Heyne <mheyne@amazon.de> wrote:

> When running selftests I encountered the following error message with
> some damon tests:
> 
>  # Traceback (most recent call last):
>  #   File "[...]/damon/./damos_quota.py", line 7, in <module>
>  #     import _damon_sysfs
>  # ModuleNotFoundError: No module named '_damon_sysfs'
> 
> Fix this by adding the _damon_sysfs.py file to TEST_FILES so that it
> will be available when running the respective damon selftests.

Thank you for finding and fixing this issue, Max!

> 
> Fixes: 306abb63a8ca ("selftests/damon: implement a python module for test-purpose DAMON sysfs controls")
> Signed-off-by: Maximilian Heyne <mheyne@amazon.de>

Reviewed-by: SeongJae Park <sj@kernel.org>


Thanks,
SJ

> ---
>  tools/testing/selftests/damon/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/damon/Makefile b/tools/testing/selftests/damon/Makefile
> index 5b2a6a5dd1af7..812f656260fba 100644
> --- a/tools/testing/selftests/damon/Makefile
> +++ b/tools/testing/selftests/damon/Makefile
> @@ -6,7 +6,7 @@ TEST_GEN_FILES += debugfs_target_ids_read_before_terminate_race
>  TEST_GEN_FILES += debugfs_target_ids_pid_leak
>  TEST_GEN_FILES += access_memory access_memory_even
>  
> -TEST_FILES = _chk_dependency.sh _debugfs_common.sh
> +TEST_FILES = _chk_dependency.sh _debugfs_common.sh _damon_sysfs.py
>  
>  # functionality tests
>  TEST_PROGS = debugfs_attrs.sh debugfs_schemes.sh debugfs_target_ids.sh
> -- 
> 2.40.1
[...]


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-11-27 17:04 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-11-27 12:08 [PATCH] selftests/damon: Add _damon_sysfs.py to TEST_FILES Maximilian Heyne
2024-11-27 17:04 ` SeongJae Park

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox