From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2DC8D6ACF3 for ; Wed, 27 Nov 2024 16:34:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 84AE96B0092; Wed, 27 Nov 2024 11:34:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7D3636B0093; Wed, 27 Nov 2024 11:34:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 673EB6B0095; Wed, 27 Nov 2024 11:34:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 452D66B0092 for ; Wed, 27 Nov 2024 11:34:57 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id F13F71C75F0 for ; Wed, 27 Nov 2024 16:34:56 +0000 (UTC) X-FDA: 82832424150.28.6A439CA Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by imf18.hostedemail.com (Postfix) with ESMTP id 716461C0003 for ; Wed, 27 Nov 2024 16:34:51 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf18.hostedemail.com: domain of jonathan.cameron@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=jonathan.cameron@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1732725292; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=18eg53FoTqozl23XBtzu7McsZiupDgi0cFGy8iLdMCA=; b=rXzvXoA36IBlUSizEeuh1UzCTKgOYzj3rTDoYz+YvJSjtrrrTMZhXEIEQvhnQSrY1jtp4e luxa8RVlyirGuTZuC45KxAzStFCZeSftuzOjzpL1Q+JJsoorukFM1xEzo+7XqeL4BZRvov JeqiccgX70Gt/P5fLJy4AYVheaiSiXU= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf18.hostedemail.com: domain of jonathan.cameron@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=jonathan.cameron@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1732725292; a=rsa-sha256; cv=none; b=bWsG/QsPtxlLkioLL+UzoJkibVkRnICGV58yULFsea35xFnHaNQsayWkZPnIdSiY1nI2m2 FI2GGBOdWNSDWfzP7wAOe28imvumUkCV0djNEqTLk4fW1yCVmAaps0L3RUVapCEHaVEpe7 ydcZEazp2zNOlVo2/IbEGQldZ98ukNQ= Received: from mail.maildlp.com (unknown [172.18.186.216]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4Xz4j723Dwz6D8gt; Thu, 28 Nov 2024 00:32:11 +0800 (CST) Received: from frapeml500008.china.huawei.com (unknown [7.182.85.71]) by mail.maildlp.com (Postfix) with ESMTPS id 8F6851400D8; Thu, 28 Nov 2024 00:34:48 +0800 (CST) Received: from localhost (10.203.177.66) by frapeml500008.china.huawei.com (7.182.85.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Wed, 27 Nov 2024 17:34:47 +0100 Date: Wed, 27 Nov 2024 16:34:44 +0000 From: Jonathan Cameron To: , , , , CC: , Yicong Yang , "Niyas Sait" , , Vandana Salve , Davidlohr Bueso , Dave Jiang , Alison Schofield , "Ira Weiny" , Dan Williams , Alexander Shishkin , Peter Zijlstra , Ingo Molnar , "Arnaldo Carvalho de Melo" , Mark Rutland , Gregory Price , Huang Ying Subject: Re: [RFC PATCH 0/4] CXL Hotness Monitoring Unit perf driver Message-ID: <20241127163426.00004a65@huawei.com> In-Reply-To: <20241121101845.1815660-1-Jonathan.Cameron@huawei.com> References: <20241121101845.1815660-1-Jonathan.Cameron@huawei.com> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.42; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.203.177.66] X-ClientProxiedBy: lhrpeml500006.china.huawei.com (7.191.161.198) To frapeml500008.china.huawei.com (7.182.85.71) X-Rspamd-Queue-Id: 716461C0003 X-Stat-Signature: tnpnpfu3168kcduirwrfoywccykgafxd X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1732725291-473962 X-HE-Meta: U2FsdGVkX18BND2zCfZ2qebqxqLQKIIxgsr7sRtYYtK1Z2Bl34bHCzr2LWvf3frjJ2TjXFS9MP2TZ4xM1BBKNF/xhyPjAN03wVGcVdFf9CbCSQDvTBjyFKWLOlN9t4McG8sNQK6b1rOCwle9WRVLPCnXiedCjuJtlzOgLZ4DQMSk5Mpzot4ReefvXftXhnx5rEkkq44Z++f2cDYQgXT/KzRbInVh2gZ7KO3e0oXNnS/mjELrFeFDLb/+/zM9e7nRqQPGBY9y+hdjIUsFPIFawpUrtxr69HiIT7Dvv0tv76+WgEIFnoKSAe9ga1K9A8DOFSkUCx0CYTim6A6FO02UmCYQ/g6JaC3VAPU85wlQEUXpQDluX2XH257SLxEgabOJG11UK6dqUwMBIuRHMT1Z0bNbZZeL8nNp4A1u/k0tIwdJ3eYGhhsq/j9btJpSTQigogFqw/DsryCyH5TiavFitTXjte22cHiqcF075Km6yflW13rUeDsj4lBXDOLjbKhfKNsyxDW/ePA17SYciISTxkixsomVbXYgwVDX0zSW4jL2o/fXlRx6SftLhjHKaadfM4ZnSfSdboZxysnHKKDW8EgRU78CjjdvswqotAT9yubBOgB7DFUUfKi4UbGaZvnOlC+tUuBgvjxF3TaefIondhUbdi0rgD4qo4lN0zaornwgiU4gBGe0WkjeZmkefEcHAMWnNlZFwDldogUoWDGe0al7vE/I4dS22sMALNcRsH3CSC9L+1c17PoMC+6Df5+rKBC7fE19UGKFFGVC0+NWx6kGSVhHtSlc2gbgMMwLnPTad6y3Hk/efO9xTaZ39lNsi96EZd7U8sYPe36URypmuAyz5zAL+mSqAn2O+LmcpaN5ZZXMprTUojjYPHOiUMRZGR6r1l29zCXmHZViKZmXuKRgFINpKqE/A8J+8lT5lL/hgkxP4azjR+wm4TJi7X8x0bwPSKbdKWH1+O7TgNh QMfYC2Se QaKNoPv6/vgnVj5ZSztfN/6deKJ+j3bMSFW8qz8OQDpAGeacEeOEdNYgSy6lSgsvyRbibKNynRQdhQ1kgrhi0eUAXjUSfaZCuIzav/QTLausX/XskGQRYyLmvtGyNxXpcpkmMUiK5EX4THefsIZiSG6M8H3rwhLgZC6YJsEZCFW2dyaXHsNjKW32t1mmP9cmlJtWdtawQBpckTRyJ1H+N5QUZlz23vS8RlAA8/vLWS9q7Ebo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 21 Nov 2024 10:18:41 +0000 Jonathan Cameron wrote: > The CXL specification release 3.2 is now available under a click through at > https://computeexpresslink.org/cxl-specification/ and it brings new > shiny toys. If anyone wants to play, basic emulation on my CXL QEMU staging tree https://gitlab.com/jic23/qemu/-/commit/e89b35d264c1bcc04807e7afab1254f35ffc8cb9 Branch with a few other things on top is: https://gitlab.com/jic23/qemu/-/commits/cxl-2024-11-27 Note that this currently doesn't produce real data. I have a plan / initial PoC / hack to hook that up via an addition to the QEMU cache plugin and an external tool to emulate the hotness tracker counting hardware. Will be a little while before I get that finished, so in a meantime the above exercises the driver. Jonathan > > RFC reason > - Whilst trace capture with a particular configuration is potentially useful > the intent is that CXL HMU units will be used to drive various forms of > hotpage migration for memory tiering setups. This driver doesn't do this > (yet), but rather provides data capture etc for experimentation and > for working out how to mostly put the allocations in the right place to > start with by tuning applications. > > CXL r3.2 introduces a CXL Hotness Monitoring Unit definition. The intent > of this is to provide a way to establish which units of memory (typically > pages or larger) in CXL attached memory are hot. The implementation details > and algorithm are all implementation defined. The specification simply > describes the 'interface' which takes the form of ring buffer of hotness > records in a PCI BAR and defined capability, configuration and status > registers. > > The hardware may have constraints on what it can track, granularity etc > and on how accurately it tracks (e.g. counter exhaustion, inaccurate > trackers). Some of these constraints are discoverable from the hardware > registers, others such as loss of accuracy have no universally accepted > measures as they are typically access pattern dependent. Sadly it is > very unlikely any hardware will implement a truly precise tracker given > the large resource requirements for tracking at a useful granularity. > > There are two fundamental operation modes: > > * Epoch based. Counters are checked after a period of time (Epoch) and > if over a threshold added to the hotlist. > * Always on. Counters run until a threshold is reached, after that the > hot unit is added to the hotlist and the counter released. > > Counting can be filtered on: > > * Region of CXL DPA space (256MiB per bit in a bitmap). > * Type of access - Trusted and non trusted or non trusted only, R/W/RW > > Sampling can be modified by: > > * Downsampling including potentially randomized downsampling. > > The driver presented here is intended to be useful in its own right but > also to act as the first step of a possible path towards hotness monitoring > based hot page migration. Those steps might look like. > > 1. Gather data - drivers provide telemetry like solutions to get that > data. May be enhanced, for example in this driver by providing the > HPA address rather than DPA Unit Address. Userspace can access enough > information to do this so maybe not. > 2. Userspace algorithm development, possibly combined with userspace > triggered migration by PA. Working out how to use different levels > of constrained hardware resources will be challenging. > 3. Move those algorithms in kernel. Will require generalization across > different hotpage trackers etc. > > So far this driver just gives access to the raw data. I will probably kick > of a longer discussion on how to do adaptive sampling needed to actually > use these units for tiering etc, sometime soon (if no one one else beats > me too it). There is a follow up topic of how to virtualize this stuff > for memory stranding cases (VM gets a fixed mixture of fast and slow > memory and should do it's own tiering). > > More details in the Documentation patch but typical commands are: > > $perf record -a -e cxl_hmu_mem0.0.0/epoch_type=0,access_type=6,\ > hotness_threshold=1024,epoch_multiplier=4,epoch_scale=4,range_base=0,\ > range_size=1024,randomized_downsampling=0,downsampling_factor=32,\ > hotness_granual=12 > > $perf report --dump-raw-traces > > Example output. With a counter_width of 16 (0x10) the least significant > 4 bytes are the counter value and the unit index is bits 16-63. > Here all units are over the threshold and the indexes are 0,1,2 etc. > > . ... CXL_HMU data: size 33512 bytes > Header 0: units: 29c counter_width 10 > Header 1 : deadbeef > 0000000000000283 > 0000000000010364 > 0000000000020366 > 000000000003033c > 0000000000040343 > 00000000000502ff > 000000000006030d > 000000000007031a > > Which will produce a list of hotness entries. > Bits[N-1:0] counter value > Bits[63:N] Unit ID (combine with unit size and DPA base + HDM decoder > config to get to a Host Physical Address) > > Specific RFC questions. > - What should be in the header added to the aux buffer. > Currently just the minimum is provided. Number of records > and the counter width needed to decode them. > - Should we reset the counters when doing sampling "-F X" > If the frequency is higher than the epoch we never see any hot units. > If so, when should we reset them? > > Note testing has been light and on emulation only + as perf tool is > a pain to build on a striped back VM, build testing has all be on > arm64 so far. The driver loads though on both arm64 and x86 so > any problems are likely in the perf tool arch specific code > which is build tested (on wrong machine) > > The QEMU emulation needs some cleanup, but I should be able to post > that shortly to let people actually play with this. There are lots > of open questions there on how 'right' we want the emulation to be > and what counting uarch to emulate. > > Jonathan Cameron (4): > cxl: Register devices for CXL Hotness Monitoring Units (CHMU) > cxl: Hotness Monitoring Unit via a Perf AUX Buffer. > perf: Add support for CXL Hotness Monitoring Units (CHMU) > hwtrace: Document CXL Hotness Monitoring Unit driver > > Documentation/trace/cxl-hmu.rst | 197 +++++++ > Documentation/trace/index.rst | 1 + > drivers/cxl/Kconfig | 6 + > drivers/cxl/Makefile | 3 + > drivers/cxl/core/Makefile | 1 + > drivers/cxl/core/core.h | 1 + > drivers/cxl/core/hmu.c | 64 ++ > drivers/cxl/core/port.c | 2 + > drivers/cxl/core/regs.c | 14 + > drivers/cxl/cxl.h | 5 + > drivers/cxl/cxlpci.h | 1 + > drivers/cxl/hmu.c | 880 ++++++++++++++++++++++++++++ > drivers/cxl/hmu.h | 23 + > drivers/cxl/pci.c | 26 +- > tools/perf/arch/arm/util/auxtrace.c | 58 ++ > tools/perf/arch/x86/util/auxtrace.c | 76 +++ > tools/perf/util/Build | 1 + > tools/perf/util/auxtrace.c | 4 + > tools/perf/util/auxtrace.h | 1 + > tools/perf/util/cxl-hmu.c | 367 ++++++++++++ > tools/perf/util/cxl-hmu.h | 18 + > 21 files changed, 1748 insertions(+), 1 deletion(-) > create mode 100644 Documentation/trace/cxl-hmu.rst > create mode 100644 drivers/cxl/core/hmu.c > create mode 100644 drivers/cxl/hmu.c > create mode 100644 drivers/cxl/hmu.h > create mode 100644 tools/perf/util/cxl-hmu.c > create mode 100644 tools/perf/util/cxl-hmu.h >