linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Gregory Price <gourry@gourry.net>
To: linux-mm@kvack.org
Cc: linux-kernel@vger.kernel.org, nehagholkar@meta.com,
	abhishekd@meta.com, kernel-team@meta.com, david@redhat.com,
	ying.huang@intel.com, nphamcs@gmail.com, gourry@gourry.net,
	akpm@linux-foundation.org, hannes@cmpxchg.org,
	feng.tang@intel.com, kbusch@meta.com
Subject: [PATCH 3/4] vmstat: add page-cache numa hints
Date: Wed, 27 Nov 2024 03:22:00 -0500	[thread overview]
Message-ID: <20241127082201.1276-4-gourry@gourry.net> (raw)
In-Reply-To: <20241127082201.1276-1-gourry@gourry.net>

Count non-page-fault events as page-cache numa hints instead of
fault hints in vmstat.

Signed-off-by: Gregory Price <gourry@gourry.net>
---
 include/linux/vm_event_item.h |  2 ++
 mm/memory.c                   | 15 ++++++++++-----
 mm/vmstat.c                   |  2 ++
 3 files changed, 14 insertions(+), 5 deletions(-)

diff --git a/include/linux/vm_event_item.h b/include/linux/vm_event_item.h
index f70d0958095c..9fee15d9ba48 100644
--- a/include/linux/vm_event_item.h
+++ b/include/linux/vm_event_item.h
@@ -63,6 +63,8 @@ enum vm_event_item { PGPGIN, PGPGOUT, PSWPIN, PSWPOUT,
 		NUMA_HUGE_PTE_UPDATES,
 		NUMA_HINT_FAULTS,
 		NUMA_HINT_FAULTS_LOCAL,
+		NUMA_HINT_PAGE_CACHE,
+		NUMA_HINT_PAGE_CACHE_LOCAL,
 		NUMA_PAGE_MIGRATE,
 #endif
 #ifdef CONFIG_MIGRATION
diff --git a/mm/memory.c b/mm/memory.c
index a373b6ad0b34..35b72a1cfbd5 100644
--- a/mm/memory.c
+++ b/mm/memory.c
@@ -5507,11 +5507,16 @@ int numa_migrate_check(struct folio *folio, struct vm_fault *vmf,
 		*last_cpupid = folio_last_cpupid(folio);
 
 #ifdef CONFIG_NUMA_BALANCING
-	count_vm_numa_event(NUMA_HINT_FAULTS);
-	count_memcg_folio_events(folio, NUMA_HINT_FAULTS, 1);
-	if (folio_nid(folio) == numa_node_id()) {
-		count_vm_numa_event(NUMA_HINT_FAULTS_LOCAL);
-		*flags |= TNF_FAULT_LOCAL;
+	if (vmf) {
+		count_vm_numa_event(NUMA_HINT_FAULTS);
+		count_memcg_folio_events(folio, NUMA_HINT_FAULTS, 1);
+		if (folio_nid(folio) == numa_node_id()) {
+			count_vm_numa_event(NUMA_HINT_FAULTS_LOCAL);
+			*flags |= TNF_FAULT_LOCAL;
+		}
+	} else {
+		count_vm_numa_event(NUMA_HINT_PAGE_CACHE);
+		count_memcg_folio_events(folio, NUMA_HINT_PAGE_CACHE, 1);
 	}
 #endif
 
diff --git a/mm/vmstat.c b/mm/vmstat.c
index 4d016314a56c..bcd9be11e957 100644
--- a/mm/vmstat.c
+++ b/mm/vmstat.c
@@ -1338,6 +1338,8 @@ const char * const vmstat_text[] = {
 	"numa_huge_pte_updates",
 	"numa_hint_faults",
 	"numa_hint_faults_local",
+	"numa_hint_page_cache",
+	"numa_hint_page_cache_local",
 	"numa_pages_migrated",
 #endif
 #ifdef CONFIG_MIGRATION
-- 
2.43.0



  parent reply	other threads:[~2024-11-27 16:28 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-27  8:21 [RFC PATCH 0/4] Promotion of Unmapped Page Cache Folios Gregory Price
2024-11-27  8:21 ` [PATCH 1/4] migrate: Allow migrate_misplaced_folio APIs without a VMA Gregory Price
2024-11-28 11:12   ` Huang, Ying
2024-12-02 15:47     ` Gregory Price
2024-11-29  6:21   ` Raghavendra K T
2024-11-27  8:21 ` [PATCH 2/4] memory: allow non-fault migration in numa_migrate_check path Gregory Price
2024-11-27  8:22 ` Gregory Price [this message]
2024-11-27  8:22 ` [PATCH 4/4] migrate,sysfs: add pagecache promotion Gregory Price
2024-11-27 21:18 ` [RFC PATCH 0/4] Promotion of Unmapped Page Cache Folios SeongJae Park

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241127082201.1276-4-gourry@gourry.net \
    --to=gourry@gourry.net \
    --cc=abhishekd@meta.com \
    --cc=akpm@linux-foundation.org \
    --cc=david@redhat.com \
    --cc=feng.tang@intel.com \
    --cc=hannes@cmpxchg.org \
    --cc=kbusch@meta.com \
    --cc=kernel-team@meta.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=nehagholkar@meta.com \
    --cc=nphamcs@gmail.com \
    --cc=ying.huang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox