From: Gregory Price <gourry@gourry.net>
To: linux-mm@kvack.org
Cc: linux-kernel@vger.kernel.org, nehagholkar@meta.com,
abhishekd@meta.com, kernel-team@meta.com, david@redhat.com,
ying.huang@intel.com, nphamcs@gmail.com, gourry@gourry.net,
akpm@linux-foundation.org, hannes@cmpxchg.org,
feng.tang@intel.com, kbusch@meta.com
Subject: [PATCH 1/4] migrate: Allow migrate_misplaced_folio APIs without a VMA
Date: Wed, 27 Nov 2024 03:21:58 -0500 [thread overview]
Message-ID: <20241127082201.1276-2-gourry@gourry.net> (raw)
In-Reply-To: <20241127082201.1276-1-gourry@gourry.net>
To migrate unmapped pagecache folios, migrate_misplaced_folio and
migrate_misplaced_folio_prepare must handle folios without VMAs.
migrate_misplaced_folio_prepare checks VMA for exec bits, so allow
a NULL VMA when it does not have a mapping.
migrate_misplaced_folio must call migrate_pages with MIGRATE_SYNC
when in the pagecache path because it is a synchronous context.
Suggested-by: Johannes Weiner <hannes@cmpxchg.org>
Signed-off-by: Gregory Price <gourry@gourry.net>
---
mm/migrate.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/migrate.c b/mm/migrate.c
index dfb5eba3c522..3b0bd3f21ac3 100644
--- a/mm/migrate.c
+++ b/mm/migrate.c
@@ -2632,7 +2632,7 @@ int migrate_misplaced_folio_prepare(struct folio *folio,
* See folio_likely_mapped_shared() on possible imprecision
* when we cannot easily detect if a folio is shared.
*/
- if ((vma->vm_flags & VM_EXEC) &&
+ if (vma && (vma->vm_flags & VM_EXEC) &&
folio_likely_mapped_shared(folio))
return -EACCES;
--
2.43.0
next prev parent reply other threads:[~2024-11-27 16:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-27 8:21 [RFC PATCH 0/4] Promotion of Unmapped Page Cache Folios Gregory Price
2024-11-27 8:21 ` Gregory Price [this message]
2024-11-28 11:12 ` [PATCH 1/4] migrate: Allow migrate_misplaced_folio APIs without a VMA Huang, Ying
2024-12-02 15:47 ` Gregory Price
2024-11-29 6:21 ` Raghavendra K T
2024-11-27 8:21 ` [PATCH 2/4] memory: allow non-fault migration in numa_migrate_check path Gregory Price
2024-11-27 8:22 ` [PATCH 3/4] vmstat: add page-cache numa hints Gregory Price
2024-11-27 8:22 ` [PATCH 4/4] migrate,sysfs: add pagecache promotion Gregory Price
2024-11-27 21:18 ` [RFC PATCH 0/4] Promotion of Unmapped Page Cache Folios SeongJae Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241127082201.1276-2-gourry@gourry.net \
--to=gourry@gourry.net \
--cc=abhishekd@meta.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=feng.tang@intel.com \
--cc=hannes@cmpxchg.org \
--cc=kbusch@meta.com \
--cc=kernel-team@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nehagholkar@meta.com \
--cc=nphamcs@gmail.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox