From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 715A2D5A6FD for ; Tue, 26 Nov 2024 08:24:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C120B6B0088; Tue, 26 Nov 2024 03:24:49 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B9A276B0089; Tue, 26 Nov 2024 03:24:49 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A3A906B008C; Tue, 26 Nov 2024 03:24:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 82CC66B0088 for ; Tue, 26 Nov 2024 03:24:49 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 302F3A0DD3 for ; Tue, 26 Nov 2024 08:24:49 +0000 (UTC) X-FDA: 82827559962.17.10DBF77 Received: from invmail4.hynix.com (exvmail4.skhynix.com [166.125.252.92]) by imf17.hostedemail.com (Postfix) with ESMTP id 4BB0B40016 for ; Tue, 26 Nov 2024 08:24:42 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf17.hostedemail.com: domain of honggyu.kim@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=honggyu.kim@sk.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1732609485; a=rsa-sha256; cv=none; b=d6YqeXGW6CvwD9/gqJX1IdDz3Cz3foEbS7QHtTPYgPvm/KxZCypJ90HFz7/2qWC0V/6oqd IBuYvScxqD8SU2DiaSrZUQUIcIpg3Ko2WcJFsqWwc88bmJt8+7Z5S9a9cc4jNcgGPOgABU QAUfmmD335reFb9f0puumLcxL/TmjrM= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf17.hostedemail.com: domain of honggyu.kim@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=honggyu.kim@sk.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1732609485; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oioXKcZ0iFM/j01q/sYqGNgVhzgSa3AUnt3bZ91xPLs=; b=oDrIGHHlB3jvjzDquYz5Z4Gh6fJKytEAuB7eJp7daleBFpADSaHRdEFiGUbyRpyaGrXHxg D/7glnV4+tgesqkR7gldXu2hjDXOFYXmor8G/+aF9K4kwq8GRa8M6ZZCYWvezcKmE6M+WR VRX1YcPShVCRu0gk658aUokxx8wUC9w= X-AuditID: a67dfc5b-3e1ff7000001d7ae-8c-674585cb1f22 From: Honggyu Kim To: SeongJae Park Cc: damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Yunjeong Mun , Honggyu Kim , kernel_team@skhynix.com Subject: Re: [RFC PATCH] mm/damon: explain "effective quota" on kernel-doc comment Date: Tue, 26 Nov 2024 17:24:33 +0900 Message-ID: <20241126082436.1491-1-honggyu.kim@sk.com> X-Mailer: git-send-email 2.43.0.windows.1 In-Reply-To: <20241126002921.50035-1-sj@kernel.org> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrNLMWRmVeSWpSXmKPExsXC9ZZnke6ZVtd0g3WzWC2e/P/NanF51xw2 i3tr/rNaHP76hsmBxWPTqk42j02fJrF7vNg8k9Hj8ya5AJYoLpuU1JzMstQifbsErozbr6az FnQIVbz/cZq5gXETXxcjJ4eEgInEuzfT2boYOcDsnn+qIGE2ATWJKy8nMYHYIgKKEuceX2Tt YuTiYBbYwihx4elnZpCEsECQxIkbR1hAelkEVCXWnZMECfMKmEnMeDqfBWK8psTj7T/ZQWxO AWOJeeeWM4LYQgI8Eq827GeEqBeUODnzCVg9s4C8RPPW2cwguyQEZrBJbP04lw1ikKTEwRU3 WCYw8s9C0jMLSc8CRqZVjEKZeWW5iZk5JnoZlXmZFXrJ+bmbGIFBuKz2T/QOxk8Xgg8xCnAw KvHw3qh2SRdiTSwrrsw9xCjBwawkwssn7pwuxJuSWFmVWpQfX1Sak1p8iFGag0VJnNfoW3mK kEB6YklqdmpqQWoRTJaJg1OqgbHrQsXf/I03458Yy0Xse1pZqq4R0P5Y4HDGfJdTrru1trcJ LZ/p9viUc+PTSzdU3XoiFOqcPXmcGe7Pn9Y+b5U820KRCx9Xhm4qSstj8XtbE8cWve702dLr k79KrtbVO10kIPIi30VXe80bs2unUoOLSmXWJWYv1X55tu6qMq+0LXfH2UO/k5VYijMSDbWY i4oTAXF3Wiw+AgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrALMWRmVeSWpSXmKPExsXCNUNLT/d0q2u6wa+XFhZP/v9mtfj87DWz xeG5J1ktLu+aw2Zxb81/VovDX98wWfzetoLNgd1j06pONo9Nnyaxe7zYPJPR49ttD4/FLz4w eXzeJBfAFsVlk5Kak1mWWqRvl8CVcfvVdNaCDqGK9z9OMzcwbuLrYuTgkBAwkej5p9rFyMnB JqAmceXlJCYQW0RAUeLc44usXYxcHMwCWxglLjz9zAySEBYIkjhx4wgLSC+LgKrEunOSIGFe ATOJGU/ns4DYEgKaEo+3/2QHsTkFjCXmnVvOCGILCfBIvNqwnxGiXlDi5MwnYPXMAvISzVtn M09g5JmFJDULSWoBI9MqRpHMvLLcxMwcU73i7IzKvMwKveT83E2MwHBbVvtn4g7GL5fdDzEK cDAq8fDeqHZJF2JNLCuuzD3EKMHBrCTCyyfunC7Em5JYWZValB9fVJqTWnyIUZqDRUmc1ys8 NUFIID2xJDU7NbUgtQgmy8TBKdXAyJD81G/TWbbYgwen5lXv3bC9W3lPfy1PjuFWW6e6o5OF jNx+nWk8n8EvN8mZ88/PdU6doT1nVimcNA7693nx53IF93774/YTv8wrFN3tLTJt3s2Y6K2x 3y48PfR88oIcGSWTM3dsY8Rfzzwfuzy2NkNl8aXHoapdmsxHPfnMQ69suP0nyolPS4mlOCPR UIu5qDgRANtq0EUzAgAA X-CFilter-Loop: Reflected X-Rspam-User: X-Rspamd-Queue-Id: 4BB0B40016 X-Rspamd-Server: rspam11 X-Stat-Signature: ehdonxjwqe3fqdibdwhc56py6oh5f4ew X-HE-Tag: 1732609482-937889 X-HE-Meta: U2FsdGVkX1/0lgJ0du4dTEi3G8miXs6dq/wBHui8dZ6PULWIkBXBRyAjNDJ/69foz2w5ftIorC/be8XEDlr9v0j8BntyakYdY/c8oJBolTAiKe7fgaD9ybz26L+YQvGczXdhUYcSf69A7lpDBiKiYnWDJYizS1SLeSXfidfzWjWHOffOy/G48QT247qd6rVKO9DJ7jjmzZKq2UiVvTXiGyoYZ76mS6ZwG1LHfbq/CAluqibSxmJv8SMS6S1hSf9HuQIYxF/b0saMBRsk/sw3WuqErb/wV1zh9xx1luWFfQxN8u1fYtzSVdXbArGD2TxIwRfiKts9aGlbZmOQ+aB8lScIBlRFfe4QwaSbmpGm1bv5ObgnsZ1toLaUi13NIc0ZlFjm+LZPK+gZEkY/Ohy4EmPIYd07EQEaQn4Kxowig4GTz6MZXq8sjWQ6f9uLAUWh7RpXoBDJfZ7LtumSi1ofS1uAsJ43yHYfQ7defoLt+cryFQ0U60aao/6E/Gy78XyhxvoeTPF4w8vh5zScIpfWNYsRJIF8v/V4hwBkTdliD31L5vrCun2E0sZs+Dr4MBTGHpHSV6xutgsR3B+zrnuvlvsYKpl09fiEdEjuPCaa00i8Dl7Ayztbn1bkEgP7+wYepbUbwAvWadPnWfkhJxmtU7C/Tf7D+Y1lSKV0t8P9SQe0yhACrnZ/u53iLdYYXKCF4PmOLySX3BvC9rIKYdn/gQSntlGZvQHAjaxMJetdrsTuANkzY4Kt6KqocNYBXeMlhjlomoXSR7wO8edv5voseLzq7VTfaynjhjxIPSG44VyH9fleUgQ2MqrH6YJ/6FhjyCLCTQ5ynkCxjgnhIguuywuG+4YriQK753z0inSqDz7H3dhWp/l4dOXJMBNTEz4pkRzpYdjrce0wXXiDHo7Zi5+Ri5HXuBXoHJnMauAZH/M2C4aPzeWyusL/EpXOKT/P6EaDGzHfR9f0/k0Ptvs Nkva3Tmb DXlEeHiqyqTcZP3oT6FQupAYLRBXWTvWBYHbyC7Y4qHoEXOt4K75NKZO1oGzad2XXR38cRMcGgf1orjs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi SeongJae, Thanks very much for the quick response. I think it looks great but I have some minor comments so please see my inline comments below. Thanks, Honggyu On Mon, 25 Nov 2024 16:29:21 -0800 SeongJae Park wrote: > The kernel-doc comment for 'struct damos_quota' describes how "effective > quota" is calculated, but does not explain what it is. Actually there > was an input[1] about it. Add the explanation on the comment. > > [1] https://github.com/damonitor/damo/issues/17#issuecomment-2497525043 > > Cc: Yunjeong Mun > Cc: Honggyu Kim > Signed-off-by: SeongJae Park > --- > include/linux/damon.h | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > > diff --git a/include/linux/damon.h b/include/linux/damon.h > index a67f2c4940e9..a01bfe2ff616 100644 > --- a/include/linux/damon.h > +++ b/include/linux/damon.h > @@ -193,9 +193,13 @@ struct damos_quota_goal { > * size quota is set, DAMON tries to apply the action only up to &sz bytes > * within &reset_interval. > * > - * Internally, the time quota is transformed to a size quota using estimated > - * throughput of the scheme's action. DAMON then compares it against &sz and > - * uses smaller one as the effective quota. > + * To convince the different types of quotas and goals, DAMON internally > + * converts those into one single size quota called "effective quota". DAMON Could we use "effective size quota" instead of "effective quota"? IMHO, it will better give an idea this is related to "esz" in the code, which means effective size. > + * internally uses it as only one real quota. The convert is made as follows. (nit) "as only one" can be "as the only one". (another nit) "The convert is made" can be "The conversion is made". > + * > + * The time quota is transformed to a size quota using estimated throughput of > + * the scheme's action. DAMON then compares it against &sz and uses smaller > + * one as the effective quota. > * > * If @goals is not empt, DAMON calculates yet another size quota based on the We better fix "empt" to "empty" together. > * goals using its internal feedback loop algorithm, for every @reset_interval. > -- > 2.39.5 >