From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F17CD5A6DF for ; Tue, 26 Nov 2024 05:37:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9EA1F6B0083; Tue, 26 Nov 2024 00:37:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 999C46B0085; Tue, 26 Nov 2024 00:37:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 83A3C6B0088; Tue, 26 Nov 2024 00:37:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 677D76B0083 for ; Tue, 26 Nov 2024 00:37:12 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id B419B1405C6 for ; Tue, 26 Nov 2024 05:37:11 +0000 (UTC) X-FDA: 82827137652.13.E5A674F Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) by imf10.hostedemail.com (Postfix) with ESMTP id EF0D1C0006 for ; Tue, 26 Nov 2024 05:37:07 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=PVgLelvh; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf10.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.210.179 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1732599427; a=rsa-sha256; cv=none; b=l2RF1BnAvXegRarBVHC4H9ESASYxFO+tvWYBk9QnCxS4kccsQ/7xY7rA55MrweyKpx+gLY Dv7YvPbBWnkd+65rhTXou7HYqQYO0gpVztyzFvtbvLyx8h5GE8e8jV8NzbqTEetu9Q5CSE ufcDKXXanZBPU/khfjfm573bTJyM1ns= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=PVgLelvh; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf10.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.210.179 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1732599427; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OZIs9h93WPrwz+VBwfPbM+vLbBlKmlPavgqCo2DVCiA=; b=LgJvhJvPvOf+Q6vdwfssEbTnguq9sLDJ64G4LiaZGUnArIlBIqo+fTqPInasBWFxiihMeB D/Qy8IgBKcgi+vqkIBexoW9CVljxFR5OhLOwu5XN6tJDl3gZSUv/auXlT3qp0X9mXiQnyG XCT7IzoRjPeRZta4xlWwJOlNHSNqjOU= Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-7245a9d0e92so5852054b3a.0 for ; Mon, 25 Nov 2024 21:37:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1732599428; x=1733204228; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=OZIs9h93WPrwz+VBwfPbM+vLbBlKmlPavgqCo2DVCiA=; b=PVgLelvhtEv5hyNu9YvRT+pxBeu705E0atFgjsXCRP2yOU/OWQ5YBKedo5OvyokGwC 5vlrLLqepHlDzLMx/6EUdNfaDayj1PH35nYs2O29VJ/+gQDncYbnDG/1qiR7t62v0of4 lAQ5jdf3qiwouPu1PwM1jgNqi7yPKu156/+3c= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732599428; x=1733204228; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=OZIs9h93WPrwz+VBwfPbM+vLbBlKmlPavgqCo2DVCiA=; b=L6UfYjwoSgfC0ILkJLWavYFaTqdpf2EQyAllNfYxVcCELuWlNVZmfV5rXqyKfawXGd 9Rw68FZj8xCisJDBwqvfjgs+Ic/TSDc2KxCRcbCVnklBA+9fvUZFngF7+VZt6EM4h/WN 2bdXdX12GOP9ErP5K8q/QGhE6z/vthlI0n7umG3SWXPzBf8u0XprngpVYbP535ksfkEY l4hBFQJ9lhvvkGiixVkylRQG9/dfmKTDPkDHXLsNSOt/5LX46ZLeAF0qqMk3GHh+ZBiD 5O8bb6YxawCItB+UstQxhSCW1845CRnt7KpFMoc+p480iKM4l9wnFsCHxGjHT6BsoRG4 XhaA== X-Forwarded-Encrypted: i=1; AJvYcCWYl2UJWN//50Pa+L4TGPyU5jUVjhg/AHLDcssy73Ot+bDrgGeHzBEzF0orTzRIRDPOMEQN1wWoNQ==@kvack.org X-Gm-Message-State: AOJu0YxX/CjtulEfgQjCi+pg0htMepLXWcWFB+mHNOvGIQWiW/04HEqz gtfYmjEDNb66rtIQ8k/3cAOt9Z/xA+DXhHgJqhF62eelP6ZySww3XtmzZ2U2FQ== X-Gm-Gg: ASbGnctZz1y0Gx7QejTb7UzedMo8uSZMLYoigoWoiT4origAMsQM2bcOeTtXvxm8g5o I2LXC+1t3rJ0z0utM7ov9hBcm2pLTMCkyADLcwA9800M6CrHg75NCgy2+oodNlrDlgWaTtLVFvF nSo1wsabdvST7uuHCbUrOOquCR/0ShDoEkwF0mXrbG/y9XRxM77DDQbZdiZ/1a3ApMs00gNhGub Jn7Bpgg0rmco1VvZukC+pRSoqpAAd8blI4ka8ESVz1L8pPdRZ4z X-Google-Smtp-Source: AGHT+IFcmwAYkfd43AO17AjLRO77+cjhEf0Q+v+bMz9ooJo6Oy9pdgPf2JtLOA/9sKzwZCKdSetmJQ== X-Received: by 2002:a05:6a00:b45:b0:71e:6c65:e7c4 with SMTP id d2e1a72fcca58-724df6a799bmr23337783b3a.26.1732599428408; Mon, 25 Nov 2024 21:37:08 -0800 (PST) Received: from google.com ([2401:fa00:8f:203:7631:203f:1b91:cbb]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-724de45725dsm7435473b3a.16.2024.11.25.21.37.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Nov 2024 21:37:07 -0800 (PST) Date: Tue, 26 Nov 2024 14:37:01 +0900 From: Sergey Senozhatsky To: Barry Song <21cnbao@gmail.com> Cc: akpm@linux-foundation.org, linux-mm@kvack.org, axboe@kernel.dk, bala.seshasayee@linux.intel.com, chrisl@kernel.org, david@redhat.com, hannes@cmpxchg.org, kanchana.p.sridhar@intel.com, kasong@tencent.com, linux-block@vger.kernel.org, minchan@kernel.org, nphamcs@gmail.com, ryan.roberts@arm.com, senozhatsky@chromium.org, surenb@google.com, terrelln@fb.com, usamaarif642@gmail.com, v-songbaohua@oppo.com, wajdi.k.feghali@intel.com, willy@infradead.org, ying.huang@intel.com, yosryahmed@google.com, yuzhao@google.com, zhengtangquan@oppo.com, zhouchengming@bytedance.com Subject: Re: [PATCH RFC v3 1/4] mm: zsmalloc: support objects compressed based on multiple pages Message-ID: <20241126053701.GD440697@google.com> References: <20241121222521.83458-1-21cnbao@gmail.com> <20241121222521.83458-2-21cnbao@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241121222521.83458-2-21cnbao@gmail.com> X-Rspamd-Queue-Id: EF0D1C0006 X-Stat-Signature: 8dczoofs6aozmgsozx88y8dt5qtruc37 X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1732599427-45385 X-HE-Meta: U2FsdGVkX18SnePCMk/wqd5OKr5n5+rN0GXx/E6aEsAxTmmejdlxv8PCRJxnaiJmUiVDfwQtdWaJGhrY0Ea+16RiAiSLVHfguzkKVyiuYoMhvpAR1ESFUw6VN4XSI0/iTabbJa2BUaqBBWw+M+O1j4mSzV9IhwUYdjhpH4BqJQp5z9gsgYmjedvNOo8YzoJ3Ck+o/aJiyEcsxGub7cdvRJ/OtNmIzu+BmCZpLpLrwuh+52/wcoTn5uX3GW6nQPCGcyTV9uEgQQlgL1pJlGJztDH+8t8jt5qnkYnKii4Cmh/f1GrU2KWtgc98c9zeUvI7KN1Axa6friA0sO13Pc4jqs3QBq1Qn+/uw41R0AMoHmHJBki3GcbyEe67moBKwHJvB3nJaLXCrP+DF5zw/vmV66dv8saTh4Pe1n7JBsXTdyE3TsM6t8bfhw0lbRcWzWRG2csCsJwhK0WvlkROZUgXoiHOXhdkw/O6L2mBLm8B23KHNt3vJxxVun83Wi6LsBWXKF8GKm73Ag+Ropdhb3kiH3FALek5QKz7tw2OnU8UzYXtL1DrQNNRl2DA/QqM8ExIaRAwjbeMORcWTGAGel4TMrB3P3m32wpHwqneju1CiFaJwzRu2MYTMjzGtYnPfk3yxMOt+ATTtEmDqO3EhBfypxhm4dbQ2OblijxcmYmz8yGyjcVNJ6x0fgflhWD/rD38E/itl0RRUey216EqJtk4tKspBRF0RC63ZhY3kExXlcYeHki/LddiSrhNd7+vjawPUgOAil9Z6svKjV/joaTLREesSmgTKCNDOqeBv/1X3MRpAIeeeVWIdhJGhT7JkfjviWp5Z/EVvl7hKG5BYxxDfcct7FITF7P+7FXrZAei3hc/Dver/x6LQKaAwvH4+FRs2P8bX5N18qy5nNUmOzp1uR9Z3UiFQAkrWvIE1i3E8kag+u8sP9b/GZ79QP2lO4TE9I7AN1X06goHyH1rtIR X9/hfzLD w1Wh617zQZFk/G8zsHaqLqVWN9Z7oCvnWehfjXZtUrQ/2aWAfmBXFkLyG2wdRwst6OcYXJNNJlPF+ezPBjN7fez1OylpoCxpaSygLOOKw4fiRe4a5x5FxQICljfTjoiCgdgDk+ASJZ59FixdEMYjn2PBuN44aqQRqcGGrGevzNyTgjlVnPKTKpWoQ+OdIvp8PVApEOmUrn6SZOHaw4vgmqSfbNmEUkq/WYlmlZcQN/3JjFyxaDIFyl258NF1ePhinzDLHggmWEwewLNNJsCzElC18XIlplDTN8M5nol2O9dK2Jt3GX+/hBCsnzUSUXkz90/uHZuWWx36LIDV9STAdcj7TSB+TaC17L4bfG4diSnzxJtI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On (24/11/22 11:25), Barry Song wrote: > static void reset_page(struct page *page) > { > - __ClearPageMovable(page); > + if (PageMovable(page)) > + __ClearPageMovable(page); A side note: ERROR: modpost: "PageMovable" [mm/zsmalloc.ko] undefined!