From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89C9BD58D6A for ; Mon, 25 Nov 2024 16:54:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BD0FE6B0085; Mon, 25 Nov 2024 11:54:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B81306B0088; Mon, 25 Nov 2024 11:54:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A48E26B0089; Mon, 25 Nov 2024 11:54:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 851176B0085 for ; Mon, 25 Nov 2024 11:54:14 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id D5D7540530 for ; Mon, 25 Nov 2024 16:54:13 +0000 (UTC) X-FDA: 82825215186.29.3695B2E Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) by imf11.hostedemail.com (Postfix) with ESMTP id 5994540005 for ; Mon, 25 Nov 2024 16:54:07 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=infradead.org header.s=desiato.20200630 header.b=cSTTDs13; spf=none (imf11.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.92.199) smtp.mailfrom=peterz@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1732553650; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=E2Re+/DWcuGRoj5t1bYoz9VASCPFYUF6fXcLL5oeIGw=; b=iO/633IWz8HLoEh3sO8EYU4tNjhoTKfVcqv7tKi1fRzMtU2LNAmdg6P3RcTkanenLwIXDN TpvW7fGls/g41GT63XKZydcZUr8OACHIiA2lbwf3ZQa22rkymrtdrY7R1Tgf4sx1v4nDOb v9PG7HLpHC+kteQh9RxxqVwj04zmyAY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1732553650; a=rsa-sha256; cv=none; b=3RP4DMy6Uw9mnK9kkP9wt1TZnuCpz8kl1AvmdZuerPEF+cjZ9Acg9wcuhyVNONIUPqTb6j mF2lKV09AYh0ER8VQK37Qf9BdnceMusWbUPFACul9Vao6RK9PrppIvL0Sw1UVyrn9pWUeW WSoLdRu9gPoMVkTDBQXNfdCX5Z5gbsc= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=infradead.org header.s=desiato.20200630 header.b=cSTTDs13; spf=none (imf11.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.92.199) smtp.mailfrom=peterz@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=E2Re+/DWcuGRoj5t1bYoz9VASCPFYUF6fXcLL5oeIGw=; b=cSTTDs13q0Voxav85dJNtCfvAi h81tDHDatyKXr2upRiEwNTU79fp2G3CrMDM9CH7p/bsB/Bg+MFOQga1+lc3O9eYRv1a78+ZdHxppx i2weMhHN8GimiArPA4CjzM1we1WbpchmxYuKodE3h6tr46yF8ZV/gCsd89HW+Lx8w76pY6+WrjAzH m6/6jswOEczit9ogAhMsmihVa+We1ukh+OYmDGh6NqGa1vQyoJkIecOckrB7b8uJ06qsLklKpNbKv YINxw9HrOl9Pxc0xCrLKyp7GwKRS/Xb4YFDiVmAYUR+bXLjR8Sf2Za2cyOhJwXJwmGRMxuzDQjg2f h853yH8w==; Received: from 77-249-17-89.cable.dynamic.v4.ziggo.nl ([77.249.17.89] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.98 #2 (Red Hat Linux)) id 1tFcLW-000000016tq-18sH; Mon, 25 Nov 2024 16:53:58 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 1000) id 7EE8730026A; Mon, 25 Nov 2024 17:53:57 +0100 (CET) Date: Mon, 25 Nov 2024 17:53:57 +0100 From: Peter Zijlstra To: Suren Baghdasaryan Cc: Wei Yang , akpm@linux-foundation.org, andrii@kernel.org, jannh@google.com, Liam.Howlett@oracle.com, lorenzo.stoakes@oracle.com, vbabka@suse.cz, mhocko@kernel.org, shakeel.butt@linux.dev, hannes@cmpxchg.org, david@redhat.com, willy@infradead.org, brauner@kernel.org, oleg@redhat.com, arnd@arndb.de, zhangpeng.00@bytedance.com, linmiaohe@huawei.com, viro@zeniv.linux.org.uk, hca@linux.ibm.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 3/3] mm: introduce mmap_lock_speculate_{try_begin|retry} Message-ID: <20241125165357.GA16789@noisy.programming.kicks-ass.net> References: <20241122174416.1367052-1-surenb@google.com> <20241122174416.1367052-3-surenb@google.com> <20241125005804.libwzfcz6d5zeyi4@master> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Stat-Signature: 89d1e1wcykmujme1q6ue74yu9zxc9ttr X-Rspam-User: X-Rspamd-Queue-Id: 5994540005 X-Rspamd-Server: rspam02 X-HE-Tag: 1732553647-926530 X-HE-Meta: U2FsdGVkX18gau/oMwT3hyqQhKqoZJFwxcgKXqZrQzwR5Bt0hUXO/9T+Auw9VeczXySFctXlbNGHMbwoxirEsFYFJn68ppPVDhYbIMieokbFJCSiwup8HY9+r10kwTSzjiEDMjMpiAuKjeKGLbED8leRvNilbJ4odIh/zhIVVqSOt/50+d5/AT2Ml86sEEPAWdLSAOxufFX8dUy/ClpWmFFdKj9NIXwlakMHJm6luYCnyrQXaZFof857+5artL9IIwLZS2iOSA2+YC05qR2XpLlMIGHdHV/5zgPGWASXdF5dbG242/KHQlRDLkd11yR4mrKG0cc0a8k8VPRkbTw5h7uPGJAGNXgQa6kQ+vDUkEW2sogveQE060OMItNnPw/Gk7Q8arBw32pbV0Aww7eMYjnH2YO3NAa1iAOwNtN9WIWAmMMYq4DbKOek0wU8lKzlP4ZlTh9gJdmyPtwKy09w3I3TVJuVwHt6+KQvd9FFudf/3HARpgQJUY3SJOMrxbTMjhcRL76dW4XDlSKpcRPzDzKZL9lv3R5KdfBxdYOOCL0P6VfbmSjgFdPlCZDQGvYnkEFfpS4ZqovWt8qCFK+xPQIbubAmdnN1mkLrB94oYd038CoMAemSYkGnD38H9vNb1Lx5mUSuB1S7RWtiRYUsSjnf8JfOG5MvbetKzSjldDdiKAK3aaRi77Je+RB4p4DWM+ZvgQaWcFDx/jjpQdTCdZkGD0IXFffa6LCONInhgsOlQ8IfoyWmpxA9SJQt/5MPAsO0kXuRftYEi8AYWWHIA7x7eiAGwb1giMg/4Y1hnLkCNvG7i1GroCnzLEmV+yzBitka1XYGpmTewIa2qvGpGQfrDAjWl+eD3iHF4R3UZz5Mx60C9UUd602GoVQFjexP7he7MfxxQkGUVgie3gTqEkWc1kPNzPQpNOIV+srBljExiwtPvJ8A+Ojmx1dqRBM9HXzZeKKPgXW8QK3Vk6f cjaeTcHb xhHL9n9FLJgS+h6tao0/uJd8gnRipQVAaj7EHEwB4XnZ9btD1W2ZQfE3dZxxw0HZg52cJ7iv+NG//c2LJk/yMUv29G1jfQ5JF5kTE0c2mSGPWbk6ru+EqaDzWEXEDn85MasfHYK2r28Re4GHA+aJnlmi6LYHb05Vu4xVnOWdc+w/kWXSGb+ixbnKZMx2x9Ov9xX+TLgi6YiVlcHI3lT9skUKzAPI0CFwOpJZgHklynMBLT4LXcWt9ISfZJxAAYT4lelXJN5g7PhtnBeXH/YVI7YqGxm+Um5G9M2yjvIUazPOWgzTcFfMGADeIFQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Nov 25, 2024 at 08:18:38AM -0800, Suren Baghdasaryan wrote: > > >+static inline bool mmap_lock_speculate_retry(struct mm_struct *mm, unsigned int seq) > > >+{ > > >+ return do_read_seqcount_retry(&mm->mm_lock_seq, seq); > > > > Just curious why we don't use read_seqcount_retry(). > > > > Looks this is the only user outside seqlock.h. > > Ah, good eye! read_seqcount_retry() would be better. > > Peter, do you want me to post a new patchset or you can patch it when > picking it up? Fixed up my local copy, thanks!