From: Peter Zijlstra <peterz@infradead.org>
To: Suren Baghdasaryan <surenb@google.com>
Cc: Wei Yang <richard.weiyang@gmail.com>,
akpm@linux-foundation.org, andrii@kernel.org, jannh@google.com,
Liam.Howlett@oracle.com, lorenzo.stoakes@oracle.com,
vbabka@suse.cz, mhocko@kernel.org, shakeel.butt@linux.dev,
hannes@cmpxchg.org, david@redhat.com, willy@infradead.org,
brauner@kernel.org, oleg@redhat.com, arnd@arndb.de,
zhangpeng.00@bytedance.com, linmiaohe@huawei.com,
viro@zeniv.linux.org.uk, hca@linux.ibm.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/3] mm: introduce mmap_lock_speculate_{try_begin|retry}
Date: Mon, 25 Nov 2024 17:53:57 +0100 [thread overview]
Message-ID: <20241125165357.GA16789@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <CAJuCfpF+ZdD3-gTSLr1iwpa=fefUyL5dLoy8vGpv=v7LABnjNw@mail.gmail.com>
On Mon, Nov 25, 2024 at 08:18:38AM -0800, Suren Baghdasaryan wrote:
> > >+static inline bool mmap_lock_speculate_retry(struct mm_struct *mm, unsigned int seq)
> > >+{
> > >+ return do_read_seqcount_retry(&mm->mm_lock_seq, seq);
> >
> > Just curious why we don't use read_seqcount_retry().
> >
> > Looks this is the only user outside seqlock.h.
>
> Ah, good eye! read_seqcount_retry() would be better.
>
> Peter, do you want me to post a new patchset or you can patch it when
> picking it up?
Fixed up my local copy, thanks!
next prev parent reply other threads:[~2024-11-25 16:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-22 17:44 [PATCH v3 1/3] seqlock: add raw_seqcount_try_begin Suren Baghdasaryan
2024-11-22 17:44 ` [PATCH v3 2/3] mm: convert mm_lock_seq to a proper seqcount Suren Baghdasaryan
2024-11-22 17:44 ` [PATCH v3 3/3] mm: introduce mmap_lock_speculate_{try_begin|retry} Suren Baghdasaryan
2024-11-25 0:58 ` Wei Yang
2024-11-25 16:18 ` Suren Baghdasaryan
2024-11-25 16:53 ` Peter Zijlstra [this message]
2024-12-01 6:44 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241125165357.GA16789@noisy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=andrii@kernel.org \
--cc=arnd@arndb.de \
--cc=brauner@kernel.org \
--cc=david@redhat.com \
--cc=hannes@cmpxchg.org \
--cc=hca@linux.ibm.com \
--cc=jannh@google.com \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=mhocko@kernel.org \
--cc=oleg@redhat.com \
--cc=richard.weiyang@gmail.com \
--cc=shakeel.butt@linux.dev \
--cc=surenb@google.com \
--cc=vbabka@suse.cz \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
--cc=zhangpeng.00@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox