From: Peter Zijlstra <peterz@infradead.org>
To: David Hildenbrand <david@redhat.com>
Cc: Suren Baghdasaryan <surenb@google.com>,
akpm@linux-foundation.org, andrii@kernel.org, jannh@google.com,
Liam.Howlett@oracle.com, lorenzo.stoakes@oracle.com,
vbabka@suse.cz, mhocko@kernel.org, shakeel.butt@linux.dev,
hannes@cmpxchg.org, willy@infradead.org, brauner@kernel.org,
oleg@redhat.com, arnd@arndb.de, richard.weiyang@gmail.com,
zhangpeng.00@bytedance.com, linmiaohe@huawei.com,
viro@zeniv.linux.org.uk, hca@linux.ibm.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/3] seqlock: add raw_seqcount_try_begin
Date: Fri, 22 Nov 2024 12:19:14 +0100 [thread overview]
Message-ID: <20241122111914.GS24774@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <46aa36f0-64a6-4aee-8134-0ec93f62e59c@redhat.com>
On Fri, Nov 22, 2024 at 12:10:29PM +0100, David Hildenbrand wrote:
> In gup_fast(), we simply do
>
> seq = raw_read_seqcount(¤t->mm->write_protect_seq);
> if (seq & 1)
> return 0;
>
> Should we be using that there as well?
>
> if (!raw_seqcount_try_begin(¤t->mm->write_protect_seqs, seq))
> return 0;
Might as well. A quick grep doesn't find me another instance of this
pattern, but does find me something 'funny' in net/netfilter/x_tables.c.
Let's pretend I didn't see that for now ... *sigh*
Want me to stick a patch like this on, or do you want to do that later,
when the dust has settled?
next prev parent reply other threads:[~2024-11-22 11:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-21 16:28 Suren Baghdasaryan
2024-11-21 16:28 ` [PATCH v2 2/3] mm: convert mm_lock_seq to a proper seqcount Suren Baghdasaryan
2024-11-22 15:14 ` Liam R. Howlett
2024-11-21 16:28 ` [PATCH v2 3/3] mm: introduce mmap_lock_speculate_{try_begin|retry} Suren Baghdasaryan
2024-11-22 11:05 ` Peter Zijlstra
2024-11-22 15:03 ` Suren Baghdasaryan
2024-11-22 15:15 ` Liam R. Howlett
2024-11-22 11:10 ` [PATCH v2 1/3] seqlock: add raw_seqcount_try_begin David Hildenbrand
2024-11-22 11:19 ` Peter Zijlstra [this message]
2024-11-22 11:21 ` David Hildenbrand
2024-11-22 15:13 ` Liam R. Howlett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241122111914.GS24774@noisy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=andrii@kernel.org \
--cc=arnd@arndb.de \
--cc=brauner@kernel.org \
--cc=david@redhat.com \
--cc=hannes@cmpxchg.org \
--cc=hca@linux.ibm.com \
--cc=jannh@google.com \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=mhocko@kernel.org \
--cc=oleg@redhat.com \
--cc=richard.weiyang@gmail.com \
--cc=shakeel.butt@linux.dev \
--cc=surenb@google.com \
--cc=vbabka@suse.cz \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
--cc=zhangpeng.00@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox