From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A3A4D6ED11 for ; Thu, 21 Nov 2024 11:59:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B742D6B00A4; Thu, 21 Nov 2024 06:59:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B243F6B00A5; Thu, 21 Nov 2024 06:59:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9EBFF6B00A6; Thu, 21 Nov 2024 06:59:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 80A146B00A4 for ; Thu, 21 Nov 2024 06:59:40 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 25FC5C12F7 for ; Thu, 21 Nov 2024 11:59:40 +0000 (UTC) X-FDA: 82809955662.25.D49E613 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf26.hostedemail.com (Postfix) with ESMTP id E5210140010 for ; Thu, 21 Nov 2024 11:58:57 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="WbDF2+/Q"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=+jrpssDL; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="WbDF2+/Q"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=+jrpssDL; spf=pass (imf26.hostedemail.com: domain of jack@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1732190174; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ffwoLapS7ds0fc8Z3M05iUgxL+jHEXm7ir+HgYb1z3k=; b=iJ114cfCq9Ky9QB1QCQbPFi8jAS0Bs9VDP6bb8+O72jX0TS1/YXYDsiuLj6TQLenki9IIS SlgEBliJePsaqV8tqO8XhmIpoROBf3ul5tAZutn0zWGMKQWIbzh3eJAeSp9WTvtXHJkfIZ RUB7KtVXXoeOHKqfS2HZjY8dJAnACZk= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="WbDF2+/Q"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=+jrpssDL; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="WbDF2+/Q"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=+jrpssDL; spf=pass (imf26.hostedemail.com: domain of jack@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1732190174; a=rsa-sha256; cv=none; b=h+bZYazc5WrtCpBxcvzKmGulxYQXqEHs9Woxwv33DZjX6evVDoPU7gymjpilDCv2vDWiqv PWcEJxktoO3QUp8YfFM3MpbYmJCpLpaIs9ToQDCPLCWcl9Qb3jcMEjNXbjptnX7z6wB9ga JdGlI1mf258GblJhal3CEzR08LgytPw= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 74DB6219DA; Thu, 21 Nov 2024 11:59:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1732190376; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ffwoLapS7ds0fc8Z3M05iUgxL+jHEXm7ir+HgYb1z3k=; b=WbDF2+/QPA0BtRSxUvFeewXAZflxCiLqPIZMTUTBOMoeZMewXFqQhyVIPwsyKnsLuIxLjC YBChiaJq5lKbX8t4wNVp2++Qx7FR6qZMYkzwasGxasrMAz+wa3x2aScdHMns5vY1+ieppk NhUl+b/emgEGkDchCkFue9JS0Af1ZT8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1732190376; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ffwoLapS7ds0fc8Z3M05iUgxL+jHEXm7ir+HgYb1z3k=; b=+jrpssDLjADPog+MQaemqubSlppPYFhOsOzpEiliVLAEQMf4vMl0xJ3upfL8L62marbGSA VDGseYFK8w5YByAg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1732190376; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ffwoLapS7ds0fc8Z3M05iUgxL+jHEXm7ir+HgYb1z3k=; b=WbDF2+/QPA0BtRSxUvFeewXAZflxCiLqPIZMTUTBOMoeZMewXFqQhyVIPwsyKnsLuIxLjC YBChiaJq5lKbX8t4wNVp2++Qx7FR6qZMYkzwasGxasrMAz+wa3x2aScdHMns5vY1+ieppk NhUl+b/emgEGkDchCkFue9JS0Af1ZT8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1732190376; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ffwoLapS7ds0fc8Z3M05iUgxL+jHEXm7ir+HgYb1z3k=; b=+jrpssDLjADPog+MQaemqubSlppPYFhOsOzpEiliVLAEQMf4vMl0xJ3upfL8L62marbGSA VDGseYFK8w5YByAg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 6B2EC13927; Thu, 21 Nov 2024 11:59:36 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id WMsqGqggP2d/DAAAD6G6ig (envelope-from ); Thu, 21 Nov 2024 11:59:36 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id 2E8BBA089E; Thu, 21 Nov 2024 12:59:32 +0100 (CET) Date: Thu, 21 Nov 2024 12:59:32 +0100 From: Jan Kara To: Mateusz Guzik Cc: brauner@kernel.org, viro@zeniv.linux.org.uk, jack@suse.cz, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, hughd@google.com, linux-ext4@vger.kernel.org, tytso@mit.edu, linux-mm@kvack.org Subject: Re: [PATCH v3 3/3] tmpfs: use inode_set_cached_link() Message-ID: <20241121115932.bwm64mrghjc3nxtk@quack3> References: <20241120112037.822078-1-mjguzik@gmail.com> <20241120112037.822078-4-mjguzik@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241120112037.822078-4-mjguzik@gmail.com> X-Rspamd-Action: no action X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: E5210140010 X-Stat-Signature: 3yonoibn8bdiw9843e7okymk3bikj1dp X-Rspam-User: X-HE-Tag: 1732190337-681628 X-HE-Meta: U2FsdGVkX1+cFN1eWCGzbxHgPqo99XDW7hHHCUCp5IW2nxIsqgTvqdI3TAeweJCwY8ZSSdI4kJg/COf8/KcrjUL9Um1FfNC8tmsv4ipkiGueDyYmL/UjGGzb2KGNK86KMInoQNr5riB5xOvsTQ+trhKJgLI57+vDsB0IS5I+/6/beuqH+BwMy40anN1iscPSbG/SK08gBswCjzKjJiZ7qEmvn9leZCM+7HWtDn6PL1sSV4R+81sDvK2Z2cWFgdTiadLZqwE+21ahM/iNKwm3VNXQe52vUHiuKYO/cxEXF+nRs2+E9RuVbtu5H8Y06/niIDBPIzRvojjfHpRI0whYoAGs61H7fOLfb7S73o6pdMYkayiGwhZpkr1A05kNP6doo6Ohxz3mN7boT9Y6WhscuQPhp6isDZMGX3Hzokytnl/o1IwzqdkhlVdSbblyCS2WqWm/lD5j8cGvGmwQo/rHlu6Ycy36cu2K6oqWu6JgSZTSWdW9orjUF08ZYyQc2kE410kPhQ7y7EXcNvviiYKXyRd0QYnmJD3SccyT16Wy5s1wbkN2Jizbyh0zdh/zA6vHMzQKjWEtQWlYGpOyhhIHBgLggkNjeak08bDNyki26OmSEaCkZRHKaSxC/BYE1/0wc+pWU7OWfcO5h0rocLCT0DfLkYbFMTMkHnco/KJX3zz3PqjVeD1FZ2SpPHzxBedTWY+vPz0eVaay34IpZEJjlW7X5gaw2SvESqVCb7eP0eRYQRu+6rlXx/Xw4Dl25Tqe0abQ3lELSccgceZfxOU86G8dOVfnLcf9/zsGud1/ThhwkXW0js0fFPcoJMlSTYuL2yUTUOREV6b5L5g0HVvF0iYYXRkiojUT0I3/kITy6f74jv8lOGr5SHNgD8Y8CEslsvnF3YYC/qJrd0NnhUW35VsYMRC4UcdLigh/2ye2Z7ushHMHwi+MkCu+HXnmH9+K+LeotDAj1WYUA41BqmK zvwmAydA 5L6Wz9ZBQ0/4KNiyvges0c+/PkjAgdIIwlTSFAZv4bqbeVHHJvXaY9jkV7KaHzzBrTsh3SNbbfdHbn20N8gOz803s3oJbSSL1lCwSAyZoWfz7zfGBP+LEGbWTLJCqdZhI/4sOIZiaNR5gFadhBKZS5of45DMHO2aTxl4MLBv8f6R/vNzYxFa9n95R38EyYsDaSXV6Lq+gsHrDgNzyus4BFdo2k6Q9ZirXAlacNA1cLhbkiVyKOipM30g49IlhDccMX4EiHSsmwb1oSHKaBIEjIOH5f9SwP38qb99bl2kgchtIrfD8Mvp6xeBDI1xQqTVG8lqD9Q00QhkbluU1uK/aMGIyYdJL/c1C/LOLpjoaOISPCiOyzh26LidCf+dU3MYKXy0ZOogtb2ao0v4+zEGTZBBYpRpnA/RL78iZ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed 20-11-24 12:20:36, Mateusz Guzik wrote: > Signed-off-by: Mateusz Guzik Looks good. Feel free to add: Reviewed-by: Jan Kara Honza > --- > mm/shmem.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/mm/shmem.c b/mm/shmem.c > index c7881e16f4be..135f38eb2ff1 100644 > --- a/mm/shmem.c > +++ b/mm/shmem.c > @@ -3868,6 +3868,7 @@ static int shmem_symlink(struct mnt_idmap *idmap, struct inode *dir, > int len; > struct inode *inode; > struct folio *folio; > + char *link; > > len = strlen(symname) + 1; > if (len > PAGE_SIZE) > @@ -3889,12 +3890,13 @@ static int shmem_symlink(struct mnt_idmap *idmap, struct inode *dir, > > inode->i_size = len-1; > if (len <= SHORT_SYMLINK_LEN) { > - inode->i_link = kmemdup(symname, len, GFP_KERNEL); > - if (!inode->i_link) { > + link = kmemdup(symname, len, GFP_KERNEL); > + if (!link) { > error = -ENOMEM; > goto out_remove_offset; > } > inode->i_op = &shmem_short_symlink_operations; > + inode_set_cached_link(inode, link, len - 1); > } else { > inode_nohighmem(inode); > inode->i_mapping->a_ops = &shmem_aops; > -- > 2.43.0 > -- Jan Kara SUSE Labs, CR