From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC2AED6ED11 for ; Thu, 21 Nov 2024 11:58:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7A49F6B0098; Thu, 21 Nov 2024 06:58:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7533B6B00A2; Thu, 21 Nov 2024 06:58:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5F32F6B00A3; Thu, 21 Nov 2024 06:58:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 40C766B0098 for ; Thu, 21 Nov 2024 06:58:50 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id D5F2781294 for ; Thu, 21 Nov 2024 11:58:49 +0000 (UTC) X-FDA: 82809953184.19.EABE435 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf27.hostedemail.com (Postfix) with ESMTP id E8D8440019 for ; Thu, 21 Nov 2024 11:57:50 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=XmXmOQgp; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=FBM0+Vkz; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=XmXmOQgp; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=FBM0+Vkz; spf=pass (imf27.hostedemail.com: domain of jack@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1732190266; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GcSWdomwDNDpO7ZSV571broabLlQiL9P5rzLFLnfqRY=; b=P7DbDb/237JZWBKsG99IhspYY8+xP8SWPwt4X1RjPsx0rfdZJRT6X6cT6tOv5BtOMcKrCK se4bgC/g/hvNcOOyoI3L3huDaHO6ZEofD2zitAInxnAIzaXYkmPlGBSv5R8eiFBXxXj2+8 H3vABId1qFWL/Av3JX/ygS3OeBUxs8M= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1732190266; a=rsa-sha256; cv=none; b=pEmHeEEOJVm1+2YhyCSO5zL19qw/tkVYI+6dy7KgtIRYRQpVGdscr++ano5gZYXb35dMMW T1M0Ckw6r3PLIwk8akr4nv/k0CZgXrNSD8yrw/ZBJh1E6IUYCHn1AVzhLUCBSdaIuFFZiY BQ4b2nxa8kmS8yaIEuH7MSKj3bgQvlk= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=XmXmOQgp; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=FBM0+Vkz; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=XmXmOQgp; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=FBM0+Vkz; spf=pass (imf27.hostedemail.com: domain of jack@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id CE1641F802; Thu, 21 Nov 2024 11:58:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1732190325; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=GcSWdomwDNDpO7ZSV571broabLlQiL9P5rzLFLnfqRY=; b=XmXmOQgpWD4xQdXE9FMcKsQKBYG8zJLyuajze7Z4gOl598dVI1UpiAxaxTTiaF1SjOlAel GOMmKrU6n5wqVhV/1/coNQeRF5mO+HVuqXmtu55C3P8xf4Cj6aQeJZFFRzTSZV8b3T1U23 DfBlAwTeVIjpdQAT66QmQI9j0NNp2Jw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1732190325; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=GcSWdomwDNDpO7ZSV571broabLlQiL9P5rzLFLnfqRY=; b=FBM0+Vkz83qVLdHck2RnXLdkMKgZcY5oLBRsyxUSKPYFGwZFfBDkf3B42K0Yc4iQNFlaWp MMnNzk5Zx4GWBMBg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1732190325; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=GcSWdomwDNDpO7ZSV571broabLlQiL9P5rzLFLnfqRY=; b=XmXmOQgpWD4xQdXE9FMcKsQKBYG8zJLyuajze7Z4gOl598dVI1UpiAxaxTTiaF1SjOlAel GOMmKrU6n5wqVhV/1/coNQeRF5mO+HVuqXmtu55C3P8xf4Cj6aQeJZFFRzTSZV8b3T1U23 DfBlAwTeVIjpdQAT66QmQI9j0NNp2Jw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1732190325; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=GcSWdomwDNDpO7ZSV571broabLlQiL9P5rzLFLnfqRY=; b=FBM0+Vkz83qVLdHck2RnXLdkMKgZcY5oLBRsyxUSKPYFGwZFfBDkf3B42K0Yc4iQNFlaWp MMnNzk5Zx4GWBMBg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id C32F613927; Thu, 21 Nov 2024 11:58:45 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id F2uhL3UgP2c7DAAAD6G6ig (envelope-from ); Thu, 21 Nov 2024 11:58:45 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id 7BA4AA089E; Thu, 21 Nov 2024 12:58:45 +0100 (CET) Date: Thu, 21 Nov 2024 12:58:45 +0100 From: Jan Kara To: Mateusz Guzik Cc: brauner@kernel.org, viro@zeniv.linux.org.uk, jack@suse.cz, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, hughd@google.com, linux-ext4@vger.kernel.org, tytso@mit.edu, linux-mm@kvack.org Subject: Re: [PATCH v3 2/3] ext4: use inode_set_cached_link() Message-ID: <20241121115845.5rlrxawr62n4jhke@quack3> References: <20241120112037.822078-1-mjguzik@gmail.com> <20241120112037.822078-3-mjguzik@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241120112037.822078-3-mjguzik@gmail.com> X-Stat-Signature: x1aqgdtobimfj35755rkrkqcbhzzqxqt X-Rspam-User: X-Rspamd-Queue-Id: E8D8440019 X-Rspamd-Server: rspam02 X-HE-Tag: 1732190270-78358 X-HE-Meta: U2FsdGVkX1+j0mM/1TFTdHVzD3XpSYdh1ye5jM3ZJuEDnF6MVUUyoXfRgsI4YmroJxYV3Blyuav0sM9TxZ4k8H1UBOlMNW3xfjSLECCpvxQP+I0MstijrCKiQs6P2X3eABIcukR0J+2uOdPDBT0vbPDOPMhmOuZU+QXcwx/4S4miRP+vsKPHekBq7WfO49JAdgQi6c1S9YYqgXmWvWGoujeZUYR+eHwb1YX9U4at0ynryS9KJ6qjFKfVqyZD9uXteoorF5mWkgufQn/QpRcSzCwKcrvmntzd/F/4pyAFqtrTWBB1Z8uKr6P4JLm19gPJ/XnrzmQ7GnGU6KRfyzewp5C1UAmx+spg+oDWcV8IirF5NMgu2DYMdJfUYbHahMmiiLkP4DguKDYFwYyz1aWKFXcRU0F9ad60+Id96OpBobPqa2Gd2TrV2OFUA1bWBQqBlR5Nvw1xFrYkSQSyvRfdb6Ni0yC7HBywB29via17aXcuzmBqsF2NZ2vzEbtpsbXrq4ZpWU2+4Dw/LTZwocRRtbmA4M4Spj+YHnV8oEEackczbk+TtfZVYSftAVsvzxT66MJ5owu6kSv8sCFYdEa+rTOj4Ghq94eSKeMJwty3JRdfJMV4LVl264bsOoCq7AGVjWXYVyXq5HcJBbWcV3okZssPp4xjPDVr53CtQwoFfCcfnCOS3rmSgvEd5u8+yc/VmdxrhLQJ6A8kRHMgFM49iWAgfkgjieZixQiUasWtmeUr3iQ225pkyoKrlAi1ei2wj2+CQEg/+13YseZ/7qloCv7xZ46LxKBjCHpWQMsKPwq5hUQKrydGyyaXxbdIAnKtMbRC1Mvt/WwlA0CFJW/4zGlqrKX9eG/E8CiohdPleOmcZv2Ko9J4fez0J3s87VCbpDK5fgCazbWCg+4berjZbeKM9x5NWXEW5f0Uul0QNrfg++g0UQp56ha0FPmJnpE7WUd6KKzumrEGFMGpmsb Aiacj3iC PhMaKyOY0H1ilpVxDIsVPnFdAuMK7oR5pBau5aXamlTAPvBC98wF9fMWjM8ekYiOar0DpMvPAG1zSCdxid/x/Al57HLEQAh/3qTZH6WMlcep6ZaW0DFxHXaQr+1GWfpIduBtnrazSuoqwgfLYmciKiq2EdxXcybblYUn0yPHXBH3vL3PMn+PRXMq7kYzaomZWC3PmJ9Ah7qSeiIC59JKzbrKqIktIxGtz1nIQ/fLJE5fFOppOhZ/gmbkaT0R9rQHCbWJEpvN8b6U3M+Rd3fN/BjsMozRIUe5yToiLVT8vPoVSyJXjqynL3puzeAzqYGsl0nyHFcLDsA8Wxv67ZoY8GIWXnD1jmLcsDOnP11EOZ+Kwta0bPM9FdQMrmEDHm7AEckObGOCieEEqAFmrafd53Qd1ANNxo4v2SjRq X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed 20-11-24 12:20:35, Mateusz Guzik wrote: > Signed-off-by: Mateusz Guzik Looks good to me. Feel free to add: Reviewed-by: Jan Kara Honza > --- > fs/ext4/inode.c | 3 ++- > fs/ext4/namei.c | 4 +++- > 2 files changed, 5 insertions(+), 2 deletions(-) > > diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c > index 89aade6f45f6..7c54ae5fcbd4 100644 > --- a/fs/ext4/inode.c > +++ b/fs/ext4/inode.c > @@ -5006,10 +5006,11 @@ struct inode *__ext4_iget(struct super_block *sb, unsigned long ino, > if (IS_ENCRYPTED(inode)) { > inode->i_op = &ext4_encrypted_symlink_inode_operations; > } else if (ext4_inode_is_fast_symlink(inode)) { > - inode->i_link = (char *)ei->i_data; > inode->i_op = &ext4_fast_symlink_inode_operations; > nd_terminate_link(ei->i_data, inode->i_size, > sizeof(ei->i_data) - 1); > + inode_set_cached_link(inode, (char *)ei->i_data, > + inode->i_size); > } else { > inode->i_op = &ext4_symlink_inode_operations; > } > diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c > index bcf2737078b8..536d56d15072 100644 > --- a/fs/ext4/namei.c > +++ b/fs/ext4/namei.c > @@ -3418,7 +3418,6 @@ static int ext4_symlink(struct mnt_idmap *idmap, struct inode *dir, > inode->i_op = &ext4_symlink_inode_operations; > } else { > inode->i_op = &ext4_fast_symlink_inode_operations; > - inode->i_link = (char *)&EXT4_I(inode)->i_data; > } > } > > @@ -3434,6 +3433,9 @@ static int ext4_symlink(struct mnt_idmap *idmap, struct inode *dir, > disk_link.len); > inode->i_size = disk_link.len - 1; > EXT4_I(inode)->i_disksize = inode->i_size; > + if (!IS_ENCRYPTED(inode)) > + inode_set_cached_link(inode, (char *)&EXT4_I(inode)->i_data, > + inode->i_size); > } > err = ext4_add_nondir(handle, dentry, &inode); > if (handle) > -- > 2.43.0 > -- Jan Kara SUSE Labs, CR