From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8A02D6ED04 for ; Thu, 21 Nov 2024 11:16:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 446786B007B; Thu, 21 Nov 2024 06:16:49 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3F6C06B0082; Thu, 21 Nov 2024 06:16:49 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 297256B0083; Thu, 21 Nov 2024 06:16:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 0B7F36B007B for ; Thu, 21 Nov 2024 06:16:49 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 84BCFC129F for ; Thu, 21 Nov 2024 11:16:48 +0000 (UTC) X-FDA: 82809846966.07.C3AA8C7 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf05.hostedemail.com (Postfix) with ESMTP id 8C199100007 for ; Thu, 21 Nov 2024 11:15:06 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=vpyrFgGY; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=NLQCsoPk; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=vpyrFgGY; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=NLQCsoPk; dmarc=none; spf=pass (imf05.hostedemail.com: domain of jack@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=jack@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1732187620; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OO3PiFMSVMzJJNLk3EErxSTVlpJaS5ys4vHrrygEOx0=; b=YRTiG43wT3t7JcRF/CKJK1Bz9cIVcMtfIKkVeGPIY7QGXbOSignXTuErlzGLQpxc30UmK5 B2ft7HSKNtRGlYGVmHY66SWy85Bon8F3HKJXxYxUxq0u36djd06U4ThwVf8dRr+djxtOXk x/dDMikS5LyVY0j3oiSb4wrWP4wAHGo= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=vpyrFgGY; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=NLQCsoPk; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=vpyrFgGY; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=NLQCsoPk; dmarc=none; spf=pass (imf05.hostedemail.com: domain of jack@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=jack@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1732187620; a=rsa-sha256; cv=none; b=vBWxYLr3DqqOUjqn3d7qfINDLA0DBf/9CpR03CtDQop2WEl5QnCtEEqpJ4QFAtbjBnD6dP Ey5jDGpP/hDaL2+WSzlmI0lP/J9I+s/65fXCM8nwp91oeuVWkrqMQwznxbV/O+eK5CePO4 dSA8jhNCmw9vziN1KEUvFpBc4ct22IM= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 8A6B11F800; Thu, 21 Nov 2024 11:16:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1732187804; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OO3PiFMSVMzJJNLk3EErxSTVlpJaS5ys4vHrrygEOx0=; b=vpyrFgGYPbLysXQTkhAwkgafmzcuWtDagZ+kEtMsYu23SuwnRwY2mZrgbqiFJevWTOtHyU ilGPMT9oJbOHcqaZtxDR6K19jMzja3h5PzTrwS+9wyajBpagf8PAczKfXEa6l7Q1DBAAu8 k1hSJLen9A1awEYNIhFXuJU5BhahU8I= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1732187804; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OO3PiFMSVMzJJNLk3EErxSTVlpJaS5ys4vHrrygEOx0=; b=NLQCsoPkUtM3JKWpx4YvqUx8eeiWKIxDZyA8FB81qe09O12lwWgUuB2D0BwRApsvAga2Z6 eP+yNFPFQHj7HhDw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1732187804; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OO3PiFMSVMzJJNLk3EErxSTVlpJaS5ys4vHrrygEOx0=; b=vpyrFgGYPbLysXQTkhAwkgafmzcuWtDagZ+kEtMsYu23SuwnRwY2mZrgbqiFJevWTOtHyU ilGPMT9oJbOHcqaZtxDR6K19jMzja3h5PzTrwS+9wyajBpagf8PAczKfXEa6l7Q1DBAAu8 k1hSJLen9A1awEYNIhFXuJU5BhahU8I= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1732187804; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OO3PiFMSVMzJJNLk3EErxSTVlpJaS5ys4vHrrygEOx0=; b=NLQCsoPkUtM3JKWpx4YvqUx8eeiWKIxDZyA8FB81qe09O12lwWgUuB2D0BwRApsvAga2Z6 eP+yNFPFQHj7HhDw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 7D0FC137CF; Thu, 21 Nov 2024 11:16:44 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id KJSAHpwWP2clfQAAD6G6ig (envelope-from ); Thu, 21 Nov 2024 11:16:44 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id 3B6C4A089E; Thu, 21 Nov 2024 12:16:44 +0100 (CET) Date: Thu, 21 Nov 2024 12:16:44 +0100 From: Jan Kara To: Amir Goldstein Cc: Christian Brauner , Jan Kara , Josef Bacik , kernel-team@fb.com, linux-fsdevel@vger.kernel.org, torvalds@linux-foundation.org, viro@zeniv.linux.org.uk, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-mm@kvack.org, linux-ext4@vger.kernel.org Subject: Re: [PATCH v8 02/19] fsnotify: opt-in for permission events at file open time Message-ID: <20241121111644.y63uejriiti4vce5@quack3> References: <5ea5f8e283d1edb55aa79c35187bfe344056af14.1731684329.git.josef@toxicpanda.com> <20241120155309.lecjqqhohgcgyrkf@quack3> <20241121093918.d2ml5lrfcqwknffb@quack3> <20241121-satirisch-siehst-5cdabde2ff67@brauner> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 8C199100007 X-Stat-Signature: zqo8umm95j4ww7af39b7u5to8xjeyfkt X-Rspam-User: X-HE-Tag: 1732187706-983169 X-HE-Meta: U2FsdGVkX18J+LyQF75gJbwLYpSSSSRint2rT7sflsEVMEGJ+MZetM2xkJUSOFC8U0Wrcb2jgWlwhahMNIiLfjUz1uXrDxQnAWTEma1F219rV/lVf4VZMFfvwlMwNcSv9AhorvIVpolcT0WF0s7OFfIGSk+rz12V9RmrpPTGJsX2L93zC1aRQBO1tqUaLGe+amdezFFnGUaMfMHd0dOvv/L2zPDmRZuF3xxpuFRZ/1/6Z9fvuGDiAOWgTq1XWc2Z/hnH51WsvRxxL62P7/MA0yA8lPLTOIjuzn/AQSVReIDfqzQI/HfDx4gh9mq/k/U3Lwlzk0XEnj0IJZRNWC9RP1ysAC5ui8VycB9qf0LE/y+yz49AGTRbz9gajdfQvdfBintPBFM9vdvGxUfIOWOD5FlF+olh8lCWb28LK0V/CnBcvzI8OguZ05LdXWPtw4l1C45ao9tfR7jRkof44qJ7N2nhC51vuVGgtynKdjWw5YcbAIMYsHQraA+bUgicpd1j1cdx5okzN0x4OIikZccfptLBCRbDyuVeVEPKTXAyFAvy+S/6/x//5SdjxY7CUo4gaGlcKqNmsej7bCOFfZPzwnPRNbJWujsSKKoAV540qe2kpNI4kf2+onUN2o6c3AJo+8W6/M5DoHY6iMBdNIdGL/mSnbt1PBH9ECu5seP1nQ0xXNNipJWkaJC4xTWkIWjaEpjKgPkpmCwPyZ7vWXz7a9vxrQB9P5IlsHEpYa1fSeuk2G7Ldoj+kYRbYe8ESok+qbzkE32Fd+vwtjMgHv4UlDHbQwAfnwXydi2ML9xkgNl3v8Wpv1C6HTyq023LSaircaTHjyv1JtUMWa3vUH2o+H4YA1oTddMYUDKR3VFuunA2FVYd3ssKcqoLvFLIcH1atU/tG+oMRdF7vcESJKUHr1IQH/rNeQGMTHL+47P3c6MHNS4da3mcbl1oITZ2gv/gxBlRYkwOQBvtlFytbqa 30PkpXh+ BqVB2CHOZ5JvuFvMBUVYnNv7NjJD7/5XByS2rfbkx/oYw//nBJ2eoL2gURn8OSXWBjmBbhT3bVUg9tCc9lO0d/iIe0g88/I9eEKTIN3AjAzLJCvytybn+beDDVFC5NfagaWBOTLT9Vi2WaCbmR1wdZxptn7ddHlPykG3H2wE0EeV0sVblp2djzNn5BPwelqFYY/SaxsUS/hzgGXaDdDX9CLaJBiy9kdkQs88A2ImoqA1DuOtB1bLW9DDIkJ28TD1b+CGcnz4E47dUZvs0tnL+B/q+oTV0UPFH6U9gFKs0eogS00M49Qm3dbpvXvSzB09j4cMDF+f3QUzv/ShUrVXq0c1dxzTCYrAsjaU/E/upS3y3zj0YHPCesjNxuKCvoeu9m2pQ2qnoyA5mzgI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu 21-11-24 12:04:23, Amir Goldstein wrote: > On Thu, Nov 21, 2024 at 11:09 AM Christian Brauner wrote: > > > > > It is not that I object to "two bit constants". FMODE_FSNOTIFY_MASK is a > > > two-bit constant and a good one. But the name clearly suggests it is not a > > > single bit constant. When you have all FMODE_FOO and FMODE_BAR things > > > single bit except for FMODE_BAZ which is multi-bit, then this is IMHO a > > > recipe for problems and I rather prefer explicitely spelling the > > > combination out as FMODE_NONOTIFY | FMODE_NONOTIFY_PERM in the few places > > > that need this instead of hiding it behind some other name. > > > > Very much agreed! > > Yes, I agree as well. > What I meant is that the code that does > return FMODE_NONOTIFY | FMODE_NONOTIFY_PERM; > > is going to be unclear to the future code reviewer unless there is > a comment above explaining that this is a special flag combination > to specify "suppress only pre-content events". So this combination is used in file_set_fsnotify_mode() only (three occurences) and there I have: /* * If there are permission event watchers but no pre-content event * watchers, set FMODE_NONOTIFY | FMODE_NONOTIFY_PERM to indicate that. */ at the first occurence. So hopefully that's enough of an explanation. Honza -- Jan Kara SUSE Labs, CR