From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B61B6D6E2CA for ; Thu, 21 Nov 2024 10:22:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4235D6B0099; Thu, 21 Nov 2024 05:22:53 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3D2EF6B009A; Thu, 21 Nov 2024 05:22:53 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 273966B009B; Thu, 21 Nov 2024 05:22:53 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 081BE6B0099 for ; Thu, 21 Nov 2024 05:22:52 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id B0576140E77 for ; Thu, 21 Nov 2024 10:22:52 +0000 (UTC) X-FDA: 82809711474.27.536F953 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf17.hostedemail.com (Postfix) with ESMTP id 1CB5D40008 for ; Thu, 21 Nov 2024 10:22:09 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=3PbC7j72; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=z000pJx+; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=3PbC7j72; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=z000pJx+; spf=pass (imf17.hostedemail.com: domain of jack@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1732184478; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Kxm7ovrk+K1yTBvGNMVkCAtMMkTAJ4W+DeknJDrENns=; b=ujUyF/LU2SPT6Jye+enTv5Pt8obIT0xhMRvuGG72U9dz998RlPlWpFduG02W3KEvfDzcVB 3MgypjulcfFSgJFp3fq57NQokICX/kC/79prS161H4A9ctugy4cRDkOcE/pXuIxSBvxZzm /Kfle+F2iA2YLZv+t/+EOxc2BWhNLDM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1732184478; a=rsa-sha256; cv=none; b=JEYqjolg+e84CmT+CXvrNSfhzepy4xjtAeJd+1LNwdwpU+UM2tYhqxxYeB7KsHk4XZnxZZ Xn0LQiUszovqfjGKj6XAirnjQEOfFtXYcfKeLW9zrQF9E4bi+71gjQkS3hOxlMTg85i3V/ 71ZwESB9SRiHPo/3/S5ZJ7GmL3gc6qw= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=3PbC7j72; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=z000pJx+; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=3PbC7j72; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=z000pJx+; spf=pass (imf17.hostedemail.com: domain of jack@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 9877B219BD; Thu, 21 Nov 2024 10:22:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1732184568; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Kxm7ovrk+K1yTBvGNMVkCAtMMkTAJ4W+DeknJDrENns=; b=3PbC7j72wbheuOzDwR2yXVLAGtJ7F3Lda6T4yPr3abvmptbP9bMRm0l/cIg0BC9mUfAb9J onnZ2NvoMT5suPU++qVE382uPxncTqDd252RnlJ16wuDb+9awsVxzU/5TzkeU8DAfuqgk3 XtipTWHH2kIhFPbdMi6V19mku7OlisE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1732184568; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Kxm7ovrk+K1yTBvGNMVkCAtMMkTAJ4W+DeknJDrENns=; b=z000pJx+2ebarxGC/hK4I0Vsx2r9l9zMoGFYyMerkRoW1OfFZBEIRWLhPZiUf+SOVZfoK/ wQ/aPWzupghQuBBw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1732184568; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Kxm7ovrk+K1yTBvGNMVkCAtMMkTAJ4W+DeknJDrENns=; b=3PbC7j72wbheuOzDwR2yXVLAGtJ7F3Lda6T4yPr3abvmptbP9bMRm0l/cIg0BC9mUfAb9J onnZ2NvoMT5suPU++qVE382uPxncTqDd252RnlJ16wuDb+9awsVxzU/5TzkeU8DAfuqgk3 XtipTWHH2kIhFPbdMi6V19mku7OlisE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1732184568; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Kxm7ovrk+K1yTBvGNMVkCAtMMkTAJ4W+DeknJDrENns=; b=z000pJx+2ebarxGC/hK4I0Vsx2r9l9zMoGFYyMerkRoW1OfFZBEIRWLhPZiUf+SOVZfoK/ wQ/aPWzupghQuBBw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 8ABFA137CF; Thu, 21 Nov 2024 10:22:48 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id UbbXIfgJP2cZawAAD6G6ig (envelope-from ); Thu, 21 Nov 2024 10:22:48 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id 4C07FA089E; Thu, 21 Nov 2024 11:22:48 +0100 (CET) Date: Thu, 21 Nov 2024 11:22:48 +0100 From: Jan Kara To: Josef Bacik Cc: kernel-team@fb.com, linux-fsdevel@vger.kernel.org, jack@suse.cz, amir73il@gmail.com, brauner@kernel.org, torvalds@linux-foundation.org, viro@zeniv.linux.org.uk, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-mm@kvack.org, linux-ext4@vger.kernel.org Subject: Re: [PATCH v8 17/19] xfs: add pre-content fsnotify hook for write faults Message-ID: <20241121102248.w3jkpcn3wosxbh62@quack3> References: <9eccdf59a65b72f0a1a5e2f2b9bff8eda2d4f2d9.1731684329.git.josef@toxicpanda.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9eccdf59a65b72f0a1a5e2f2b9bff8eda2d4f2d9.1731684329.git.josef@toxicpanda.com> X-Rspamd-Server: rspam10 X-Stat-Signature: yd3z3usmfcam8mh4nkoyryrk47c3igs5 X-Rspamd-Queue-Id: 1CB5D40008 X-Rspam-User: X-HE-Tag: 1732184529-331854 X-HE-Meta: U2FsdGVkX1/T2L85JIFcRpMOdNe2zzHq8on0CYIkjnBFQdgsNPzO3+tD+mSnbxBcL5WykKr3Dn5lDAHVz9KGvFnybfXn8Q0Ji4937O+I7i+PRS64gEeOjOBvi/17zc7fwyhsHXsCOeE1BwnHNrz7KFpQBDubXRiPFmByKT8nfFD6i1xOuqGg+mlTiOq+WR8F4nAtRH+w/2dqCiIQ+uLzgJa6LQ5WCKfCyQHyddkjiqFzkkDQB0Pj1ZYgqeBcKmwKO8ymjQxJswzFXtxUDUSE5VOLNQcuqJti2pyatwIj968BXBI8nstkHeodFC8TXDFeAlv+nMlEK+U9KciWiSqOlgvmEu0LulvCBTUPR+0pkGVS/JvgpaOYWo8GMWtZ7a8nyFWK9+vrjH059COLqXSVn3KoAc4elknqL6alVr0ozC1oCXsmaEqOksHwZQKt7FvHHQHu1XIMOZ7HiK+XlvV4tEwWdHI9/oHkmFpE976GXhztoIeJ0ZDFWfj+t9A7Wx30U6b7JAZHD+5nXICSc6+SgVl49rf3d2YTBXN2tWTiRmW8w/wOG6l7LEacyCJA/Eru5OFs5SC+tp4Ur9gyqiAYBhWSpItEH6mcUfmoa6I8+O903dAD9+J1KrupHyY57ctosW0nvuh7HEcU2/MTHYHMmkXJbXk6STDdGbGu/RCse7phxSmtlJ+v+QV03w++aAnaPBSZdJm+e0kd+61Ds3K+rvoRy3mIE9m57nj0RtSZ6OZakpYfLoj5HKQw5sUnMQbBl0H7Crxo9ONgdsoglrX8F+XMuBlPLK3a2SQgjF0MzYgyKsPJwvr4K1uIZLv5tnmyRC1GHt4VagUsjA9qgYFBAXFaqEw4VWRfwYZEtv3zqTK2AmmGvI8FBbyQ8uThotIjlEX8Cutk7nN2rU81aVBv1yfQ0i8TthduXJD7YB207j4tMW60rw3CwgYAqJ0/M5YUlffTlCraTV3PKMZ6BID vjJi474A Qpza3kRk+Wl6P0eret1/81aRnWDMTcRg9g5vU5RP5ntbPcq+LQrlwr3aA5b1Bpeo5Elsfgj2+nVBTY8CCmVgt4zBYMCRrsYNvf0wUzEkR4KNTmDoxyv8rIms/5eXx/WU0oXc6Ne1qFh32bgh6FQlylcRxblB25BHSCYzDH5iKvgu3Lg7D+r/G60iR0QFcOrlICKrrMfJ+jZ2SL1+BzUaxNYNY5Mb4r6IecPQhMIqZiISGzf3oemVUISLRzGFqF5zF1GM4StaBouHg6QO/IIFL8Y6CH1Q00OVt9A5IiKmdEtuX1e1muZ0q81+71Ds5Hhf7iZHTCIsFBSkXBDGimOnJsYIBQ7zKqJdoK8uJUyLf6eAUlXgVAlUQJMducZb0sBCwg1XfZrD3nEcxT5g= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri 15-11-24 10:30:30, Josef Bacik wrote: > xfs has it's own handling for write faults, so we need to add the > pre-content fsnotify hook for this case. Reads go through filemap_fault > so they're handled properly there. > > Signed-off-by: Josef Bacik This was missing proper handling for DAX read faults. What I've ended up with is: struct xfs_inode *ip = XFS_I(file_inode(vmf->vma->vm_file)); vm_fault_t ret; + ret = filemap_fsnotify_fault(vmf); + if (unlikely(ret)) + return ret; xfs_ilock(ip, XFS_MMAPLOCK_SHARED); ret = xfs_dax_fault_locked(vmf, order, false); xfs_iunlock(ip, XFS_MMAPLOCK_SHARED); @@ -1412,6 +1415,17 @@ xfs_write_fault( unsigned int lock_mode = XFS_MMAPLOCK_SHARED; vm_fault_t ret; + /* + * Usually we get here from ->page_mkwrite callback but in case of DAX + * we will get here also for ordinary write fault. Handle HSM + * notifications for that case. + */ + if (IS_DAX(inode)) { + ret = filemap_fsnotify_fault(vmf); + if (unlikely(ret)) + return ret; + } + sb_start_pagefault(inode->i_sb); file_update_time(vmf->vma->vm_file); Honza -- Jan Kara SUSE Labs, CR